From 849525735f784f8e2e0fca19ba5699aea6b1724e Mon Sep 17 00:00:00 2001
From: Greg Cusack <greg.cusack@solana.com>
Date: Sun, 6 Aug 2023 20:36:23 -0700
Subject: [PATCH] report received message signatures only on PUSH requests
 (#32708)

* we only want to report received message signatures on PUSH requests, not PULL requests

* woops accidently had it has LocalMessage not PushMessage

* switch from match to if let statement

* convert if let to matches macro
---
 gossip/src/crds.rs | 10 ++++++----
 1 file changed, 6 insertions(+), 4 deletions(-)

diff --git a/gossip/src/crds.rs b/gossip/src/crds.rs
index c19eb9b4d5..1dc7f9509d 100644
--- a/gossip/src/crds.rs
+++ b/gossip/src/crds.rs
@@ -669,7 +669,7 @@ impl Default for CrdsDataStats {
 }
 
 impl CrdsDataStats {
-    fn record_insert(&mut self, entry: &VersionedCrdsValue) {
+    fn record_insert(&mut self, entry: &VersionedCrdsValue, route: GossipRoute) {
         self.counts[Self::ordinal(entry)] += 1;
         if let CrdsData::Vote(_, vote) = &entry.value.data {
             if let Some(slot) = vote.slot() {
@@ -678,7 +678,9 @@ impl CrdsDataStats {
             }
         }
 
-        if should_report_message_signature(&entry.value.signature) {
+        if matches!(route, GossipRoute::PushMessage)
+            && should_report_message_signature(&entry.value.signature)
+        {
             datapoint_info!(
                 "gossip_crds_sample",
                 (
@@ -723,8 +725,8 @@ impl CrdsStats {
         match route {
             GossipRoute::LocalMessage => (),
             GossipRoute::PullRequest => (),
-            GossipRoute::PushMessage => self.push.record_insert(entry),
-            GossipRoute::PullResponse => self.pull.record_insert(entry),
+            GossipRoute::PushMessage => self.push.record_insert(entry, route),
+            GossipRoute::PullResponse => self.pull.record_insert(entry, route),
         }
     }