blockworks-foundation
/
solana
mirror of https://github.com/blockworks-foundation/solana.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

Applied review feedback

This commit is contained in:
Greg Fitzgerald 2019-02-16 16:26:18 -07:00
parent d63c8ae1ae
commit 8ec1f6ea2e
1 changed files with 14 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
CONTRIBUTING.md
View File

@ -23,10 +23,20 @@ is merged, you can use git-rebase to purge it from your original branch.
$ git pull --rebase upstream master
```
How big is too big? If there are no functional changes, PRs can be very large and that's
no problem. If, however, your changes are making meaningful changes or additions, then
about 1,000 lines of changes is about the most you should ask a Solana maintainer to
review.
### How big is too big?
If there are no functional changes, PRs can be very large and that's no problem. If,
however, your changes are making meaningful changes or additions, then about 1,000 lines of
changes is about the most you should ask a Solana maintainer to review.
### Should I send small PRs as I develop large, new components?
Add only code to the codebase that is ready to be deployed. If you are building a large
library, consider developing it in a separate git repository. When it is ready to be
integrated, the Solana maintainers will work with you to decide on a path forward. Smaller
libraries may be copied in whereas very large ones may be pulled in with a package manager.
### When will my PR be reviewed?
PRs are typically reviewed and merged in under 7 days. If your PR has been open for longer,
it's a strong indicator that the reviewers aren't confident the change meets the quality