diff --git a/ci/test-checks.sh b/ci/test-checks.sh index 136f53a35f..3dc7c194a4 100755 --- a/ci/test-checks.sh +++ b/ci/test-checks.sh @@ -69,18 +69,7 @@ fi _ ci/order-crates-for-publishing.py -nightly_clippy_allows=( - # This lint occurs all over the code base - "--allow=clippy::significant_drop_in_scrutinee" - - # The prost crate, used by solana-storage-proto, generates Rust source that - # triggers this lint. Need to resolve upstream in prost - "--allow=clippy::derive_partial_eq_without_eq" - - # This link seems to incorrectly trigger in - # `programs/bpf_loader/src/syscalls/{lib,cpi}.rs` - "--allow=clippy::explicit_auto_deref" -) +nightly_clippy_allows=() # -Z... is needed because of clippy bug: https://github.com/rust-lang/rust-clippy/issues/4612 # run nightly clippy for `sdk/` as there's a moderate amount of nightly-only code there diff --git a/program-runtime/src/executor_cache.rs b/program-runtime/src/executor_cache.rs index 4645bf6dcd..1cfc1c432d 100644 --- a/program-runtime/src/executor_cache.rs +++ b/program-runtime/src/executor_cache.rs @@ -29,7 +29,7 @@ pub trait Executor: Debug + Send + Sync { /// Relation between a TransactionExecutorCacheEntry and its matching BankExecutorCacheEntry #[repr(u8)] -#[derive(Clone, Copy, PartialEq, Debug)] +#[derive(Clone, Copy, PartialEq, Eq, Debug)] pub enum TxBankExecutorCacheDiff { /// The TransactionExecutorCacheEntry did not change and is the same as the BankExecutorCacheEntry. None, diff --git a/programs/bpf_loader/src/lib.rs b/programs/bpf_loader/src/lib.rs index f9835b7669..e9f2bada50 100644 --- a/programs/bpf_loader/src/lib.rs +++ b/programs/bpf_loader/src/lib.rs @@ -690,9 +690,9 @@ fn process_loader_upgradeable_instruction( let instruction_context = transaction_context.get_current_instruction_context()?; let caller_program_id = instruction_context.get_last_program_key(transaction_context)?; - let signers = [&[new_program_id.as_ref(), &[bump_seed]]] + let signers = [[new_program_id.as_ref(), &[bump_seed]]] .iter() - .map(|seeds| Pubkey::create_program_address(*seeds, caller_program_id)) + .map(|seeds| Pubkey::create_program_address(seeds, caller_program_id)) .collect::, solana_sdk::pubkey::PubkeyError>>()?; invoke_context.native_invoke(instruction, signers.as_slice())?;