FindPacketSenderStake: Improve metrics (#24971)

- separate names for vote and non-vote thread
- time unit postfixes (one is in ns!)
This commit is contained in:
Christian Kamm 2022-05-06 21:16:13 +02:00 committed by GitHub
parent df9a4a0c9d
commit cb6cd5d60f
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 10 additions and 7 deletions

View File

@ -43,25 +43,25 @@ struct FindPacketSenderStakeStats {
} }
impl FindPacketSenderStakeStats { impl FindPacketSenderStakeStats {
fn report(&mut self) { fn report(&mut self, name: &'static str) {
let now = timestamp(); let now = timestamp();
let elapsed_ms = now - self.last_print; let elapsed_ms = now - self.last_print;
if elapsed_ms > 2000 { if elapsed_ms > 2000 {
datapoint_info!( datapoint_info!(
"find_packet_sender_stake-services_stats", name,
( (
"refresh_ip_to_stake_time", "refresh_ip_to_stake_time_us",
self.refresh_ip_to_stake_time as i64, self.refresh_ip_to_stake_time as i64,
i64 i64
), ),
( (
"apply_sender_stakes_time", "apply_sender_stakes_time_us",
self.apply_sender_stakes_time as i64, self.apply_sender_stakes_time as i64,
i64 i64
), ),
("send_batches_time", self.send_batches_time as i64, i64), ("send_batches_time_us", self.send_batches_time as i64, i64),
( (
"receive_batches_time", "receive_batches_time_ns",
self.receive_batches_time as i64, self.receive_batches_time as i64,
i64 i64
), ),
@ -84,6 +84,7 @@ impl FindPacketSenderStakeStage {
sender: FindPacketSenderStakeSender, sender: FindPacketSenderStakeSender,
bank_forks: Arc<RwLock<BankForks>>, bank_forks: Arc<RwLock<BankForks>>,
cluster_info: Arc<ClusterInfo>, cluster_info: Arc<ClusterInfo>,
name: &'static str,
) -> Self { ) -> Self {
let mut stats = FindPacketSenderStakeStats::default(); let mut stats = FindPacketSenderStakeStats::default();
let thread_hdl = Builder::new() let thread_hdl = Builder::new()
@ -139,7 +140,7 @@ impl FindPacketSenderStakeStage {
}, },
} }
stats.report(); stats.report(name);
} }
}) })
.unwrap(); .unwrap();

View File

@ -122,6 +122,7 @@ impl Tpu {
find_packet_sender_stake_sender, find_packet_sender_stake_sender,
bank_forks.clone(), bank_forks.clone(),
cluster_info.clone(), cluster_info.clone(),
"tpu-find-packet-sender-stake",
); );
let (vote_find_packet_sender_stake_sender, vote_find_packet_sender_stake_receiver) = let (vote_find_packet_sender_stake_sender, vote_find_packet_sender_stake_receiver) =
@ -132,6 +133,7 @@ impl Tpu {
vote_find_packet_sender_stake_sender, vote_find_packet_sender_stake_sender,
bank_forks.clone(), bank_forks.clone(),
cluster_info.clone(), cluster_info.clone(),
"tpu-vote-find-packet-sender-stake",
); );
let (verified_sender, verified_receiver) = unbounded(); let (verified_sender, verified_receiver) = unbounded();