ci: prefer clippy::default_trait_access over shell (#31318)
Prefer clippy::default_trait_access over shell
This commit is contained in:
parent
ee10a48739
commit
cece64daad
10
ci/nits.sh
10
ci/nits.sh
|
@ -41,16 +41,6 @@ if _ git --no-pager grep -n "${prints[@]/#/-e}" -- "${print_free_tree[@]}"; then
|
|||
exit 1
|
||||
fi
|
||||
|
||||
|
||||
# Code readability: please be explicit about the type instead of using
|
||||
# Default::default()
|
||||
#
|
||||
# Ref: https://github.com/solana-labs/solana/issues/2630
|
||||
if _ git --no-pager grep -n 'Default::default()' -- '*.rs'; then
|
||||
exit 1
|
||||
fi
|
||||
|
||||
|
||||
# Github Issues should be used to track outstanding work items instead of
|
||||
# marking up the code
|
||||
#
|
||||
|
|
|
@ -76,6 +76,7 @@ nightly_clippy_allows=()
|
|||
# run nightly clippy for `sdk/` as there's a moderate amount of nightly-only code there
|
||||
_ scripts/cargo-for-all-lock-files.sh -- "+${rust_nightly}" clippy --workspace --all-targets --features dummy-for-ci-check -- \
|
||||
--deny=warnings \
|
||||
--deny=clippy::default_trait_access \
|
||||
--deny=clippy::integer_arithmetic \
|
||||
"${nightly_clippy_allows[@]}"
|
||||
|
||||
|
|
Loading…
Reference in New Issue