83409ded59
Correctly deserialize large userdata
2018-09-29 19:39:54 -07:00
396b2e9772
Ignore keep alive for completed games
2018-09-29 19:39:54 -07:00
b6b5455917
Fix test in coverage build
2018-09-28 19:19:16 -07:00
c79acac37b
Add tic-tac-toe dashboard program
2018-09-28 18:48:34 -07:00
a5f2aa6777
s/grid/board/g
2018-09-28 18:48:34 -07:00
4169e5c510
Simplify game setup messaging
2018-09-28 18:48:34 -07:00
0727c440b3
Add KeepAlive message so players can detect abandoned games
2018-09-28 18:48:34 -07:00
52d50e6bc4
Update for new solana-jsonrpc
2018-09-28 17:53:41 -06:00
e7de7c32db
Transactions with multiple programs. ( #1381 )
...
Transactions contain a vector of instructions that are executed atomically.
Bench shows a 2.3x speed up when using 5 instructions per tx.
2018-09-28 16:16:35 -07:00
a5f07638ec
Use static str define for ledger files
2018-09-28 14:23:37 -07:00
aa2a3fe201
Add chacha module to encrypt ledger files
2018-09-28 14:23:37 -07:00
abd13ba4ca
move program tests to integration
2018-09-28 11:30:10 -07:00
423e7ebc3f
Pacify clippy
2018-09-27 16:21:12 -06:00
6cdbdfbbcb
Enable bench and fix upload-perf
2018-09-27 14:16:56 -07:00
dbc1ffc75e
Use jsonrpc fork
2018-09-27 12:50:38 -06:00
1fdbe893c5
Improve game setup experience: X now shares game key and accepts O
2018-09-27 10:44:13 -07:00
55a542bff0
Fix erasure and cuda related compilation errors
2018-09-27 10:42:37 -06:00
e10574c64d
Remove recycler and it's usage
...
- The memory usage due to recycler was high, and incrementing with
time.
2018-09-27 10:42:37 -06:00
2e00be262e
Remove data from BankError.
...
This reduces how much memory is written to last_id_sigs table on very TX, and has a 40% impact on
`cargo +nightly watch -x 'bench bench_banking_stage'`
2018-09-27 09:07:56 -06:00
4172bde081
Only send a vote once a second
2018-09-27 09:06:41 -06:00
9c47e022dc
break dependency of programs on solana core ( #1371 )
...
* break dependency of programs on Solana core
2018-09-27 07:49:26 -07:00
874addc51a
Move KeyedAccount into Account
...
Now programs don't need to depend on dynamic_program and its
dependencies.
2018-09-26 20:40:40 -06:00
b7ae5b712a
Move Pubkey into its own module
2018-09-26 20:40:40 -06:00
c6d7cd2d33
Move Account into its own module
...
Also use default Default generator, since system program ID is
[0; 32]. Bank should probably be the one to set this anyway.
2018-09-26 20:40:40 -06:00
b238c57179
Add trace! when an error is mapped to GenericFailure
2018-09-26 19:30:20 -07:00
1821e72812
Add getSignatureStatus
2018-09-26 19:00:34 -07:00
a23c230603
fix reverse loop in write_stage, simplify banking_stage, add tooling to help find this ( #1366 )
2018-09-26 18:37:24 -07:00
4e01fd5458
Update test to show when we should collect tx fees
...
See #1157 for details. The `from` account should be cloned
before execute_transaction(), and that's the only one that should
be stored if there's an error executing the program.
2018-09-26 19:30:27 -06:00
e416cf7adf
Let clients know when transactions failed
2018-09-26 19:30:27 -06:00
93c4f6c9b8
Synchronize PoH, bank last_id queue and ledger entry channel.
...
PoH, bank's last_id queue and the Entry channel need to have a synchronized order of ids.
2018-09-26 16:19:03 -07:00
d546614936
Handle deserialize failure with error
2018-09-26 15:17:07 -07:00
ac8d738045
Don't call unwrap() in StorageProgram::process_tx
2018-09-26 15:17:07 -07:00
ca962371b8
Fix build
...
Two PRs crossed in flight.
2018-09-26 14:40:48 -06:00
e6f8922e35
fix issue #1347 ( #1355 )
2018-09-26 13:31:39 -07:00
7292ece7ad
Free up term instruction for new multi-instruction feature
2018-09-26 14:17:15 -06:00
df3b78c18c
Move BudgetTransaction into its own module
2018-09-26 14:17:15 -06:00
c83dcea87d
Move SystemTransaction into its own module
2018-09-26 14:17:15 -06:00
be20c99758
Promote the one true transaction constructor
2018-09-26 14:17:15 -06:00
694add9919
Move budget-specific and system-specific tx constructors into traits
...
These functions pull in budget-specific and system-specific
dependencies that aren't needed by the runtime.
2018-09-26 14:17:15 -06:00
113c8b5880
Rollback jsonrpc SendTransaction pool for signature; ignore flaky tests
2018-09-26 10:25:29 -07:00
a5b28349ed
Add max entry height to download for replicator
2018-09-26 09:57:22 -07:00
14bc160674
Clean up test and add signature return to rpc send tx
2018-09-25 16:38:51 -07:00
d438c22618
Update RFC
2018-09-25 16:38:51 -07:00
bcbae0a64f
Fix witness functionality
2018-09-25 16:38:51 -07:00
f636408647
Fix timestamp and cancel functionality
...
- Also serialize and send helper fn
2018-09-25 16:38:51 -07:00
3ffc7aa5bc
Add helper fn to get last id
2018-09-25 16:38:51 -07:00
7b7e8c0d3f
Clippy
2018-09-25 16:38:51 -07:00
11ea9e7c4b
Add cancelable handling
2018-09-25 16:38:51 -07:00
5038e5ccd7
Preliminary Wallet-Budget functionality
2018-09-25 16:38:51 -07:00
e943ed8caf
Expand parse_command and add tests
2018-09-25 16:38:51 -07:00
c196952afd
Flesh out Wallet CLI & add placeholder WalletCommands
2018-09-25 16:38:51 -07:00
e7383a7e66
Validator to leader ( #1303 )
...
* Add check in window_service to exit in checks for leader rotation, and propagate that service exit up to fullnode
* Added logic to shutdown Tvu once ReplicateStage finishes
* Added test for successfully shutting down validator and starting up leader
* Add test for leader validator interaction
* fix streamer to check for exit signal before checking socket again to prevent busy leaders from never returning
* PR comments - Rewrite make_consecutive_blobs() function, revert genesis function change
2018-09-25 15:41:29 -07:00
8a7545197f
move tick generation back to banking_stage, add unit tests ( #1332 )
...
* move tick generation back to banking_stage, add unit tests
fixes #1217
* remove channel() stuff for synchronous comm; use a mutex
2018-09-25 15:01:51 -07:00
680072e5e2
No need to special case vote failures
2018-09-25 13:43:35 -06:00
4ca377a655
Delete dead code
2018-09-25 13:43:35 -06:00
751dd7eebb
Move vote into ReplicateStage after process_entries
2018-09-25 13:43:35 -06:00
8f0e0c4440
Add tic-tac-toe program
2018-09-25 12:07:41 -07:00
db310a044c
Add Budget::And element, and supporting functions ( #1329 )
2018-09-25 12:38:13 -06:00
88a609ade5
groom write_stage
2018-09-25 00:18:35 -07:00
304d63623f
give replication some time to happen
...
fixes #1307
2018-09-24 23:57:09 -07:00
407b2682e8
remove dead code
2018-09-24 23:12:09 -07:00
0f4fd8367d
Add counters for channel pressure and time spent in TPU pipeline ( #1324 )
...
* Add counters for channel pressure and time spent in TPU pipeline
* Fixed failing tests
* Fix rust format issue
2018-09-24 17:13:49 -07:00
747ba6a8d3
Boot BudgetState::last_error
2018-09-24 17:14:23 -06:00
bb99fd40de
Update transaction status in the bank
...
This will allow jsonrpc to query the system to find out if a
recent transaction failed.
2018-09-24 17:14:23 -06:00
e972d6639d
Return errors from BudgetProgram::process_transaction
2018-09-24 17:14:23 -06:00
22e77c9485
Add a way of getting transaction errors out of the bank
2018-09-24 17:14:23 -06:00
95677a81c5
Pacify clippy
2018-09-24 13:36:31 -06:00
ea37d29d3a
Pass Bank::process_transactions() a reference to the txs instead of moving them
2018-09-24 13:36:31 -06:00
e030673c9d
Do a recv on join to prevent channel destruction ( #1320 )
...
before window thread join
2018-09-24 11:50:37 -07:00
3e76efe97e
Fix bench compilation ( #1311 )
2018-09-24 10:40:42 -07:00
f5a30615c1
Ignore replicator startup for now
2018-09-24 09:43:58 -06:00
9e3d2956d8
remove last recycle?
2018-09-24 08:09:41 -06:00
26b1466ef6
Initial integration of dynamic contracts and native module loading ( #1256 )
...
* Integration of native dynamic programs
2018-09-23 22:13:44 -07:00
a1f01fb8f8
revert is_some to not is_none, causes test failure
2018-09-23 17:09:18 -06:00
b2be0e2e5e
fix clippy warning
2018-09-23 17:09:18 -06:00
1a45587c08
fix clippy warnings
2018-09-23 17:09:18 -06:00
a51c2f193e
fix Rob and Carl crossing wires
2018-09-21 21:37:25 -07:00
be31da3dce
lastidnotfound step 2: ( #1300 )
...
lastidnotfound step 2:
* move "record stage", aka poh_service into banking stage
* remove Entry.has_more, is incompatible with leader rotation
* rewrite entry_next_hash in terms of Poh
* simplify and unify transaction hashing (no embedded nulls)
* register_last_entry from banking stage, fixes #1171 (w00t!)
* new PoH doesn't generate empty ledger entries, so some fixes necessary in
multinode tests that rely on that (e.g. giving validators airdrops)
* make window repair less patient, if we've been waiting for an answer,
don't be shy about most recent blobs
* delete recorder and record stage
* make more verbost thin_client error reporting
* more tracing in window (sigh)
2018-09-21 21:01:13 -07:00
54b407b4ca
Wait on blob fetch before window, Seems to fix instability ( #1304 )
...
also cleanup ledger.
2018-09-21 18:56:20 -07:00
e87cac06da
Request/reqwest improvements
...
- Use json macro to simplify request builds
- Add proxy option for reqwest to use TLS
- Add rpc port options for configured nodes
2018-09-21 18:06:20 -06:00
ad4fef4f09
Doc for rpc_port configuration
2018-09-21 18:06:20 -06:00
e3b3701e13
Add RPC port option to fullnode
2018-09-21 18:06:20 -06:00
9228fe11c9
Port Wallet to jsonrpc and fix tests
2018-09-21 18:06:20 -06:00
5ab38afa51
Changed the window_service in Replicator to send entries instead of blobs ( #1302 )
2018-09-21 16:50:58 -07:00
e49b8f0ce7
Update poh_service.rs
2018-09-21 16:03:54 -07:00
c50ac96f75
Moved deserialization of blobs to entries from replicate_stage to window_service ( #1287 )
2018-09-21 16:01:24 -07:00
a9355c33b2
Placeholder storage contract and replicator client ( #1286 )
...
* Add hooks for executing the storage contract
* Add store_ledger stage
Similar to replicate_stage but no voting/banking stuff, just convert
blobs to entries and write the ledger out
* Add storage_addr to tests and add new NodeInfo constructor
to reduce duplication...
2018-09-21 15:32:15 -07:00
3dcee9f79e
Update poh_service.rs
2018-09-21 08:01:24 -07:00
2614189157
cargo fmt
2018-09-20 19:46:20 -07:00
beeb09646a
suppress warning: unused variable: recycler
2018-09-20 19:46:20 -07:00
c0e7e43e96
fixup! s/contract/program
2018-09-20 19:33:54 -07:00
9bfead2e01
s/contract/program
2018-09-20 19:33:54 -07:00
6073cd57fa
Boot Recycler::recycle()
2018-09-20 17:08:51 -06:00
5174be5fe7
Rename getAccount to getAccountInfo
2018-09-20 15:18:56 -07:00
62a18d4c02
step one of lastidnotfound: record_stage->record_service, trim recorder to hashes ( #1281 )
...
step one of lastidnotfound
* record_stage->record_service, trim recorder to hashes
* doc updates, hash multiple without alloc()
cc #1171
2018-09-20 15:02:24 -07:00
a6c15684c9
Avoid panicking invalid instructions
2018-09-20 14:08:39 -07:00
5691bf557c
Handle bad account userdata better
2018-09-20 14:08:39 -07:00
8f01f7cf21
Trace syscalls for more helpful logs
2018-09-20 14:08:39 -07:00
bb8c94ad2c
Add getAccount JSON RPC request
2018-09-20 13:58:15 -07:00
d98e35e095
Delete no longer used PaymentPlan trait
2018-09-20 14:22:45 -06:00
3163fbad0e
Remove 'Plan' indirection since it's implied by BUDGET_CONTRACT_ID
2018-09-20 14:22:45 -06:00
0172422961
Require a self-assigned account ID
2018-09-20 14:16:14 -06:00
8ccfb26923
tests for my IP picker
2018-09-20 09:21:09 -07:00
12a474b6ee
sort local interfaces before selecting one
2018-09-20 09:21:09 -07:00
270fd6d61c
Fix compiler warnings
2018-09-20 09:47:36 -06:00
7b9c7d4150
Cleaned up find_leader_rotation function. Added testing for WriteStage find_leader_rotation_index() function ( #1276 )
2018-09-19 18:16:00 -07:00
55126f5fb6
Marked Tvu functionality in Fullnode as unused for now
2018-09-19 16:05:31 -07:00
431692d9d0
Use a Drop trait to keep track of lifetimes for recycled objects.
...
* Move recycler instances to the point of allocation
* sinks no longer need to call `recycle`
* Remove the recycler arguments from all the apis that no longer need them
2018-09-19 16:59:42 -06:00
6732a9078d
Clarify AfterTimestamp wire format
2018-09-19 13:28:35 -07:00
2981076a14
Add solana-upload-perf to parse json from bench and upload to influx ( #1166 )
2018-09-19 13:16:55 -07:00
cd2d50e06c
Changed transition to restart Rpu rather than modify bank to prevent lock contention
2018-09-19 10:48:05 -06:00
8c8a4ba705
debugging commit
2018-09-19 10:48:05 -06:00
b10de40506
Made LEADER_ROTATION_INTERVAL settable so that integration tests don't time out
2018-09-19 10:48:05 -06:00
2030dfa435
Implement PR comments, tidy up
2018-09-19 10:48:05 -06:00
bfe64f5f6e
Added integration test for transitioning leader to validator to see that tpu pipeline can exit and restart a tvu. Fixed Tpu and broadcast stage so that exiting later stages in the pipeline also causes earlier stages to exit.
2018-09-19 10:48:05 -06:00
6d27751365
give fullnode ownership of state needed to dynamically start up a tpu or tvu for role transition
2018-09-19 10:48:05 -06:00
1fb1c0a681
added jointypes to the stages in the tpu involved in leader rotation
2018-09-19 10:48:05 -06:00
062f654fe0
formatted code
2018-09-19 10:48:05 -06:00
d3cb161c36
Added broadcast stage test for leader rotation exit
2018-09-19 10:48:05 -06:00
98b47d2540
Added check in broadcast stage to exit after transmitting last blob before leader rotation. Also added tests
2018-09-19 10:48:05 -06:00
f28ba3937b
Added check in write stage to exit when scheduled entry_height for leader rotation is detected
2018-09-19 10:48:05 -06:00
91cf14e641
Rewrote service trait join() method to allow thread join handles to return values other than ()
2018-09-19 10:48:05 -06:00
0ee6c5bf9d
Read multiple entries in write stage ( #1259 )
...
- Also use rayon to parallelize to_blobs() to maximize CPU usage
2018-09-18 21:45:49 -07:00
6dee632d67
Remove Signature from ApplySignature
2018-09-18 20:00:42 -07:00
51e5de4d97
Log specific send_transaction error messages
2018-09-18 16:17:08 -07:00
1f08b22c8e
Tweak log messages
2018-09-18 16:17:08 -07:00
83ae5bcee2
Detect binary changes in serialized contract userdata
2018-09-18 16:17:08 -07:00
339a570b26
Update comment
2018-09-18 16:17:08 -07:00
5310b6e5a2
Move entry->blob creation out of write stage ( #1257 )
...
- The write stage will output vector of entries
- Broadcast stage will create blobs out of the entries
- Helps reduce MIPS requirements for write stage
2018-09-18 13:49:10 -07:00
7d14f44a7c
Move register_entry_id() call out of write stage ( #1253 )
...
* Move register_entry_id() call out of write stage
- Write stage is MIPS intensive and has become a bottleneck for
TPU pipeline
- This will reduce the MIPS requirements for the stage
* Fix rust format issues
2018-09-18 11:42:25 -07:00
aebf7f88e5
Various spelling fixes
2018-09-17 19:37:59 -07:00
aac1571670
mint now uses the SystemContract instead of Budget
2018-09-17 18:02:40 -07:00
8bae75a8a6
system contract tests
2018-09-17 14:34:55 -07:00
c2f7ca9d8f
Change process_command return type and improve test
2018-09-17 13:45:47 -07:00
6ec0e42220
budget as separate contract and system call contract ( #1189 )
...
* budget and system contracts and verification
* contract check_id methods
* system call contract
* verify contract execution rules
* move system into its own file
* allocate before transfer for budget
* store error in budget context
* budget contract and tests without bank
* moved budget of of bank
2018-09-17 13:36:31 -07:00
072b244575
Add perf counters for record/write stages ( #1240 )
2018-09-17 11:07:04 -07:00
7ac9d6c604
Create keygen helper function for use in Wallet CLI, print keypair statement
2018-09-17 11:53:33 -06:00
0125163190
Remove wallet.sh, update entrypoint syntax for wallet network argument
2018-09-17 11:53:33 -06:00
a06f4b1d44
Update wallet to trigger keygen if no keypair provided and no keypair found in default location
2018-09-17 11:53:33 -06:00
10daa015c4
Simplify timeout arg
2018-09-17 11:53:33 -06:00
0babee39a4
Update wallet to take network arg
2018-09-17 11:53:33 -06:00
27986d7abb
Standardize CLI help text
2018-09-16 15:17:10 -06:00
8b7edc6d64
Alphabetize
2018-09-16 15:17:10 -06:00
7dfab867fe
Mark --outfile parameter as required
2018-09-16 10:49:02 -07:00
fd36954477
clippy
2018-09-15 05:12:53 -06:00
fd51599fa8
Replace replace(..., None) with take()
...
This is strictly for simplicity, since Option::take() is imlemented with replace().
2018-09-15 05:12:09 -06:00
e142aafca9
Use multiple sockets for receiving blobs on validators ( #1228 )
...
* Use multiple sockets for receiving blobs on validators
- The blobs that are broadcasted by leader or retransmitted by peer
validators are received on replicate_port
- Using reuse_addr/reuse_port, multiple sockets can be opened for
the same port
- This allows the kernel to queue data to user space app on multiple
socket queues, preventing over-running one queue
- This helps with reducing packets dropped due to queue over-runs
Fixes #1224
* Fixed failing tests
2018-09-14 16:56:06 -07:00
4196cf43e8
cargo fmt
2018-09-14 16:37:49 -07:00
bcb3b3c21f
Add integration tests to wallet module
2018-09-14 08:21:33 -06:00
d8c9a1aae9
Add method to run local drone for tests
2018-09-14 08:21:33 -06:00
9ca2f5b3f7
Move all handling except network/gossip from /bin to wallet module
2018-09-14 08:21:33 -06:00
4dc30ea104
Add recycler stats ( #1187 )
2018-09-13 14:49:48 -07:00
90df6237c6
Implements recvmmsg() for UDP packets ( #1161 )
...
* Implemented recvmmsg() for UDP packets
- This change implements binding between libc API for recvmmsg()
- The function can receive multiple packets using one system call
Fixes #1141
* Added unit tests for recvmmsg()
* Added recv_mmsg() wrapper for non Linux OS
* Address review comments for recvmmsg()
* Remove unnecessary imports
* Moved target specific dependencies to the function
2018-09-13 14:41:28 -07:00
8706774ea7
Rewrote service trait join() method to allow thread join handles to return values other than () ( #1213 )
2018-09-13 14:00:17 -07:00
1d7e87d430
Increase number of sockets for transaction processing
2018-09-13 14:22:07 -06:00
1a4cd763f8
Fix missing recycle in recv_from ( #1205 )
...
In the error case that i>0 (we have blobs to send)
we break out of the loop and do not push the allocated r
to the v array. We should recycle this blob, otherwise it
will be dropped.
2018-09-13 08:29:18 -07:00
f06113500d
bench-tps/net sanity: add ability to check for unexpected extra nodes
2018-09-12 15:38:57 -07:00
9ab5692acf
fix "leak" in Blob::recv_from ( #1198 )
...
* fix "leak" in Blob::recv_from
fixes #1199
2018-09-12 14:45:43 -07:00
b52230097e
groom Fullnode's new_with_bank() to match new() more
2018-09-12 09:24:42 -07:00
a8fdb8a5a7
use a single BlobRecycler per fullnode
2018-09-11 16:56:54 -07:00
297f859631
Change '>=' back to '>' to fix recycling of blobs/packets ( #1192 )
...
Recycler will have a strong ref to the item so it will be at
least 1, >= will always prevent recycling.
2018-09-11 16:52:45 -07:00
b313b7f6f9
Revert "move rpc_server to drop() semantics instead of having its own thread"
...
This reverts commit 40aa0654fa
2018-09-10 22:48:33 -07:00
c3fc98c48f
use gossip to find the leader for every airdrop request
2018-09-10 21:29:45 -07:00
40aa0654fa
move rpc_server to drop() semantics instead of having its own thread
2018-09-10 20:25:53 -07:00
bace2880d0
Correct spelling
2018-09-10 19:58:21 -07:00
9d80eefb81
Log the number of accounts each 250k txes ( #1178 )
2018-09-10 17:40:00 -07:00
2be0dbddbb
Correct spelling
2018-09-10 13:48:43 -07:00
a91b785ba5
move fullnode trace generation into crdt
2018-09-10 13:47:57 -07:00
0ef05de889
Add sleep to prevent spinning thread
2018-09-10 12:50:28 -07:00
a093d5c809
Fix erasure build
2018-09-10 11:40:26 -06:00
fc64e1853c
Initialize Window, not SharedWindow
...
Wrap with Arc<RwLock>> when/if needed, no earlier.
2018-09-10 11:40:26 -06:00
7f669094de
Split window into two modules
2018-09-10 11:40:26 -06:00
5025d89c88
Inline window method implementations
2018-09-10 11:40:26 -06:00
2b44c4504a
Use WindowUtil for more idiomatic code
2018-09-10 11:40:26 -06:00
d2c9beb843
Add a trait to pretend Window is an object
2018-09-10 11:40:26 -06:00
9e6d3bf532
Correct spelling
2018-09-10 09:29:01 -07:00
a89b611e9e
comments ( #1165 )
2018-09-09 07:07:38 -07:00
97c3125a78
improve localnet-sanity's robustness ( #1160 )
...
* fix poll_gossip_for_leader() loop to actually wait
for 30 seconds
* reduce reuseaddr use to only when necessary,
try to avoid already bound sockets
* move nat.rs to netutil.rs
* add gossip tracing to thin_client and bench-tps
2018-09-09 04:50:43 +09:00
e8206cb2d4
Echo the network address before entering a quiet polling loop
2018-09-07 21:20:00 -07:00
c34d911eaf
Migrate Budget DSL to use the Account state ( #979 )
...
* Migrate Budget DSL to use the Account state instead of global bank data structures.
* Serialize Instruction into Transaction::userdata.
* Store the pending set in the Account::userdata
* Enforce the token balance rules on contract execution. This becomes the entry point for generic contracts.
* This pr will have a performance impact on the bank. The next set of changes will fix this by locking each account during multi threaded execution of all the contracts.
* With this change a contract transaction needs to store its state under an address. That address could be the destination of the tokens, or any random address. For the latter, an extra step would be needed to claim the tokens which isn't implemented by budget_dsl at the moment.
* test tracking issue 1157
2018-09-07 20:18:36 -07:00
bf29590f41
WSL needs ReuseAddr in addition to ReusePort (which it doesn't honor) ( #1149 )
2018-09-08 07:28:22 +09:00
51b27779c9
client changes for TODOs and looping ( #1138 )
...
* remove client.sh from snap
* default to ephemeral instead of ~/.config key
* rework CLI for bench-tps
* remote multinode-demo stuff from remote-client.sh
* remove multinode-demo from remote-sanity and localnet-sanity
2018-09-08 07:07:10 +09:00
5169c8d08f
Add method to return hash of bank state
2018-09-07 15:38:53 -06:00
4b47abd3bf
Fix --num-nodes argument parsing
2018-09-07 12:20:42 -07:00
71a617b4dc
Fix erasure build
2018-09-07 13:18:19 -06:00
a722802c95
Window write lock to read lock
2018-09-07 13:18:19 -06:00
e9f44b6661
window -> window_service
2018-09-07 13:18:19 -06:00
9693de1867
Reposition parameters
2018-09-07 13:18:19 -06:00
f7ea95aed1
Hoist lock, reposition parameters
2018-09-07 13:18:19 -06:00
f07ce59be8
Toggle parameters
2018-09-07 13:18:19 -06:00
da423b6cf0
Hoist read lock
2018-09-07 13:18:19 -06:00
d5f60b68e4
Hoist window write lock
2018-09-07 13:18:19 -06:00
78b3a8f7f9
Hoist repair_window() branches
...
This probably would have been done if repair_window() was unit-tested.
2018-09-07 13:18:19 -06:00
d77699c126
Do the easy check first
...
All functions above operate on immutable values, so this shouldn't
change functionality, but no repair_window() tests to be certain.hI
2018-09-07 13:18:19 -06:00
09ba0dae15
Remove redundant clone()
2018-09-07 13:18:19 -06:00
a5c7575207
Rewrite find_next_missing, call it clear_slots
2018-09-07 13:18:19 -06:00
50f040530b
Remove redundant cast
2018-09-07 13:18:19 -06:00
7f99c90539
Simplify using early return and Result::ok()
2018-09-07 13:18:19 -06:00
d8564b725c
Don't reference window to get each slot
2018-09-07 13:18:19 -06:00
e4de25442a
Hoist write lock
...
It needed to be passed the lock before, because it contained a
branch where one side didn't require locking. Now that that
defensive programming was hoisted, we can hoist the write lock
as well, leaving a simpler function for unit testing.
2018-09-07 13:18:19 -06:00
Michael Vines
Greg Fitzgerald
Tyera Eulberg
anatoly yakovenko
Stephen Akridge
Jack May
Pankaj Garg
Anatoly Yakovenko
jackcmay
Rob Walker
Stephen Akridge
carllin
Tyera Eulberg
Carl
Jay Kickliter