d6ec03f13c
In CrdsFilter.mask all bits after mask_bits are set to 1: https://github.com/solana-labs/solana/blob/555252f4/core/src/crds_gossip_pull.rs#L65 However the default implementation, sets both mask and mask_bits to zero which is inconsistent with CrdsFilter::compute_mask for a mask_bits of zero. This commit changes the default implementation by setting mask to `!0u64` (i.e all bits set to one). As a result, for the default crds filter, `test_mask` will always return true, whereas previously it was always returning false. https://github.com/solana-labs/solana/blob/555252f4/core/src/crds_gossip_pull.rs#L85 This is only used in tests and benchmarks, but causes some benchmarks to be misleading by short circuiting in this line: https://github.com/solana-labs/solana/blob/555252f4/core/src/crds_gossip_pull.rs#L429 |
||
|---|---|---|
| .. | ||
| benches | ||
| src | ||
| tests | ||
| .gitignore | ||
| Cargo.toml | ||
| build.rs | ||