Go to file
Felipe Lopes 817b163703 Stop removing stake from neutral nodes
This PR is a proposal to not remove stake from nodes that couldn't get any slot because their stake was too small.

This happened in testnet with at least 2 pubkeys:
ED3Y3cuH3wtHXT8TmbDE5toHU6kwQzevWtvkP6rGFNgc
5dB4Ygb8Sf3Sssdxxrpbb4NFX9bMrYnieiz11Vr5xJkJ

They were good producers in epoch 162 and in #tds-stake they were given 50k bonus stake.

But epoch 163 was a special one, lots of new joiners made nodes with a few stake (less than 1k) have a zero slot schedule.

Check lines 479 to 485. If a node didn't get a slot, the node is not considered a quality neither a poor producer, which is correct.

But removing its bonus stake in the line 1032 to 1050 is not correct IMHO...

We should consider someone good until they prove they are bad right? And if you don't give a single slot (chance) for them to prove there's no reason to say they were bad....

Thanks and I'm happy to discuss this more...
2021-02-25 20:08:48 -08:00
.buildkite
.github
.travis
account-decoder Revert "Make UiTokenAmount::ui_amount a String (#15447)" (#15542) 2021-02-25 21:53:40 +00:00
accounts-bench Re-allow clippy::integer_arithmetic at crate-level 2021-02-17 13:55:08 -07:00
accounts-cluster-bench Add accounts cluster bench (#14096) 2021-02-25 19:51:46 -08:00
banking-bench Pacify clippy 2021-02-19 20:08:41 -08:00
banks-client sdk: Add Borsh support for types and utilities (#15290) 2021-02-18 11:14:56 +01:00
banks-interface chore: bump serde from 1.0.118 to 1.0.122 (#15126) 2021-02-05 19:23:24 +09:00
banks-server Re-allow clippy::integer_arithmetic at crate-level 2021-02-17 13:55:08 -07:00
bench-exchange Re-allow clippy::integer_arithmetic at crate-level 2021-02-17 13:55:08 -07:00
bench-streamer Add limit and shrink policy for recycler (#15320) 2021-02-24 00:15:58 -08:00
bench-tps Re-allow clippy::integer_arithmetic at crate-level 2021-02-17 13:55:08 -07:00
ci Upgrade to Rust v1.50 2021-02-19 20:08:41 -08:00
clap-utils CLI: Make derived address seed.len() check a clap validator 2021-02-19 23:20:40 +00:00
cli Implement OutputFormat for confirm in Cli and ledger-tool bigtable (#15528) 2021-02-25 14:15:52 -07:00
cli-config Re-allow clippy::integer_arithmetic at crate-level 2021-02-17 13:55:08 -07:00
cli-output Revert "Make UiTokenAmount::ui_amount a String (#15447)" (#15542) 2021-02-25 21:53:40 +00:00
client Add accounts cluster bench (#14096) 2021-02-25 19:51:46 -08:00
core Revert "Make UiTokenAmount::ui_amount a String (#15447)" (#15542) 2021-02-25 21:53:40 +00:00
crate-features
docs docs: Update stake merging documentation (#15489) 2021-02-25 17:24:39 +01:00
dos Re-allow clippy::integer_arithmetic at crate-level 2021-02-17 13:55:08 -07:00
download-utils Re-allow clippy::integer_arithmetic at crate-level 2021-02-17 13:55:08 -07:00
explorer fix: explorer vote card has incorrect timestamp conversion (#15552) 2021-02-26 03:22:12 +00:00
faucet chore: bump serde from 1.0.118 to 1.0.122 (#15126) 2021-02-05 19:23:24 +09:00
frozen-abi Pacify clippy 2021-02-19 20:08:41 -08:00
genesis Re-allow clippy::integer_arithmetic at crate-level 2021-02-17 13:55:08 -07:00
gossip
install Re-allow clippy::integer_arithmetic at crate-level 2021-02-17 13:55:08 -07:00
keygen Re-allow clippy::integer_arithmetic at crate-level 2021-02-17 13:55:08 -07:00
ledger Add limit and shrink policy for recycler (#15320) 2021-02-24 00:15:58 -08:00
ledger-tool Fix root scan in ledger tool (#15532) 2021-02-25 15:52:16 -08:00
local-cluster Re-allow clippy::integer_arithmetic at crate-level 2021-02-17 13:55:08 -07:00
log-analyzer Pacify clippy 2021-02-19 20:08:41 -08:00
logger
measure Re-allow clippy::integer_arithmetic at crate-level 2021-02-17 13:55:08 -07:00
merkle-root-bench move hashing functionality to accounts_hash (#15353) 2021-02-17 00:29:50 +00:00
merkle-tree Re-allow clippy::integer_arithmetic at crate-level 2021-02-17 13:55:08 -07:00
metrics Re-allow clippy::integer_arithmetic at crate-level 2021-02-17 13:55:08 -07:00
multinode-demo Add validator flag to opt in to cpi and logs storage (#14922) 2021-02-01 14:00:51 -07:00
net Log devbuild branch and commit for locally built testnet (#15541) 2021-02-25 14:57:40 -07:00
net-shaper Re-allow clippy::integer_arithmetic at crate-level 2021-02-17 13:55:08 -07:00
net-utils Re-allow clippy::integer_arithmetic at crate-level 2021-02-17 13:55:08 -07:00
notifier
perf Add limit and shrink policy for recycler (#15320) 2021-02-24 00:15:58 -08:00
poh-bench Re-allow clippy::integer_arithmetic at crate-level 2021-02-17 13:55:08 -07:00
program-test Pacify clippy 2021-02-19 20:08:41 -08:00
programs Implement OutputFormat for confirm in Cli and ledger-tool bigtable (#15528) 2021-02-25 14:15:52 -07:00
ramp-tps Re-allow clippy::integer_arithmetic at crate-level 2021-02-17 13:55:08 -07:00
rayon-threadlimit
remote-wallet Pacify clippy 2021-02-19 20:08:41 -08:00
runtime Introduce ttl eviction for RecycleStore (#15513) 2021-02-25 17:27:27 +09:00
scripts Revert "Make UiTokenAmount::ui_amount a String (#15447)" (#15542) 2021-02-25 21:53:40 +00:00
sdk Check vote account initialization (#15503) 2021-02-24 10:00:48 -07:00
stake-accounts Re-allow clippy::integer_arithmetic at crate-level 2021-02-17 13:55:08 -07:00
stake-monitor Re-allow clippy::integer_arithmetic at crate-level 2021-02-17 13:55:08 -07:00
stake-o-matic Stop removing stake from neutral nodes 2021-02-25 20:08:48 -08:00
storage-bigtable Re-allow clippy::integer_arithmetic at crate-level 2021-02-17 13:55:08 -07:00
storage-proto Revert "Make UiTokenAmount::ui_amount a String (#15447)" (#15542) 2021-02-25 21:53:40 +00:00
streamer Add limit and shrink policy for recycler (#15320) 2021-02-24 00:15:58 -08:00
sys-tuner
system-test
tokens Revert "Make UiTokenAmount::ui_amount a String (#15447)" (#15542) 2021-02-25 21:53:40 +00:00
transaction-status Revert "Make UiTokenAmount::ui_amount a String (#15447)" (#15542) 2021-02-25 21:53:40 +00:00
upload-perf
validator Re-allow clippy::integer_arithmetic at crate-level 2021-02-17 13:55:08 -07:00
version chore: bump serde from 1.0.118 to 1.0.122 (#15126) 2021-02-05 19:23:24 +09:00
watchtower Prevent u64 overflow when calculating current stake percentage 2021-02-19 22:57:47 -08:00
web3.js chore: bump @rollup/plugin-replace from 2.3.4 to 2.4.0 in /web3.js (#15464) 2021-02-22 09:33:28 +00:00
.clippy.toml
.codecov.yml
.gitignore Fix cli usage build 2021-01-29 19:03:10 +00:00
.mergify.yml Drop v1.3, add v1.7 2021-02-17 09:01:45 -08:00
.travis.yml
CONTRIBUTING.md
Cargo.lock Add accounts cluster bench (#14096) 2021-02-25 19:51:46 -08:00
Cargo.toml Add accounts cluster bench (#14096) 2021-02-25 19:51:46 -08:00
LICENSE
README.md
RELEASE.md
SECURITY.md Update SECURITY.md 2021-02-24 07:44:57 -08:00
cargo
cargo-build-bpf
cargo-test-bpf
fetch-perf-libs.sh
fetch-spl.sh Load memo v2 into genesis for test validator (#15425) 2021-02-19 15:59:31 +08:00
run.sh Add validator flag to opt in to cpi and logs storage (#14922) 2021-02-01 14:00:51 -07:00
test-abi.sh

README.md

Solana

Solana crate Solana documentation Build status codecov

Building

1. Install rustc, cargo and rustfmt.

$ curl https://sh.rustup.rs -sSf | sh
$ source $HOME/.cargo/env
$ rustup component add rustfmt

Please sure you are always using the latest stable rust version by running:

$ rustup update

On Linux systems you may need to install libssl-dev, pkg-config, zlib1g-dev, etc. On Ubuntu:

$ sudo apt-get update
$ sudo apt-get install libssl-dev libudev-dev pkg-config zlib1g-dev llvm clang make

2. Download the source code.

$ git clone https://github.com/solana-labs/solana.git
$ cd solana

3. Build.

$ cargo build

4. Run a minimal local cluster.

$ ./run.sh

Testing

Run the test suite:

$ cargo test

Starting a local testnet

Start your own testnet locally, instructions are in the online docs.

Accessing the remote development cluster

  • devnet - stable public cluster for development accessible via devnet.solana.com. Runs 24/7. Learn more about the public clusters

Benchmarking

First install the nightly build of rustc. cargo bench requires use of the unstable features only available in the nightly build.

$ rustup install nightly

Run the benchmarks:

$ cargo +nightly bench

Release Process

The release process for this project is described here.

Code coverage

To generate code coverage statistics:

$ scripts/coverage.sh
$ open target/cov/lcov-local/index.html

Why coverage? While most see coverage as a code quality metric, we see it primarily as a developer productivity metric. When a developer makes a change to the codebase, presumably it's a solution to some problem. Our unit-test suite is how we encode the set of problems the codebase solves. Running the test suite should indicate that your change didn't infringe on anyone else's solutions. Adding a test protects your solution from future changes. Say you don't understand why a line of code exists, try deleting it and running the unit-tests. The nearest test failure should tell you what problem was solved by that code. If no test fails, go ahead and submit a Pull Request that asks, "what problem is solved by this code?" On the other hand, if a test does fail and you can think of a better way to solve the same problem, a Pull Request with your solution would most certainly be welcome! Likewise, if rewriting a test can better communicate what code it's protecting, please send us that patch!

Disclaimer

All claims, content, designs, algorithms, estimates, roadmaps, specifications, and performance measurements described in this project are done with the Solana Foundation's ("SF") best efforts. It is up to the reader to check and validate their accuracy and truthfulness. Furthermore nothing in this project constitutes a solicitation for investment.

Any content produced by SF or developer resources that SF provides, are for educational and inspiration purposes only. SF does not encourage, induce or sanction the deployment, integration or use of any such applications (including the code comprising the Solana blockchain protocol) in violation of applicable laws or regulations and hereby prohibits any such deployment, integration or use. This includes use of any such applications by the reader (a) in violation of export control or sanctions laws of the United States or any other applicable jurisdiction, (b) if the reader is located in or ordinarily resident in a country or territory subject to comprehensive sanctions administered by the U.S. Office of Foreign Assets Control (OFAC), or (c) if the reader is or is working on behalf of a Specially Designated National (SDN) or a person subject to similar blocking or denied party prohibitions.

The reader should be aware that U.S. export control and sanctions laws prohibit U.S. persons (and other persons that are subject to such laws) from transacting with persons in certain countries and territories or that are on the SDN list. As a project based primarily on open-source software, it is possible that such sanctioned persons may nevertheless bypass prohibitions, obtain the code comprising the Solana blockchain protocol (or other project code or applications) and deploy, integrate, or otherwise use it. Accordingly, there is a risk to individuals that other persons using the Solana blockchain protocol may be sanctioned persons and that transactions with such persons would be a violation of U.S. export controls and sanctions law. This risk applies to individuals, organizations, and other ecosystem participants that deploy, integrate, or use the Solana blockchain protocol code directly (e.g., as a node operator), and individuals that transact on the Solana blockchain through light clients, third party interfaces, and/or wallet software.