505 lines
18 KiB
Rust
505 lines
18 KiB
Rust
//! The `sigverify_stage` implements the signature verification stage of the TPU. It
|
|
//! receives a list of lists of packets and outputs the same list, but tags each
|
|
//! top-level list with a list of booleans, telling the next stage whether the
|
|
//! signature in that packet is valid. It assumes each packet contains one
|
|
//! transaction. All processing is done on the CPU by default and on a GPU
|
|
//! if perf-libs are available
|
|
|
|
use {
|
|
crate::{find_packet_sender_stake_stage, sigverify},
|
|
core::time::Duration,
|
|
crossbeam_channel::{RecvTimeoutError, SendError, Sender},
|
|
itertools::Itertools,
|
|
solana_measure::measure::Measure,
|
|
solana_perf::{
|
|
packet::PacketBatch,
|
|
sigverify::{count_valid_packets, shrink_batches, Deduper},
|
|
},
|
|
solana_sdk::timing,
|
|
solana_streamer::streamer::{self, StreamerError},
|
|
std::{
|
|
thread::{self, Builder, JoinHandle},
|
|
time::Instant,
|
|
},
|
|
thiserror::Error,
|
|
};
|
|
|
|
// Try to target 50ms, rough timings from mainnet machines
|
|
//
|
|
// 50ms/(300ns/packet) = 166666 packets ~ 1300 batches
|
|
const MAX_DEDUP_BATCH: usize = 165_000;
|
|
|
|
// 50ms/(25us/packet) = 2000 packets
|
|
const MAX_SIGVERIFY_BATCH: usize = 2_000;
|
|
|
|
#[derive(Error, Debug)]
|
|
pub enum SigVerifyServiceError {
|
|
#[error("send packets batch error")]
|
|
Send(#[from] SendError<Vec<PacketBatch>>),
|
|
|
|
#[error("streamer error")]
|
|
Streamer(#[from] StreamerError),
|
|
}
|
|
|
|
type Result<T> = std::result::Result<T, SigVerifyServiceError>;
|
|
|
|
pub struct SigVerifyStage {
|
|
thread_hdl: JoinHandle<()>,
|
|
}
|
|
|
|
pub trait SigVerifier {
|
|
fn verify_batches(&self, batches: Vec<PacketBatch>, valid_packets: usize) -> Vec<PacketBatch>;
|
|
}
|
|
|
|
#[derive(Default, Clone)]
|
|
pub struct DisabledSigVerifier {}
|
|
|
|
#[derive(Default)]
|
|
struct SigVerifierStats {
|
|
recv_batches_us_hist: histogram::Histogram, // time to call recv_batch
|
|
verify_batches_pp_us_hist: histogram::Histogram, // per-packet time to call verify_batch
|
|
discard_packets_pp_us_hist: histogram::Histogram, // per-packet time to call verify_batch
|
|
dedup_packets_pp_us_hist: histogram::Histogram, // per-packet time to call verify_batch
|
|
batches_hist: histogram::Histogram, // number of packet batches per verify call
|
|
packets_hist: histogram::Histogram, // number of packets per verify call
|
|
total_batches: usize,
|
|
total_packets: usize,
|
|
total_dedup: usize,
|
|
total_excess_fail: usize,
|
|
total_valid_packets: usize,
|
|
total_shrinks: usize,
|
|
total_discard_random: usize,
|
|
total_dedup_time_us: usize,
|
|
total_discard_time_us: usize,
|
|
total_discard_random_time_us: usize,
|
|
total_verify_time_us: usize,
|
|
total_shrink_time_us: usize,
|
|
}
|
|
|
|
impl SigVerifierStats {
|
|
fn report(&self, name: &'static str) {
|
|
datapoint_info!(
|
|
name,
|
|
(
|
|
"recv_batches_us_90pct",
|
|
self.recv_batches_us_hist.percentile(90.0).unwrap_or(0),
|
|
i64
|
|
),
|
|
(
|
|
"recv_batches_us_min",
|
|
self.recv_batches_us_hist.minimum().unwrap_or(0),
|
|
i64
|
|
),
|
|
(
|
|
"recv_batches_us_max",
|
|
self.recv_batches_us_hist.maximum().unwrap_or(0),
|
|
i64
|
|
),
|
|
(
|
|
"recv_batches_us_mean",
|
|
self.recv_batches_us_hist.mean().unwrap_or(0),
|
|
i64
|
|
),
|
|
(
|
|
"verify_batches_pp_us_90pct",
|
|
self.verify_batches_pp_us_hist.percentile(90.0).unwrap_or(0),
|
|
i64
|
|
),
|
|
(
|
|
"verify_batches_pp_us_min",
|
|
self.verify_batches_pp_us_hist.minimum().unwrap_or(0),
|
|
i64
|
|
),
|
|
(
|
|
"verify_batches_pp_us_max",
|
|
self.verify_batches_pp_us_hist.maximum().unwrap_or(0),
|
|
i64
|
|
),
|
|
(
|
|
"verify_batches_pp_us_mean",
|
|
self.verify_batches_pp_us_hist.mean().unwrap_or(0),
|
|
i64
|
|
),
|
|
(
|
|
"discard_packets_pp_us_90pct",
|
|
self.discard_packets_pp_us_hist
|
|
.percentile(90.0)
|
|
.unwrap_or(0),
|
|
i64
|
|
),
|
|
(
|
|
"discard_packets_pp_us_min",
|
|
self.discard_packets_pp_us_hist.minimum().unwrap_or(0),
|
|
i64
|
|
),
|
|
(
|
|
"discard_packets_pp_us_max",
|
|
self.discard_packets_pp_us_hist.maximum().unwrap_or(0),
|
|
i64
|
|
),
|
|
(
|
|
"discard_packets_pp_us_mean",
|
|
self.discard_packets_pp_us_hist.mean().unwrap_or(0),
|
|
i64
|
|
),
|
|
(
|
|
"dedup_packets_pp_us_90pct",
|
|
self.dedup_packets_pp_us_hist.percentile(90.0).unwrap_or(0),
|
|
i64
|
|
),
|
|
(
|
|
"dedup_packets_pp_us_min",
|
|
self.dedup_packets_pp_us_hist.minimum().unwrap_or(0),
|
|
i64
|
|
),
|
|
(
|
|
"dedup_packets_pp_us_max",
|
|
self.dedup_packets_pp_us_hist.maximum().unwrap_or(0),
|
|
i64
|
|
),
|
|
(
|
|
"dedup_packets_pp_us_mean",
|
|
self.dedup_packets_pp_us_hist.mean().unwrap_or(0),
|
|
i64
|
|
),
|
|
(
|
|
"batches_90pct",
|
|
self.batches_hist.percentile(90.0).unwrap_or(0),
|
|
i64
|
|
),
|
|
("batches_min", self.batches_hist.minimum().unwrap_or(0), i64),
|
|
("batches_max", self.batches_hist.maximum().unwrap_or(0), i64),
|
|
("batches_mean", self.batches_hist.mean().unwrap_or(0), i64),
|
|
(
|
|
"packets_90pct",
|
|
self.packets_hist.percentile(90.0).unwrap_or(0),
|
|
i64
|
|
),
|
|
("packets_min", self.packets_hist.minimum().unwrap_or(0), i64),
|
|
("packets_max", self.packets_hist.maximum().unwrap_or(0), i64),
|
|
("packets_mean", self.packets_hist.mean().unwrap_or(0), i64),
|
|
("total_batches", self.total_batches, i64),
|
|
("total_packets", self.total_packets, i64),
|
|
("total_dedup", self.total_dedup, i64),
|
|
("total_excess_fail", self.total_excess_fail, i64),
|
|
("total_valid_packets", self.total_valid_packets, i64),
|
|
("total_discard_random", self.total_discard_random, i64),
|
|
("total_shrinks", self.total_shrinks, i64),
|
|
("total_dedup_time_us", self.total_dedup_time_us, i64),
|
|
("total_discard_time_us", self.total_discard_time_us, i64),
|
|
(
|
|
"total_discard_random_time_us",
|
|
self.total_discard_random_time_us,
|
|
i64
|
|
),
|
|
("total_verify_time_us", self.total_verify_time_us, i64),
|
|
("total_shrink_time_us", self.total_shrink_time_us, i64),
|
|
);
|
|
}
|
|
}
|
|
|
|
impl SigVerifier for DisabledSigVerifier {
|
|
fn verify_batches(
|
|
&self,
|
|
mut batches: Vec<PacketBatch>,
|
|
_valid_packets: usize,
|
|
) -> Vec<PacketBatch> {
|
|
sigverify::ed25519_verify_disabled(&mut batches);
|
|
batches
|
|
}
|
|
}
|
|
|
|
impl SigVerifyStage {
|
|
#[allow(clippy::new_ret_no_self)]
|
|
pub fn new<T: SigVerifier + 'static + Send + Clone>(
|
|
packet_receiver: find_packet_sender_stake_stage::FindPacketSenderStakeReceiver,
|
|
verified_sender: Sender<Vec<PacketBatch>>,
|
|
verifier: T,
|
|
name: &'static str,
|
|
) -> Self {
|
|
let thread_hdl = Self::verifier_services(packet_receiver, verified_sender, verifier, name);
|
|
Self { thread_hdl }
|
|
}
|
|
|
|
pub fn discard_excess_packets(batches: &mut [PacketBatch], mut max_packets: usize) {
|
|
// Group packets by their incoming IP address.
|
|
let mut addrs = batches
|
|
.iter_mut()
|
|
.rev()
|
|
.flat_map(|batch| batch.iter_mut().rev())
|
|
.filter(|packet| !packet.meta.discard())
|
|
.map(|packet| (packet.meta.addr, packet))
|
|
.into_group_map();
|
|
// Allocate max_packets evenly across addresses.
|
|
while max_packets > 0 && !addrs.is_empty() {
|
|
let num_addrs = addrs.len();
|
|
addrs.retain(|_, packets| {
|
|
let cap = (max_packets + num_addrs - 1) / num_addrs;
|
|
max_packets -= packets.len().min(cap);
|
|
packets.truncate(packets.len().saturating_sub(cap));
|
|
!packets.is_empty()
|
|
});
|
|
}
|
|
// Discard excess packets from each address.
|
|
for packet in addrs.into_values().flatten() {
|
|
packet.meta.set_discard(true);
|
|
}
|
|
}
|
|
|
|
fn verifier<T: SigVerifier>(
|
|
deduper: &Deduper,
|
|
recvr: &find_packet_sender_stake_stage::FindPacketSenderStakeReceiver,
|
|
sendr: &Sender<Vec<PacketBatch>>,
|
|
verifier: &T,
|
|
stats: &mut SigVerifierStats,
|
|
) -> Result<()> {
|
|
let (mut batches, num_packets, recv_duration) = streamer::recv_vec_packet_batches(recvr)?;
|
|
|
|
let batches_len = batches.len();
|
|
debug!(
|
|
"@{:?} verifier: verifying: {}",
|
|
timing::timestamp(),
|
|
num_packets,
|
|
);
|
|
|
|
let mut discard_random_time = Measure::start("sigverify_discard_random_time");
|
|
let non_discarded_packets = solana_perf::discard::discard_batches_randomly(
|
|
&mut batches,
|
|
MAX_DEDUP_BATCH,
|
|
num_packets,
|
|
);
|
|
let num_discarded_randomly = num_packets.saturating_sub(non_discarded_packets);
|
|
discard_random_time.stop();
|
|
|
|
let mut dedup_time = Measure::start("sigverify_dedup_time");
|
|
let discard_or_dedup_fail = deduper.dedup_packets_and_count_discards(&mut batches) as usize;
|
|
dedup_time.stop();
|
|
let num_unique = non_discarded_packets.saturating_sub(discard_or_dedup_fail);
|
|
|
|
let mut discard_time = Measure::start("sigverify_discard_time");
|
|
let mut num_valid_packets = num_unique;
|
|
if num_unique > MAX_SIGVERIFY_BATCH {
|
|
Self::discard_excess_packets(&mut batches, MAX_SIGVERIFY_BATCH);
|
|
num_valid_packets = MAX_SIGVERIFY_BATCH;
|
|
}
|
|
let excess_fail = num_unique.saturating_sub(MAX_SIGVERIFY_BATCH);
|
|
discard_time.stop();
|
|
|
|
let mut verify_time = Measure::start("sigverify_batch_time");
|
|
let mut batches = verifier.verify_batches(batches, num_valid_packets);
|
|
verify_time.stop();
|
|
|
|
let mut shrink_time = Measure::start("sigverify_shrink_time");
|
|
let num_valid_packets = count_valid_packets(&batches);
|
|
let start_len = batches.len();
|
|
const MAX_EMPTY_BATCH_RATIO: usize = 4;
|
|
if non_discarded_packets > num_valid_packets.saturating_mul(MAX_EMPTY_BATCH_RATIO) {
|
|
let valid = shrink_batches(&mut batches);
|
|
batches.truncate(valid);
|
|
}
|
|
let total_shrinks = start_len.saturating_sub(batches.len());
|
|
shrink_time.stop();
|
|
|
|
sendr.send(batches)?;
|
|
|
|
debug!(
|
|
"@{:?} verifier: done. batches: {} total verify time: {:?} verified: {} v/s {}",
|
|
timing::timestamp(),
|
|
batches_len,
|
|
verify_time.as_ms(),
|
|
num_packets,
|
|
(num_packets as f32 / verify_time.as_s())
|
|
);
|
|
|
|
stats
|
|
.recv_batches_us_hist
|
|
.increment(recv_duration.as_micros() as u64)
|
|
.unwrap();
|
|
stats
|
|
.verify_batches_pp_us_hist
|
|
.increment(verify_time.as_us() / (num_packets as u64))
|
|
.unwrap();
|
|
stats
|
|
.discard_packets_pp_us_hist
|
|
.increment(discard_time.as_us() / (num_packets as u64))
|
|
.unwrap();
|
|
stats
|
|
.dedup_packets_pp_us_hist
|
|
.increment(dedup_time.as_us() / (num_packets as u64))
|
|
.unwrap();
|
|
stats.batches_hist.increment(batches_len as u64).unwrap();
|
|
stats.packets_hist.increment(num_packets as u64).unwrap();
|
|
stats.total_batches += batches_len;
|
|
stats.total_packets += num_packets;
|
|
stats.total_dedup += discard_or_dedup_fail;
|
|
stats.total_valid_packets += num_valid_packets;
|
|
stats.total_discard_random_time_us += discard_random_time.as_us() as usize;
|
|
stats.total_discard_random += num_discarded_randomly;
|
|
stats.total_excess_fail += excess_fail;
|
|
stats.total_shrinks += total_shrinks;
|
|
stats.total_dedup_time_us += dedup_time.as_us() as usize;
|
|
stats.total_discard_time_us += discard_time.as_us() as usize;
|
|
stats.total_verify_time_us += verify_time.as_us() as usize;
|
|
stats.total_shrink_time_us += shrink_time.as_us() as usize;
|
|
|
|
Ok(())
|
|
}
|
|
|
|
fn verifier_service<T: SigVerifier + 'static + Send + Clone>(
|
|
packet_receiver: find_packet_sender_stake_stage::FindPacketSenderStakeReceiver,
|
|
verified_sender: Sender<Vec<PacketBatch>>,
|
|
verifier: &T,
|
|
name: &'static str,
|
|
) -> JoinHandle<()> {
|
|
let verifier = verifier.clone();
|
|
let mut stats = SigVerifierStats::default();
|
|
let mut last_print = Instant::now();
|
|
const MAX_DEDUPER_AGE: Duration = Duration::from_secs(2);
|
|
const MAX_DEDUPER_ITEMS: u32 = 1_000_000;
|
|
Builder::new()
|
|
.name("solana-verifier".to_string())
|
|
.spawn(move || {
|
|
let mut deduper = Deduper::new(MAX_DEDUPER_ITEMS, MAX_DEDUPER_AGE);
|
|
loop {
|
|
deduper.reset();
|
|
if let Err(e) = Self::verifier(
|
|
&deduper,
|
|
&packet_receiver,
|
|
&verified_sender,
|
|
&verifier,
|
|
&mut stats,
|
|
) {
|
|
match e {
|
|
SigVerifyServiceError::Streamer(StreamerError::RecvTimeout(
|
|
RecvTimeoutError::Disconnected,
|
|
)) => break,
|
|
SigVerifyServiceError::Streamer(StreamerError::RecvTimeout(
|
|
RecvTimeoutError::Timeout,
|
|
)) => (),
|
|
SigVerifyServiceError::Send(_) => {
|
|
break;
|
|
}
|
|
_ => error!("{:?}", e),
|
|
}
|
|
}
|
|
if last_print.elapsed().as_secs() > 2 {
|
|
stats.report(name);
|
|
stats = SigVerifierStats::default();
|
|
last_print = Instant::now();
|
|
}
|
|
}
|
|
})
|
|
.unwrap()
|
|
}
|
|
|
|
fn verifier_services<T: SigVerifier + 'static + Send + Clone>(
|
|
packet_receiver: find_packet_sender_stake_stage::FindPacketSenderStakeReceiver,
|
|
verified_sender: Sender<Vec<PacketBatch>>,
|
|
verifier: T,
|
|
name: &'static str,
|
|
) -> JoinHandle<()> {
|
|
Self::verifier_service(packet_receiver, verified_sender, &verifier, name)
|
|
}
|
|
|
|
pub fn join(self) -> thread::Result<()> {
|
|
self.thread_hdl.join()
|
|
}
|
|
}
|
|
|
|
#[cfg(test)]
|
|
mod tests {
|
|
use {
|
|
super::*,
|
|
crate::{sigverify::TransactionSigVerifier, sigverify_stage::timing::duration_as_ms},
|
|
crossbeam_channel::unbounded,
|
|
solana_perf::{
|
|
packet::{to_packet_batches, Packet},
|
|
test_tx::test_tx,
|
|
},
|
|
};
|
|
|
|
fn count_non_discard(packet_batches: &[PacketBatch]) -> usize {
|
|
packet_batches
|
|
.iter()
|
|
.map(|batch| {
|
|
batch
|
|
.iter()
|
|
.map(|p| if p.meta.discard() { 0 } else { 1 })
|
|
.sum::<usize>()
|
|
})
|
|
.sum::<usize>()
|
|
}
|
|
|
|
#[test]
|
|
fn test_packet_discard() {
|
|
solana_logger::setup();
|
|
let batch_size = 10;
|
|
let mut batch = PacketBatch::with_capacity(batch_size);
|
|
batch.resize(batch_size, Packet::default());
|
|
batch[3].meta.addr = std::net::IpAddr::from([1u16; 8]);
|
|
batch[3].meta.set_discard(true);
|
|
batch[4].meta.addr = std::net::IpAddr::from([2u16; 8]);
|
|
let mut batches = vec![batch];
|
|
let max = 3;
|
|
SigVerifyStage::discard_excess_packets(&mut batches, max);
|
|
assert_eq!(count_non_discard(&batches), max);
|
|
assert!(!batches[0][0].meta.discard());
|
|
assert!(batches[0][3].meta.discard());
|
|
assert!(!batches[0][4].meta.discard());
|
|
}
|
|
fn gen_batches(use_same_tx: bool) -> Vec<PacketBatch> {
|
|
let len = 4096;
|
|
let chunk_size = 1024;
|
|
if use_same_tx {
|
|
let tx = test_tx();
|
|
to_packet_batches(&vec![tx; len], chunk_size)
|
|
} else {
|
|
let txs: Vec<_> = (0..len).map(|_| test_tx()).collect();
|
|
to_packet_batches(&txs, chunk_size)
|
|
}
|
|
}
|
|
|
|
#[test]
|
|
fn test_sigverify_stage() {
|
|
solana_logger::setup();
|
|
trace!("start");
|
|
let (packet_s, packet_r) = unbounded();
|
|
let (verified_s, verified_r) = unbounded();
|
|
let verifier = TransactionSigVerifier::default();
|
|
let stage = SigVerifyStage::new(packet_r, verified_s, verifier, "test");
|
|
|
|
let use_same_tx = true;
|
|
let now = Instant::now();
|
|
let mut batches = gen_batches(use_same_tx);
|
|
trace!(
|
|
"starting... generation took: {} ms batches: {}",
|
|
duration_as_ms(&now.elapsed()),
|
|
batches.len()
|
|
);
|
|
|
|
let mut sent_len = 0;
|
|
for _ in 0..batches.len() {
|
|
if let Some(batch) = batches.pop() {
|
|
sent_len += batch.len();
|
|
packet_s.send(vec![batch]).unwrap();
|
|
}
|
|
}
|
|
let mut received = 0;
|
|
trace!("sent: {}", sent_len);
|
|
loop {
|
|
if let Ok(mut verifieds) = verified_r.recv_timeout(Duration::from_millis(10)) {
|
|
while let Some(v) = verifieds.pop() {
|
|
received += v.len();
|
|
batches.push(v);
|
|
}
|
|
if use_same_tx || received >= sent_len {
|
|
break;
|
|
}
|
|
}
|
|
}
|
|
trace!("received: {}", received);
|
|
drop(packet_s);
|
|
stage.join().unwrap();
|
|
}
|
|
}
|