fix: duplicate vesting and format (#9535)
<!-- The default pull request template is for types feat, fix, or refactor. For other templates, add one of the following parameters to the url: - template=docs.md - template=other.md --> ## Description <!-- Add a description of the changes that this PR introduces and the files that are the most critical to review. --> This pull request fixes the duplicate `vesting` command displayed with `--help` for the `tx` command. It also removes line breaks for consistent formatting across all commands and it fixes a minor typo. ## Manual Test ``` make build ``` ``` ./build/simd tx -h ``` ``` ./build/simd tx vesting -h ``` --- ### Author Checklist *All items are required. Please add a note to the item if the item is not applicable and please add links to any relevant follow up issues.* I have... - [x] included the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title - [x] added `!` to the type prefix if API or client breaking change - *n/a* - [x] targeted the correct branch (see [PR Targeting](https://github.com/cosmos/cosmos-sdk/blob/master/CONTRIBUTING.md#pr-targeting)) - [x] provided a link to the relevant issue or specification - *n/a* - [x] followed the guidelines for [building modules](https://github.com/cosmos/cosmos-sdk/blob/master/docs/building-modules) - *n/a* - [x] included the necessary unit and integration [tests](https://github.com/cosmos/cosmos-sdk/blob/master/CONTRIBUTING.md#testing) - [x] added a changelog entry to `CHANGELOG.md` - [x] included comments for [documenting Go code](https://blog.golang.org/godoc) - [x] updated the relevant documentation or specification - [x] reviewed "Files changed" and left comments if necessary - [x] confirmed all CI checks have passed ### Reviewers Checklist *All items are required. Please add a note if the item is not applicable and please add your handle next to the items reviewed if you only reviewed selected items.* I have... - [ ] confirmed the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title - [ ] confirmed `!` in the type prefix if API or client breaking change - [ ] confirmed all author checklist items have been addressed - [ ] reviewed state machine logic - [ ] reviewed API design and naming - [ ] reviewed documentation is accurate - [ ] reviewed tests and test coverage - [ ] manually tested (if applicable)
This commit is contained in:
parent
0e64fa77d1
commit
0ae07fe69c
|
@ -44,7 +44,6 @@ The pass backend requires GnuPG: https://gnupg.org/
|
||||||
ImportKeyCommand(),
|
ImportKeyCommand(),
|
||||||
ListKeysCmd(),
|
ListKeysCmd(),
|
||||||
ShowKeysCmd(),
|
ShowKeysCmd(),
|
||||||
flags.LineBreak,
|
|
||||||
DeleteKeyCommand(),
|
DeleteKeyCommand(),
|
||||||
ParseKeyStringCommand(),
|
ParseKeyStringCommand(),
|
||||||
MigrateCommand(),
|
MigrateCommand(),
|
||||||
|
|
|
@ -11,5 +11,5 @@ func TestCommands(t *testing.T) {
|
||||||
assert.NotNil(t, rootCommands)
|
assert.NotNil(t, rootCommands)
|
||||||
|
|
||||||
// Commands are registered
|
// Commands are registered
|
||||||
assert.Equal(t, 10, len(rootCommands.Commands()))
|
assert.Equal(t, 9, len(rootCommands.Commands()))
|
||||||
}
|
}
|
||||||
|
|
|
@ -264,10 +264,8 @@ func AddCommands(rootCmd *cobra.Command, defaultNodeHome string, appCreator type
|
||||||
rootCmd.AddCommand(
|
rootCmd.AddCommand(
|
||||||
startCmd,
|
startCmd,
|
||||||
UnsafeResetAllCmd(),
|
UnsafeResetAllCmd(),
|
||||||
flags.LineBreak,
|
|
||||||
tendermintCmd,
|
tendermintCmd,
|
||||||
ExportCmd(appExport, defaultNodeHome),
|
ExportCmd(appExport, defaultNodeHome),
|
||||||
flags.LineBreak,
|
|
||||||
version.NewVersionCommand(),
|
version.NewVersionCommand(),
|
||||||
)
|
)
|
||||||
}
|
}
|
||||||
|
|
|
@ -28,7 +28,6 @@ import (
|
||||||
sdk "github.com/cosmos/cosmos-sdk/types"
|
sdk "github.com/cosmos/cosmos-sdk/types"
|
||||||
authcmd "github.com/cosmos/cosmos-sdk/x/auth/client/cli"
|
authcmd "github.com/cosmos/cosmos-sdk/x/auth/client/cli"
|
||||||
"github.com/cosmos/cosmos-sdk/x/auth/types"
|
"github.com/cosmos/cosmos-sdk/x/auth/types"
|
||||||
vestingcli "github.com/cosmos/cosmos-sdk/x/auth/vesting/client/cli"
|
|
||||||
banktypes "github.com/cosmos/cosmos-sdk/x/bank/types"
|
banktypes "github.com/cosmos/cosmos-sdk/x/bank/types"
|
||||||
"github.com/cosmos/cosmos-sdk/x/crisis"
|
"github.com/cosmos/cosmos-sdk/x/crisis"
|
||||||
genutilcli "github.com/cosmos/cosmos-sdk/x/genutil/client/cli"
|
genutilcli "github.com/cosmos/cosmos-sdk/x/genutil/client/cli"
|
||||||
|
@ -151,12 +150,9 @@ func txCommand() *cobra.Command {
|
||||||
authcmd.GetMultiSignCommand(),
|
authcmd.GetMultiSignCommand(),
|
||||||
authcmd.GetMultiSignBatchCmd(),
|
authcmd.GetMultiSignBatchCmd(),
|
||||||
authcmd.GetValidateSignaturesCommand(),
|
authcmd.GetValidateSignaturesCommand(),
|
||||||
flags.LineBreak,
|
|
||||||
authcmd.GetBroadcastCommand(),
|
authcmd.GetBroadcastCommand(),
|
||||||
authcmd.GetEncodeCommand(),
|
authcmd.GetEncodeCommand(),
|
||||||
authcmd.GetDecodeCommand(),
|
authcmd.GetDecodeCommand(),
|
||||||
flags.LineBreak,
|
|
||||||
vestingcli.GetTxCmd(),
|
|
||||||
)
|
)
|
||||||
|
|
||||||
simapp.ModuleBasics.AddTxCommands(cmd)
|
simapp.ModuleBasics.AddTxCommands(cmd)
|
||||||
|
|
|
@ -17,7 +17,7 @@ const flagHex = "hex"
|
||||||
func GetDecodeCommand() *cobra.Command {
|
func GetDecodeCommand() *cobra.Command {
|
||||||
cmd := &cobra.Command{
|
cmd := &cobra.Command{
|
||||||
Use: "decode [amino-byte-string]",
|
Use: "decode [amino-byte-string]",
|
||||||
Short: "Decode an binary encoded transaction string.",
|
Short: "Decode a binary encoded transaction string",
|
||||||
Args: cobra.ExactArgs(1),
|
Args: cobra.ExactArgs(1),
|
||||||
RunE: func(cmd *cobra.Command, args []string) (err error) {
|
RunE: func(cmd *cobra.Command, args []string) (err error) {
|
||||||
clientCtx := client.GetClientContextFromCmd(cmd)
|
clientCtx := client.GetClientContextFromCmd(cmd)
|
||||||
|
|
Loading…
Reference in New Issue