Merge PR #3421: Upgrade ledger-cosmos-go dep to 0.9.3

* Upgrading to ledger-cosmos-go
* Add cli test and update PENDING.md
This commit is contained in:
Alessio Treglia 2019-01-29 13:45:30 -08:00 committed by Christopher Goes
parent f66b7b6310
commit 14dcaa6458
5 changed files with 21 additions and 4 deletions

6
Gopkg.lock generated
View File

@ -522,12 +522,12 @@
revision = "v0.29.0"
[[projects]]
digest = "1:a7485b2a69f996923f9d3406a9a853fd8eb31818515e985a830d71f88f6a925b"
digest = "1:29b886f00694ae7c18c4559a2901f2a057d5a62308ed5eb6cd52b9a31016fb14"
name = "github.com/zondax/ledger-cosmos-go"
packages = ["."]
pruneopts = "UT"
revision = "d4aed6d929a703bb555a2d79fe9c470afe61f648"
version = "v0.9.2"
revision = "71aa0ab6e03d2d320c82bbe13678a36584a5b813"
version = "v0.9.3"
[[projects]]
digest = "1:6f6dc6060c4e9ba73cf28aa88f12a69a030d3d19d518ef8e931879eaa099628d"

View File

@ -44,7 +44,7 @@
[[constraint]]
name = "github.com/zondax/ledger-cosmos-go"
version = "=v0.9.2"
version = "=v0.9.3"
## deps without releases:

View File

@ -58,6 +58,9 @@ BUG FIXES
* Gaia CLI (`gaiacli`)
- [\#3417](https://github.com/cosmos/cosmos-sdk/pull/3417) Fix `q slashing signing-info` panic by ensuring safety of user input and properly returning not found error
- [\#3345](https://github.com/cosmos/cosmos-sdk/issues/3345) Upgrade ledger-cosmos-go dependency to v0.9.3 to pull
https://github.com/ZondaX/ledger-cosmos-go/commit/ed9aa39ce8df31bad1448c72d3d226bf2cb1a8d1 in order to fix a derivation path issue that causes `gaiacli keys add --recover`
to malfunction.
- [\#3419](https://github.com/cosmos/cosmos-sdk/pull/3419) Fix `q distr slashes` panic
* Gaia

View File

@ -45,6 +45,14 @@ func TestGaiaCLIKeysAddMultisig(t *testing.T) {
require.NotEqual(t, f.KeysShow("msig3").Address, f.KeysShow("msig4").Address)
}
func TestGaiaCLIKeysAddRecover(t *testing.T) {
t.Parallel()
f := InitFixtures(t)
f.KeysAddRecover("test-recover", "dentist task convince chimney quality leave banana trade firm crawl eternal easily")
require.Equal(t, f.KeyAddress("test-recover").String(), "cosmos1qcfdf69js922qrdr4yaww3ax7gjml6pdds46f4")
}
func TestGaiaCLIMinimumFees(t *testing.T) {
t.Parallel()
f := InitFixtures(t)

View File

@ -226,6 +226,12 @@ func (f *Fixtures) KeysAdd(name string, flags ...string) {
executeWriteCheckErr(f.T, addFlags(cmd, flags), app.DefaultKeyPass)
}
// KeysAdd is gaiacli keys add --recover
func (f *Fixtures) KeysAddRecover(name, mnemonic string, flags ...string) {
cmd := fmt.Sprintf("gaiacli keys add --home=%s --recover %s", f.GCLIHome, name)
executeWriteCheckErr(f.T, addFlags(cmd, flags), app.DefaultKeyPass, mnemonic)
}
// KeysShow is gaiacli keys show
func (f *Fixtures) KeysShow(name string, flags ...string) keys.KeyOutput {
cmd := fmt.Sprintf("gaiacli keys show --home=%s %s", f.GCLIHome, name)