Fixing the issues suggested in code review

This commit is contained in:
Sridhar Ganesan 2018-07-23 18:12:22 +02:00
parent adceed9e12
commit 196a45bb30
2 changed files with 4 additions and 7 deletions

View File

@ -25,8 +25,8 @@ FEATURES
* Modules can test random combinations of their own operations
* Applications can integrate operations and invariants from modules together for an integrated simulation
* [baseapp] Initialize validator set on ResponseInitChain
* Added support for cosmos-sdk-cli tool under cosmos-sdk/cmd
* This allows SDK users to init a new project repository with a single command.
* [cosmos-sdk-cli] Added support for cosmos-sdk-cli tool under cosmos-sdk/cmd
* This allows SDK users to initialize a new project repository.
IMPROVEMENTS
* [baseapp] Allow any alphanumeric character in route
@ -35,9 +35,6 @@ IMPROVEMENTS
* [x/stake] Add revoked to human-readable validator
* [x/gov] Votes on a proposal can now be queried
* [x/bank] Unit tests are now table-driven
* [cosmos-sdk-cli]
* Replacing all instances of "Basecoin" to ProjectName in Basecoin code
* Checking if directory exists before creating a new project
BUG FIXES
* \#1666 Add intra-tx counter to the genesis validators

View File

@ -151,8 +151,8 @@ func setupBasecoinWorkspace(projectName string, remoteProjectPath string) {
copyBasecoinTemplate(projectName, projectPath, remoteProjectPath)
createGopkg(projectPath)
createMakefile(projectPath)
fmt.Printf("\nInitialized a new project at %s.\nHappy hacking!\n", projectPath)
fmt.Printf("Initialized a new project at %s.\nHappy hacking!\n", projectPath)
} else {
fmt.Printf("\n%s already exists, please choose a different project path\n", projectPath)
fmt.Errorf("%s already exists, please choose a different project path\n", projectPath)
}
}