From 2f394ce1a8e95916872f5e51a443eaa8e836e97b Mon Sep 17 00:00:00 2001 From: Marko Date: Mon, 18 May 2020 16:09:14 +0200 Subject: [PATCH] remove auto-comment bot; add PR template (#6242) Co-authored-by: Alexander Bezobchuk --- .github/PULL_REQUEST_TEMPLATE.md | 20 ++++++++++++++++++-- .github/auto-comment.yml | 30 ------------------------------ 2 files changed, 18 insertions(+), 32 deletions(-) delete mode 100644 .github/auto-comment.yml diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index 302ee203e..627df604a 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -1,5 +1,5 @@ @@ -10,5 +10,21 @@ v If a checkbox is n/a - please still include it but + a little note why are the most critical to review. --> - closes: #XXXX + +Before we can merge this PR, please make sure that all the following items have been +checked off. If any of the checklist items are not applicable, please leave them but +write a little note why. + +--- + +For contributor use: + +- [ ] Targeted PR against correct branch (see [CONTRIBUTING.md](https://github.com/cosmos/cosmos-sdk/blob/master/CONTRIBUTING.md#pr-targeting)) +- [ ] Linked to Github issue with discussion and accepted design OR link to spec that describes this work. +- [ ] Code follows the [module structure standards](https://github.com/cosmos/cosmos-sdk/blob/master/docs/building-modules/structure.md). +- [ ] Wrote unit and integration [tests](https://github.com/cosmos/cosmos-sdk/blob/master/CONTRIBUTING.md#testing) +- [ ] Updated relevant documentation (`docs/`) or specification (`x//spec/`) +- [ ] Added relevant `godoc` [comments](https://blog.golang.org/godoc-documenting-go-code). +- [ ] Added a relevant changelog entry to the `Unreleased` section in `CHANGELOG.md` +- [ ] Re-reviewed `Files changed` in the Github PR explorer diff --git a/.github/auto-comment.yml b/.github/auto-comment.yml deleted file mode 100644 index 260bb755a..000000000 --- a/.github/auto-comment.yml +++ /dev/null @@ -1,30 +0,0 @@ -pullRequestOpened: | - :wave: Thanks for creating a PR! - - Before we can merge this PR, please make sure that all the following items have been - checked off. If any of the checklist items are not applicable, please leave them but - write a little note why. - - ______ - - For contributor use: - - - [ ] Targeted PR against correct branch (see [CONTRIBUTING.md](https://github.com/cosmos/cosmos-sdk/blob/master/CONTRIBUTING.md#pr-targeting)) - - [ ] Linked to Github issue with discussion and accepted design OR link to spec that describes this work. - - [ ] Code follows the [module structure standards](https://github.com/cosmos/cosmos-sdk/blob/master/docs/building-modules/structure.md). - - [ ] Wrote unit and integration [tests](https://github.com/cosmos/cosmos-sdk/blob/master/CONTRIBUTING.md#testing) - - [ ] Updated relevant documentation (`docs/`) or specification (`x//spec/`) - - [ ] Added relevant `godoc` [comments](https://blog.golang.org/godoc-documenting-go-code). - - [ ] Added a relevant changelog entry to the `Unreleased` section in `CHANGELOG.md` - - [ ] Re-reviewed `Files changed` in the Github PR explorer - - ______ - - For admin use: - - - [ ] Added appropriate labels to PR (ex. `WIP`, `R4R`, `docs`, etc) - - [ ] Reviewers assigned - - [ ] Squashed all commits, uses message "Merge pull request #XYZ: [title]" ([coding standards](https://github.com/tendermint/coding/blob/master/README.md#merging-a-pr)) - - - Thank you for your contribution to the Cosmos-SDK! :rocket: