Merge pull request #1182 from cosmos/cwgoes/max-gas-flag

Add --gas flag to specify gas limit for a transaction

CHANGELOG.md

@@ -12,6 +12,7 @@ IMPROVEMENTS
 
 FIXES
 * [lcd] Switch to bech32 for addresses on all human readable inputs and outputs
+* [cli] Added `--gas` flag to specify transaction gas limit
 
 ## 0.18.0
 

client/context/helpers.go

@@ -114,7 +114,7 @@ func (ctx CoreContext) SignAndBuild(name, passphrase string, msg sdk.Msg, cdc *w
 		ChainID:   chainID,
 		Sequences: []int64{sequence},
 		Msg:       msg,
-		Fee:       auth.NewStdFee(10000, sdk.Coin{}), // TODO run simulate to estimate gas?
+		Fee:       auth.NewStdFee(ctx.Gas, sdk.Coin{}), // TODO run simulate to estimate gas?
 	}
 
 	keybase, err := keys.GetKeyBase()

client/context/types.go

@@ -10,6 +10,7 @@ import (
 type CoreContext struct {
 	ChainID         string
 	Height          int64
+	Gas             int64
 	TrustNode       bool
 	NodeURI         string
 	FromAddressName string
@@ -31,6 +32,12 @@ func (c CoreContext) WithHeight(height int64) CoreContext {
 	return c
 }
 
+// WithGas - return a copy of the context with an updated gas
+func (c CoreContext) WithGas(gas int64) CoreContext {
+	c.Gas = gas
+	return c
+}
+
 // WithTrustNode - return a copy of the context with an updated TrustNode flag
 func (c CoreContext) WithTrustNode(trustNode bool) CoreContext {
 	c.TrustNode = trustNode

client/context/viper.go

@@ -30,6 +30,7 @@ func NewCoreContextFromViper() CoreContext {
 	return CoreContext{
 		ChainID:         chainID,
 		Height:          viper.GetInt64(client.FlagHeight),
+		Gas:             viper.GetInt64(client.FlagGas),
 		TrustNode:       viper.GetBool(client.FlagTrustNode),
 		FromAddressName: viper.GetString(client.FlagName),
 		NodeURI:         nodeURI,

client/flags.go

@@ -7,6 +7,7 @@ const (
 	FlagChainID   = "chain-id"
 	FlagNode      = "node"
 	FlagHeight    = "height"
+	FlagGas       = "gas"
 	FlagTrustNode = "trust-node"
 	FlagName      = "name"
 	FlagSequence  = "sequence"
@@ -37,6 +38,7 @@ func PostCommands(cmds ...*cobra.Command) []*cobra.Command {
 		c.Flags().String(FlagFee, "", "Fee to pay along with transaction")
 		c.Flags().String(FlagChainID, "", "Chain ID of tendermint node")
 		c.Flags().String(FlagNode, "tcp://localhost:46657", "<host>:<port> to tendermint rpc interface for this chain")
+		c.Flags().Int64(FlagGas, 200000, "gas limit to set per-transaction")
 	}
 	return cmds
 }

client/lcd/lcd_test.go

@@ -22,11 +22,11 @@ import (
 	tmcfg "github.com/tendermint/tendermint/config"
 	nm "github.com/tendermint/tendermint/node"
 	p2p "github.com/tendermint/tendermint/p2p"
+	pvm "github.com/tendermint/tendermint/privval"
 	"github.com/tendermint/tendermint/proxy"
 	ctypes "github.com/tendermint/tendermint/rpc/core/types"
 	tmrpc "github.com/tendermint/tendermint/rpc/lib/server"
 	tmtypes "github.com/tendermint/tendermint/types"
-	pvm "github.com/tendermint/tendermint/privval"
 	"github.com/tendermint/tmlibs/cli"
 	dbm "github.com/tendermint/tmlibs/db"
 	"github.com/tendermint/tmlibs/log"
@@ -392,6 +392,7 @@ func startTMAndLCD() (*nm.Node, net.Listener, error) {
 		return nil, nil, err
 	}
 	viper.Set(cli.HomeFlag, dir)
+	viper.Set(client.FlagGas, 200000)
 	kb, err := keys.GetKeyBase() // dbm.NewMemDB()) // :(
 	if err != nil {
 		return nil, nil, err