0.43 aidut changes for client module (#9295)

Co-authored-by: atheeshp <59333759+atheeshp@users.noreply.github.com>
Co-authored-by: Amaury <1293565+amaurym@users.noreply.github.com>

client/config/cmd.go

@@ -36,8 +36,11 @@ func runConfigCmd(cmd *cobra.Command, args []string) error {
 
 	switch len(args) {
 	case 0:
-		// print all client config fields to sdt out
-		s, _ := json.MarshalIndent(conf, "", "\t")
+		// print all client config fields to stdout
+		s, err := json.MarshalIndent(conf, "", "\t")
+		if err != nil {
+			return err
+		}
 		cmd.Println(string(s))
 
 	case 1:

client/docs/swagger-ui/swagger.yaml

@@ -1545,7 +1545,7 @@ paths:
       parameters:
         - in: body
           name: delegation
-          description: The password of the account to remove from the KMS
+          description: Delegate an amount of liquid coins to a validator
           schema:
             type: object
             properties:
@@ -1760,7 +1760,7 @@ paths:
       parameters:
         - in: body
           name: delegation
-          description: The password of the account to remove from the KMS
+          description: Unbond an amount of bonded shares from a validator
           schema:
             type: object
             properties:
@@ -16945,6 +16945,11 @@ paths:
                   bond_denom:
                     type: string
                     description: bond_denom defines the bondable coin denomination.
+                  power_reduction:
+                    type: string
+                    title: >-
+                      power_reduction is the amount of staking tokens required
+                      for 1 unit of consensus-engine power
             description: >-
               QueryParamsResponse is response type for the Query/Params RPC
               method.
@@ -31115,6 +31120,11 @@ definitions:
       bond_denom:
         type: string
         description: bond_denom defines the bondable coin denomination.
+      power_reduction:
+        type: string
+        title: >-
+          power_reduction is the amount of staking tokens required for 1 unit of
+          consensus-engine power
     description: Params defines the parameters for the staking module.
   cosmos.staking.v1beta1.Pool:
     type: object
@@ -32355,6 +32365,11 @@ definitions:
           bond_denom:
             type: string
             description: bond_denom defines the bondable coin denomination.
+          power_reduction:
+            type: string
+            title: >-
+              power_reduction is the amount of staking tokens required for 1
+              unit of consensus-engine power
     description: QueryParamsResponse is response type for the Query/Params RPC method.
   cosmos.staking.v1beta1.QueryPoolResponse:
     type: object
@@ -35881,7 +35896,14 @@ definitions:
               transaction.
           memo:
             type: string
-            title: memo is any arbitrary memo to be added to the transaction
+            description: >-
+              memo is any arbitrary note/comment to be added to the transaction.
+
+              WARNING: in clients, any publicly exposed text should not be
+              called memo,
+
+              but should be called `note` instead (see
+              https://github.com/cosmos/cosmos-sdk/issues/9122).
           timeout_height:
             type: string
             format: uint64
@@ -36451,7 +36473,14 @@ definitions:
           transaction.
       memo:
         type: string
-        title: memo is any arbitrary memo to be added to the transaction
+        description: >-
+          memo is any arbitrary note/comment to be added to the transaction.
+
+          WARNING: in clients, any publicly exposed text should not be called
+          memo,
+
+          but should be called `note` instead (see
+          https://github.com/cosmos/cosmos-sdk/issues/9122).
       timeout_height:
         type: string
         format: uint64

client/docs/swagger_legacy.yaml

@@ -556,7 +556,7 @@ paths:
       parameters:
         - in: body
           name: delegation
-          description: The password of the account to remove from the KMS
+          description: Delegate an amount of liquid coins to a validator
           schema:
             type: object
             properties:
@@ -646,7 +646,7 @@ paths:
       parameters:
         - in: body
           name: delegation
-          description: The password of the account to remove from the KMS
+          description: Unbond an amount of bonded shares from a validator
           schema:
             type: object
             properties:

client/keys/add.go

@@ -102,7 +102,6 @@ output
 	- armor encrypted private key (saved to file)
 */
 func RunAddCmd(ctx client.Context, cmd *cobra.Command, args []string, inBuf *bufio.Reader) error {
-	// func RunAddCmd(cmd *cobra.Command, args []string, kb keyring.Keyring, inBuf *bufio.Reader) error {
 	var err error
 
 	name := args[0]