* fix: enable setting sequence (nonce) for module account (#10536)
## Description
Closes #10538
---
### Author Checklist
*All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.*
I have...
- [ ] included the correct `docs:` prefix in the PR title
- [ ] targeted the correct branch (see [PR Targeting](https://github.com/cosmos/cosmos-sdk/blob/master/CONTRIBUTING.md#pr-targeting))
- [ ] provided a link to the relevant issue or specification
- [ ] followed the [documentation writing guidelines](https://github.com/cosmos/cosmos-sdk/blob/master/docs/DOC_WRITING_GUIDELINES.md)
- [ ] reviewed "Files changed" and left comments if necessary
- [ ] confirmed all CI checks have passed
### Reviewers Checklist
*All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.*
I have...
- [ ] confirmed the correct `docs:` prefix in the PR title
- [ ] confirmed all author checklist items have been addressed
- [ ] confirmed that this PR only changes documentation
- [ ] reviewed content for consistency
- [ ] reviewed content for thoroughness
- [ ] reviewed content for spelling and grammar
- [ ] tested instructions (if applicable)
(cherry picked from commit 7043dde071
)
# Conflicts:
# CHANGELOG.md
* conflicts
Co-authored-by: Federico Kunze Küllmer <31522760+fedekunze@users.noreply.github.com>
Co-authored-by: Federico Kunze Küllmer <federico.kunze94@gmail.com>
This commit is contained in:
parent
1321bc1614
commit
7115d3b2c8
|
@ -41,6 +41,7 @@ Ref: https://keepachangelog.com/en/1.0.0/
|
|||
|
||||
### State Machine Breaking
|
||||
|
||||
* (auth) [\#10536](https://github.com/cosmos/cosmos-sdk/pull/10536]) Enable `SetSequence` for `ModuleAccount`.
|
||||
* (store) [#10218](https://github.com/cosmos/cosmos-sdk/pull/10218) Charge gas even when there are no entries while seeking.
|
||||
* (store) [#10247](https://github.com/cosmos/cosmos-sdk/pull/10247) Charge gas for the key length in gas meter.
|
||||
|
||||
|
|
|
@ -218,11 +218,6 @@ func (ma ModuleAccount) SetPubKey(pubKey cryptotypes.PubKey) error {
|
|||
return fmt.Errorf("not supported for module accounts")
|
||||
}
|
||||
|
||||
// SetSequence - Implements AccountI
|
||||
func (ma ModuleAccount) SetSequence(seq uint64) error {
|
||||
return fmt.Errorf("not supported for module accounts")
|
||||
}
|
||||
|
||||
// Validate checks for errors on the account fields
|
||||
func (ma ModuleAccount) Validate() error {
|
||||
if strings.TrimSpace(ma.Name) == "" {
|
||||
|
@ -265,7 +260,6 @@ func (ma ModuleAccount) MarshalYAML() (interface{}, error) {
|
|||
Name: ma.Name,
|
||||
Permissions: ma.Permissions,
|
||||
})
|
||||
|
||||
if err != nil {
|
||||
return nil, err
|
||||
}
|
||||
|
|
Loading…
Reference in New Issue