From 9e4ee7bf18c6dc352049d6fde5028089cdc7045f Mon Sep 17 00:00:00 2001 From: Marko Date: Tue, 5 May 2020 21:43:01 +0200 Subject: [PATCH] add comment bot for PR checklist (#6149) * add comment bot and remove checklist from pr template * give the bot some speech * Update .github/PULL_REQUEST_TEMPLATE.md Co-authored-by: Alexander Bezobchuk --- .github/PULL_REQUEST_TEMPLATE.md | 22 +--------------------- .github/auto-comment.yml | 30 ++++++++++++++++++++++++++++++ 2 files changed, 31 insertions(+), 21 deletions(-) create mode 100644 .github/auto-comment.yml diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index 6dd37f7f2..302ee203e 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -4,31 +4,11 @@ v Before smashing the submit button please review the checkboxes. v If a checkbox is n/a - please still include it but + a little note why ☺ > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > --> -Closes: #XXX - ## Description -______ -For contributor use: - -- [ ] Targeted PR against correct branch (see [CONTRIBUTING.md](https://github.com/cosmos/cosmos-sdk/blob/master/CONTRIBUTING.md#pr-targeting)) -- [ ] Linked to Github issue with discussion and accepted design OR link to spec that describes this work. -- [ ] Code follows the [module structure standards](https://github.com/cosmos/cosmos-sdk/blob/master/docs/building-modules/structure.md). -- [ ] Wrote unit and integration [tests](https://github.com/cosmos/cosmos-sdk/blob/master/CONTRIBUTING.md#testing) -- [ ] Updated relevant documentation (`docs/`) or specification (`x//spec/`) -- [ ] Added relevant `godoc` [comments](https://blog.golang.org/godoc-documenting-go-code). -- [ ] Added a relevant changelog entry to the `Unreleased` section in `CHANGELOG.md` -- [ ] Re-reviewed `Files changed` in the Github PR explorer - -______ - -For admin use: - -- [ ] Added appropriate labels to PR (ex. `WIP`, `R4R`, `docs`, etc) -- [ ] Reviewers assigned -- [ ] Squashed all commits, uses message "Merge pull request #XYZ: [title]" ([coding standards](https://github.com/tendermint/coding/blob/master/README.md#merging-a-pr)) +closes: #XXXX diff --git a/.github/auto-comment.yml b/.github/auto-comment.yml new file mode 100644 index 000000000..260bb755a --- /dev/null +++ b/.github/auto-comment.yml @@ -0,0 +1,30 @@ +pullRequestOpened: | + :wave: Thanks for creating a PR! + + Before we can merge this PR, please make sure that all the following items have been + checked off. If any of the checklist items are not applicable, please leave them but + write a little note why. + + ______ + + For contributor use: + + - [ ] Targeted PR against correct branch (see [CONTRIBUTING.md](https://github.com/cosmos/cosmos-sdk/blob/master/CONTRIBUTING.md#pr-targeting)) + - [ ] Linked to Github issue with discussion and accepted design OR link to spec that describes this work. + - [ ] Code follows the [module structure standards](https://github.com/cosmos/cosmos-sdk/blob/master/docs/building-modules/structure.md). + - [ ] Wrote unit and integration [tests](https://github.com/cosmos/cosmos-sdk/blob/master/CONTRIBUTING.md#testing) + - [ ] Updated relevant documentation (`docs/`) or specification (`x//spec/`) + - [ ] Added relevant `godoc` [comments](https://blog.golang.org/godoc-documenting-go-code). + - [ ] Added a relevant changelog entry to the `Unreleased` section in `CHANGELOG.md` + - [ ] Re-reviewed `Files changed` in the Github PR explorer + + ______ + + For admin use: + + - [ ] Added appropriate labels to PR (ex. `WIP`, `R4R`, `docs`, etc) + - [ ] Reviewers assigned + - [ ] Squashed all commits, uses message "Merge pull request #XYZ: [title]" ([coding standards](https://github.com/tendermint/coding/blob/master/README.md#merging-a-pr)) + + + Thank you for your contribution to the Cosmos-SDK! :rocket: