Add pagination flags to x{ibc, bank} (#6804)
* updated pagination flags * updated all balances pagination flags * updated all balances * some doc updates Co-authored-by: Anil Kumar Kammari <anil@vitwit.com> Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
This commit is contained in:
parent
61d69a978f
commit
9ee14ee985
|
@ -10,7 +10,6 @@ import (
|
||||||
"github.com/cosmos/cosmos-sdk/client"
|
"github.com/cosmos/cosmos-sdk/client"
|
||||||
"github.com/cosmos/cosmos-sdk/client/flags"
|
"github.com/cosmos/cosmos-sdk/client/flags"
|
||||||
sdk "github.com/cosmos/cosmos-sdk/types"
|
sdk "github.com/cosmos/cosmos-sdk/types"
|
||||||
"github.com/cosmos/cosmos-sdk/types/query"
|
|
||||||
"github.com/cosmos/cosmos-sdk/version"
|
"github.com/cosmos/cosmos-sdk/version"
|
||||||
"github.com/cosmos/cosmos-sdk/x/bank/types"
|
"github.com/cosmos/cosmos-sdk/x/bank/types"
|
||||||
)
|
)
|
||||||
|
@ -73,7 +72,7 @@ Example:
|
||||||
return err
|
return err
|
||||||
}
|
}
|
||||||
|
|
||||||
pageReq := &query.PageRequest{}
|
pageReq := client.ReadPageRequest(cmd.Flags())
|
||||||
if denom == "" {
|
if denom == "" {
|
||||||
params := types.NewQueryAllBalancesRequest(addr, pageReq)
|
params := types.NewQueryAllBalancesRequest(addr, pageReq)
|
||||||
|
|
||||||
|
@ -96,6 +95,7 @@ Example:
|
||||||
|
|
||||||
cmd.Flags().String(FlagDenom, "", "The specific balance denomination to query for")
|
cmd.Flags().String(FlagDenom, "", "The specific balance denomination to query for")
|
||||||
flags.AddQueryFlagsToCmd(cmd)
|
flags.AddQueryFlagsToCmd(cmd)
|
||||||
|
flags.AddPaginationFlagsToCmd(cmd, "all balances")
|
||||||
|
|
||||||
return cmd
|
return cmd
|
||||||
}
|
}
|
||||||
|
|
|
@ -315,7 +315,7 @@ $ %[1]s query gov votes 1 --page=2 --limit=100
|
||||||
}
|
}
|
||||||
|
|
||||||
// Deprecated, remove line when removing FlagPage altogether.
|
// Deprecated, remove line when removing FlagPage altogether.
|
||||||
cmd.Flags().Int(flags.FlagPage, 1, "pagination page of proposals to to query for")
|
cmd.Flags().Int(flags.FlagPage, 1, "pagination page of proposals to query for")
|
||||||
|
|
||||||
flags.AddPaginationFlagsToCmd(cmd, "votes")
|
flags.AddPaginationFlagsToCmd(cmd, "votes")
|
||||||
flags.AddQueryFlagsToCmd(cmd)
|
flags.AddQueryFlagsToCmd(cmd)
|
||||||
|
|
|
@ -45,7 +45,7 @@ func GetCmdQueryClientStates() *cobra.Command {
|
||||||
},
|
},
|
||||||
}
|
}
|
||||||
|
|
||||||
cmd.Flags().Int(flags.FlagPage, 1, "pagination page of light clients to to query for")
|
cmd.Flags().Int(flags.FlagPage, 1, "pagination page of light clients to query for")
|
||||||
cmd.Flags().Int(flags.FlagLimit, 100, "pagination limit of light clients to query for")
|
cmd.Flags().Int(flags.FlagLimit, 100, "pagination limit of light clients to query for")
|
||||||
flags.AddQueryFlagsToCmd(cmd)
|
flags.AddQueryFlagsToCmd(cmd)
|
||||||
|
|
||||||
|
|
|
@ -8,7 +8,6 @@ import (
|
||||||
|
|
||||||
"github.com/cosmos/cosmos-sdk/client"
|
"github.com/cosmos/cosmos-sdk/client"
|
||||||
"github.com/cosmos/cosmos-sdk/client/flags"
|
"github.com/cosmos/cosmos-sdk/client/flags"
|
||||||
"github.com/cosmos/cosmos-sdk/types/query"
|
|
||||||
"github.com/cosmos/cosmos-sdk/version"
|
"github.com/cosmos/cosmos-sdk/version"
|
||||||
"github.com/cosmos/cosmos-sdk/x/ibc/03-connection/client/utils"
|
"github.com/cosmos/cosmos-sdk/x/ibc/03-connection/client/utils"
|
||||||
"github.com/cosmos/cosmos-sdk/x/ibc/03-connection/types"
|
"github.com/cosmos/cosmos-sdk/x/ibc/03-connection/types"
|
||||||
|
@ -33,14 +32,8 @@ func GetCmdQueryConnections() *cobra.Command {
|
||||||
|
|
||||||
queryClient := types.NewQueryClient(clientCtx)
|
queryClient := types.NewQueryClient(clientCtx)
|
||||||
|
|
||||||
offset, _ := cmd.Flags().GetInt(flags.FlagPage)
|
|
||||||
limit, _ := cmd.Flags().GetInt(flags.FlagLimit)
|
|
||||||
|
|
||||||
req := &types.QueryConnectionsRequest{
|
req := &types.QueryConnectionsRequest{
|
||||||
Pagination: &query.PageRequest{
|
Pagination: client.ReadPageRequest(cmd.Flags()),
|
||||||
Offset: uint64(offset),
|
|
||||||
Limit: uint64(limit),
|
|
||||||
},
|
|
||||||
}
|
}
|
||||||
|
|
||||||
res, err := queryClient.Connections(context.Background(), req)
|
res, err := queryClient.Connections(context.Background(), req)
|
||||||
|
@ -52,9 +45,8 @@ func GetCmdQueryConnections() *cobra.Command {
|
||||||
},
|
},
|
||||||
}
|
}
|
||||||
|
|
||||||
cmd.Flags().Int(flags.FlagPage, 1, "pagination page of light clients to to query for")
|
|
||||||
cmd.Flags().Int(flags.FlagLimit, 100, "pagination limit of light clients to query for")
|
|
||||||
flags.AddQueryFlagsToCmd(cmd)
|
flags.AddQueryFlagsToCmd(cmd)
|
||||||
|
flags.AddPaginationFlagsToCmd(cmd, "connection ends")
|
||||||
|
|
||||||
return cmd
|
return cmd
|
||||||
}
|
}
|
||||||
|
|
|
@ -9,7 +9,6 @@ import (
|
||||||
|
|
||||||
"github.com/cosmos/cosmos-sdk/client"
|
"github.com/cosmos/cosmos-sdk/client"
|
||||||
"github.com/cosmos/cosmos-sdk/client/flags"
|
"github.com/cosmos/cosmos-sdk/client/flags"
|
||||||
"github.com/cosmos/cosmos-sdk/types/query"
|
|
||||||
"github.com/cosmos/cosmos-sdk/version"
|
"github.com/cosmos/cosmos-sdk/version"
|
||||||
"github.com/cosmos/cosmos-sdk/x/ibc/04-channel/client/utils"
|
"github.com/cosmos/cosmos-sdk/x/ibc/04-channel/client/utils"
|
||||||
"github.com/cosmos/cosmos-sdk/x/ibc/04-channel/types"
|
"github.com/cosmos/cosmos-sdk/x/ibc/04-channel/types"
|
||||||
|
@ -38,14 +37,8 @@ func GetCmdQueryChannels() *cobra.Command {
|
||||||
}
|
}
|
||||||
queryClient := types.NewQueryClient(clientCtx)
|
queryClient := types.NewQueryClient(clientCtx)
|
||||||
|
|
||||||
offset, _ := cmd.Flags().GetInt(flags.FlagPage)
|
|
||||||
limit, _ := cmd.Flags().GetInt(flags.FlagLimit)
|
|
||||||
|
|
||||||
req := &types.QueryChannelsRequest{
|
req := &types.QueryChannelsRequest{
|
||||||
Pagination: &query.PageRequest{
|
Pagination: client.ReadPageRequest(cmd.Flags()),
|
||||||
Offset: uint64(offset),
|
|
||||||
Limit: uint64(limit),
|
|
||||||
},
|
|
||||||
}
|
}
|
||||||
|
|
||||||
res, err := queryClient.Channels(context.Background(), req)
|
res, err := queryClient.Channels(context.Background(), req)
|
||||||
|
@ -58,9 +51,8 @@ func GetCmdQueryChannels() *cobra.Command {
|
||||||
},
|
},
|
||||||
}
|
}
|
||||||
|
|
||||||
cmd.Flags().Int(flags.FlagPage, 1, "pagination page of light clients to to query for")
|
|
||||||
cmd.Flags().Int(flags.FlagLimit, 100, "pagination limit of light clients to query for")
|
|
||||||
flags.AddQueryFlagsToCmd(cmd)
|
flags.AddQueryFlagsToCmd(cmd)
|
||||||
|
flags.AddPaginationFlagsToCmd(cmd, "channels")
|
||||||
|
|
||||||
return cmd
|
return cmd
|
||||||
}
|
}
|
||||||
|
@ -119,15 +111,9 @@ func GetCmdQueryConnectionChannels() *cobra.Command {
|
||||||
}
|
}
|
||||||
queryClient := types.NewQueryClient(clientCtx)
|
queryClient := types.NewQueryClient(clientCtx)
|
||||||
|
|
||||||
offset, _ := cmd.Flags().GetInt(flags.FlagPage)
|
|
||||||
limit, _ := cmd.Flags().GetInt(flags.FlagLimit)
|
|
||||||
|
|
||||||
req := &types.QueryConnectionChannelsRequest{
|
req := &types.QueryConnectionChannelsRequest{
|
||||||
Connection: args[0],
|
Connection: args[0],
|
||||||
Pagination: &query.PageRequest{
|
Pagination: client.ReadPageRequest(cmd.Flags()),
|
||||||
Offset: uint64(offset),
|
|
||||||
Limit: uint64(limit),
|
|
||||||
},
|
|
||||||
}
|
}
|
||||||
|
|
||||||
res, err := queryClient.ConnectionChannels(context.Background(), req)
|
res, err := queryClient.ConnectionChannels(context.Background(), req)
|
||||||
|
@ -140,9 +126,8 @@ func GetCmdQueryConnectionChannels() *cobra.Command {
|
||||||
},
|
},
|
||||||
}
|
}
|
||||||
|
|
||||||
cmd.Flags().Int(flags.FlagPage, 1, "pagination page of light clients to to query for")
|
|
||||||
cmd.Flags().Int(flags.FlagLimit, 100, "pagination limit of light clients to query for")
|
|
||||||
flags.AddQueryFlagsToCmd(cmd)
|
flags.AddQueryFlagsToCmd(cmd)
|
||||||
|
flags.AddPaginationFlagsToCmd(cmd, "channels associated with a connection")
|
||||||
|
|
||||||
return cmd
|
return cmd
|
||||||
}
|
}
|
||||||
|
@ -197,16 +182,10 @@ func GetCmdQueryPacketCommitments() *cobra.Command {
|
||||||
}
|
}
|
||||||
queryClient := types.NewQueryClient(clientCtx)
|
queryClient := types.NewQueryClient(clientCtx)
|
||||||
|
|
||||||
offset, _ := cmd.Flags().GetInt(flags.FlagPage)
|
|
||||||
limit, _ := cmd.Flags().GetInt(flags.FlagLimit)
|
|
||||||
|
|
||||||
req := &types.QueryPacketCommitmentsRequest{
|
req := &types.QueryPacketCommitmentsRequest{
|
||||||
PortID: args[0],
|
PortID: args[0],
|
||||||
ChannelID: args[1],
|
ChannelID: args[1],
|
||||||
Pagination: &query.PageRequest{
|
Pagination: client.ReadPageRequest(cmd.Flags()),
|
||||||
Offset: uint64(offset),
|
|
||||||
Limit: uint64(limit),
|
|
||||||
},
|
|
||||||
}
|
}
|
||||||
|
|
||||||
res, err := queryClient.PacketCommitments(context.Background(), req)
|
res, err := queryClient.PacketCommitments(context.Background(), req)
|
||||||
|
@ -219,9 +198,8 @@ func GetCmdQueryPacketCommitments() *cobra.Command {
|
||||||
},
|
},
|
||||||
}
|
}
|
||||||
|
|
||||||
cmd.Flags().Int(flags.FlagPage, 1, "pagination page of light clients to to query for")
|
|
||||||
cmd.Flags().Int(flags.FlagLimit, 100, "pagination limit of light clients to query for")
|
|
||||||
flags.AddQueryFlagsToCmd(cmd)
|
flags.AddQueryFlagsToCmd(cmd)
|
||||||
|
flags.AddPaginationFlagsToCmd(cmd, "packet commitments associated with a channel")
|
||||||
|
|
||||||
return cmd
|
return cmd
|
||||||
}
|
}
|
||||||
|
|
Loading…
Reference in New Issue