From a07ed83dd250aeb1fb319d356bc4767744088173 Mon Sep 17 00:00:00 2001 From: Jonathan Gimeno Date: Wed, 26 Feb 2020 15:08:43 +0100 Subject: [PATCH] refactor TestEditValidatorIncreaseMinSelfDelegationBeyondCurrentBond --- x/staking/handler_test.go | 69 ++++++++++++++++++++------------------- 1 file changed, 35 insertions(+), 34 deletions(-) diff --git a/x/staking/handler_test.go b/x/staking/handler_test.go index c98b54d11..9a8d21dee 100644 --- a/x/staking/handler_test.go +++ b/x/staking/handler_test.go @@ -421,40 +421,41 @@ func TestEditValidatorDecreaseMinSelfDelegation(t *testing.T) { require.Nil(t, res) } -//func TestEditValidatorIncreaseMinSelfDelegationBeyondCurrentBond(t *testing.T) { -// validatorAddr := sdk.ValAddress(Addrs[0]) -// -// initPower := int64(100) -// initBond := sdk.TokensFromConsensusPower(100) -// ctx, _, _, keeper, _ := CreateTestInput(t, false, initPower) -// handler := NewHandler(keeper) -// -// // create validator -// msgCreateValidator := NewTestMsgCreateValidator(validatorAddr, PKs[0], initBond) -// msgCreateValidator.MinSelfDelegation = sdk.NewInt(2) -// res, err := handler(ctx, msgCreateValidator) -// require.NoError(t, err) -// require.NotNil(t, res) -// -// // must end-block -// updates := keeper.ApplyAndReturnValidatorSetUpdates(ctx) -// require.Equal(t, 1, len(updates)) -// -// // verify the self-delegation exists -// bond, found := keeper.GetDelegation(ctx, sdk.AccAddress(validatorAddr), validatorAddr) -// require.True(t, found) -// gotBond := bond.Shares.RoundInt() -// require.Equal(t, initBond, gotBond, -// "initBond: %v\ngotBond: %v\nbond: %v\n", -// initBond, gotBond, bond) -// -// newMinSelfDelegation := initBond.Add(sdk.OneInt()) -// msgEditValidator := NewMsgEditValidator(validatorAddr, Description{}, nil, &newMinSelfDelegation) -// res, err = handler(ctx, msgEditValidator) -// require.Error(t, err) -// require.Nil(t, res) -//} -// +func TestEditValidatorIncreaseMinSelfDelegationBeyondCurrentBond(t *testing.T) { + initPower := int64(100) + initBond := sdk.TokensFromConsensusPower(100) + + app, ctx, _, valAddrs := bootstrapHandlerGenesisTest(t, initPower, 2, 1000000000) + validatorAddr := valAddrs[0] + + handler := staking.NewHandler(app.StakingKeeper) + + // create validator + msgCreateValidator := NewTestMsgCreateValidator(validatorAddr, PKs[0], initBond) + msgCreateValidator.MinSelfDelegation = sdk.NewInt(2) + res, err := handler(ctx, msgCreateValidator) + require.NoError(t, err) + require.NotNil(t, res) + + // must end-block + updates := app.StakingKeeper.ApplyAndReturnValidatorSetUpdates(ctx) + require.Equal(t, 1, len(updates)) + + // verify the self-delegation exists + bond, found := app.StakingKeeper.GetDelegation(ctx, sdk.AccAddress(validatorAddr), validatorAddr) + require.True(t, found) + gotBond := bond.Shares.RoundInt() + require.Equal(t, initBond, gotBond, + "initBond: %v\ngotBond: %v\nbond: %v\n", + initBond, gotBond, bond) + + newMinSelfDelegation := initBond.Add(sdk.OneInt()) + msgEditValidator := types.NewMsgEditValidator(validatorAddr, types.Description{}, nil, &newMinSelfDelegation) + res, err = handler(ctx, msgEditValidator) + require.Error(t, err) + require.Nil(t, res) +} + //func TestIncrementsMsgUnbond(t *testing.T) { // initPower := int64(1000) // initBond := sdk.TokensFromConsensusPower(initPower)