types: use (*math/big.Int).BitLen() == 0 to check if value is 0 (#8580)
Instead of using len((*math/big.Int).Bytes()) == 0, which expensively creates a byte slice and marshals a value, on the majority hot path, instead use the cheaper method .BitLen() to check if 0. Benchmarking results, just from types: name old time/op new time/op delta CoinsAdditionIntersect/sizes:_A_1,_B_1-8 132ns ± 2% 126ns ±13% -4.55% (p=0.050 n=10+10) CoinsAdditionIntersect/sizes:_A_5,_B_5-8 1.41µs ± 3% 1.41µs ± 2% ~ (p=1.000 n=10+10) CoinsAdditionIntersect/sizes:_A_5,_B_20-8 2.30µs ± 1% 2.27µs ± 3% ~ (p=0.066 n=10+10) CoinsAdditionIntersect/sizes:_A_1,_B_1000-8 30.9µs ± 3% 30.7µs ± 1% ~ (p=0.218 n=10+10) CoinsAdditionIntersect/sizes:_A_2,_B_1000-8 31.4µs ± 3% 30.8µs ± 2% -1.94% (p=0.015 n=10+10) CoinsAdditionNoIntersect/sizes:_A_1,_B_1-8 116ns ± 1% 114ns ± 4% ~ (p=0.142 n=10+10) CoinsAdditionNoIntersect/sizes:_A_5,_B_5-8 1.11µs ± 1% 1.08µs ± 3% -2.36% (p=0.003 n=8+10) CoinsAdditionNoIntersect/sizes:_A_5,_B_20-8 1.85µs ± 2% 1.82µs ± 1% -1.38% (p=0.001 n=10+9) CoinsAdditionNoIntersect/sizes:_A_1,_B_1000-8 30.7µs ± 1% 30.6µs ± 3% ~ (p=0.393 n=10+10) CoinsAdditionNoIntersect/sizes:_A_2,_B_1000-8 31.1µs ± 1% 30.7µs ± 2% -1.32% (p=0.015 n=10+10) CoinsAdditionNoIntersect/sizes:_A_1000,_B_2-8 31.0µs ± 2% 30.7µs ± 2% ~ (p=0.190 n=10+10) Bech32ifyPubKey-8 28.8µs ± 5% 28.8µs ± 3% ~ (p=0.965 n=10+8) GetPubKeyFromBech32-8 38.8µs ± 3% 39.4µs ± 2% +1.70% (p=0.013 n=9+10) ParseCoin-8 16.7µs ± 6% 15.8µs ± 4% -5.21% (p=0.001 n=10+10) MarshalTo-8 521ns ± 5% 508ns ± 3% -2.56% (p=0.029 n=10+10) UintMarshal-8 3.10µs ±17% 2.56µs ± 3% -17.45% (p=0.000 n=10+9) IntMarshal-8 2.52µs ±10% 1.94µs ± 2% -23.10% (p=0.000 n=10+10) name old alloc/op new alloc/op delta Bech32ifyPubKey-8 4.02kB ± 0% 4.02kB ± 0% ~ (all equal) GetPubKeyFromBech32-8 2.48kB ± 0% 2.48kB ± 0% ~ (all equal) ParseCoin-8 2.21kB ± 0% 2.21kB ± 0% ~ (all equal) MarshalTo-8 80.0B ± 0% 80.0B ± 0% ~ (all equal) UintMarshal-8 440B ± 0% 392B ± 0% -10.91% (p=0.000 n=10+10) IntMarshal-8 216B ± 0% 168B ± 0% -22.22% (p=0.000 n=10+10) name old allocs/op new allocs/op delta Bech32ifyPubKey-8 25.0 ± 0% 25.0 ± 0% ~ (all equal) GetPubKeyFromBech32-8 85.0 ± 0% 85.0 ± 0% ~ (all equal) ParseCoin-8 71.0 ± 0% 71.0 ± 0% ~ (all equal) MarshalTo-8 2.00 ± 0% 2.00 ± 0% ~ (all equal) UintMarshal-8 31.0 ± 0% 25.0 ± 0% -19.35% (p=0.000 n=10+10) IntMarshal-8 24.0 ± 0% 18.0 ± 0% -25.00% (p=0.000 n=10+10) name old speed new speed delta UintMarshal-8 2.27MB/s ±15% 2.75MB/s ± 2% +20.87% (p=0.000 n=10+8) IntMarshal-8 2.78MB/s ± 9% 3.60MB/s ± 2% +29.69% (p=0.000 n=10+10) Fixes #8575 Co-authored-by: Alessio Treglia <alessio@tendermint.com> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
This commit is contained in:
Emmanuel T Odeke
GitHub
parent
d162b29cf4
commit
a534a960db
|
|
@ -28,3 +28,53 @@ func BenchmarkParseCoin(b *testing.B) {
|
|||
}
|
||||
}
|
||||
}
|
||||
|
||||
func BenchmarkUintMarshal(b *testing.B) {
|
||||
var values = []uint64{
|
||||
0,
|
||||
1,
|
||||
1 << 10,
|
||||
1<<10 - 3,
|
||||
1<<63 - 1,
|
||||
1<<32 - 7,
|
||||
1<<22 - 8,
|
||||
}
|
||||
|
||||
var scratch [20]byte
|
||||
b.ReportAllocs()
|
||||
for i := 0; i < b.N; i++ {
|
||||
for _, value := range values {
|
||||
u := types.NewUint(value)
|
||||
n, err := u.MarshalTo(scratch[:])
|
||||
if err != nil {
|
||||
b.Fatal(err)
|
||||
}
|
||||
b.SetBytes(int64(n))
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
func BenchmarkIntMarshal(b *testing.B) {
|
||||
var values = []int64{
|
||||
0,
|
||||
1,
|
||||
1 << 10,
|
||||
1<<10 - 3,
|
||||
1<<63 - 1,
|
||||
1<<32 - 7,
|
||||
1<<22 - 8,
|
||||
}
|
||||
|
||||
var scratch [20]byte
|
||||
b.ReportAllocs()
|
||||
for i := 0; i < b.N; i++ {
|
||||
for _, value := range values {
|
||||
in := types.NewInt(value)
|
||||
n, err := in.MarshalTo(scratch[:])
|
||||
if err != nil {
|
||||
b.Fatal(err)
|
||||
}
|
||||
b.SetBytes(int64(n))
|
||||
}
|
||||
}
|
||||
}
|
||||
|
|
|
|||
|
|
@ -375,7 +375,7 @@ func (i *Int) MarshalTo(data []byte) (n int, err error) {
|
|||
if i.i == nil {
|
||||
i.i = new(big.Int)
|
||||
}
|
||||
if len(i.i.Bytes()) == 0 {
|
||||
if i.i.BitLen() == 0 { // The value 0
|
||||
copy(data, []byte{0x30})
|
||||
return 1, nil
|
||||
}
|
||||
|
|
|
|||
|
|
@ -1,6 +1,7 @@
|
|||
package types_test
|
||||
|
||||
import (
|
||||
"fmt"
|
||||
"math/big"
|
||||
"math/rand"
|
||||
"strconv"
|
||||
|
|
@ -385,3 +386,36 @@ func (s *intTestSuite) TestIntEq() {
|
|||
_, resp, _, _, _ = sdk.IntEq(s.T(), sdk.OneInt(), sdk.ZeroInt())
|
||||
s.Require().False(resp)
|
||||
}
|
||||
|
||||
func TestRoundTripMarshalToInt(t *testing.T) {
|
||||
var values = []int64{
|
||||
0,
|
||||
1,
|
||||
1 << 10,
|
||||
1<<10 - 3,
|
||||
1<<63 - 1,
|
||||
1<<32 - 7,
|
||||
1<<22 - 8,
|
||||
}
|
||||
|
||||
for _, value := range values {
|
||||
value := value
|
||||
t.Run(fmt.Sprintf("%d", value), func(t *testing.T) {
|
||||
t.Parallel()
|
||||
|
||||
var scratch [20]byte
|
||||
iv := sdk.NewInt(value)
|
||||
n, err := iv.MarshalTo(scratch[:])
|
||||
if err != nil {
|
||||
t.Fatal(err)
|
||||
}
|
||||
rt := new(sdk.Int)
|
||||
if err := rt.Unmarshal(scratch[:n]); err != nil {
|
||||
t.Fatal(err)
|
||||
}
|
||||
if !rt.Equal(iv) {
|
||||
t.Fatalf("roundtrip=%q != original=%q", rt, iv)
|
||||
}
|
||||
})
|
||||
}
|
||||
}
|
||||
|
|
|
|||
|
|
@ -161,7 +161,7 @@ func (u *Uint) MarshalTo(data []byte) (n int, err error) {
|
|||
if u.i == nil {
|
||||
u.i = new(big.Int)
|
||||
}
|
||||
if len(u.i.Bytes()) == 0 {
|
||||
if u.i.BitLen() == 0 { // The value 0
|
||||
copy(data, []byte{0x30})
|
||||
return 1, nil
|
||||
}
|
||||
|
|
|
|||
|
|
@ -1,6 +1,7 @@
|
|||
package types_test
|
||||
|
||||
import (
|
||||
"fmt"
|
||||
"math"
|
||||
"math/big"
|
||||
"math/rand"
|
||||
|
|
@ -290,3 +291,36 @@ func maxuint(i1, i2 uint64) uint64 {
|
|||
}
|
||||
return i2
|
||||
}
|
||||
|
||||
func TestRoundTripMarshalToUint(t *testing.T) {
|
||||
var values = []uint64{
|
||||
0,
|
||||
1,
|
||||
1 << 10,
|
||||
1<<10 - 3,
|
||||
1<<63 - 1,
|
||||
1<<32 - 7,
|
||||
1<<22 - 8,
|
||||
}
|
||||
|
||||
for _, value := range values {
|
||||
value := value
|
||||
t.Run(fmt.Sprintf("%d", value), func(t *testing.T) {
|
||||
t.Parallel()
|
||||
|
||||
var scratch [20]byte
|
||||
uv := sdk.NewUint(value)
|
||||
n, err := uv.MarshalTo(scratch[:])
|
||||
if err != nil {
|
||||
t.Fatal(err)
|
||||
}
|
||||
rt := new(sdk.Uint)
|
||||
if err := rt.Unmarshal(scratch[:n]); err != nil {
|
||||
t.Fatal(err)
|
||||
}
|
||||
if !rt.Equal(uv) {
|
||||
t.Fatalf("roundtrip=%q != original=%q", rt, uv)
|
||||
}
|
||||
})
|
||||
}
|
||||
}
|
||||
|
|
|
|||
Loading…
Reference in New Issue