From abafd8bf9dbb7f92a428c7829e8635950c545a20 Mon Sep 17 00:00:00 2001
From: Christopher Goes <cwgoes@pluranimity.org>
Date: Wed, 13 Feb 2019 15:26:43 +0100
Subject: [PATCH] Add Bcrypt benchmarks

---
 PENDING.md                                |  2 ++
 crypto/keys/mintkey/README.md             | 24 +++++++++++++++++++++
 crypto/keys/mintkey/mintkey_bench_test.go | 26 +++++++++++++++++++++++
 3 files changed, 52 insertions(+)
 create mode 100644 crypto/keys/mintkey/README.md
 create mode 100644 crypto/keys/mintkey/mintkey_bench_test.go

diff --git a/PENDING.md b/PENDING.md
index a41bbe0ca..3a1e1a1ae 100644
--- a/PENDING.md
+++ b/PENDING.md
@@ -35,6 +35,8 @@ IMPROVEMENTS
 
 * SDK
 
+  * \# Add Bcrypt benchmarks & justification of security parameter choice
+
 * Tendermint
   * [\#3618] Upgrade to Tendermint 0.30.03
 
diff --git a/crypto/keys/mintkey/README.md b/crypto/keys/mintkey/README.md
new file mode 100644
index 000000000..38da0fbe7
--- /dev/null
+++ b/crypto/keys/mintkey/README.md
@@ -0,0 +1,24 @@
+To run Bcrypt benchmarks:
+
+```bash
+go test -bench .
+```
+
+On the test machine (midrange ThinkPad; i7 6600U), this results in:
+
+```bash
+goos: linux
+goarch: amd64
+pkg: github.com/cosmos/cosmos-sdk/crypto/keys/mintkey
+BenchmarkBcryptGenerateFromPassword/benchmark-security-param-9-4         	      50	  34609268 ns/op
+BenchmarkBcryptGenerateFromPassword/benchmark-security-param-10-4        	      20	  67874471 ns/op
+BenchmarkBcryptGenerateFromPassword/benchmark-security-param-11-4        	      10	 135515404 ns/op
+BenchmarkBcryptGenerateFromPassword/benchmark-security-param-12-4        	       5	 274824600 ns/op
+BenchmarkBcryptGenerateFromPassword/benchmark-security-param-13-4        	       2	 547012903 ns/op
+BenchmarkBcryptGenerateFromPassword/benchmark-security-param-14-4        	       1	1083685904 ns/op
+BenchmarkBcryptGenerateFromPassword/benchmark-security-param-15-4        	       1	2183674041 ns/op
+PASS
+ok  	github.com/cosmos/cosmos-sdk/crypto/keys/mintkey	12.093s
+```
+
+Benchmark results are in nanoseconds, so security parameter 12 takes about a quarter of a second to generate the Bcrypt key, security param 13 takes half a second, and so on.
diff --git a/crypto/keys/mintkey/mintkey_bench_test.go b/crypto/keys/mintkey/mintkey_bench_test.go
new file mode 100644
index 000000000..fbc3e58dd
--- /dev/null
+++ b/crypto/keys/mintkey/mintkey_bench_test.go
@@ -0,0 +1,26 @@
+package mintkey
+
+import (
+	"fmt"
+	"testing"
+
+	"github.com/stretchr/testify/require"
+	"golang.org/x/crypto/bcrypt"
+
+	"github.com/tendermint/tendermint/crypto"
+)
+
+func BenchmarkBcryptGenerateFromPassword(b *testing.B) {
+	passphrase := []byte("passphrase")
+	for securityParam := 9; securityParam < 16; securityParam++ {
+		param := securityParam
+		b.Run(fmt.Sprintf("benchmark-security-param-%d", param), func(b *testing.B) {
+			saltBytes := crypto.CRandBytes(16)
+			b.ResetTimer()
+			for i := 0; i < b.N; i++ {
+				_, err := bcrypt.GenerateFromPassword(saltBytes, passphrase, param)
+				require.Nil(b, err)
+			}
+		})
+	}
+}