certusone
/
cosmos-sdk
mirror of https://github.com/certusone/cosmos-sdk.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

Merge PR #2886: Don't get command through client.{Get,Post}Commands() 

* Don't get command through client.{Get,Post}Commands()

Logic has changed recently and commands are now enriched
with flags by default.

Closes: #2884
This commit is contained in:
Christopher Goes 2018-11-26 12:46:22 +01:00 committed by GitHub
parent b7da2eaa33 c22b400ba8
commit c21961b21d
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 31 additions and 33 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
PENDING.md
View File

@ -94,6 +94,7 @@ BUG FIXES
- \#2733 [x/gov, x/mock/simulation] Fix governance simulation, update x/gov import/export - \#2733 [x/gov, x/mock/simulation] Fix governance simulation, update x/gov import/export
- \#2854 [x/bank] Remove unused bank.MsgIssue, prevent possible panic - \#2854 [x/bank] Remove unused bank.MsgIssue, prevent possible panic
- \#2884 [docs/examples] Fix `basecli version` panic
* Tendermint * Tendermint
* [\#2797](https://github.com/tendermint/tendermint/pull/2797) AddressBook requires addresses to have IDs; Do not crap out immediately after sending pex addrs in seed mode * [\#2797](https://github.com/tendermint/tendermint/pull/2797) AddressBook requires addresses to have IDs; Do not crap out immediately after sending pex addrs in seed mode

53
docs/examples/basecoin/cmd/basecli/main.go
View File

@ -72,35 +72,34 @@ func main() {
// add query/post commands (custom to binary) // add query/post commands (custom to binary)
rootCmd.AddCommand( rootCmd.AddCommand(
client.GetCommands( stakecmd.GetCmdQueryValidator(storeStake, cdc),
stakecmd.GetCmdQueryValidator(storeStake, cdc), stakecmd.GetCmdQueryValidators(storeStake, cdc),
stakecmd.GetCmdQueryValidators(storeStake, cdc), stakecmd.GetCmdQueryValidatorUnbondingDelegations(storeStake, cdc),
stakecmd.GetCmdQueryValidatorUnbondingDelegations(storeStake, cdc), stakecmd.GetCmdQueryValidatorRedelegations(storeStake, cdc),
stakecmd.GetCmdQueryValidatorRedelegations(storeStake, cdc), stakecmd.GetCmdQueryDelegation(storeStake, cdc),
stakecmd.GetCmdQueryDelegation(storeStake, cdc), stakecmd.GetCmdQueryDelegations(storeStake, cdc),
stakecmd.GetCmdQueryDelegations(storeStake, cdc), stakecmd.GetCmdQueryPool(storeStake, cdc),
stakecmd.GetCmdQueryPool(storeStake, cdc), stakecmd.GetCmdQueryParams(storeStake, cdc),
stakecmd.GetCmdQueryParams(storeStake, cdc), stakecmd.GetCmdQueryUnbondingDelegation(storeStake, cdc),
stakecmd.GetCmdQueryUnbondingDelegation(storeStake, cdc), stakecmd.GetCmdQueryUnbondingDelegations(storeStake, cdc),
stakecmd.GetCmdQueryUnbondingDelegations(storeStake, cdc), stakecmd.GetCmdQueryRedelegation(storeStake, cdc),
stakecmd.GetCmdQueryRedelegation(storeStake, cdc), stakecmd.GetCmdQueryRedelegations(storeStake, cdc),
stakecmd.GetCmdQueryRedelegations(storeStake, cdc), slashingcmd.GetCmdQuerySigningInfo(storeSlashing, cdc),
slashingcmd.GetCmdQuerySigningInfo(storeSlashing, cdc), stakecmd.GetCmdQueryValidatorDelegations(storeStake, cdc),
authcmd.GetAccountCmd(storeAcc, cdc), authcmd.GetAccountCmd(storeAcc, cdc),
)...) )
rootCmd.AddCommand( rootCmd.AddCommand(
client.PostCommands( bankcmd.SendTxCmd(cdc),
bankcmd.SendTxCmd(cdc), ibccmd.IBCTransferCmd(cdc),
ibccmd.IBCTransferCmd(cdc), ibccmd.IBCRelayCmd(cdc),
ibccmd.IBCRelayCmd(cdc), stakecmd.GetCmdCreateValidator(cdc),
stakecmd.GetCmdCreateValidator(cdc), stakecmd.GetCmdEditValidator(cdc),
stakecmd.GetCmdEditValidator(cdc), stakecmd.GetCmdDelegate(cdc),
stakecmd.GetCmdDelegate(cdc), stakecmd.GetCmdUnbond(storeStake, cdc),
stakecmd.GetCmdUnbond(storeStake, cdc), stakecmd.GetCmdRedelegate(storeStake, cdc),
stakecmd.GetCmdRedelegate(storeStake, cdc), slashingcmd.GetCmdUnjail(cdc),
slashingcmd.GetCmdUnjail(cdc), )
)...)
// add proxy, version and key info // add proxy, version and key info
rootCmd.AddCommand( rootCmd.AddCommand(

10
docs/examples/democoin/cmd/democli/main.go
View File

@ -70,13 +70,11 @@ func main() {
// add query/post commands (custom to binary) // add query/post commands (custom to binary)
// start with commands common to basecoin // start with commands common to basecoin
rootCmd.AddCommand( rootCmd.AddCommand(
client.GetCommands( authcmd.GetAccountCmd(storeAcc, cdc),
authcmd.GetAccountCmd(storeAcc, cdc), )
)...)
rootCmd.AddCommand( rootCmd.AddCommand(
client.PostCommands( bankcmd.SendTxCmd(cdc),
bankcmd.SendTxCmd(cdc), )
)...)
rootCmd.AddCommand( rootCmd.AddCommand(
client.PostCommands( client.PostCommands(
simplestakingcmd.BondTxCmd(cdc), simplestakingcmd.BondTxCmd(cdc),