* style: lint go and markdown (#10060)
## Description
+ fixing `x/bank/migrations/v44.migrateDenomMetadata` - we could potentially put a wrong data in a new key if the old keys have variable length.
+ linting the code
Putting in the same PR because i found the issue when running a linter.
Depends on: #10112
---
### Author Checklist
*All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.*
I have...
- [x] included the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title
- [x] added `!` to the type prefix if API or client breaking change
- [x] targeted the correct branch (see [PR Targeting](https://github.com/cosmos/cosmos-sdk/blob/master/CONTRIBUTING.md#pr-targeting))
- [ ] provided a link to the relevant issue or specification
- [x] followed the guidelines for [building modules](https://github.com/cosmos/cosmos-sdk/blob/master/docs/building-modules)
- [ ] included the necessary unit and integration [tests](https://github.com/cosmos/cosmos-sdk/blob/master/CONTRIBUTING.md#testing)
- [ ] added a changelog entry to `CHANGELOG.md`
- [ ] included comments for [documenting Go code](https://blog.golang.org/godoc)
- [ ] updated the relevant documentation or specification
- [ ] reviewed "Files changed" and left comments if necessary
- [ ] confirmed all CI checks have passed
### Reviewers Checklist
*All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.*
I have...
- [ ] confirmed the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title
- [ ] confirmed `!` in the type prefix if API or client breaking change
- [ ] confirmed all author checklist items have been addressed
- [ ] reviewed state machine logic
- [ ] reviewed API design and naming
- [ ] reviewed documentation is accurate
- [ ] reviewed tests and test coverage
- [ ] manually tested (if applicable)
(cherry picked from commit 479485f95d)
# Conflicts:
# CODING_GUIDELINES.md
# CONTRIBUTING.md
# STABLE_RELEASES.md
# contrib/rosetta/README.md
# cosmovisor/README.md
# crypto/keyring/keyring.go
# db/README.md
# docs/404.md
# docs/DOCS_README.md
# docs/architecture/adr-038-state-listening.md
# docs/architecture/adr-040-storage-and-smt-state-commitments.md
# docs/architecture/adr-043-nft-module.md
# docs/architecture/adr-044-protobuf-updates-guidelines.md
# docs/architecture/adr-046-module-params.md
# docs/migrations/pre-upgrade.md
# docs/migrations/rest.md
# docs/ru/README.md
# docs/run-node/rosetta.md
# docs/run-node/run-node.md
# docs/run-node/run-testnet.md
# go.mod
# scripts/module-tests.sh
# snapshots/README.md
# store/streaming/README.md
# store/streaming/file/README.md
# store/v2/flat/store.go
# store/v2/smt/store.go
# x/auth/ante/sigverify.go
# x/auth/middleware/basic.go
# x/auth/spec/01_concepts.md
# x/auth/spec/05_vesting.md
# x/auth/spec/07_client.md
# x/authz/spec/05_client.md
# x/bank/spec/README.md
# x/crisis/spec/05_client.md
# x/distribution/spec/README.md
# x/epoching/keeper/keeper.go
# x/epoching/spec/03_to_improve.md
# x/evidence/spec/07_client.md
# x/feegrant/spec/README.md
# x/gov/spec/01_concepts.md
# x/gov/spec/07_client.md
# x/group/internal/orm/spec/01_table.md
# x/mint/spec/06_client.md
# x/slashing/spec/09_client.md
# x/slashing/spec/README.md
# x/staking/spec/09_client.md
# x/upgrade/spec/04_client.md
* fix conflicts
* remove unnecessary files
Co-authored-by: Robert Zaremba <robert@zaremba.ch>
* Update tooling around docker
* Run commands
* Remove swagger gen for now
* Update proto-gen-any
* Fix indentn
* Use CURDIR
Co-authored-by: Alessio Treglia <alessio@tendermint.com>
* consolidate proto files into single directory, turn on PACKAGE_DIRECTORY_MATCH linting
* add third_party root for third party proto files
* move ibc proto files to top level folder, rename .proto files to types.proto as before
* update protocgen script, and run code generation
* move vesting proto definition to cosmos namespace, rename from types.proto in alignment with buf.build naming conventions
* update Makefile so proto dependencies are set with new structure when updated
* add comment for sed usage in makefile
* remove unused aliases of proto generated types
* add settings.json instructions to contributing.md for including protobuf paths
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
Co-authored-by: Aaron Craelius <aaron@regen.network>
git describe by default use annotated tags.
Rationale:
Annotated tags, however, are stored as full objects in the Git
database. They’re checksummed; contain the tagger name, email,
and date; have a tagging message; and can be signed and verified
with GNU Privacy Guard (GPG). It’s generally recommended that you
create annotated tags so you can have all this information; but
if you want a temporary tag or for some reason don’t want to keep
the other information, lightweight tags are available too.
From: https://git-scm.com/book/en/v2/Git-Basics-Tagging#tagging
* add pre-commit hook
Co-authored-by: Gianguido Sora <gsora@users.noreply.github.com>
* add go tools installation notes
* Update CONTRIBUTING.md
* run both go mod and golangci-lint
* silence which
* add go.mod go.sum after go mod tidy
* update README
* look up golangci-lint specifically in GOPATH/bin
* don't run golangci-lint
* exclude proto files
Co-authored-by: Gianguido Sora <gsora@users.noreply.github.com>
Co-authored-by: Alexander Bezobchuk <alexanderbez@users.noreply.github.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Cancel ci if no .go files have been touched. There is no clean way of
doing this so i opted to `exit 1` on the diff job if no go files were
changed and have builds depend on diff passing
- migrate proto checks to github actions.
- providing make commands to use buf within docker.
- test-sim-multi-seed-long migration to github actions. Follows same
logic and only runs on release branches.
- add protobuf section to CONTRIBUTING.md.
- Added a ADR section to the Contributing.md
- This will streamline and create a central palce for discussions
- Currently conversations are fragmented across platfroms and different forum posts,
the aim here is to move it all to one place and create a document to be used as
reference in the future for why SDK went in this direction.
{,scripts/}Makefile:
- Remove gometalinter, install golangci-lint.
- Remove distinction between tools and devtools.
Just tools is enough.
- test_lint -> lint
Migrating away from underscore separated names.
- Remove unnecessary targets.
- Drop tendermint/lint. Incompatbile with golangci-lint
and no longer necessary anyway.
- Fix misleading message in go-mod-cache.
- New ci-target to avoid download tools twice.
- Run tests with -mod=readonly.
Port tools/gometalinter.json to .golangci.yml
Update CircleCI config accordingly.
Closes: #3896
Replace sha1sum with jack's gosum and get rid of
vendor-deps.
Also don't compute hash on vendor/ contents.
Instead hash go.sum.
Disable unconvert lint check. It does not
work very well with go mod.
Remove update_vendor_deps once and for all.
Upgrade to go 1.12
Closes: #3919#3630
mergify[bot]
Marko
Ryan Christoffersen
Robert Zaremba
colin axnér
billy rennekamp
Aaron Craelius
Amaury
Akhil Kumar P
Alessio Treglia
Cory
Alexander Bezobchuk
Arda Güçlü
gamarin2
frog power 4000
mircea-c
Frank Yang
Alessio Treglia
Jack Zampolin
Christopher Goes
Dev Ojha
ValarDragon