Federico Kunze
740a4c50c7
ibc: remove legacy REST endpoint support ( #7083 )
2020-08-18 08:39:40 -04:00
Alexander Bezobchuk
7d2062b674
x/bank: gRPC Params Route ( #7070 )
...
* update x/bank proto gRPC query service
* fix path
* update keeper
* add godoc
* add test
* lint++
2020-08-17 13:55:04 +00:00
Marko
8de96d16f9
tendermint: update to rc3 ( #6892 )
...
* modify light imports
* change abci.header to tmproto.header
* use rc
* rc
* fix import
* Merge PR #6893 : fix key imports
* fix rc2
* tendermint: update 3 (#6899 )
* tendermint: update 4 (#6919 )
Co-authored-by: Alexander Bezobchuk <alexanderbez@users.noreply.github.com>
* tendermint: update 5 (#6923 )
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
* bump to latest master
* tendermint: update (#6972 )
Co-authored-by: Aleksandr Bezobchuk <aleks.bezobchuk@gmail.com>
Co-authored-by: Cory Levinson <cjlevinson@gmail.com>
* Update x/ibc/07-tendermint/types/test_utils.go
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
* address comment
* go mod
* bring back things
* fix test
* update tm proto files
Co-authored-by: Alexander Bezobchuk <alexanderbez@users.noreply.github.com>
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
Co-authored-by: Aleksandr Bezobchuk <aleks.bezobchuk@gmail.com>
Co-authored-by: Cory Levinson <cjlevinson@gmail.com>
Co-authored-by: Federico Kunze <federico.kunze94@gmail.com>
2020-08-14 13:58:53 -04:00
atheeshp
f87624e9de
Add Grpc gateway annotations ( #6918 )
...
* grpc for bank module
* edit module.go
* added annotations for x/auth query proto
* generated gw file
* added grpc gateway for x/staking query proto
* added annotations for evidence
* added annotations for gov query proto
* added annotations
* added annotations for slashing module
* updated annotations
* added annotations for staking module
* added annotations for upgrade query
* annotations added for x/ibc/channel query proto
* added annotations for ibc/connection query proto
* updated annotations
* updated annotations
* annotation changes
* ommitted ibc module
* updated go.mod
* fixed lint issue
* review changes
* review changes
* review changes
* review changes
* go sum changes
* updated annotations
* annotation changes
* Fix proto lint issues
* review changes
* review changes
* review changes
* discussion changes
* review changes
* grpc for bank module
* edit module.go
* added annotations for x/auth query proto
* generated gw file
* added grpc gateway for x/staking query proto
* added annotations for evidence
* added annotations for gov query proto
* added annotations
* added annotations for slashing module
* updated annotations
* added annotations for staking module
* added annotations for upgrade query
* annotations added for x/ibc/channel query proto
* added annotations for ibc/connection query proto
* updated annotations
* updated annotations
* annotation changes
* ommitted ibc module
* updated go.mod
* fixed lint issue
* review changes
* review changes
* review changes
* review changes
* go sum changes
* updated annotations
* annotation changes
* Fix proto lint issues
* review changes
* review changes
* review changes
* discussion changes
* review changes
* fixed conflicts
* review changes
* updated gw files
* lint
* lint
* lint
* added missing annotations
* review changes
* review changes
* review changes
* review changes
Co-authored-by: SaReN <sahithnarahari@gmail.com>
Co-authored-by: Anil Kumar Kammari <anil@vitwit.com>
2020-08-14 10:05:35 +00:00
Amaury Martiny
5559af8b97
Proto Auditing: Replace ID with Id ( #7032 )
...
* Proto Auditing: Replace ID with Id
* make proto-gen
* Update docs
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
2020-08-14 08:55:54 +00:00
colin axnér
3a4e608930
Add clientState and consensusState gRPC support to connection ( #7017 )
...
* add proto querys for connection
* add client state and consensus state grpc for connection
* update client utils
2020-08-12 08:54:38 -04:00
colin axnér
d752a7b21f
ConsensusState is retrieved by light clients in verifyXYZ as necessary ( #7005 )
...
* move con state retrieval to verify funcs
* refactor tm client state tests
* fix build
* Apply suggestions from code review
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
Co-authored-by: Aditya <adityasripal@gmail.com>
* apply @fedekunze review comments
* apply @AdityaSripal review comment
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
Co-authored-by: Aditya <adityasripal@gmail.com>
2020-08-12 05:20:29 -04:00
Cory
61a97ef347
Audit / Refactor proto packages layout ( #6905 )
...
* create base proto package, move ValAddresses to staking
* move tx, crypto, query proto packages into base; mark module level packages as beta
* new cosmos/base/abci.proto file, refactor some message names
* add comments to TxResponse
* refactor RegisterInterface calls to new proto package names
* fix bug in merge commit
* move missing module proto packages to beta, move cosmos.kv to cosmos.base.kv
* add tx.proto files, holding proto messages for module Msgs
* rm old generated pb.go files
* cosmos/base/base.proto -> cosmos/base/coin.proto
* mark genutil proto package as beta
* Fix conflicts
* Restructure proto files
* Re put signing
* Fix test
* Update slashing genesis
* Ignore confio proto files
* Fix interface register
* Make proto-gen
* Fix lint
* Put tx service into tx.v1beta1
* Use v1beta1 in interface registry
* Remove to cosmos.base.store
* Remove extra confio in buf
Co-authored-by: Amaury Martiny <amaury.martiny@protonmail.com>
Co-authored-by: Alexander Bezobchuk <alexanderbez@users.noreply.github.com>
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
2020-08-11 11:49:45 +00:00
Alexander Bezobchuk
0f44d1af23
store: Remove Amino ( #6984 )
...
* Update kv pair to proto
* updates
* fix LastCommitID
* lint++
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
2020-08-11 10:09:16 +00:00
dauTT
20c80cfd44
Rename *codec.Codec to *codec.LegacyAmino ( #6991 )
...
* Rename *codec.Codec to *codec.LegacyAmino
* Implement requested changes
Co-authored-by: Aaron Craelius <aaron@regen.network>
2020-08-10 19:41:21 +00:00
atheeshp
ceba0cb45d
x/ibc migrate genesis proto ( #6878 )
...
* migrated channel genesis types to proto
* connection genesis types migrated to proto
* client proto migration
* failing tests due to tendermint part incomplete
* add genesis test
* x/ibc: ClientState Any
* add genesis test
* suite NotPanics
* comment tests
* update export logic
* refactor
* update test
* fix non-determinism
* castrepeated
* x/ibc: migrate simulations to protobuf
* add proto genesis
* add UnpackInterfaces func to genclientstate
* add unpackinterfaces for consensus states
* formatting
* fix genesis tests
* add modified genesis test
* update comments
* remove localhost register codec
* use app registry
* fix bug
* Update simapp/app.go
* Update x/ibc/02-client/types/genesis.go
* unmarshaler interface
Co-authored-by: Colin Axner <colinaxner@berkeley.edu>
Co-authored-by: Federico Kunze <federico.kunze94@gmail.com>
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
Co-authored-by: colin axnér <25233464+colin-axner@users.noreply.github.com>
2020-08-07 08:33:47 +00:00
colin axnér
0e4d67601f
Migrate Consensus State to being proto encoded/decoded in 02-client ( #6960 )
...
* flip switch to proto on consensus state in 02-client
* change consensus state to pointer
* fix bug
* remove amino from connection
* some test cleanup
2020-08-06 07:06:14 -04:00
SaReN
95cf3c95a6
Remove old tx code from rest ( #6939 )
...
* Cleanup rest txs
* Remove nolint
* Update x/ibc to use WriteGeneratedTxResponse
* Update marshaler usages
* Fix PostProcessResponse test
* Update PostProcessResponse
2020-08-05 18:08:13 +00:00
colin axnér
1a531cb645
x/ibc: migrate 02-client to use proto encoded/decoded client states ( #6948 )
...
* begin migration
* make client state a pointer
* fix build
* fixes from self review and rename cdctypes -> codectypes
* add godoc
2020-08-05 11:14:24 -04:00
colin axnér
00961f2082
x/ibc: remove parts of amino ( #6819 )
...
* remove amino from channel types
* fix unmarshal error
* fix msgs_test
* update msgs test with underscore json encoding
* remove amino from connections
* purge amino from ibc-transfer
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
2020-08-03 08:08:41 -04:00
Marko
617b822efa
types: add kv type ( #6897 )
...
* add kv type
* add changelog entry
* fix build
* replace sdkkv with kv
* revert change
* fix some tests
* proto-gen
* fix tests
Co-authored-by: Aleksandr Bezobchuk <aleks.bezobchuk@gmail.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
2020-07-30 14:53:02 +00:00
dauTT
5a7e22022c
Implement ADR 024 - Coin Metadata ( #6821 )
...
* Implement ADR 024 - Coin Metadata
* Fix lint
* Fix proto lint
* Index metadata by denom
* Fix test
* Fix proto comments
* Add GetAllDenomMetaData help method and refactor code accordingly
* Add x/bank/keeper/genesis_test.go
Co-authored-by: Alexander Bezobchuk <alexanderbez@users.noreply.github.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
2020-07-28 07:49:56 +00:00
Aditya
5676e7293f
Remove ID from ClientState ( #6823 )
...
* remove id from clients, build works
* fix client state tests
* fix tests
* address @fedekunze review
* Apply suggestions from code review
Co-authored-by: colin axner <25233464+colin-axner@users.noreply.github.com>
* lint
* remove commented-out test case
* Update x/ibc/02-client/keeper/keeper_test.go
Co-authored-by: colin axner <25233464+colin-axner@users.noreply.github.com>
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
Co-authored-by: colin axner <25233464+colin-axner@users.noreply.github.com>
2020-07-27 18:43:09 +00:00
Anil Kumar Kammari
3bafd8255a
Remove hybrid codec usage ( #6843 )
...
* remove hybrid codec for slashing, staking and upgrade
* Remove hybridcodec from params and mint
* revert staking
* Fix gov
* Fix ibc and evidence
* Fix ibc-transfer
* Fix staking
* remove evidence json marshaling
* Fix tests
Co-authored-by: Aaron Craelius <aaron@regen.network>
Co-authored-by: Aaron Craelius <aaronc@users.noreply.github.com>
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
2020-07-25 08:03:58 +00:00
Anil Kumar Kammari
e906c012a0
add page flag for CLI queries ( #6824 )
...
* add page flag for CLI queries
* fix review suggestions
* Fix `page` flag default value
* fix offset calc
* Apply suggestions from code review
Co-authored-by: Aaron Craelius <aaron@regen.network>
* fix review suggestions
* refactor
* fix returning error
Co-authored-by: SaReN <sahithnarahari@gmail.com>
Co-authored-by: Aaron Craelius <aaron@regen.network>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
2020-07-24 08:17:11 +00:00
colin axner
ef0a7344af
x/ibc: remove ID from ConnectionEnd ( #6814 )
...
* remove connection id
* various test and code fixes
* fix tests
* Update proto/ibc/connection/connection.proto
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
* rename utils.go to parse.go in host
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
2020-07-22 09:59:15 -04:00
atheeshp
9ee14ee985
Add pagination flags to x{ibc, bank} ( #6804 )
...
* updated pagination flags
* updated all balances pagination flags
* updated all balances
* some doc updates
Co-authored-by: Anil Kumar Kammari <anil@vitwit.com>
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
2020-07-21 15:36:45 +00:00
Amaury Martiny
69bbb8b327
Rename proto Req/Res to Pagination ( #6796 )
...
* Rename proto Req to Pagination
* Change Res to Pagination
Co-authored-by: Alexander Bezobchuk <alexanderbez@users.noreply.github.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
2020-07-20 16:51:16 +00:00
colin axner
1d6344888e
Fix query unrelayed packets logic ( #6733 )
...
* add some query functions to channel keeper
* update grpc queries and cli cmd and tests
* rerun proto gen after merging master
* fix build broken from merge conflicts
* add test and update proto
* Update x/ibc/04-channel/client/cli/query.go
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
2020-07-20 12:42:36 +00:00
colin axner
5dfc4a2ec9
Standardize connection versioning + channel versioning docs ( #6640 )
...
* update connection versions with feature set flag
* make connection version modular to support channel versioning and registering
* revert IBCVersion renaming, add channel versioning logic
* fix channel version flag
* remove unnecessary godoc
* remove unused func
* fix lint and version test
* add test and fix error
* revert changes
* update docs
* remove unnecessary godoc
* Apply suggestions from code review
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
* update doc
* add test cases for unchecked lines
* go fmt
* begin migration to standardized version
* revert proto changes
* restructure versioning to go from string to proto
* update versionStr to encodedVersion naming
* fix version test build
* fix keeper tests
* fix various tests
* fixes from self review
* update docs
* fix lint
* add more code cov
* rename ToString funcs to Encode/DecodeVersion + GetCompatibleEncodedVersions renaming
* update spec docs
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
2020-07-14 08:43:26 +00:00
Alexander Bezobchuk
e7554bb3b0
Fix Gas Flag Usage + CLI Flag APIs ( #6685 )
...
* Use new APIs
* fix usage
* fix usage of gas flag
* tests: TestParseGasSetting
2020-07-11 08:13:46 +00:00
colin axner
03fdc9d744
x/ibc: update error messages ( #6659 )
...
* update errors in 02-client
* update errors in 03-connection
* update 04-channel errors + fixes to 03 changes
* update ibc handler errors
* tm, commitment, and verify error updates
* update ics20
* remove unnecessary wrapping
* fix various build issues
2020-07-09 12:06:08 -04:00
Federico Kunze
3fc5a4dfc6
x/ibc: update CLI queries ( #6647 )
2020-07-08 10:57:42 -04:00
Federico Kunze
e6bb2e7ed7
x/ibc: refactor CLI ( #6639 )
...
* x/ibc: refactor CLI
* refactor client CLI
* rename version ClientName
* Update x/ibc/09-localhost/client/cli/cli.go
Co-authored-by: Amaury Martiny <amaury.martiny@protonmail.com>
* address comments from review
Co-authored-by: Amaury Martiny <amaury.martiny@protonmail.com>
2020-07-08 05:57:59 -04:00
colin axner
9a029aea04
refactor connection keeper_test ( #6622 )
...
* refactor first set of keeper
* finish cleaning up keeper tests
* fix build
Co-authored-by: Aditya <adityasripal@gmail.com>
2020-07-07 16:29:47 +00:00
colin axner
b4a027cb5d
update consensus height check ( #6625 )
...
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
2020-07-07 15:45:30 +00:00
Alexander Bezobchuk
8670a10564
Merge PR #6595 : Single Binary & Command Refactor
2020-07-07 11:40:46 -04:00
Federico Kunze
0fd559e42d
x/ibc: minor fixes ( #6621 )
2020-07-07 07:33:06 -04:00
Aditya
7fdcdc18e0
Enforce Connection Features on Channel Opening ( #6620 )
...
* add channel open checks for supported feature
* add tests and fix bugs
* fix version tests
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
2020-07-07 10:00:12 +00:00
Federico Kunze
f35e3b2c02
x/ibc: gRPC query service ( #6466 )
...
* x/ibc: gRPC query service
* fixes
* connection updates
* register channel query service
* update clients
* change proofs to bytes
* implement additional channel grpc queries
* unrelayed packets query
* query.proto files
* move next sequence recv query to channel client
* update REST
* wip test
* add missing cli queries
* install the right tools
* fixes
* build
* lint
* use gRPC when query proof is not requested
* connection gRPC tests
* IBC query server interface
* more gRPC channel tests
* pagination tests
* connection use query server
* connection pagination tests
* channel pagination tests
* typo
* remove buf
* Update x/ibc/03-connection/keeper/grpc_query_test.go
Co-authored-by: colin axner <25233464+colin-axner@users.noreply.github.com>
* address comments from review
* fix tests
* unrelayed packet sequences flag
* remove ClientsConnections query
* fix
Co-authored-by: colin axner <25233464+colin-axner@users.noreply.github.com>
2020-07-06 15:35:35 -04:00
colin axner
bbe245ac1d
refactor connection verify_test ( #6588 )
...
* refactor verify consensus state
* refactor connection verification
* simplify code, channel + packet commitment tests
* refactor verify ack
* refactor verify ack absence
* refactor next seq recv test
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
Co-authored-by: Christopher Goes <cwgoes@pluranimity.org>
2020-07-06 13:37:12 +00:00
Alexander Bezobchuk
fd9cdb8ba7
Merge PR #6608 : ibc: remove viper from CLI
2020-07-06 09:25:47 -04:00
dauTT
4f3efaded4
Add same attributes for all connection/ channel/ packet IBC events ( #6482 )
...
* Emmit events with same attributes in connection handlers
* Emmit events with same attributes in channel handlers
* Add paket_data attribute to EventTypeAcknowledgePacket
* Revert proto changes
* Query channel and connection to emit events with same attributes
* Simplify code
* Update x/ibc/04-channel/keeper/packet.go
* Update x/ibc/04-channel/handler.go
* Apply suggestions from code review
Co-authored-by: Aditya <adityasripal@gmail.com>
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
2020-07-03 15:48:48 +00:00
colin axner
73757243c2
Update connection handshake version negotiation ( #6534 )
...
* update version negotiation and add basic testing
* add integration tests
* update spec
* apply @fedekunze suggestions
* update to enforce connection validation checks
* add test
* update godoc and spec
* small doc fix
* update versioning to feature set
* update version code and tests to specified version tuple
* update docs/spec
* merge and fix bug
* Update x/ibc/03-connection/types/version.go
Co-authored-by: Aditya <adityasripal@gmail.com>
* Apply suggestions from code review
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
* add verify proposed feature set test
* fix formatting bug
* add safety check
* merge tests into existing handshake tests
Co-authored-by: Aditya <adityasripal@gmail.com>
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
2020-07-03 09:28:02 +00:00
colin axner
db60e658f8
refactor connection handshake_test ( #6576 )
...
* refactor connopeninit test
* updated opentry
* refactor openack
* update openconfirm
* fix typo and test issue
* fix missing code cov hits
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
2020-07-02 20:08:29 +00:00
colin axner
e8fb76ae44
x/ibc: remove alias.go from 03-connection ( #6543 )
2020-06-30 09:10:53 -04:00
Cory
4e73e0f817
Update proto files & definitions in accordance with ADR023 ( #6413 )
...
* consolidate proto files into single directory, turn on PACKAGE_DIRECTORY_MATCH linting
* add third_party root for third party proto files
* move ibc proto files to top level folder, rename .proto files to types.proto as before
* update protocgen script, and run code generation
* move vesting proto definition to cosmos namespace, rename from types.proto in alignment with buf.build naming conventions
* update Makefile so proto dependencies are set with new structure when updated
* add comment for sed usage in makefile
* remove unused aliases of proto generated types
* add settings.json instructions to contributing.md for including protobuf paths
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
Co-authored-by: Aaron Craelius <aaron@regen.network>
2020-06-18 10:04:26 -07:00
Federico Kunze
1c8249e26d
x/ibc: tx client protobuf migration ( #6461 )
...
* ibc/03-connection: tx client migration
* update commands
* update ibc-transfer
* remove unused queryRoute
* initialize clientCtx
2020-06-17 21:56:48 +02:00
Alexander Bezobchuk
35312d098e
JSON Codec Updates ( #6444 )
...
* Initial commit
* More updates
* Fix tests
* CLI test updates
* Updates
* Updates
2020-06-16 00:20:50 +00:00
dauTT
14e3aa1265
x/staking: remove alias.go usage ( #6397 )
...
* x/staking: remove alias.go usage
* Fix formatting and Add entry in CHANGELOG.md
* Add missing end curly parenthesis
Co-authored-by: Alessio Treglia <alessio@tendermint.com>
2020-06-12 14:54:37 +00:00
Aditya
d82c2e6a94
Enforce ProofSpecs in 23-Commitment ( #6374 )
...
* enforce spec ordering
* modify clients to pass in specs to verify functions
* start fixing tests
* Apply suggestions from code review
* enforce spec length and proof length match
* fix all tests
* add argument to constructor:
* fixed msg client and tests
* appease linter
* Apply suggestions from code review
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
* finish fixes from review
* add back proof-specific checks
* Apply suggestions from code review
* more robust proof spec checks
* add CHANGELOG entries
* do not hardcode proofspecs in 23-commitment
* fix client modules
* fix tests
* appease linter
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
2020-06-12 10:45:40 +00:00
colin axner
9048ffa8d3
Update ibc proof to be bytes ( #6393 )
...
* update interfaces to use []byte instead of commitment proof
* update 03/04 msgs with bytes
* fix compile errors
* fix channel tests
* fix connection tests
* fix testing, tm, and localhost tests
* fix ante tests
* update 03-connection spec
* update channel msgs spec
* small fixes after self review
* rm unused import
* Update x/ibc/03-connection/client/utils/utils.go
Co-authored-by: Alessio Treglia <alessio@tendermint.com>
* add empty proof test and rm ics 20 from ibc spec
* fix merge issues
Co-authored-by: Alessio Treglia <alessio@tendermint.com>
2020-06-12 00:19:25 +02:00
Jonathan Gimeno
b09d6728ec
Rename all methods IsEmpty to Empty to be consistent with all codebase ( #6409 )
...
Co-authored-by: Alessio Treglia <alessio@tendermint.com>
2020-06-11 23:32:24 +02:00
colin axner
affe7265cb
Update connection and channel to use types_test package name ( #6395 )
...
* convert connection types test pacakge name
* convert channel types test package name
Co-authored-by: Alexander Bezobchuk <alexanderbez@users.noreply.github.com>
2020-06-11 00:31:54 +00:00
Federico Kunze
744c1ce250
x/ibc: simulation store decoders ( #6247 )
...
* x/ibc: simulation store decoders
* x/ibc: missing decoders
* fixes
* 02-client: decoder test
* 03-connection: decoder test
* x/ibc: decoder test
* address comments from review
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
2020-06-10 08:09:51 +00:00