Amaury
13bc504bec
docs: Add REST endpoints migration guide ( #8011 )
...
* Add REST endpoints migration guide
* add bank, distrib, evidence
* Add slashing, mint
* Add staking
* Add query
* Add todo
* Typos
* Add link to interact node
* grammar
* Better wording
* Update docs/migrations/rest.md
Co-authored-by: Robert Zaremba <robert@zaremba.ch>
* Update docs/migrations/rest.md
* Add footnote
Co-authored-by: Robert Zaremba <robert@zaremba.ch>
2020-11-24 14:34:20 +00:00
Aditya
53294f5269
check clients against params and consensus against clients ( #8016 )
...
Co-authored-by: colin axnér <25233464+colin-axner@users.noreply.github.com>
2020-11-24 12:27:35 +00:00
Aditya
def3c5ba71
Add ConsensusState to IBC Upgrades ( #7919 )
...
* upgrade progress
* fix build minus cli
* write state at block before upgrade height
* refix build
* Apply suggestions from code review
Co-authored-by: colin axnér <25233464+colin-axner@users.noreply.github.com>
* fix upgrade and start with tests
* fix tendermint tests
* add tests and remove unnecessary relayer options on upgradedClient
* fix all tests except weird msg panic
* add invalid final client test and codec stuff
* fix everything but msg issue
* remove problematic test for now
* safer self validation
* upgrade fixes
* proto-linting
* remove unnecessary last height
* add timestamp to committed upgrade consensus state
* address final nits
* address nit
Co-authored-by: colin axnér <25233464+colin-axner@users.noreply.github.com>
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
2020-11-24 11:45:33 +00:00
Amaury
74435137e9
Show height on legacy REST endpoints ( #7997 )
...
* Fix showing height in rest endpoints
* Fix query height
* Manually inject req.Height
* Small tweaks
* Use withHeight
Co-authored-by: Aleksandr Bezobchuk <alexanderbez@users.noreply.github.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
2020-11-24 10:28:12 +00:00
colin axnér
966e26d23d
Fix tendermint misbehaviour trusted consensus state age check ( #8006 )
...
* use TrustingPeriod instead of UnbondingPeriod when verifying the age of the trusted consensus state
* update comment
2020-11-23 16:10:25 +01:00
Aleksandr Bezobchuk
a7296d3d4e
Bump Tendermint v0.34.0 ( #7995 )
...
* init commit
* ibc: remove redundant casting
* ci: attempt fix liveness job
2020-11-20 19:00:11 +01:00
SaReN
07cfed4178
Merge branch 'master' into robert/bech32-pubkey-slashing
2020-11-20 01:23:54 +05:30
Aleksandr Bezobchuk
4be5cd3454
docs: x/bank: Atlas Doc ( #7961 )
2020-11-19 11:57:10 -05:00
Robert Zaremba
a4130f5821
remove unused function
2020-11-19 02:19:19 +01:00
Robert Zaremba
0034e48458
Bech32 PubKey: use protobuf in slashing keeper
2020-11-19 01:10:11 +01:00
Federico Kunze
87315a6aab
ibc: commit packet and hash ( #7808 )
...
* ibc: commit packet and hash
* minor changes
* fix build
* update err msgs
* don't use Any
* update commitment hash to used fixed length preimage
The commitment hash will now use 8 bytes timeout timestamp + 8 bytes timeout height version number + 8 bytes timeout height version height + sha 256 hash of data
* remove error from CommitPacket return values
* update godoc
* rm proto-tools-stamp
Co-authored-by: Colin Axner <colinaxner@berkeley.edu>
Co-authored-by: colin axnér <25233464+colin-axner@users.noreply.github.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
2020-11-18 19:01:22 +00:00
colin axnér
f02a46263f
update transfer error messages ( #7968 )
...
* update transfer err messages
* apply @AdityaSripal review suggestion
2020-11-18 14:56:26 +01:00
Marie Gauthier
1cc8af8d9b
[docs]: update building modules section to reflect ADR31 ( #7702 )
...
* Revert "Revert "Update old ref of RegisterQueryService""
This reverts commit 03e4c56de53938ccbf025a441e54b9842f7c4544.
* Update intro, module-manager and messages-and-queries
* Update messages-and-queries
* Update handler
* Update structure
* Add doc related to RegisterMsgServiceDesc
* Update docs/building-modules/handler.md
Co-authored-by: Robert Zaremba <robert@zaremba.ch>
* Update docs/building-modules/handler.md
Co-authored-by: Robert Zaremba <robert@zaremba.ch>
* Update docs/building-modules/handler.md
Co-authored-by: Robert Zaremba <robert@zaremba.ch>
* Update docs/building-modules/messages-and-queries.md
* Update handler.md
* Rename handler.md to msg-services.md
* Update legacy msgs wording
* Update messages-and-queries.md
* Update docs/building-modules/msg-services.md
Co-authored-by: Amaury Martiny <amaury.martiny@protonmail.com>
* Update docs/building-modules/intro.md
Co-authored-by: Amaury Martiny <amaury.martiny@protonmail.com>
* Remove handler mention from intro.md
* Update docs/building-modules/messages-and-queries.md
Co-authored-by: Amaury Martiny <amaury.martiny@protonmail.com>
* Update docs/building-modules/messages-and-queries.md
Co-authored-by: Amaury Martiny <amaury.martiny@protonmail.com>
* Update docs/building-modules/msg-services.md
Co-authored-by: Amaury Martiny <amaury.martiny@protonmail.com>
* Update docs/building-modules/keeper.md
Co-authored-by: Amaury Martiny <amaury.martiny@protonmail.com>
* Update docs/building-modules/msg-services.md
Co-authored-by: Amaury Martiny <amaury.martiny@protonmail.com>
* Address review comments
* Use tag
* Update docs/building-modules/intro.md
Co-authored-by: Cory <cjlevinson@gmail.com>
* Update docs/building-modules/intro.md
Co-authored-by: Aaron Craelius <aaron@regen.network>
* Update docs/building-modules/messages-and-queries.md
Co-authored-by: Aaron Craelius <aaron@regen.network>
* Update docs/building-modules/messages-and-queries.md
Co-authored-by: Aaron Craelius <aaron@regen.network>
* Update docs/building-modules/messages-and-queries.md
Co-authored-by: Aaron Craelius <aaron@regen.network>
* Update docs/core/transactions.md
Co-authored-by: Aaron Craelius <aaron@regen.network>
* Update docs/building-modules/messages-and-queries.md
Co-authored-by: Aaron Craelius <aaron@regen.network>
* Update docs/building-modules/messages-and-queries.md
Co-authored-by: Aaron Craelius <aaron@regen.network>
* Update docs/building-modules/messages-and-queries.md
Co-authored-by: Aaron Craelius <aaron@regen.network>
* Update docs/building-modules/messages-and-queries.md
Co-authored-by: Aaron Craelius <aaron@regen.network>
* Remove framework related explanation from docs
* Update docs/building-modules/messages-and-queries.md
Co-authored-by: Aaron Craelius <aaron@regen.network>
* Update docs/building-modules/module-manager.md
Co-authored-by: Aaron Craelius <aaron@regen.network>
* Update docs/building-modules/module-manager.md
Co-authored-by: Aaron Craelius <aaron@regen.network>
* Update docs/building-modules/msg-services.md
Co-authored-by: Aaron Craelius <aaron@regen.network>
* Update docs/building-modules/msg-services.md
Co-authored-by: Aaron Craelius <aaron@regen.network>
* Update docs/building-modules/msg-services.md
Co-authored-by: Aaron Craelius <aaron@regen.network>
* Update docs/building-modules/msg-services.md
Co-authored-by: Aaron Craelius <aaron@regen.network>
* Update docs/building-modules/msg-services.md
Co-authored-by: Aaron Craelius <aaron@regen.network>
* Update docs/building-modules/msg-services.md
Co-authored-by: Aaron Craelius <aaron@regen.network>
* Update docs/building-modules/msg-services.md
Co-authored-by: Aaron Craelius <aaron@regen.network>
* Update docs/core/baseapp.md
Co-authored-by: Aaron Craelius <aaron@regen.network>
* Update docs/core/baseapp.md
Co-authored-by: Aaron Craelius <aaron@regen.network>
* Update beginblock-endblock.md
* Update docs/core/baseapp.md
Co-authored-by: Aaron Craelius <aaron@regen.network>
* Update docs/core/transactions.md
Co-authored-by: Aaron Craelius <aaron@regen.network>
* Add deprecated notice
* Update tx-lifecycle.md
Co-authored-by: Robert Zaremba <robert@zaremba.ch>
Co-authored-by: Amaury Martiny <amaury.martiny@protonmail.com>
Co-authored-by: Aaron Craelius <aaron@regen.network>
Co-authored-by: Cory <cjlevinson@gmail.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
2020-11-17 20:41:43 +00:00
colin axnér
03c8fb313d
add domain separation between port and channel ( #7960 )
...
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
2020-11-17 15:37:20 +00:00
colin axnér
a7435d03eb
fix validate basic check ( #7962 )
...
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
2020-11-17 15:18:16 +00:00
colin axnér
715933b5f3
reduce redundancy ( #7959 )
...
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
2020-11-17 15:01:34 +00:00
atheeshp
ab7104865d
improve error messages for legacy rest endpoints ( #7856 )
...
* improve error messages for legacy rest endpoints
* add test
* review changes
* review changes
* refactor
* Update x/auth/client/rest/query.go
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Co-authored-by: Aleksandr Bezobchuk <alexanderbez@users.noreply.github.com>
2020-11-17 14:46:24 +00:00
Emmanuel T Odeke
9369a00557
x/simulation: make signals channel buffered to avoid missing signals ( #7952 )
...
Invoking:
c := make(chan os.Signal)
signal.Notify(c, signals...)
is explicitly called out as a bug in the os/signal docs
and should instead make that channel buffered lest
a signal could be lost.
Fixes #7950
Co-authored-by: Aleksandr Bezobchuk <alexanderbez@users.noreply.github.com>
2020-11-17 14:27:12 +00:00
colin axnér
0647d897f5
add is frozen client state check to send packet ( #7957 )
...
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
2020-11-17 12:55:33 +00:00
colin axnér
e93b18e60e
self height uses GTE in self client check ( #7945 )
...
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
2020-11-17 11:40:12 +00:00
Jun Kimura
f962f3a28c
Fix int64 overflow error for height comparison ( #7944 )
...
* fix int64 overflow for height comparison
* apply suggestions from review
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
2020-11-17 10:42:06 +00:00
Sunny Aggarwal
479ad6be45
Merge branch 'master' into fix_power_reduction_test_cast_int64
2020-11-16 12:19:39 -04:00
colin axnér
be10bcb163
counterParty -> counterparty ( #7946 )
...
* nit
* fix spec and docs
2020-11-16 15:06:55 +00:00
yihuang
54201d11e6
cli: convert coins to smallest unit registered ( #7777 )
...
* cli: convert coins to smallest unit registered
fixes : #7623
- test order of decimal operations
- support both int and decimal coins, truncate when normalizing to
base unit
* Update types/coin_test.go
* Update types/coin_test.go
Co-authored-by: Alessio Treglia <alessio@tendermint.com>
Co-authored-by: Amaury <amaury.martiny@protonmail.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
2020-11-16 11:34:54 +00:00
colin axnér
cd29fd642a
Fix connection path validation and remove unused PathValidator function ( #7930 )
...
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
2020-11-16 09:30:57 +00:00
Callum Waters
6b62d266bb
use verifycommitlight ( #7936 )
2020-11-16 09:14:21 +00:00
Sunny Aggarwal
e239504bc0
Merge branch 'master' into gov_split_vote_weighted_vote
2020-11-16 01:53:13 -04:00
colin axnér
7e6978ae55
ibc: tendermint misbehaviour should use block hash for equality check ( #7928 )
...
* check block hash equality
* update err msg
* valid commit now uses block id hash
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
2020-11-13 19:01:33 +00:00
Sunny Aggarwal
9e9dbf315d
Merge branch 'master' into fix_power_reduction_test_cast_int64
2020-11-13 11:49:39 -04:00
Sunny Aggarwal
8bc429d288
fix int64
2020-11-13 11:48:06 -04:00
vincent
6e3fab854f
Fix upgrade store loader ( #7817 )
...
* fix upgrade store loader
* fix test
* resolve comment
Co-authored-by: billy rennekamp <billy.rennekamp@gmail.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
2020-11-13 15:27:52 +00:00
Sunny Aggarwal
5a95db669b
Merge branch 'master' into fix_power_reduction_test_cast_int64
2020-11-13 11:07:02 -04:00
colin axnér
0b1a3eed39
add docs and make prefix a const ( #7926 )
...
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
2020-11-13 14:32:33 +00:00
colin axnér
ddc777cf6f
remove chainid from ibc tm misbehaviour ( #7932 )
...
* remove chainid from misbehaviour
* update err msg
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
2020-11-13 14:16:51 +00:00
Federico Kunze
e77c9506c8
ibc: packet fixes ( #7810 )
...
* ibc: msg validation fields
* msg tests
* rename proof
* rename proofs
* check seq ≠ 0
Co-authored-by: Aditya <adityasripal@gmail.com>
Co-authored-by: colin axnér <25233464+colin-axner@users.noreply.github.com>
2020-11-13 13:58:13 +00:00
Aditya
4b529a41cf
Capability Fixes ( #7918 )
...
* add cap and name checks
* Update x/capability/keeper/keeper.go
* address reviews
* fix missing trim
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
2020-11-13 11:13:59 +00:00
Ethan Buchman
15103b63a1
x/ibc/24-host: fix some comments ( #7923 )
...
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
2020-11-13 10:33:33 +00:00
Amaury
6f5eaba95b
Add support for TM secp256k1 ( #7838 )
...
* Add secp256k1 support
* Fix test
* Add test in handler_test
* Use table tests
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
2020-11-13 10:15:29 +00:00
colin axnér
c0d7233141
Minor fixes for ibc tendermint ( #7916 )
...
* remove nil checks in getter functions for ibc tm header
* remove redundant registration
* add upgrade height version height check
* fix err msg
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
2020-11-12 19:01:22 +00:00
colin axnér
956e1cf68f
move sdk denom validation to top of validateibcdenom ( #7917 )
2020-11-12 18:44:02 +00:00
colin axnér
96f239db1c
remove timestamp check from solomachine misbehaviour ( #7915 )
...
* remove timestamp check from solomachine misbehaviour
* add more documentation
2020-11-12 16:15:33 +00:00
MD Aleem
f3e4964f2f
Add TxsByEvent gRPC endpoint ( #7842 )
...
* add service definition for TxsByEvents
* add TxsByEvent gRPC endpoint
* fix lint
* fix test
* review changes
* review changes
* fix proto descriptions
* review changes
* fix lint
* review changes
* Update proto/cosmos/tx/v1beta1/service.proto
* review changes
Co-authored-by: Aleksandr Bezobchuk <alexanderbez@users.noreply.github.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
2020-11-12 14:22:54 +00:00
colin axnér
c8afb2cbe7
Remove consensus params from IBC tm client ( #7891 )
...
* remove consensus params
* fix build
* fix build
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
2020-11-12 10:08:04 +00:00
Marko
104a2031ab
docker: proto ( #7893 )
...
* migrate fully to buf
* run protoc-gen-cosmos in script
* migrate to docker container
* Update Makefile
Co-authored-by: Alessio Treglia <alessio@tendermint.com>
* Update scripts/protocgen.sh
Co-authored-by: Aleksandr Bezobchuk <alexanderbez@users.noreply.github.com>
Co-authored-by: Alessio Treglia <alessio@tendermint.com>
Co-authored-by: Aleksandr Bezobchuk <alexanderbez@users.noreply.github.com>
2020-11-12 09:49:46 +00:00
colin axnér
e9f19225a9
IBC Upgrades function interface return client/consensus ( #7895 )
...
* return client and consensus state on upgrades
* fix build
2020-11-11 18:06:37 +00:00
antstalepresh
4515b8782d
Merge branch 'master' of github.com:cosmos/cosmos-sdk into fix_power_reduction_test_cast_int64
2020-11-12 02:52:59 +10:00
antstalepresh
0b20e23f21
fix random values testing
2020-11-12 02:05:03 +10:00
colin axnér
76ffdccb03
IBC Fraction for trust level changed to uints ( #7892 )
...
* fraction uses uint now
* Update proto/ibc/lightclients/tendermint/v1/tendermint.proto
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
2020-11-11 15:52:11 +00:00
antstalepresh
0eb0cbec65
set PowerReduction=10^18 for staking tests
2020-11-12 01:48:42 +10:00
Federico Kunze
136f3ade88
ibc: client params allowlist ( #7855 )
...
* ibc: client params allowlist
* genesis and gRPC
* client
* lint
* spec
* fixes
* validate localhost client
* move client types back to exported
* update genesis
* sort clients by id
2020-11-11 11:07:29 +00:00
colin axnér
116d0460fc
solo machine GetPubKey returns an error instead of panicing ( #7883 )
...
* solo machine public key now returns an error instead of panicing
* apply @fedekunze review suggestions
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
2020-11-11 10:09:57 +00:00
colin axnér
0bd46574f4
fix mismatched solomachine signature data type verification ( #7882 )
...
* fix mismatched signature data type verification
* update godoc
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
2020-11-10 20:37:10 +00:00
Federico Kunze
bcdd6ee15c
ibc: fix grpc gateway routes ( #7881 )
2020-11-10 17:50:53 +00:00
colin axnér
300b7393ad
Update IBC host keys + cleanup ( #7873 )
...
* init changes
* cleanup keys and remove redunancdy
* revert unintentional changes
* KeyChannel -> ChannelKey
2020-11-10 17:05:21 +00:00
antstalepresh
67b3f9071c
fix build issues && telemetry.SetGaugeWithLabels int64 range validation
2020-11-11 02:07:40 +10:00
antstalepresh
4582dcd08f
remove comment
2020-11-11 01:38:54 +10:00
antstalepresh
705e26e98c
give enough balance to operations test validator based on TokensFromConsensusPower to consider PowerReduction
2020-11-11 01:28:39 +10:00
antstalepresh
cc96ee3a3b
fix staking cli, grcp_query, keeper test for power reduction
2020-11-11 00:40:25 +10:00
Aditya
fdcb028636
ibc: proof fixes ( #7869 )
...
* change proof proto def
* progress fixing tests
* complete proof restructure
* remove use of KeyPath
* improve error msgs
* docs and lint
* Apply suggestions from code review
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
Co-authored-by: colin axnér <25233464+colin-axner@users.noreply.github.com>
* address code review
* fix string tests
* add ConvertProofs tests
* Apply suggestions from code review
Co-authored-by: colin axnér <25233464+colin-axner@users.noreply.github.com>
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
Co-authored-by: colin axnér <25233464+colin-axner@users.noreply.github.com>
2020-11-10 15:39:09 +01:00
antstalepresh
7bc08c419c
Disable telemetry.SetGaugeWithLabels when amount overflow int64 && Update CreateValidator, CreateValidatorMsg, Delegate helper functions to fix int64 overflow
2020-11-10 23:05:15 +10:00
colin axnér
55772aec8c
update err to match others ( #7857 )
...
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
2020-11-09 17:12:00 +00:00
Marie Gauthier
90e9370bd8
Replace tmcrypto.PubKey by our own cryptotypes.PubKey ( #7419 )
...
* WIP on removing tm pub/privkey
* Fix part of crypto tests
* Add PrivKeyLedgerSecp256K1 proto type
* Use BasePrivKey for ledger priv key type
* Refacto continued
* First round
* x/staking
* Continue porting
* x/* done
* Make build pass
* More conversion
* Remove IntoTmPubKey
* Fix test
* Remove crypto.PubKey in some other places
* Revert ledger changes
* Fix comment
* Remove useless function
* Add To/FromTmPublicKey
* Add migrate tests
* Fix test
* Fix another test
* Rename tm conversion functions
* Less code
* Rename BasePrivKey to LedgerPrivKey
* Add changelog
* Rename functions
Co-authored-by: Amaury Martiny <amaury.martiny@protonmail.com>
Co-authored-by: Alessio Treglia <alessio@tendermint.com>
2020-11-09 16:01:43 +00:00
antstalepresh
ebb7698339
status update for power reduction test
2020-11-10 00:14:10 +10:00
Federico Kunze
70fa17b55a
ibc: spec overview ( #7853 )
2020-11-09 12:44:20 +01:00
Federico Kunze
f294db9ccf
x/ibc: transfer specs ( #7580 )
...
* x/ibc: transfer specs
* update titles and list todos
* denom trace and client UX
* add UX recommendations and locked funds section
* metrics
* state transitions
* Apply suggestions from code review
Co-authored-by: colin axnér <25233464+colin-axner@users.noreply.github.com>
* address comments from review
* jack suggestions
* add example
* fix
* address comments from call with @zakimanian
* Update x/ibc/applications/transfer/spec/01_concepts.md
Co-authored-by: Christopher Goes <cwgoes@pluranimity.org>
* add comment about verification
* address comments from review
Co-authored-by: colin axnér <25233464+colin-axner@users.noreply.github.com>
Co-authored-by: Christopher Goes <cwgoes@pluranimity.org>
2020-11-09 08:49:16 +00:00
Ethan Buchman
dd9ef120f3
x/cap: fix comments, SetIndex, and some tests ( #7845 )
...
* x/cap: fix comments and some tests
* fix lint
* Apply suggestions from code review
Co-authored-by: Alessio Treglia <alessio@tendermint.com>
Co-authored-by: Alessio Treglia <alessio@tendermint.com>
2020-11-07 20:38:26 +00:00
Sunny Aggarwal
138ae178ff
Merge branch 'master' into gov_split_vote_weighted_vote
2020-11-06 12:33:13 -04:00
antstalepresh
be1012c8d1
remove cast to int64 for amount multiplied by PowerReduction
2020-11-07 00:57:07 +10:00
Cory
56c08d1117
Bump to tendermint v0.34-rc6 ( #7828 )
...
* bump to tendermint v0.34-rc6
* update go.mod
* tendermint version is now accessible as tmversion.TMCoreSemVer
* add changelog entry
Co-authored-by: Amaury Martiny <amaury.martiny@protonmail.com>
2020-11-06 10:13:52 +00:00
Aditya
03a46181c6
Merge Packet Functions ( #7813 )
...
* start implementation and debugging tests
* fix some issues, continue debugging
* fix IBC tests
* remove print statement and fix docs
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
2020-11-05 14:07:15 +00:00
Federico Kunze
97963c71df
ibc: remove GetClientConsensusStateLTE ( #7812 )
2020-11-05 14:46:00 +01:00
Aditya
432afb274b
ibc: minor fixes from audit ( #7807 )
2020-11-04 13:16:20 +01:00
SaReN
286e9bfbef
Remove duplicate tx commands for auth ( #7788 )
...
* remove duplicate commands
* add changelog
Co-authored-by: Alessio Treglia <alessio@tendermint.com>
2020-11-04 09:58:11 +00:00
antstalepresh
267148291c
Merge pull request #39 from antstalepresh/gov_split_vote
...
Governance split vote
2020-11-04 10:31:55 +10:00
Aditya
30efa5ab16
Host Key changes ( #7783 )
...
* change host keys on sequences
* fix prefix names
Co-authored-by: Christopher Goes <cwgoes@pluranimity.org>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
2020-11-03 14:35:54 +00:00
antstalepresh
381d1b0e70
fix deprecated function use after merging cosmos master
2020-11-03 22:32:49 +10:00
antstalepresh
eb992a4490
Merge branch 'master' of https://github.com/sikkatech/cosmos-sdk into gov_split_vote
2020-11-03 22:27:58 +10:00
antstalepresh
350f88c0ca
fix lint issues
2020-11-03 22:21:23 +10:00
antstalepresh
ee1988a4ba
split MsgVote and MsgWeightedVote for backwards compatibility
2020-11-03 21:48:53 +10:00
Federico Kunze
72ab03b3ef
ibc: validate signer address ( #7781 )
...
* ibc: validate signer address
* comment
* validate channel handshakes and transfer signers
2020-11-03 10:07:32 +00:00
Aditya
6559e19764
Remove BatchProofs implementation ( #7784 )
...
* remove batch proofs
* Apply suggestions from code review
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
2020-11-03 09:37:55 +00:00
Robert Zaremba
c201963e41
Update x/banking and x/crisis InitChain re slow Gaia startup ( #7764 )
...
* add more logs during the initialization process
* initializtion: move profiling to the top of the startProcess function
* x/bank InitGenesis: remove k.ValidateBalance
* debug: add logs and telemetry to x/bank and x/crisis
* make x/crisis AssertInvariants optional during InitGenesis
* Add module init flags mechanism
* update changelog
* remove debug fmt.Print
* fix testutil/network/
* fix log message
* update test NewApp calls
* review changes
Co-authored-by: Aaron Craelius <aaron@regen.network>
2020-11-02 19:10:14 +00:00
Federico Kunze
4420fe2d52
ibc: remove root from verification funcs ( #7780 )
...
* ibc: remove root from verification funcs
* fix VerifyClientConsensusState
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
2020-11-02 17:16:22 +00:00
Aditya
e9801edb99
Async Ack Fixes ( #7735 )
...
* Add function to query ack proofs
* fix bugs
* fix swagger
* fix final queries
* docs and add test case
* Rename QueryUnrelayedAcks to more accurate QueryUnreceivedAcks
* Apply suggestions from code review
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
Co-authored-by: colin axnér <25233464+colin-axner@users.noreply.github.com>
* address rest of reviews
* consistent spelling
Co-authored-by: Jack Zampolin <jack.zampolin@gmail.com>
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
Co-authored-by: colin axnér <25233464+colin-axner@users.noreply.github.com>
2020-11-02 15:13:48 +00:00
yihuang
aff88bbe99
Fix #7640 : tally calculation precision error ( #7641 )
...
Solution:
- change `(a / b) * c` to `a * b / c`
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
2020-11-02 14:50:33 +00:00
Aditya
88e4acac6b
Don't claim channel capability on crossing hellos ( #7763 )
...
* don't claim capability on crossing hellos
* clarify comment
2020-11-02 14:32:32 +00:00
Amaury Martiny
194d2aa196
Fix fetch txs by height on legacy REST endpoint ( #7730 )
...
* Add test
* Fix potential flakiness in sequence
* Remove test with ?height
* Fix test
* Fix tests
Co-authored-by: Aleksandr Bezobchuk <alexanderbez@users.noreply.github.com>
Co-authored-by: Zaki Manian <zaki@manian.org>
Co-authored-by: Aaron Craelius <aaron@regen.network>
Co-authored-by: Aaron Craelius <aaronc@users.noreply.github.com>
2020-11-02 11:52:52 +00:00
Marie Gauthier
bd6c16b462
Handle ServiceMsg in StdTxBuilder.SetMsgs ( #7731 )
...
* Handle ServiceMsg in StdTxBuilder.SetMsgs
* Add test
2020-10-30 15:27:12 +00:00
antstalepresh
5a082584c9
Remove Div operation on tally() considering sum(Weight)=1
2020-10-30 23:28:34 +10:00
antstalepresh
73c757dc4f
refactor SubVote to WeightedVoteOption && add utility for NewNonSplitVoteOption
2020-10-30 23:14:39 +10:00
Amaury Martiny
1961935fc7
Add GetTx gRPC endpoint ( #7688 )
...
* Add empty TxByHash
* Fix search & replace
* Renname to GetTx
* Make getTx grpc work
* Hash as string
* Add todo comment
* /tx
* Make tests pass
* Put into function
* Add changelog
* Fix lint
* RegisterTxService in server
* Remove comment
* Update proto/cosmos/tx/v1beta1/service.proto
Co-authored-by: Cory <cjlevinson@gmail.com>
* Create new protoCdc
* Move tx service to x/auth
* Small tweaks
* Link gh issue
* Fix lint
* Update x/auth/tx/service.go
Co-authored-by: Aleksandr Bezobchuk <alexanderbez@users.noreply.github.com>
Co-authored-by: Cory <cjlevinson@gmail.com>
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
Co-authored-by: Aleksandr Bezobchuk <alexanderbez@users.noreply.github.com>
Co-authored-by: SaReN <sahithnarahari@gmail.com>
2020-10-30 12:32:02 +00:00
Jack Zampolin
b2bc32f3c9
Add function to query ack proofs ( #7732 )
...
* Add function to query ack proofs
* Fix compilation issue
Co-authored-by: Aditya <adityasripal@gmail.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
2020-10-29 22:19:01 +00:00
antstalepresh
a59ac3e31a
fix integration and rest test
2020-10-29 23:52:21 +10:00
antstalepresh
b3d86e1a8d
update msg vote validate basic and test
2020-10-29 22:43:08 +10:00
colin axnér
1a15713289
remove proof path from IBC queries ( #7725 )
...
* remove proof path
* make proto-all with old install
* fix build
2020-10-29 12:42:12 +00:00
antstalepresh
e7d3549068
fix lint issues
2020-10-29 22:30:42 +10:00
antstalepresh
7e87b5d998
add cli, grpc, keeper test for new split vote
2020-10-29 22:24:55 +10:00
Aditya
b7b925a1ac
Sort validators like tendermint in HistoricalInfo ( #7691 )
...
* sort validators like tendermint
* address comments
* switch ordering in tests
* change sort logic in error case
* don't change test validators array order
Co-authored-by: Jack Zampolin <jack.zampolin@gmail.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
2020-10-29 12:17:37 +00:00
Cory
536eb689dc
Add Deprecation headers for legacy rest endpoints ( #7686 )
...
* add deprecation headers for legacy rest endpoints
* add deprecation headers for missing tx routes
* rm handler-level deprecation headers
* switch to middleware Route.Use method for setting deprecation Headers
* set deprecation headers using subrouter
* cleanup gofmt
* goimports
* Update client/rest/rest.go
* update deprecation headers to be set on each module individually
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
2020-10-29 11:37:46 +00:00
antstalepresh
0cb2c70b4d
add subvotes parser from string
2020-10-29 19:26:51 +10:00
Amaury Martiny
82f15f306e
RegisterInterfaces registers service Msg type_urls ( #7671 )
...
* Add RegisterMsgServiceDesc
* Refactor newSendTxMsgServiceCmd
* Add test
* Register in all modules
* Remove RegisterMsgServiceDesc from baseapp
* Add explicit error message
* Add comment
* Update comment
* Add test
* Update comment
* Remove duplicate import
* Fix lint
* Forgot vesting
* Fix lint
* Fix test
* Put in types/module
* Put in types/msgservice
* Add comment about panic
* Update baseapp/msg_service_router.go
Co-authored-by: Robert Zaremba <robert@zaremba.ch>
* Update baseapp/msg_service_router.go
Co-authored-by: Robert Zaremba <robert@zaremba.ch>
* Update baseapp/msg_service_router.go
Co-authored-by: Robert Zaremba <robert@zaremba.ch>
* Add comment
* Add better test
* Update baseapp/msg_service_router.go
Co-authored-by: Marie Gauthier <marie.gauthier63@gmail.com>
Co-authored-by: Robert Zaremba <robert@zaremba.ch>
Co-authored-by: Marie Gauthier <marie.gauthier63@gmail.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
2020-10-28 19:20:45 +00:00
Federico Kunze
1b0d6540d8
ibc: internal audit part 1 ( #7704 )
...
* ibc: internal audit part 1
* Update x/ibc/core/02-client/keeper/client.go
* gofmt
* fix tests
Co-authored-by: colin axnér <25233464+colin-axner@users.noreply.github.com>
Co-authored-by: Colin Axner <colinaxner@berkeley.edu>
2020-10-28 15:57:48 +00:00
antstalepresh
c504784489
Fix build errors and tests after struct modification
2020-10-28 22:05:35 +10:00
Anil Kumar Kammari
51ac6f876b
Rename RegisterGRPCRoutes ( #7696 )
...
* Rename
* Fix missing
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
2020-10-28 11:39:49 +00:00
yihuang
afb6771726
fix inconsistent flag names in upgrade proposal command ( #7697 )
...
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
2020-10-28 10:41:55 +00:00
Robert Zaremba
bd9af94174
Use embedded lib key type in sdk pub keys instead of bytes. ( #7672 )
...
* Remove duplicate print message on keys add command (#7654 )
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
* ed25519: use stdlib/crypto types
* use standard package testing
* use crypto/ed25519 instead of golang.org/x/crypto/ed25519
In Go 1.13 the new crypto/ed25519 package implements the Ed25519 signature scheme.
This functionality was previously provided by the golang.org/x/crypto/ed25519 package,
which becomes a wrapper for crypto/ed25519 when used with Go 1.13+.
* use standard package testing for secp256k1 tests
* secp256k1: add cross packages signature checks
* ed25519: rollback the _test package name
* rename underlyingSecp256k1 to btcSecp256k1
* package update
Co-authored-by: Denis Fadeev <denis@fadeev.org>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
2020-10-28 10:24:41 +00:00
Federico Kunze
426d195387
ibc: Connection Version changed from string to proto definition ( #7644 )
...
* ibc: Version to proto Any
* change version string to struct
* various version fixes
* fix build
* reorder code
* update spec
* rename to ProtoVersionsToExported and ExportedVersionsToProto
Co-authored-by: Colin Axner <colinaxner@berkeley.edu>
Co-authored-by: colin axnér <25233464+colin-axner@users.noreply.github.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
2020-10-28 09:41:54 +00:00
colin axnér
e306a852ff
update core IBC docs ( #7560 )
...
* update state
* add empty concept fields, update callbacks and messages
* update client creation, update and upgrade section
* add packet lifecycle concepts
* add host and proof section
* add connection handshake section
* add channel handshakes
* state transitions
* self review fixes
* Apply suggestions from code review
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
* apply @fedekunze review suggestions
* packet data section
* Apply suggestions from code review
Co-authored-by: Christopher Goes <cwgoes@pluranimity.org>
* add @cwgoes and @fedekunze review suggestions
* fix typos
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
Co-authored-by: Christopher Goes <cwgoes@pluranimity.org>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
2020-10-27 14:51:47 +00:00
colin axnér
3d46c672f6
Fix Optimistic Channel Handshake bugs ( #7678 )
...
* fix optimistic handshake bugs and add crossing hello test
* fix tests
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
2020-10-27 14:34:25 +00:00
Federico Kunze
7ccd2675d7
ibc: refactor proto files ( #7689 )
...
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
2020-10-27 14:14:07 +00:00
Jack Zampolin
9befc6ced8
Wrap ProtoCodec in interface ( #7637 )
...
* WIP encoding change
* Add test that describes issue
* WIP debugging
* remove extra code
* Update codec/proto_codec.go
Co-authored-by: colin axnér <25233464+colin-axner@users.noreply.github.com>
2020-10-27 13:53:54 +00:00
antstalepresh
09a282dda3
basic migration for SubVote type
2020-10-27 21:50:11 +10:00
Aditya
48c72230f0
Create separate Write-Ack Event ( #7683 )
...
* use separate type for write ack
* change event-type
Co-authored-by: Christopher Goes <cwgoes@pluranimity.org>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
2020-10-27 11:48:28 +00:00
Robert Zaremba
9bd42ace6b
simapp: rename MakeEncodingConfig to MakeTestEncodingConfig ( #7681 )
...
* simapp: rename MakeEncodingConfig to MakeTestEncodingConfig
* Updating the Changelog
+ Adding DEPRECATED attribute.
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
2020-10-27 11:33:48 +00:00
antstalepresh
da0c3910a3
modify vote type on proto
2020-10-27 19:23:15 +10:00
colin axnér
e4378e747d
IBC: panic on GetSignBytes and remove SubModuleCdc ( #7645 )
...
* panic on GetSignBytes and remove SubModuleCdc where possible
* fix build
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
2020-10-23 17:14:12 +00:00
colin axnér
c6cbe3a3db
Fix IBC Query cmds ( #7648 )
...
* fix query
* update comment
2020-10-23 16:31:32 +00:00
Robert Zaremba
6bc8ff2dfe
Use any as validator pubkey ( #7597 )
...
* protobuf pubkey type update
* wip2
* wip3
* solving types.NewValidator issues
* remove bech32 from validator type assignment
* update Validator interface
* Changelog update
* wip4
* update genutil
* fix simapp & x/ibc/testing tests
* update staking
* changelog update
* fix import cycle in tests
* fix amino panic on TestValidatorMarshalUnmarshalJSON
* fix TestValidatorMarshalUnmarshalJSON consensus_pubkey check
* Add UnpackInterfaces to HistoricalInfo
* fix TestHistoricalInfo
* update todos
* fix: Expecting ed25519.PubKey to implement proto.Message
* fix linter issues
* Fix migrate test
* Update CHANGELOG.md
Co-authored-by: Marie Gauthier <marie.gauthier63@gmail.com>
* review comments
* cosmetic changes
* add UnpackInterfaces got GenesisRandomized test
* Validator.Equal reuses Validator.MinEqual
* fix test
* use Validator.Equal in tests
* Fix staking simulation TestRandomizedGenState
* Remove TODO
* use HistoricalInfo.Equal
* use proto.Equal
* rename Validator.GetConsPubKey to TmConsPubKey
* prefer require.Equal over reflect.DeepEqual
* SetHistoricalInfo using a pointer
* Fix TestQueryDelegation test
* Fix TestQueryValidators test
* Fix TestSimulateMsgUnjail test
* experiement with LegacyAmino instances
* Register codecs in all simapp tests
* Fix cli_test compilation problems
* fix typo sdk -> std
* fix typo
* fix TestPlanStringer
* Rename to MakeEncodingConfig
* Remove RegisterCodecsTests
* Use gRPC in GetCmdQueryValidators
* Empty status
* fix info log check
* linter fixes
* rename simapparams to simappparams
* Update simapp/test_helpers.go
Co-authored-by: Marie Gauthier <marie.gauthier63@gmail.com>
* comments updates
* use valAddr1 instead of sdk.ValAddress(pk1.Address().Bytes())
Co-authored-by: Cory Levinson <cjlevinson@gmail.com>
Co-authored-by: Amaury Martiny <amaury.martiny@protonmail.com>
Co-authored-by: Marie Gauthier <marie.gauthier63@gmail.com>
2020-10-23 12:07:52 +00:00
yys
1542ecb18d
Bugfix gov votes querier to use votes params ( #7589 )
...
* bugfix gov votes querier to use votes params
* move partially used statement to the proper block
Co-authored-by: Aleksandr Bezobchuk <alexanderbez@users.noreply.github.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
2020-10-20 17:35:44 +00:00
Amaury Martiny
3c43370d0c
Add CommunitySpendProposals in migration ( #7607 )
...
* Add CommunitySpendProposals in migration
* Fix lint
* Avoid double registration
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
2020-10-20 13:19:04 +00:00
atheeshp
155a6ad7fd
Refactor x/ibc to ADR 031 ( #7576 )
...
* WIP: Refactor x/ibc to ADR 031
* updated handler
* removed unsued
* fix
* Add proto service for ibc/transfer
* lint
* remove old upgrade handler
* added doc
* review changes
* fix tests
* formatter
* Add MsgServer wiring in RegisterServices
Co-authored-by: Aaron Craelius <aaronc@users.noreply.github.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
2020-10-19 18:21:53 +00:00
Marie Gauthier
eba4c8a264
Handle nil *Any in UnpackAny and add panic handler for tx decoding ( #7594 )
...
* Handle nil any in UnpackAny
* Add test
* Add flag back
* Update runTx signature
* Update Simulate signature
* Update calls to Simulate
* Add txEncoder in baseapp
* Fix TestTxWithoutPublicKey
* Wrap errors
* Use amino in baseapp tests
* Add txEncoder arg to Check & Deliver
* Fix gas in test
* Fix remaining base app tests
* Rename to amionTxEncoder
* Update codec/types/interface_registry.go
Co-authored-by: Aaron Craelius <aaron@regen.network>
* golangci-lint fix
Co-authored-by: Amaury Martiny <amaury.martiny@protonmail.com>
Co-authored-by: Aaron Craelius <aaron@regen.network>
Co-authored-by: Cory Levinson <cjlevinson@gmail.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
2020-10-19 18:04:44 +00:00
Aaron Craelius
9e7eb0da00
Add MsgServer to Configurator for ADR 031 wiring ( #7584 )
...
* Add MsgServer to Configurator for ADR 031 wiring
* Add docs, wire up evidence & staking
* Add integration test
* Add comments
* Doc strings
* Update types/module/configurator.go
Co-authored-by: Aleksandr Bezobchuk <alexanderbez@users.noreply.github.com>
* Update types/module/configurator.go
Co-authored-by: Cory <cjlevinson@gmail.com>
* Wire up vesting
* Update CHANGELOG.md
Co-authored-by: Aleksandr Bezobchuk <alexanderbez@users.noreply.github.com>
Co-authored-by: Amaury Martiny <amaury.martiny@protonmail.com>
Co-authored-by: Cory <cjlevinson@gmail.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
2020-10-19 17:46:10 +00:00
Jun Kimura
ba2799ec6d
fix sequence checks in solomachine ( #7586 )
...
Co-authored-by: colin axnér <25233464+colin-axner@users.noreply.github.com>
2020-10-19 13:35:52 +00:00
Robert Zaremba
8eaf2ececc
Refactor x/staking Validation and Delegation tests based on MsgCreateValidator.Pubkey type change. ( #7526 )
...
* testing: refactore Validation and Delegation handling of x/staking
This Changeset introduces set of improvements for writing tests.
The idea is to create a testing subpackage which will provide functions
to make tests more dev-friendly and wrap higher level use-cases.
Here is a show-up of of creating a service for staking module
for tests.
This PR also changes the `x/staking/types.MsgCreateValidator.Pubkey` from string
to types.Any. This change motivated the other change to show the pattern I'm describing here.
* add validator checks
* type change fixes
* use deprecated
* adding test slashing
* new network comment update
* working on tests
* Fix TestMsgPkDecode test
* Add UnpackInterfaces to MsgCreateValidator
* Fix tests
* Convert bech32 pubkey to proto
* Fix test
* fix v039/migrate_test/TestMigrate
* fix tests
* testslashing: rename Service to Helper
* file rename
* update TestMsgDecode
Co-authored-by: blushi <marie.gauthier63@gmail.com>
Co-authored-by: Amaury Martiny <amaury.martiny@protonmail.com>
Co-authored-by: Cory Levinson <cjlevinson@gmail.com>
2020-10-19 13:04:55 +00:00
colin axnér
0f8fdf60df
Remove ClientType func and update consensus state path ( #7573 )
...
* update paths and remove unused func
* fix bug
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
Co-authored-by: Christopher Goes <cwgoes@pluranimity.org>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
2020-10-19 09:59:31 +00:00
colin axnér
6fa73998bd
Fix solomachine cmds ( #7581 )
...
* fix solo machine cli cmds
* polish
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
2020-10-19 09:40:29 +00:00
Cory
8138605aed
Refactor x/auth/vesting to use ADR-031 ( #7551 )
...
* update auth/vesting module to use proto msg services
* rm accidental tmp files
* Update x/auth/vesting/msg_server.go
Co-authored-by: Marie Gauthier <marie.gauthier63@gmail.com>
* golangci-lint fix
Co-authored-by: Marie Gauthier <marie.gauthier63@gmail.com>
Co-authored-by: Aaron Craelius <aaron@regen.network>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
2020-10-19 09:22:56 +00:00
colin axnér
c40f3d02a0
remove id in localhost ( #7577 )
...
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
Co-authored-by: Christopher Goes <cwgoes@pluranimity.org>
2020-10-17 21:05:26 +00:00
Amaury Martiny
58eabcb71f
Refactor x/evidence to ADR-031 ( #7538 )
...
* Refactor x/evidence to ADR-031
* Add hash in response
* Update changelog
* Update x/evidence/keeper/keeper.go
* Update proto/cosmos/evidence/v1beta1/tx.proto
Co-authored-by: Marie Gauthier <marie.gauthier63@gmail.com>
* Use msgServer struct
Co-authored-by: Marie Gauthier <marie.gauthier63@gmail.com>
2020-10-16 16:05:25 +00:00
atheeshp
18ef33caff
Refactor x/staking according to ADR 031 ( #7556 )
...
* Refactor x/staking according to ADR 031
* lint
* review changes
* review changes
* review changes
Co-authored-by: Aaron Craelius <aaron@regen.network>
2020-10-16 14:53:49 +00:00
atheeshp
6e569e1255
Refactor x/{gov, crisis} according to ADR 031 ( #7533 )
...
* Refactor x/gov according to ADR 31
* fix tests
* Refactor x/crisis according to ADR 031
* fix lint
* lint
* lint
* review changes
* lint
* review change
* fic doc
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
2020-10-16 13:04:02 +00:00
Amaury Martiny
69e2b7df16
docs: Revert SPEC-SPEC and update x/{auth,bank,evidence,slashing} ( #7407 )
...
* Revert some changes from #7404
* Update x/slashing
* Address review comments
* Small tweak
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
2020-10-16 12:42:48 +00:00
colin axnér
7818867163
ibc: update solo machine client command ( #7579 )
...
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
2020-10-16 09:24:48 -03:00
SaReN
332d8ec038
update upgrade query ( #7567 )
2020-10-15 19:02:45 +00:00
Zaki Manian
c735a8eb81
Add the option of emitting amino encoded json from the CLI ( #7221 )
...
* Add the option of emitting amino encoded json
* Update AMINO JSON serialization with ConvertTxToStdTx
* Make the Amino flag more self documenting by serializing the BroadcastRequest type instead of StdTx
* Handle amino encoding error
* Update x/auth/client/cli/tx_multisign.go
Co-authored-by: Alessio Treglia <alessio@tendermint.com>
* Update x/auth/client/cli/tx_sign.go
Co-authored-by: Alessio Treglia <alessio@tendermint.com>
* Apply suggestions from code review
Co-authored-by: Alessio Treglia <alessio@tendermint.com>
* Fix go format
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
Co-authored-by: Alessio Treglia <alessio@tendermint.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
2020-10-15 15:12:35 +00:00
Marie Gauthier
c59a04d70f
[x/slashing] Implement Protobuf Msg Services ( #7557 )
...
* Update x/slashing to use proto msg service
* Fix proto-gen
Co-authored-by: Aaron Craelius <aaron@regen.network>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
2020-10-15 14:38:15 +00:00
Federico Kunze
503b518efc
client: add GetAccount and GetAccountWithHeight to AccountRetriever ( #7558 )
...
* client: add GetAccount and GetAccountWithHeight to AccountRetriever
* update ADR
* address comments from review
2020-10-15 14:19:57 +00:00
atheeshp
bf7165414d
Refactor x/distribution according to ADR 031 ( #7524 )
...
* Refactor x/distribution according to ADR 31
* lint
* removed unused
* Apply suggestions from code review
Co-authored-by: Marie Gauthier <marie.gauthier63@gmail.com>
Co-authored-by: Aaron Craelius <aaron@regen.network>
Co-authored-by: Marie Gauthier <marie.gauthier63@gmail.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
2020-10-15 13:54:16 +00:00
Amaury Martiny
55242a659c
Add ADR 031 BaseApp and codec infrastructure ( #7519 )
...
* Refactor RegisterQueryServices -> RegisterServices
* Cleaner proto files
* Fix tests
* Add MsgServer
* Fix lint
* Remove MsgServer from configurator for now
* Remove useless file
* Fix build
* typo
* Add router
* Fix test
* WIP
* Add router
* Remove test helper
* Add beginning of test
* Move test to simapp?
* ServiceMsg implement sdk.Msg
* Add handler by MsgServiceRouter
* Correct signature
* Add full test
* use TxEncoder
* Update baseapp/msg_service_router.go
Co-authored-by: Aaron Craelius <aaron@regen.network>
* Push changes
* WIP on ServiceMsg unpacking
* Make TestMsgService test pass
* Fix tests
* Tidying up
* Tidying up
* Tidying up
* Add JSON test
* Add comments
* Tidying
* Lint
* Register MsgRequest interface
* Rename
* Fix tests
* RegisterCustomTypeURL
* Add changelog entries
* Put in features
* Update baseapp/msg_service_router.go
Co-authored-by: Aleksandr Bezobchuk <alexanderbez@users.noreply.github.com>
* Update baseapp/msg_service_router.go
Co-authored-by: Aleksandr Bezobchuk <alexanderbez@users.noreply.github.com>
* Update baseapp/msg_service_router.go
Co-authored-by: Aleksandr Bezobchuk <alexanderbez@users.noreply.github.com>
* Update baseapp/msg_service_router.go
Co-authored-by: Aleksandr Bezobchuk <alexanderbez@users.noreply.github.com>
* Update baseapp/msg_service_router.go
Co-authored-by: Aleksandr Bezobchuk <alexanderbez@users.noreply.github.com>
* Update baseapp/msg_service_router.go
Co-authored-by: Aleksandr Bezobchuk <alexanderbez@users.noreply.github.com>
* Update baseapp/msg_service_router.go
Co-authored-by: Aleksandr Bezobchuk <alexanderbez@users.noreply.github.com>
* Address review comments
* Address nit
* Fix lint
* Update codec/types/interface_registry.go
Co-authored-by: Marie Gauthier <marie.gauthier63@gmail.com>
* godoc
Co-authored-by: Aaron Craelius <aaronc@users.noreply.github.com>
Co-authored-by: Aaron Craelius <aaron@regen.network>
Co-authored-by: Aleksandr Bezobchuk <alexanderbez@users.noreply.github.com>
Co-authored-by: Marie Gauthier <marie.gauthier63@gmail.com>
2020-10-15 13:07:59 +00:00
colin axnér
652d5d93bb
remove test_utils.go in tm client ( #7522 )
...
* remove test_utils from tm client
* fix build
* fix lint?
* fix lint?
* apply @fedekunze review suggestion
* add tests as per @alessio suggestion
* fix typo
2020-10-14 14:51:11 +00:00
colin axnér
3589a3c799
Fix misbehaviour handling for solo machine ( #7515 )
...
* add timestamp to SignatureAndData
Add timestamp field to signature and data. Add ValidateBasic check for timestamp. Add ValidateBasic test. Update misbehaviour handler to use supplied timestamp.
* fix typo
* add timestamp check
* fix lint
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
2020-10-13 09:02:24 -03:00
colin axnér
037a32bc91
ibc: cleanup channel types test ( #7521 )
2020-10-13 06:57:39 -03:00
Aaron Craelius
9be15a42b9
Refactor x/bank according to ADR 031 ( #7520 )
...
* Refactor x/bank according to ADR 031
* Add comment
* Update comment
* Add comment
* Add tests, address edge cases
* Imports
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
2020-10-13 09:05:46 +00:00
colin axnér
45f5df7ea5
update solo machine specs ( #7512 )
...
* update solo machine specs
* update concepts
* self review fixes
* Apply suggestions from code review
* add note on upgarding solo machines
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
2020-10-13 05:36:23 -03:00
Aaron Craelius
228728cce2
Refactor RegisterQueryServices -> RegisterServices ( #7518 )
...
* Refactor RegisterQueryServices -> RegisterServices
* Fix tests
2020-10-12 16:31:51 +00:00
Amaury Martiny
647ad0dd3c
docs: Update "Basics" section ( #7416 )
...
* Prettier
* docs: Update "Basics" section
* appcli -> appd
* Better wording
* Fix to appCodec
* Add gRPC mention
* Add grpc
* Reference simapp code
* Update docs/basics/accounts.md
Co-authored-by: Marie Gauthier <marie.gauthier63@gmail.com>
* Add section about gRPC query services
* Optional LegacyQuerierHandler
* Clearer docs
* Update docs/basics/app-anatomy.md
Co-authored-by: Marie Gauthier <marie.gauthier63@gmail.com>
* Update docs/basics/app-anatomy.md
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
* Address comments
* Address comments
* Update docs/basics/accounts.md
Co-authored-by: Marie Gauthier <marie.gauthier63@gmail.com>
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
2020-10-12 15:31:25 +00:00
Amaury Martiny
33e7297c79
Use enum instead of int32 for BondStatus ( #7499 )
...
* Migrate staking module
* Add gov legacy
* Add comments
* Add x/distrib
* x/crisis
* x/mint
* Fix test
* migrate x/genutil
* Fix lint
* Fix staking constants
* Fix test
* Update x/genutil/legacy/v040/migrate.go
Co-authored-by: Marie Gauthier <marie.gauthier63@gmail.com>
* Add migrate script instead of change BondStatus constants
* Change staking bondStatus to enum
* Fix test
* Fix another test
* Remove staking exported
* fix references
* Better constants
* Fix build
* Fix lint
* Remove buf version
* Fix tests
* Fix test
Co-authored-by: Marie Gauthier <marie.gauthier63@gmail.com>
Co-authored-by: Aleksandr Bezobchuk <alexanderbez@users.noreply.github.com>
2020-10-12 13:56:02 +00:00
Neeraj Murarka
61d5844705
Corrected 'unsafe-reset-all' help text ( #7504 )
2020-10-10 13:02:12 +02:00
Amaury Martiny
c14a3a7cb2
CLI `migrate` command follow-up: decode & re-encode ( #7464 )
...
* Migrate staking module
* Add gov legacy
* Add comments
* Add x/distrib
* x/crisis
* x/mint
* Fix test
* migrate x/genutil
* Fix lint
* Fix staking constants
* Fix test
* Update x/genutil/legacy/v040/migrate.go
Co-authored-by: Marie Gauthier <marie.gauthier63@gmail.com>
* Add migrate script instead of change BondStatus constants
* Fix test
* Fix another test
Co-authored-by: Marie Gauthier <marie.gauthier63@gmail.com>
Co-authored-by: Cory <cjlevinson@gmail.com>
2020-10-09 19:09:43 +00:00
wimel
278eaa70f8
Fix on gov module ( #7493 )
...
* Fix ISSUE #64 on cosmosdevs/stargate
* Fix ISSUE #64 on cosmosdevs/stargate
* Update x/upgrade/client/cli/tx.go
Co-authored-by: Aleksandr Bezobchuk <alexanderbez@users.noreply.github.com>
2020-10-09 16:28:58 +00:00
Federico Kunze
c39dd9eb38
ibc: metrics ( #7441 )
...
* ibc transfer metrics
* ibc client metrics
* update connection logs
* connection metrics
* channel metrics
* update logs
* docs updates
* update telemetry.md
* move calls from handler
* Update x/ibc/core/04-channel/keeper/handshake.go
Co-authored-by: colin axnér <25233464+colin-axner@users.noreply.github.com>
* add chain-id metric
* address @colin-axner comments
Co-authored-by: colin axnér <25233464+colin-axner@users.noreply.github.com>
Co-authored-by: Christopher Goes <cwgoes@pluranimity.org>
2020-10-08 12:37:20 +00:00
colin axnér
ac9aebf4af
rename epoch to version ( #7483 )
...
* rename epoch to version
* Apply suggestions from code review
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
2020-10-08 12:03:47 +00:00
Emmanuel T Odeke
d2b914781b
x/genutil: fix CollectTxs traversal logic ( #6913 )
...
* x/genutil: fix CollectTxs traversal logic
Fixes the file traversal of CollectTxs to correctly skip over
directories instead of trying to read them, failing and erroring
out.
Also while here, changed the order to perform the os read
only after the AppState UnmarshalJSON has succeeded, otherwise
an attack vector can be to purposefully request many file stats
which touches kernel resources, while just causing failures
indefinitely.
Fixes #6788
* address comments
* Fix test by passing in blank AppState
Co-authored-by: Alexander Bezobchuk <alexanderbez@users.noreply.github.com>
Co-authored-by: SaReN <sahithnarahari@gmail.com>
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
Co-authored-by: Federico Kunze <federico.kunze94@gmail.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
2020-10-08 11:22:39 +00:00
colin axnér
dd84c8bd56
add ConsensusParams to ClientState ( #7456 )
...
* add ConsensusParams to ClientState
* validate self consensu params using context + tests
* fix tests
* remove test
* Update proto/ibc/lightclients/tendermint/v1/tendermint.proto
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
* add tests for nil consensus params
* use default consensus params variable housed in the testing pkg
* set consensus params in get context call
* disallow nil consensus params
* disallow nil consensus state + fixes
* remove comments
* make proto
* fix build
* fix build
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
2020-10-08 11:01:55 +00:00
Amaury Martiny
87e3751f5c
Update TM to latest (+add test) ( #7442 )
...
* Add test for /block_results
* Fix test
* Use http RPC client
* Fix temporarily block_results
* Use init
* Add flag back
* Remove init
* Update TM master
* Address comments
* Fix build
* require refactor
* Add build flag back
* More timeout on test
* fix timeout-minutes
Co-authored-by: Aaron Craelius <aaron@regen.network>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
2020-10-08 12:44:11 +02:00
Aditya
31ab35ad72
UpgradeClient Followup #1 ( #7457 )
...
* require old chain halts before upgrade
* Update proto/ibc/core/client/v1/client.proto
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
* start address reviews
* Apply suggestions from code review
Co-authored-by: colin axnér <25233464+colin-axner@users.noreply.github.com>
* address reviews
* rework upgrade to ensure there is never more than one upgrade client in store
* fix tests
* fix conditional
* make proto-gen
* remove if statement skipping tests in upgrade keeper test
* address reviews
* correctly escape and unescape merkle keys
* add small conditional check
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
Co-authored-by: colin axnér <25233464+colin-axner@users.noreply.github.com>
Co-authored-by: Colin Axner <colinaxner@berkeley.edu>
2020-10-08 09:22:22 +00:00
Aditya
bb6b0cf95b
Upgrade followup #3 ( #7467 )
...
* prevent upgrades if client is expired
* fix test
2020-10-07 08:51:56 +00:00
Amaury Martiny
090bae567b
Use nil instead of protobuf.Empty in genesis BaseAccount ( #7463 )
...
* Use nil instead of protobuf.Empty in genesis
* Fix tests
2020-10-06 16:07:37 +00:00
Aditya
c9cb02ea98
Upgrade-Client Followup #2 ( #7460 )
...
* enforce client-chosen parameters are persisted across upgrades in tendermint clients
* Update x/ibc/light-clients/07-tendermint/types/upgrade.go
Co-authored-by: colin axnér <25233464+colin-axner@users.noreply.github.com>
2020-10-06 09:49:15 +00:00
Aaron Craelius
4a1b2fba43
Add Fee granter field ( #7418 )
...
* WIP on adding Fee granter field
* WIP on adding Fee granter field
* WIP on adding Fee granter field
* Update comments, add tests
2020-10-05 21:56:09 +00:00
Amaury Martiny
d9ede6551a
0.39->0.40 CLI `migrate` command ( #6839 )
...
* WIP on BaseAccount protobuf pub_key
* WIP on BaseAccount.PubKey
* Migrate supply
* Change validator_slash_event
* Add evidence
* Add evidence to genutil migrate
* Fix lint
* Add println
* No _ in package name
* Add slashing migrate
* Add tests for slashing
* Add capacity to array
* stray fmt.Prinlnt
* WIP on BaseAccount pub key
* Put current types in v0_40
* Add evidence old types
* Remove useless impl
* Add RegisterInterface
* Add clientCtx to argument
* Register evidence interfaces
* Update PubKey
* Update Account
* Docs
* WIP on protobuf keys
* Use Type() and Bytes() in sr25519 pub key Equals
* Add tests
* Add few more tests
* Update other pub/priv key types Equals
* Fix PrivKey's Sign method
* Rename variables in tests
* Fix infinite recursive calls
* Use tm ed25519 keys
* Add Sign and VerifySignature tests
* Remove ed25519 and sr25519 references
* proto linting
* Add proto crypto file
* Implement some of the new multisig proto type methods
* Add tests for MultisigThresholdPubKey
* Add tests for pubkey pb/amino conversion functions
* Move crypto types.go and register new proto pubkeys
* Add missing pointer ref
* Address review comments
* panic in MultisigThresholdPubKey VerifySignature
* Fix compile errors
* Remove pk conversion in ante handler
* Use internal crypto.PubKey in multisig
* Add tests for MultisigThresholdPubKey VerifyMultisignature
* Only keep LegacyAminoMultisigThresholdPubKey and move to proto keys to v1
* Remove conversion functions and introduce internal PubKey type
* Override Amino marshaling for proto pubkeys
* Merge master
* Make proto-gen
* Start removal of old PubKeyMultisigThreshold references
* Fix tests
* Fix solomachine
* Fix ante handler tests
* Pull latest go-amino
* Remove ed25519
* Remove old secp256k1 PubKey and PrivKey
* Uncomment test case
* Fix linting issues
* More linting
* Revert tests keys values
* Add Amino overrides to proto keys
* Add pubkey test
* Fix tests
* Use threshold isntead of K
* Standardize Type
* Revert standardize types commit
* Fix build
* Fix lint
* Fix lint
* Add comment
* Register crypto.PubKey
* Add empty key in BuildSimTx
* Simplify proto names
* Unpack interfaces for signing desc
* Fix IBC tests?
* Format proto
* Use secp256k1 in ibc
* Fixed merge issues
* Uncomment tests
* Update x/ibc/testing/solomachine.go
* UnpackInterfaces for solomachine types
* Remove old multisig
* Add amino marshal for multisig
* Fix lint
* Correctly register amino
* One test left!
* Remove old struct
* Fix test
* Fix test
* Unpack into tmcrypto
* Remove old threshold pubkey tests
* Fix register amino
* Fix lint
* Use sdk crypto PubKey in multisig UnpackInterfaces
* Potential fix?
* Register LegacyAminoPubKey
* Register our own PubKey
* Register tmcrypto PubKey
* Register both PubKeys
* Register interfaces in test
* Refactor fiels
* Add comments
* Remove old cosmos-sdk/crypto/keys reference
* Use anil's suggestion
* Add norace back
* Use our own ed25519
* Fix pubkey types
* Fix network tests
* Fix more tests
* Make ibc work?
* Use TM pubkey in NewValidator
* Fix lint
* Put interface in tpyes
* rerun CI
* Better name register
* Remove stray code
* Add ed25519 tests
* Check nil
* Correct interface impl assert
* rerun CI
* Add fix for Bech32
* Address comments
* FIx lint
* Add tests for solomachine unpack interfaces
* Fix query tx by hash
* Better name in amino register
* Fix lint
* Add back ed25519 test (fixes #7352 )
* go mod tidy
* Fix merge issues
* Sort import
* Add test for backwards-compatibility
* Fix tests
* Fix merge issue
* Fix merge issues
* Fix tests build
* Fix tests
* Marshal to proto
* Fix 040 marshalling
* Remove dontcover
* Fix equivocation
* Add vesting
* Fix vesting
* Fix slashing test
* Fix evidence test
* Remove pb.go files
* Fix legacy auth tests
* deterministic tests help
* Fix auth tests
* Remove useless code
* Small cleanups
* Add comment
* Fix migrate hub
* fmt.Println
* No need to marshal indent
* Update proto comment
* Fix merge issues
* Support nil pubkey
* Use protobuf empty
* Address comments
* Fix tests
* Unify legacy package names
Co-authored-by: Aaron Craelius <aaronc@users.noreply.github.com>
Co-authored-by: Aaron Craelius <aaron@regen.network>
Co-authored-by: blushi <marie.gauthier63@gmail.com>
Co-authored-by: Alexander Bezobchuk <alexanderbez@users.noreply.github.com>
Co-authored-by: colin axnér <25233464+colin-axner@users.noreply.github.com>
Co-authored-by: Zaki Manian <zaki@manian.org>
Co-authored-by: Alessio Treglia <alessio@tendermint.com>
2020-10-05 21:28:14 +00:00
colin axnér
6fa8330c31
Flexible handshake followup ( #7454 )
...
* rename provedID
rename provedID to counterpartyChosenID for connection and channel. Update if statement in handshake and tests. Ref: https://github.com/cosmos/cosmos-sdk/pull/7439#discussion_r498858944
* update docs
Co-authored-by: Christopher Goes <cwgoes@pluranimity.org>
2020-10-05 14:48:04 +00:00
colin axnér
a84f4fb3d5
rename signature to signature data ( #7455 )
...
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
2020-10-05 14:32:26 +00:00
colin axnér
0047099061
ibc: flexible channel handshake selection ( #7439 )
...
* update channel handshake
Add ProvedID to ChanOpenTry which allows for flexible handshake identifier selection. Add CounterpartyChannelID to OpenAck. Update and add to handshake tests. Modify msgs_test. Counterparty ValidateBasic will return nil on an empty channel identifier to allow for flexible handshake identifier selection to succeed.
* Update x/ibc/core/04-channel/keeper/handshake.go
* add conn open init docs
* update docs for conn open try and conn open ack
* update channel docs
2020-10-02 16:17:00 -03:00
Federico Kunze
82c9ae3949
LGTM alerts audit ( #7440 )
...
* LGTM alerts audit
* Update x/simulation/mock_tendermint.go
Co-authored-by: Alessio Treglia <alessio@tendermint.com>
* Update x/staking/keeper/delegation.go
Co-authored-by: Alessio Treglia <alessio@tendermint.com>
* comment false positive
Co-authored-by: Alessio Treglia <alessio@tendermint.com>
2020-10-02 15:13:58 +02:00
Federico Kunze
2c93ec7a0c
ibc: core restructure ( #7434 )
...
* ibc: protobuf v1
* update codec
* core client
* core connection
* core host
* core commitment
* core port
* core channel
* core ibc module files
* core exported
* core types & simulation
* core spec
* make proto-all
* ibc alias
2020-10-02 06:03:02 -03:00
colin axnér
432ba30bed
Flexible Connection Handshake Selection ( #7427 )
...
* update connopeninit
Update ConnOpenInit to reflect changes in https://github.com/cosmos/ics/pull/482 . An additional version field is added to the connection handshake and connection open init message to take in an optional field. If this field is empty, then the default versions are used for connection handshake version negotiation.
* add version compatibility check in open init
* implement partial changes to conn open try
* partial implementation of conn open ack changes
* fix tests
* add handshake tests
* make proto
* fix conflicts
* fix lint
* fix lint
* increase code cov
Co-authored-by: Federico Kunze <federico.kunze94@gmail.com>
2020-10-01 22:28:15 +00:00
Federico Kunze
53f8aec857
ibc: protobuf v1 ( #7432 )
...
* ibc: protobuf v1
* update codec
2020-10-01 19:23:29 +00:00
Federico Kunze
92ffed01bb
ibc: applications restructure ( #7425 )
...
* ibc: applications refactor
* update proto files
* try fix castrepeated
* fix proto
* update spec
Co-authored-by: colin axnér <25233464+colin-axner@users.noreply.github.com>
2020-10-01 15:32:53 +00:00
Federico Kunze
72353902e2
ibc: rename epoch -> version ( #7429 )
...
* ibc: rename epoch -> version
* more renaming
* update spec
2020-10-01 15:08:26 +00:00
colin axnér
a32e2a03ae
Enforce solo machine signature type uniqueness ( #7394 )
...
* update solo machine proto types to use enum for uniqueness
* move data type to SignatureAndData
Adjusts SignatureAndData proto definition to take in a DataType. Updates misbehaviour basic validation to do checks on the data type. Adds unmarshaling tests.
* split signature bytes creation to allow for function reusing. Stuck on strange error on testing codec.go
* fix test bug
* update UnmarshalByType and refactor misbehaviour handle
Rename CanUnmarshalDataByType -> UnmarshalDataByType. Return a new interface and error. Refactor tests to work. Refactor misbehaviour_handle.go to check unmarshaling of the data and DRY code by separating signature and data checks into its own function. Update godoc.
* add tests to codec_test.go
* self review + lint
* update spec
* fix lint
* Update x/ibc/light-clients/solomachine/spec/01_concepts.md
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
* increase code cov, update spec
apply most of @fedekunze comments.
* format spec
* make proto
* fix merge conflicts
* make proto
* fix conflicts
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
Co-authored-by: Federico Kunze <federico.kunze94@gmail.com>
2020-10-01 11:40:35 +00:00
Federico Kunze
dcf3b54ca1
ibc: async acknowledgements ( #7361 )
...
* rename packet ack abs
* update packet executed
* write ack
* update clients
* update transfer keeper
* changes from reviews
* rename ReceiveExecuted -> WriteReceipt
* tests
* fix tests
* Apply suggestions from code review
Co-authored-by: colin axnér <25233464+colin-axner@users.noreply.github.com>
* Update x/ibc/07-tendermint/types/client_state_test.go
Co-authored-by: Aditya <adityasripal@gmail.com>
* comments from review
* update RecvPacket
* spec typo
* test fixes
Co-authored-by: colin axnér <25233464+colin-axner@users.noreply.github.com>
Co-authored-by: Aditya <adityasripal@gmail.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
2020-10-01 10:25:50 +00:00
Federico Kunze
52a0b6d899
ibc: light clients restructure ( #7408 )
...
* ibc: light clients restructure
* tendermint client cleanup
* solomachine cleanup
* rename
* add cli
* update spec README
* proto files update
* fix
* update proto files
* fix test build
* fix test build
2020-10-01 06:38:53 -03:00
Aditya
01fd22d244
ibc: upgrade client ( #7367 )
...
* implement upgrade module changes
* implement client changes
* implement core tendermint logic
* remove assumption that new client state has same structure as old
* fix light client builds
* fix rest of build
* fix tendermint tests
* fix all tests except MarshalJSON
* fix, marshalUpgrade fails
* Apply suggestions from code review
* minor updates
* update proto and validate path
* fix MarshalJSON panic
* hack my way to first passing test case
* add rest of upgrade test cases
* fix plan tests
* add keeper tests
* fix upgrade tests
* add more tests
* add upgrade path validation to ValidateSelfClient
* validate upgradedClient
* fix upgrade handler tests
* appease linter
* Apply suggestions from code review
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
* change signer to string in proto
* lint
* start address @colin-axner review
* improve test coverage
* fix abci stringer test
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
Co-authored-by: Federico Kunze <federico.kunze94@gmail.com>
2020-10-01 03:21:57 -03:00
Ethan Frey
d917520092
Add fee payer to protobuf definition ( #7384 )
...
* Add fee payer to protobuf definition
* Compile new tx type
* Use FeePayer from Tx, add it to required signers
* Add unit tests on proper handling of FeePayer field
* Use string address for fee payer field
* Update logic for string feePayer
2020-09-30 09:03:44 +00:00
Marie Gauthier
489599b70f
Remove the old message PublicKey proto oneof ( #7390 )
...
* Remove unused PublicKey type and update docs
* Update wording
* Update proto/cosmos/base/crypto/v1beta1/crypto.proto
Co-authored-by: Amaury Martiny <amaury.martiny@protonmail.com>
* Edit docs
* Move crypto.proto to multisig
* Proto linting
* Update docs/architecture/adr-020-protobuf-transaction-encoding.md
Co-authored-by: Amaury Martiny <amaury.martiny@protonmail.com>
* Update wording for Public Key Encoding
Co-authored-by: Amaury Martiny <amaury.martiny@protonmail.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Co-authored-by: Robert Zaremba <robert@zaremba.ch>
2020-09-29 10:01:54 +00:00
Amaury Martiny
e17dd4fd50
Update SPEC-SPEC & documentation for x/{bank,evidence} ( #7404 )
...
* Update documentation for x/bank
* Update ModuleAccounts
* Put contets on top
* Update comments
* Do x/evidence
* Add ValidatorEvidence
* Update SPEC-SPEC
* Update anchor
2020-09-28 13:51:14 -03:00
colin axnér
be59020f29
Add multisig support + tests to solo machine ( #7383 )
...
* add multisig support to testing pkg
Adds single and multisig public key support to the testing package. Fix build associated with changes.
* update clientstate tests to use singlesig and multsig
* add singlesig and multisig tests for consensus state, header, and misbehaviour
* add singlesig and multisig for solomachine handlers
* add spec
* fix lgtm
* fixes from self review
* fix lint?
* fix build
* increase code cov
* Update x/ibc/light-clients/solomachine/types/client_state.go
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
* apply @fedekunze review suggestions
Add comment to VerifyMultisignature explaining why it uses the nested function. Switch panic to require. Add comment for secp256k1 key usage. Ref: https://github.com/cosmos/cosmos-sdk/pull/7383#pullrequestreview-496591518
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
Co-authored-by: Christopher Goes <cwgoes@pluranimity.org>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
2020-09-28 11:00:33 +00:00
Alessio Treglia
8601dcdbb7
types: tests -> test suites migration ( #7400 )
...
Ref #7362
2020-09-28 12:46:49 +02:00
colin axnér
2a4d0ec62c
Add solo machine timestamp check ( #7392 )
...
* add check in header updates for non decreasing timestamp
Add check in update.go that the header timestamp is non decreasing compared to the consensus state timestamp. Unit test added in update_test.go
* update error message
* update godoc
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
2020-09-25 16:22:52 +00:00
Anil Kumar Kammari
06b84d902a
remove amino from x/capability ( #7389 )
...
* remove amino from x/capability
* remove codec
2020-09-25 11:43:19 +00:00
Anil Kumar Kammari
d55c1a2665
Change `address` from bytes to bech32 strings ( #7242 )
...
* init
* Fix bank proto messages
* missing conversions
* remove casttype for addresses
* Fix tests
* Fix consaddress
* more test fixes
* Fix tests
* fixed tests
* migrate missing proto declarations
* format
* Fix format
* Fix alignment
* Fix more tests
* Fix ibc merge issue
* Fix fmt
* Fix more tests
* Fix missing address declarations
* Fix staking tests
* Fix more tests
* Fix config
* fixed tests
* Fix more tests
* Update staking grpc tests
* Fix merge issue
* fixed failing tests in x/distr
* fixed sim tests
* fixed failing tests
* Fix bugs
* Add logs
* fixed slashing issue
* Fix staking grpc tests
* Fix all bank tests :)
* Fix tests in distribution
* Fix more tests in distr
* Fix slashing tests
* Fix statking tests
* Fix evidence tests
* Fix gov tests
* Fix bug in create vesting account
* Fix test
* remove fmt
* fixed gov tests
* fixed x/ibc tests
* fixed x/ibc-transfer tests
* fixed staking tests
* fixed staking tests
* fixed test
* fixed distribution issue
* fix pagination test
* fmt
* lint
* fix build
* fix format
* revert tally tests
* revert tally tests
* lint
* Fix sim test
* revert
* revert
* fixed tally issue
* fix tests
* revert
* fmt
* refactor
* remove `GetAddress()`
* remove fmt
* revert fmt.Striger usage
* Fix tests
* Fix rest test
* disable interfacer lint check
* make proto-format
* add nolint rule
* remove stray println
Co-authored-by: aleem1314 <aleem.md789@gmail.com>
Co-authored-by: atheesh <atheesh@vitwit.com>
2020-09-25 10:25:37 +00:00
Marie Gauthier
91ca8ad3c1
Migrate BaseAccount PubKey to use Any ( #7268 )
...
* WIP on BaseAccount protobuf pub_key
* WIP on BaseAccount.PubKey
* WIP on BaseAccount pub key
* Update PubKey
* Update Account
* Docs
* WIP on protobuf keys
* Use Type() and Bytes() in sr25519 pub key Equals
* Add tests
* Add few more tests
* Update other pub/priv key types Equals
* Fix PrivKey's Sign method
* Rename variables in tests
* Fix infinite recursive calls
* Use tm ed25519 keys
* Add Sign and VerifySignature tests
* Remove ed25519 and sr25519 references
* proto linting
* Add proto crypto file
* Implement some of the new multisig proto type methods
* Add tests for MultisigThresholdPubKey
* Add tests for pubkey pb/amino conversion functions
* Move crypto types.go and register new proto pubkeys
* Add missing pointer ref
* Address review comments
* panic in MultisigThresholdPubKey VerifySignature
* Fix compile errors
* Remove pk conversion in ante handler
* Use internal crypto.PubKey in multisig
* Add tests for MultisigThresholdPubKey VerifyMultisignature
* Only keep LegacyAminoMultisigThresholdPubKey and move to proto keys to v1
* Remove conversion functions and introduce internal PubKey type
* Override Amino marshaling for proto pubkeys
* Merge master
* Make proto-gen
* Start removal of old PubKeyMultisigThreshold references
* Fix tests
* Fix solomachine
* Fix ante handler tests
* Pull latest go-amino
* Remove ed25519
* Remove old secp256k1 PubKey and PrivKey
* Uncomment test case
* Fix linting issues
* More linting
* Revert tests keys values
* Add Amino overrides to proto keys
* Add pubkey test
* Fix tests
* Use threshold isntead of K
* Standardize Type
* Revert standardize types commit
* Fix build
* Fix lint
* Fix lint
* Add comment
* Register crypto.PubKey
* Add empty key in BuildSimTx
* Simplify proto names
* Unpack interfaces for signing desc
* Fix IBC tests?
* Format proto
* Use secp256k1 in ibc
* Fixed merge issues
* Uncomment tests
* Update x/ibc/testing/solomachine.go
* UnpackInterfaces for solomachine types
* Remove old multisig
* Add amino marshal for multisig
* Fix lint
* Correctly register amino
* One test left!
* Remove old struct
* Fix test
* Fix test
* Unpack into tmcrypto
* Remove old threshold pubkey tests
* Fix register amino
* Fix lint
* Use sdk crypto PubKey in multisig UnpackInterfaces
* Potential fix?
* Register LegacyAminoPubKey
* Register our own PubKey
* Register tmcrypto PubKey
* Register both PubKeys
* Register interfaces in test
* Refactor fiels
* Add comments
* Remove old cosmos-sdk/crypto/keys reference
* Use anil's suggestion
* Add norace back
* Use our own ed25519
* Fix pubkey types
* Fix network tests
* Fix more tests
* Make ibc work?
* Use TM pubkey in NewValidator
* Fix lint
* Put interface in tpyes
* rerun CI
* Better name register
* Remove stray code
* Add ed25519 tests
* Check nil
* Correct interface impl assert
* rerun CI
* Add fix for Bech32
* Address comments
* FIx lint
* Add tests for solomachine unpack interfaces
* Fix query tx by hash
* Better name in amino register
* Fix lint
* Add back ed25519 test (fixes #7352 )
* go mod tidy
* Fix merge issues
* Sort import
* Add test for backwards-compatibility
* Fix tests
* Fix merge issue
* Update client/context.go
Co-authored-by: Cory <cjlevinson@gmail.com>
* Update types/address.go
Co-authored-by: Cory <cjlevinson@gmail.com>
* Address feedback
* Add comment
* Fix BaseAccount SetPubKey and address further comments
* Lint
* Remove unnecessary use of copy in getPubKeyFromString
* Update comment
Co-authored-by: Aaron Craelius <aaronc@users.noreply.github.com>
Co-authored-by: Aaron Craelius <aaron@regen.network>
Co-authored-by: Amaury Martiny <amaury.martiny@protonmail.com>
Co-authored-by: Alexander Bezobchuk <alexanderbez@users.noreply.github.com>
Co-authored-by: colin axnér <25233464+colin-axner@users.noreply.github.com>
Co-authored-by: Cory <cjlevinson@gmail.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
2020-09-25 08:41:16 +00:00
Marie Gauthier
fb0f6d6167
Fix multisig PubKey VerifyMultisignature ( #7377 )
...
* Fix VerifyMultisignature method
* Remove unrelevant test
* Remove empty line
* Fix verify test
Co-authored-by: Robert Zaremba <robert@zaremba.ch>
Co-authored-by: Aleksandr Bezobchuk <alexanderbez@users.noreply.github.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
2020-09-24 15:40:38 +00:00
colin axnér
7ea6b2c5e6
Update QueryTendermint to take in tendermint height ( #7337 )
...
* Update QueryTendermint to take in tendermint height
Update QueryTendermint to subtract the provided height by one to query at the IAVL height.
* Update x/ibc/client/query.go
Co-authored-by: Christopher Goes <cwgoes@pluranimity.org>
* update height check to > 2
Update height check to ensure that the client context height is greater than two before decrementing. Queries at height 0 and 1 are not expected to succeed. Documentation was updated to reflect this reasoning
* update query to return error for height <= 2
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
Co-authored-by: Christopher Goes <cwgoes@pluranimity.org>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
2020-09-24 06:53:30 +00:00
Alessio Treglia
b590094e1d
make format && go mod tidy ( #7378 )
2020-09-23 18:04:26 +01:00
Robert Zaremba
f52cce2909
Makefile: drop gofmt in favor of golangci-lint ( #7260 )
...
* setup: update linter make jobs
* go lint: remove wsl from golangci-lint config
* rollback to use disable-all
* bring back vendor rules
* lint fails on golangci-lint error
Co-authored-by: Alessio Treglia <alessio@tendermint.com>
2020-09-23 15:29:21 +00:00
colin axnér
59c43cd047
fix proposal update handling ( #7372 )
...
Fix proposal update handling to update the consensus state with the new diversifier and timestamp. Add checks in the proposal update test to ensure the values provided in the header match. Did manual testing to ensure the test additions fails before updating the code to the correct behaviour.
Co-authored-by: Christopher Goes <cwgoes@pluranimity.org>
2020-09-23 14:06:20 +00:00
Marko
5ce15cb963
tm: update to latest ( #7376 )
...
* update to latest tm
* fix tests
2020-09-23 13:44:40 +00:00
Jack Zampolin
0dfe7ad6a0
Update tendermint version ( #7366 )
...
* Update tendermint version
* update testing pkg to use latest versioned block protocol for tendermint headers
Co-authored-by: colin axnér <25233464+colin-axner@users.noreply.github.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Co-authored-by: Colin Axner <colinaxner@berkeley.edu>
2020-09-23 09:12:24 +00:00
Robert Zaremba
f5afdd0117
Robert/move amino stdtx ( #7301 )
...
* x/auth: move amino StdTx... to a legacy package
* legacytx: move RegisterLegacyAminoCodec from init to tests/init
* merge fixes
Co-authored-by: Aaron Craelius <aaron@regen.network>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
2020-09-22 14:35:18 +00:00
colin axnér
9e7f504da9
remove client type from 02-client ( #7336 )
...
* remove client type struct
Remove the client type struct, remove ClientType interface function from Header and Misbehaviour.
ClientState and ConsensusState return the ClientType as a string.
All uses of client type in testing are now pointing at the testing package so changing the location of the client type const will be painless.
* update godoc and add back client type interface func
Add godoc to client type constant for solo machine, tendermint, and localhost as per @fedekunze review suggestion.
Add back the ClientType interface function for misbehaviour and header for solo machine and tendermint and add back the one liner unit tests as per @AdityaSripal suggestion.
* remove client state from return
remove client state from the return of CreateClient, UpdateClient, and CheckMisbehaviourAndUpdateState as well as update tests to reflect this change.
* fix build error introduced by latest merge
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
2020-09-22 14:25:58 +00:00
colin axnér
83f2c75f3d
connection handshake updates for versioning ( #7328 )
...
* update handshake to match spec
* add test for version
* add test for open try
* add more tests
Add a test for supplied versions that do not function with previous connection states in INIT and TRYOPEN
* update godoc
* update version checks to switch
Update the version checks in ConnOpenAck to use a switch to increase readability of the code as well as provide custom error messages for each possible case that may occur. Slighly modified version to review suggestion by @fedekunze
* add intersection comments to handshake and pick version
* remove old code
2020-09-22 13:47:43 +00:00
Amaury Martiny
7cd25abb87
Proto Tx with Any ( #7276 )
...
* WIP on protobuf keys
* Use Type() and Bytes() in sr25519 pub key Equals
* Add tests
* Add few more tests
* Update other pub/priv key types Equals
* Fix PrivKey's Sign method
* Rename variables in tests
* Fix infinite recursive calls
* Use tm ed25519 keys
* Add Sign and VerifySignature tests
* Remove ed25519 and sr25519 references
* proto linting
* Add proto crypto file
* Implement some of the new multisig proto type methods
* Add tests for MultisigThresholdPubKey
* Add tests for pubkey pb/amino conversion functions
* Move crypto types.go and register new proto pubkeys
* Add missing pointer ref
* Address review comments
* panic in MultisigThresholdPubKey VerifySignature
* Use internal crypto.PubKey in multisig
* Add tests for MultisigThresholdPubKey VerifyMultisignature
* Only keep LegacyAminoMultisigThresholdPubKey and move to proto keys to v1
* Remove conversion functions and introduce internal PubKey type
* Override Amino marshaling for proto pubkeys
* Merge master
* Make proto-gen
* Start removal of old PubKeyMultisigThreshold references
* Fix tests
* Fix solomachine
* Fix ante handler tests
* Pull latest go-amino
* Remove ed25519
* Remove old secp256k1 PubKey and PrivKey
* Uncomment test case
* Fix linting issues
* More linting
* Revert tests keys values
* Add Amino overrides to proto keys
* Add pubkey test
* Fix tests
* Use threshold isntead of K
* Standardize Type
* Revert standardize types commit
* Fix build
* Fix lint
* Fix lint
* Add comment
* Register crypto.PubKey
* Add empty key in BuildSimTx
* Simplify proto names
* Unpack interfaces for signing desc
* Fix IBC tests?
* Format proto
* Use secp256k1 in ibc
* Fixed merge issues
* Uncomment tests
* Update x/ibc/testing/solomachine.go
* UnpackInterfaces for solomachine types
* Remove old multisig
* Add amino marshal for multisig
* Fix lint
* Correctly register amino
* One test left!
* Remove old struct
* Fix test
* Fix test
* Unpack into tmcrypto
* Remove old threshold pubkey tests
* Fix register amino
* Fix lint
* Use sdk crypto PubKey in multisig UnpackInterfaces
* Potential fix?
* Register LegacyAminoPubKey
* Register our own PubKey
* Register tmcrypto PubKey
* Register both PubKeys
* Register interfaces in test
* Refactor fiels
* Add comments
* Use anil's suggestion
* Add norace back
* Check nil
* Address comments
* FIx lint
* Add tests for solomachine unpack interfaces
* Fix query tx by hash
* Better name in amino register
* Display StdTx instead of proto Tx
* Remove useless check
Co-authored-by: Aaron Craelius <aaronc@users.noreply.github.com>
Co-authored-by: blushi <marie.gauthier63@gmail.com>
Co-authored-by: Alexander Bezobchuk <alexanderbez@users.noreply.github.com>
Co-authored-by: colin axnér <25233464+colin-axner@users.noreply.github.com>
2020-09-21 16:48:28 +00:00
Alexander Bezobchuk
535510be1f
Merge PR #7354 : Fix TestMsgCreateVestingAccount
2020-09-21 09:54:50 -04:00
Alessio Treglia
d6357e77b4
use *testing.T.TempDir() in tests ( #7346 )
2020-09-18 17:56:27 +01:00
atheeshp
34bbf4d31c
Adds x/gov missing cli tests ( #7128 )
...
* WIP: adding missing cli tests
* fix command
* fixed vote tests
* udpated proposals test
* added test for single proposal
* WIP: gov cli tests
* added missing tests
* fixed tests
* Fix test
* added test for query proposals
* refactor
* refactor
Co-authored-by: Anil Kumar Kammari <anil@vitwit.com>
2020-09-18 14:26:46 +00:00
Alessio Treglia
3e616a60d5
replace testutil.NewTestCaseDir() with Go1.15's T.TempDir() ( #7014 )
...
Override go's default version with go 1.15.
2020-09-18 12:08:24 +01:00
atheeshp
2715af34a2
Registers grpc routes for `x/gov` ( #7216 )
...
* Registers grpc routes for x/gov
* added todos
* order
* lint
* added norace build flag
* new line
* review changes
Co-authored-by: Anil Kumar Kammari <anil@vitwit.com>
Co-authored-by: SaReN <sahithnarahari@gmail.com>
Co-authored-by: Alexander Bezobchuk <alexanderbez@users.noreply.github.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
2020-09-18 10:06:26 +00:00