Michael FIG
d96d79b8fb
fix: allow app.SetSnapshotStore(nil) ( #7507 )
...
* fix: allow app.SetSnapshotStore(nil)
* fix: downgrade Error to Info in BaseApp.snapshot
2020-11-03 23:02:27 +01:00
Sunny Aggarwal
6274240d7c
Apply suggestions from code review
...
Co-authored-by: Robert Zaremba <robert@zaremba.ch>
2020-11-03 15:55:16 -04:00
Emmanuel T Odeke
ec285f1798
crypto/hd: properly catch index overflows to ensure conformance with BIP 32 ( #7628 )
...
* crypto/hd: properly catch index overflows to ensure conformance with BIP 32
Uses 31 bits as the bitsize argument to strconv.ParseUint to ensure
that we correctly parse values in the range [0, max(int32)]
Adds tests too to prevent future regressions of this subtlety.
Fixes #7627 .
* Address Fedekunze's testing review
2020-11-03 20:28:42 +01:00
Emmanuel T Odeke
9f17bc77af
baseapp, client: reject gRPC connections with out-of-range/nefarious x-cosmos-block-height values ( #7663 )
...
* baseapp, client: reject gRPC connections with out-of-range/nefarious x-cosmos-block-height values
Rejects gRPC connections that send out-of-range x-cosmos-block-height
values that previously weren't checked for. We now reject any negative
values and any value greater than max(int64) aka >9223372036854775807.
Also added an enforcement for returning an error if any negative heights
are passed into (*BaseApp).createQueryContext.
Fixes #7662
* baseapp, client: reject gRPC connections with out-of-range/nefarious x-cosmos-block-height values
Rejects gRPC connections that send out-of-range x-cosmos-block-height
values that previously weren't checked for. We now reject any negative
values and any value greater than max(int64) aka >9223372036854775807.
Also added an enforcement for returning an error if any negative heights
are passed into (*BaseApp).createQueryContext.
Fixes #7662
* Address Robert's feedback to extract negative height checker
* Fix tests
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
2020-11-03 18:35:22 +00:00
Aleksandr Bezobchuk
854430e617
Add log_level CLI flag back ( #7789 )
2020-11-03 17:14:56 +00:00
Aditya
30efa5ab16
Host Key changes ( #7783 )
...
* change host keys on sequences
* fix prefix names
Co-authored-by: Christopher Goes <cwgoes@pluranimity.org>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
2020-11-03 14:35:54 +00:00
antstalepresh
381d1b0e70
fix deprecated function use after merging cosmos master
2020-11-03 22:32:49 +10:00
antstalepresh
eb992a4490
Merge branch 'master' of https://github.com/sikkatech/cosmos-sdk into gov_split_vote
2020-11-03 22:27:58 +10:00
antstalepresh
350f88c0ca
fix lint issues
2020-11-03 22:21:23 +10:00
antstalepresh
ee1988a4ba
split MsgVote and MsgWeightedVote for backwards compatibility
2020-11-03 21:48:53 +10:00
Federico Kunze
72ab03b3ef
ibc: validate signer address ( #7781 )
...
* ibc: validate signer address
* comment
* validate channel handshakes and transfer signers
2020-11-03 10:07:32 +00:00
Aditya
6559e19764
Remove BatchProofs implementation ( #7784 )
...
* remove batch proofs
* Apply suggestions from code review
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
2020-11-03 09:37:55 +00:00
Cory
ce3994020a
Stargate RC2 - Changelog updates & tag RC ( #7785 )
...
* update changelog with rc1 and rc2 entries
* add more rc2 changelog updates
2020-11-02 16:25:36 -08:00
Robert Zaremba
c201963e41
Update x/banking and x/crisis InitChain re slow Gaia startup ( #7764 )
...
* add more logs during the initialization process
* initializtion: move profiling to the top of the startProcess function
* x/bank InitGenesis: remove k.ValidateBalance
* debug: add logs and telemetry to x/bank and x/crisis
* make x/crisis AssertInvariants optional during InitGenesis
* Add module init flags mechanism
* update changelog
* remove debug fmt.Print
* fix testutil/network/
* fix log message
* update test NewApp calls
* review changes
Co-authored-by: Aaron Craelius <aaron@regen.network>
2020-11-02 19:10:14 +00:00
Federico Kunze
4420fe2d52
ibc: remove root from verification funcs ( #7780 )
...
* ibc: remove root from verification funcs
* fix VerifyClientConsensusState
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
2020-11-02 17:16:22 +00:00
Sunny Aggarwal
09d977e334
Merge branch 'master' into adr_gov_split_vote
2020-11-02 12:57:28 -04:00
Sunny Aggarwal
e9d6a8a48d
add backwards compatibility section
2020-11-02 12:56:45 -04:00
Aditya
e9801edb99
Async Ack Fixes ( #7735 )
...
* Add function to query ack proofs
* fix bugs
* fix swagger
* fix final queries
* docs and add test case
* Rename QueryUnrelayedAcks to more accurate QueryUnreceivedAcks
* Apply suggestions from code review
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
Co-authored-by: colin axnér <25233464+colin-axner@users.noreply.github.com>
* address rest of reviews
* consistent spelling
Co-authored-by: Jack Zampolin <jack.zampolin@gmail.com>
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
Co-authored-by: colin axnér <25233464+colin-axner@users.noreply.github.com>
2020-11-02 15:13:48 +00:00
yihuang
aff88bbe99
Fix #7640 : tally calculation precision error ( #7641 )
...
Solution:
- change `(a / b) * c` to `a * b / c`
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
2020-11-02 14:50:33 +00:00
Aditya
88e4acac6b
Don't claim channel capability on crossing hellos ( #7763 )
...
* don't claim capability on crossing hellos
* clarify comment
2020-11-02 14:32:32 +00:00
antstalepresh
ebe73fa28b
modify ADR for MsgVote backwards compatibility
2020-11-02 23:10:39 +10:00
Amaury Martiny
194d2aa196
Fix fetch txs by height on legacy REST endpoint ( #7730 )
...
* Add test
* Fix potential flakiness in sequence
* Remove test with ?height
* Fix test
* Fix tests
Co-authored-by: Aleksandr Bezobchuk <alexanderbez@users.noreply.github.com>
Co-authored-by: Zaki Manian <zaki@manian.org>
Co-authored-by: Aaron Craelius <aaron@regen.network>
Co-authored-by: Aaron Craelius <aaronc@users.noreply.github.com>
2020-11-02 11:52:52 +00:00
Alessio Treglia
cdc73ac605
cosmovisor: docs first draft ( #7608 )
...
Closes : #7118
2020-10-31 12:02:16 +00:00
Marie Gauthier
bd6c16b462
Handle ServiceMsg in StdTxBuilder.SetMsgs ( #7731 )
...
* Handle ServiceMsg in StdTxBuilder.SetMsgs
* Add test
2020-10-30 15:27:12 +00:00
antstalepresh
5a082584c9
Remove Div operation on tally() considering sum(Weight)=1
2020-10-30 23:28:34 +10:00
antstalepresh
73c757dc4f
refactor SubVote to WeightedVoteOption && add utility for NewNonSplitVoteOption
2020-10-30 23:14:39 +10:00
Amaury Martiny
1961935fc7
Add GetTx gRPC endpoint ( #7688 )
...
* Add empty TxByHash
* Fix search & replace
* Renname to GetTx
* Make getTx grpc work
* Hash as string
* Add todo comment
* /tx
* Make tests pass
* Put into function
* Add changelog
* Fix lint
* RegisterTxService in server
* Remove comment
* Update proto/cosmos/tx/v1beta1/service.proto
Co-authored-by: Cory <cjlevinson@gmail.com>
* Create new protoCdc
* Move tx service to x/auth
* Small tweaks
* Link gh issue
* Fix lint
* Update x/auth/tx/service.go
Co-authored-by: Aleksandr Bezobchuk <alexanderbez@users.noreply.github.com>
Co-authored-by: Cory <cjlevinson@gmail.com>
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
Co-authored-by: Aleksandr Bezobchuk <alexanderbez@users.noreply.github.com>
Co-authored-by: SaReN <sahithnarahari@gmail.com>
2020-10-30 12:32:02 +00:00
Jack Zampolin
b2bc32f3c9
Add function to query ack proofs ( #7732 )
...
* Add function to query ack proofs
* Fix compilation issue
Co-authored-by: Aditya <adityasripal@gmail.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
2020-10-29 22:19:01 +00:00
Robert Zaremba
e0e16f62f9
Remove duplicated Module.Route calls ( #7716 )
...
* Remove duplicated Module.Route calls
* make a proper test for registering empty route
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
2020-10-29 22:01:09 +00:00
Sunny Aggarwal
71e551bbae
address @alexanderbez review
2020-10-29 16:35:50 -04:00
Sunny Aggarwal
e34a986a7e
Merge branch 'master' into adr_gov_split_vote
2020-10-29 14:46:58 -04:00
Sunny Aggarwal
3a871b86ce
sunny updates
2020-10-29 14:09:05 -04:00
Amaury Martiny
9087ffc774
Throw an error on duplicate registration ( #7729 )
...
* Panic on registering a service twice
* Panic if we register twice
* Fix test
* Fix test
* Add clearer panic message
* Add comment
* Fix test
2020-10-29 15:32:47 +00:00
antstalepresh
a59ac3e31a
fix integration and rest test
2020-10-29 23:52:21 +10:00
antstalepresh
b3d86e1a8d
update msg vote validate basic and test
2020-10-29 22:43:08 +10:00
colin axnér
1a15713289
remove proof path from IBC queries ( #7725 )
...
* remove proof path
* make proto-all with old install
* fix build
2020-10-29 12:42:12 +00:00
antstalepresh
fe0d0a5045
add comment for SubVote proto
2020-10-29 22:33:24 +10:00
antstalepresh
e7d3549068
fix lint issues
2020-10-29 22:30:42 +10:00
antstalepresh
7e87b5d998
add cli, grpc, keeper test for new split vote
2020-10-29 22:24:55 +10:00
Aditya
b7b925a1ac
Sort validators like tendermint in HistoricalInfo ( #7691 )
...
* sort validators like tendermint
* address comments
* switch ordering in tests
* change sort logic in error case
* don't change test validators array order
Co-authored-by: Jack Zampolin <jack.zampolin@gmail.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
2020-10-29 12:17:37 +00:00
Cory
536eb689dc
Add Deprecation headers for legacy rest endpoints ( #7686 )
...
* add deprecation headers for legacy rest endpoints
* add deprecation headers for missing tx routes
* rm handler-level deprecation headers
* switch to middleware Route.Use method for setting deprecation Headers
* set deprecation headers using subrouter
* cleanup gofmt
* goimports
* Update client/rest/rest.go
* update deprecation headers to be set on each module individually
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
2020-10-29 11:37:46 +00:00
antstalepresh
0cb2c70b4d
add subvotes parser from string
2020-10-29 19:26:51 +10:00
Sunny Aggarwal
2ace2a738b
Update docs/architecture/adr-034-change-pubkey.md
...
Co-authored-by: Amaury Martiny <amaury.martiny@protonmail.com>
2020-10-28 22:20:25 -04:00
Amaury Martiny
82f15f306e
RegisterInterfaces registers service Msg type_urls ( #7671 )
...
* Add RegisterMsgServiceDesc
* Refactor newSendTxMsgServiceCmd
* Add test
* Register in all modules
* Remove RegisterMsgServiceDesc from baseapp
* Add explicit error message
* Add comment
* Update comment
* Add test
* Update comment
* Remove duplicate import
* Fix lint
* Forgot vesting
* Fix lint
* Fix test
* Put in types/module
* Put in types/msgservice
* Add comment about panic
* Update baseapp/msg_service_router.go
Co-authored-by: Robert Zaremba <robert@zaremba.ch>
* Update baseapp/msg_service_router.go
Co-authored-by: Robert Zaremba <robert@zaremba.ch>
* Update baseapp/msg_service_router.go
Co-authored-by: Robert Zaremba <robert@zaremba.ch>
* Add comment
* Add better test
* Update baseapp/msg_service_router.go
Co-authored-by: Marie Gauthier <marie.gauthier63@gmail.com>
Co-authored-by: Robert Zaremba <robert@zaremba.ch>
Co-authored-by: Marie Gauthier <marie.gauthier63@gmail.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
2020-10-28 19:20:45 +00:00
Federico Kunze
1b0d6540d8
ibc: internal audit part 1 ( #7704 )
...
* ibc: internal audit part 1
* Update x/ibc/core/02-client/keeper/client.go
* gofmt
* fix tests
Co-authored-by: colin axnér <25233464+colin-axner@users.noreply.github.com>
Co-authored-by: Colin Axner <colinaxner@berkeley.edu>
2020-10-28 15:57:48 +00:00
dependabot[bot]
d83fc46b97
build(deps): bump codecov/codecov-action from v1.0.13 to v1.0.14 ( #7698 )
...
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Alessio Treglia <alessio@tendermint.com>
Co-authored-by: Marko <marbar3778@yahoo.com>
2020-10-28 14:39:23 +01:00
antstalepresh
ffced9ebef
modify title
2020-10-28 23:31:45 +10:00
colin axnér
dca9dcd276
Fix panic in context when setting nodeURI ( #7699 )
...
* Fix panic in context
Move URI parsing outside of context. WithNodeURI will only set the nodeURI. To set the Client in the context, WithClient must be called.
* add changelog
* add deleted space back
2020-10-28 13:31:22 +00:00
antstalepresh
e91be95d30
revert proto change
2020-10-28 23:27:39 +10:00
antstalepresh
5061b8fe19
basic ADR for gov split vote
2020-10-28 23:24:55 +10:00