Commit Graph

17 Commits

Author SHA1 Message Date
Emmanuel T Odeke c6558fbcb9
server: catch and return unhandled errors in interceptConfigs (#7587)
Catches and returns unhandled errors after stat-ing for the configFile,
instead of assuming that we'd only encounter a non-existent error.
Added a regression test to lock-in checks for unhandled errors like
Permission errors, which is representative of all the errors that
haven't been accounted for.

Fixes #7578

Co-authored-by: Aleksandr Bezobchuk <alexanderbez@users.noreply.github.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
2020-10-20 12:41:44 +00:00
Eric 8384a5a180
fix: Rework InterceptConfigsPreRunHandler to make sure configuration … (#7501)
* fix: Rework InterceptConfigsPreRunHandler to make sure configuration is pulled from all Viper sources

* docs: Add configuration documentation in a new file
2020-10-16 13:56:10 +00:00
Marie 7f59723d88
Make JSONMarshaler methods require proto.Message (#7054)
* Make JSONMarshaler require proto.Message

* Use &msg with MarshalJSON

* Use *LegacyAmino in queriers instead of JSONMarshaler

* Revert ABCIMessageLogs String() and coins tests

* Use LegacyAmino in client/debug and fix subspace tests

* Use LegacyAmino in all legacy queriers and adapt simulation

* Make AminoCodec implement Marshaler and some godoc fixes

* Test fixes

* Remove unrelevant comment

* Use TxConfig.TxJSONEncoder

* Use encoding/json in genutil cli migrate/validate genesis cmds

* Address simulation related comments

* Use JSONMarshaler in cli tests

* Use proto.Message as respType in cli tests

* Use tmjson for tm GenesisDoc

* Update types/module/simulation.go

Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>

* Update types/module/module_test.go

Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>

* Add godoc comments

* Remove unused InsertKeyJSON

* Fix tests

Co-authored-by: Aaron Craelius <aaronc@users.noreply.github.com>
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
2020-08-26 09:39:38 +00:00
Alessio Treglia 24a1670cf0 Run make format 2018-12-10 14:27:25 +00:00
Dev Ojha 6b55093c75 Merge PR #2324: rename wire to codec
* rename wire to codec

* fix formatting and cli

* fix the docs
2018-09-13 14:17:32 -04:00
Ismail Khoffi abce54ea60
Merge branch 'develop' into sort_getsignbytes 2018-07-06 01:31:34 +01:00
Liamsi b7f902fba5 sort *all* GetSignBytes:
- call MustSortJSON before return JSON bytes to guarantee alphabetic
ordering

- moved SortJSON and MustSortJSON to types package to avoid cyclic
package dep
2018-07-06 01:12:57 +01:00
Christopher Goes 66fdb9585b Gopkg.lock & 'make format' 2018-07-06 02:09:33 +02:00
Christopher Goes 908fb39a65
Merge PR #1559: Fix genesis JSON key ordering
Inconsistent Genesis Generation Key Order
2018-07-05 23:05:05 +02:00
Liamsi 28245dba90 adhere to golint 2018-07-05 19:18:48 +01:00
Aleksandr Bezobchuk 51fdc9db2f Merge pull request #1559: Inconsistent Genesis Generation Key Order 2018-07-05 14:15:00 -04:00
Liamsi 97182dce21 Add test-cases, remove indentation 2018-07-05 19:10:35 +01:00
Liamsi 547390a238 WIP: add simple sorting using golang json.Marshal 2018-07-05 17:11:44 +01:00
Dev Ojha 955a0c9af7 Switch asserts to require (#1483)
* meta: Switch the majority of asserts to require

Switch most assert statements to require, to ease debugging.
Closes #1418

* Fix imports
2018-06-30 03:10:15 +02:00
rigelrozanski 4049c5d24f cwgoes comments, bug fix 2018-04-26 14:26:39 -04:00
rigelrozanski c8f5fcb27b init append functionality complete 2018-04-26 14:26:39 -04:00
rigelrozanski 55c1e1dcfc init refactor 2018-04-26 14:26:39 -04:00