Commit Graph

60 Commits

Author SHA1 Message Date
Alessio Treglia d84885ca49
No need to create a fake slice of signatures nor skip account no./sequence check 2018-08-31 19:09:39 +02:00
Alessio Treglia 1ed76565f2
Remove obsolete comments 2018-08-31 19:04:45 +02:00
Alessio Treglia 599923fb99
Introduce simulate mode
Add a simulate only flag '--dry-run' to both CLI tx commands
and RESTful endpoints to trigger the simulation of unsigned
transactions.

* Turning --dry-run on causes the --gas flag to be ignored.
  The simulation will return the estimate of the gas required
  to actually run the transaction.
* Adjustment is no longer required. It now defaults to 1.0.
* In some test cases accounts retrieved from the state do not
  come with a PubKey. In such cases, a fake secp256k1 key is
  generated and gas consumption calculated accordingly.

Closes: #2110
2018-08-31 19:04:11 +02:00
Alessio Treglia 76a16ab288
Modify AnteHandler to take a simulate boolean parameter 2018-08-25 20:12:14 +01:00
Alessio Treglia f432c0c383
Simulate transactions before actual execution
* Change --gas=0 semantic in order to enable gas auto estimate.
* REST clients have been modified to simulate the execution of
  the tx first to then populate the context with the estimated
  gas amount returned by the simulation.
* The simulation returns both an unadjusted gas estimate and an
  adjusted one. The adjustment is required to ensure that the
  ensuing execution doesn't fail due to state changes that might
  have occurred. Gas adjustment can be controlled via the CLI's
  --gas-adjustment flag.
* Tiny refactorig of REST endpoints error handling.

Closes: #1246
2018-08-24 10:16:51 +01:00
Dev Ojha 419cf85433 Merge PR #2046: auth: Make gas cost take into account cryptosystem
* auth: Make gas cost take into account cryptosystem

This will make including the multisig easier.
The ratio for ed25519 vs secp256k1 are based on the ratio of their
verification times, using the benchmarks in tendermint/crypto.
2018-08-21 16:13:34 +02:00
Aditya Sripal ddd4deda7d ignore linter 2018-07-13 11:12:29 -07:00
Aditya Sripal aa3a64d289 Test recover in ante 2018-07-13 10:53:12 -07:00
Aditya Sripal f6d5c85049 Added recover to standard antehandler 2018-07-12 19:38:22 -07:00
Christopher Goes 5a56c3f03d
Merge PR #1575: ready-for-review: sdk.AccAddress natively bech32 2018-07-10 04:18:23 +02:00
ValarDragon 2b5ccdbf87 Reduce code complexity in AnteHandler, and GetExternalIP 2018-07-09 15:29:16 -07:00
sunnya97 7ac220beb6 asdf 2018-07-09 00:59:51 -07:00
Dev Ojha ac3adff1e8 Merge PR #1438: Tools: Add errcheck linter
This linter ensures that all errors are checked.
This is disabled in the client directories, since its not needed on
those writes
2018-06-29 00:52:10 +02:00
Christopher Goes 8bdf06b9f6 Remove Viper from ante handler 2018-06-26 23:45:31 +02:00
Dev Ojha 893bb4027d Merge PR #1377: types: remove GetMemo from Tx
This method is an unneccessary requirement on Tx. Auth casts the Tx
to StdTx, so the memo can be obtained in previous usecases from
StdTx. This also makes it more clear for when something is
implementing StdTx vs Tx.

Resolves #1375
2018-06-26 04:37:21 +02:00
Aditya f049a56376 Merge PR #1266: Multiple messages
* Started work on multiple msgs, types and x/auth tests pass
* Fix issues in x, examples, and baseapp
* Added baseapp tests for multiple msgs
* Documentation fixes
* Fix baseapp tests with sdk.Int
* Modify test
* Transaction handling is now atomic
* Fix test comment
* Minor doc fixes and code cleanup
* Added baseapp result changes
* Use address in validator update accumulation
* Started work on multiple msgs, types and x/auth tests pass
* Fix issues in x, examples, and baseapp
* Added baseapp tests for multiple msgs
* Documentation fixes
* Fix baseapp tests with sdk.Int
* Modify test
* Transaction handling is now atomic
* Fix test comment
* Minor doc fixes and code cleanup
* Added baseapp result changes
* Use address in validator update accumulation
* Added ante tests for multisigner
* Remove validatorUpdates from tx result
* Better error logs
* Put Memo in StdSignBytes and formatting
* Updated changelog
2018-06-22 00:05:25 +02:00
Christopher Goes 918e217e1f
Merge PR #1280: Implement simple transaction memos
* AltBytes -> Memo, memo CLI support & thread-through
* Check memo size, update changelog
* Update existing testcases
* Nuke CircleCI caches
* Charge gas proportional to memo size
* Fix gas allocations in ante handler testcases
* Add testcases
* Update changelog
* Fix tiny CLI bug & add to CLI tests
* Add '--memo' to gaiacli
* Add testcase for large memos
* Address PR comments
2018-06-20 21:27:36 +02:00
Sunny Aggarwal 161cb474d4 Account Numbers for Replay Protection with Account Pruning (#1077)
* in progress
* passes current tests
* added tests and got working
* changelog and docs
* removed prints
* oops
* works!
* issue in test_cli
* number 9 number 9 number 9
* at least it does only the 9 issue now
* hallelujah it works!
* removed print statement
* rebased
* gah
2018-06-12 04:30:54 +02:00
Sunny Aggarwal 4f6c77d8cb antehandler tests 2018-05-25 21:10:09 -07:00
Sunny Aggarwal d3bdb09ffc passes, needs tests 2018-05-25 20:29:40 -07:00
sunnya97 5d7c3af1b8 works 2018-05-23 22:09:01 -07:00
sunnya97 cb52712660 in progress 2018-05-23 19:49:35 -07:00
rigelrozanski e70249b631 more bucky comments, single status validator, only one store now for core validator object 2018-05-20 17:39:04 -04:00
rigelrozanski 26be2a231b working addressed bucky comments 2018-05-18 18:57:47 -04:00
rigelrozanski d871605241 staking fee distribution working commit 2018-05-17 09:15:06 -04:00
Christopher Goes 4134bf922c
Address PR comments 2018-05-16 02:06:17 +02:00
Christopher Goes 4775437426
Unexport verifyCost 2018-05-16 01:15:22 +02:00
Christopher Goes 38716d5edc
ConsumeGas for pubkey.VerifyBytes 2018-05-16 01:14:31 +02:00
Sunny Aggarwal ea6d3e8efc should work maybe? 2018-05-15 16:52:30 -04:00
Christopher Goes 474fa1dfd1
Switch to BurnFeeHandler 2018-04-17 01:06:07 +02:00
Christopher Goes 3bbb15f454
Add tx to feeHandler, move around in example apps 2018-04-16 14:58:19 +02:00
Christopher Goes 39ee95abe4
Refactor to use FeeHandler function 2018-04-16 14:15:03 +02:00
Christopher Goes e870163ec0
Implement fee pool pseudo-account in sdk.AccountMapper 2018-04-16 13:59:56 +02:00
Jae Kwon 49fdf80d9d WIP commit 2018-04-06 17:25:08 -07:00
Ethan Buchman 984aff12da
Merge pull request #642 from cosmos/sunny/errors
move some errors to sdk from bank
2018-03-19 22:37:30 +01:00
Sunny Aggarwal 3e91e12a2f moved errors to sdk from bank 2018-03-18 03:42:54 +01:00
Ethan Buchman 64852138b6 fix the tests. includes some hacks 2018-03-18 02:02:26 +01:00
Ethan Buchman 683663f680 fixes post rebase 2018-03-17 23:09:04 +01:00
Ethan Buchman 7c3213fa00 fixes from review 2018-03-17 22:08:19 +01:00
Ethan Buchman dd4a86b856 x/auth: crank the test coverage 2018-03-17 21:20:24 +01:00
Ethan Buchman 3babf8c2d9 fix and clean fees and x/auth 2018-03-17 19:54:18 +01:00
Matt Bell 1b16f0c684 Deduct fee from fee payer's account balance 2018-03-17 18:34:06 +01:00
Ethan Buchman 45f8ccbe90 x/auth: cleanup ante handler 2018-03-17 18:34:06 +01:00
Yukai Tu aee516f595 Fix auth handler public key issue 2018-03-16 17:57:28 -07:00
Ethan Buchman 20e2c24f9d x/auth: ante_test.go 2018-03-13 01:42:13 +01:00
Ethan Buchman 661d0fd7e8 types: StdSignDoc includes sequence for each sig 2018-03-13 01:42:13 +01:00
Ethan Buchman a05ea5fcc9 implement replay protection 2018-03-13 01:42:13 +01:00
Ethan Buchman 9b8db6b37c x/auth: clean up ante handler 2018-03-13 01:42:13 +01:00
Ethan Buchman 630a5fe579 revert to old go-wire 2018-03-02 04:24:07 -05:00
Ethan Buchman c31f871de6 finish removing TestApp and TestTx 2018-02-17 16:32:30 -05:00