--validate-signatures should not be a flag of the sign command
as the operation performed (transaction signatures verification)
is logically distinct.
cli_test is and has always been an horrible name for package
directory as it's very much Go anti-idiomatic - _test is the
suffix used by test packages, not directories. Plus, CLI test
cases can and should live alongside other testcases that don't
require binaries to be built beforehand. Thus:
x/module/client/cli_test/*.go -> x/module/client/cli/
Test files that require sim{cli,d} shall be tagged with // +build cli_test
With regard to cli test auxiliary functions, they should live in:
x/module/client/testutil/
Co-authored-by: Alexander Bezobchuk <alexanderbez@users.noreply.github.com>
x/staking: Fix all linter warnings.
Fixed warnings across base packages.
New linters:
- unparam
- nolintlint
Co-authored-by: Alessio Treglia <alessio@tendermint.com>
* Added cli integration base setup
* Added cmd to simapp
* Fixed ci-lint issues
* Fixed ci-lint issues
* Addressed changes in Makefile
* Updated simd to latest
* Removed testnet and replay commands
* Modified tx command for simcli
* Did code cleanup
* Removed duplication in Makefile
* Refactored cli_test
* Added build-sim to Makefile
* Added test-cli to circleci
* Added tests for staking txns
* Addressed format issues
* refctored tests code
* Added tests for send, staking
* Removed test_hepers file
* Moved test_cover to contrib
* Added codec in fixtures
* Migrated tests to respective modules
* Exported helper methods
* Moved helpers to bank
* Added codec to fixtures
* Migrated tests to modules
* Removed auth helpers from staking
* Did minor code cleanup
* Added test-cli to Makefile
* Updated github actions
* Did code refactor
* Fixed github actions for cli-test
* Added tests for recover keys and fee deduction
* Did minor code cleanup
* Added build flag to cli_tests
* Moved cli_test to tests
* Modified path in Makefile
* Updated codec std in fixtures
* Added doc for cli tests
* Remove ibc genesis validation
* Fix issue number
* Added missing imports
* Add tests for distribution and simd
* Modified naming for test functions
* Added test for withdraw rewards
* Modified test function names
* Fixed import format
* Migrated helpers to package cli
* Fixed github test actions
* Fixed test coverage in actions
* Added build sim to actions
* Apply Alessio patch for tests
* Removed unused imports
* Added init for go tests
* try fix tests
* goimports what wasn't goimports'd
* try fix ci
* add relevant tags to integration tests
* run integration tests separately
* use go build -o flag and let compiler gemerate the binary with the
right extension for the HOST platform
rename cli-test to test-integration
* update ci
* rename
Co-authored-by: atheesh <atheesh1>
Co-authored-by: kaustubhkapatral <54210167+kaustubhkapatral@users.noreply.github.com>
Co-authored-by: Aaron Craelius <aaron@regen.network>
Co-authored-by: anilCSE <anil@vitwit.com>
Co-authored-by: Alessio Treglia <alessio@tendermint.com>
* enable the wsl linter
Fix various wsl-related warnings.
x/ibc/04-channel/keeper/handshake.go: fix missing return statement in ChanOpenTry().
* goimports -w files
* remove unknown linter references
* run make format
* Revert "run make format"
This reverts commit f810b62b9e4993f08506663d4e5f2ec2228a9863.
* run make format
Alessio Treglia
Marko
SaReN
Zach Ramsay
Ethan Frey
rigelrozanski
Rigel Rozanski
Emmanuel Odeke