8e67a5d23b
Allow empty version strings ( #6904 )
...
* Allow empty version strings
* Restore empty version.Identifier check
* Fix test
Co-authored-by: colin axner <25233464+colin-axner@users.noreply.github.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
2020-07-31 18:18:05 +00:00
617b822efa
types: add kv type ( #6897 )
...
* add kv type
* add changelog entry
* fix build
* replace sdkkv with kv
* revert change
* fix some tests
* proto-gen
* fix tests
Co-authored-by: Aleksandr Bezobchuk <aleks.bezobchuk@gmail.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
2020-07-30 14:53:02 +00:00
c7dab51192
remove ack length limit ( #6874 )
...
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
2020-07-29 10:46:44 +00:00
2651427ab4
x/ibc-transfer: use ibc testing package ( #6641 )
...
* x/ibc-transfer: use ibc testing package
* coin denom failure
* update handler tests
* refactor first test in relay
* update onrecvtest, failing tests expected due to existing bug
* update on acknowledgement test, failing test is expected
* refactor timeout test
* revert coin validation changed, comment out tests
* minor fix
* update coordinator.go
* update coordinator.go
* add comment to fix handler test
* add link to issue in handler test
* fix test
Co-authored-by: Colin Axner <colinaxner@berkeley.edu>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
2020-07-28 08:24:13 +00:00
3bafd8255a
Remove hybrid codec usage ( #6843 )
...
* remove hybrid codec for slashing, staking and upgrade
* Remove hybridcodec from params and mint
* revert staking
* Fix gov
* Fix ibc and evidence
* Fix ibc-transfer
* Fix staking
* remove evidence json marshaling
* Fix tests
Co-authored-by: Aaron Craelius <aaron@regen.network>
Co-authored-by: Aaron Craelius <aaronc@users.noreply.github.com>
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
2020-07-25 08:03:58 +00:00
e906c012a0
add page flag for CLI queries ( #6824 )
...
* add page flag for CLI queries
* fix review suggestions
* Fix `page` flag default value
* fix offset calc
* Apply suggestions from code review
Co-authored-by: Aaron Craelius <aaron@regen.network>
* fix review suggestions
* refactor
* fix returning error
Co-authored-by: SaReN <sahithnarahari@gmail.com>
Co-authored-by: Aaron Craelius <aaron@regen.network>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
2020-07-24 08:17:11 +00:00
ef0a7344af
x/ibc: remove ID from ConnectionEnd ( #6814 )
...
* remove connection id
* various test and code fixes
* fix tests
* Update proto/ibc/connection/connection.proto
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
* rename utils.go to parse.go in host
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
2020-07-22 09:59:15 -04:00
e9627abc54
bump identifier maximum to 64 characters ( #6812 )
...
* bump identifier maximum to 64 characters
* fix tests
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
2020-07-22 10:20:41 +00:00
35a59b1573
rename MsgPacket to MsgRecvPacket ( #6813 )
2020-07-22 10:01:57 +00:00
97a83e9c78
Update IBC events docs and code ( #6798 )
...
* update msgs type from opaque
* update spec for createclient
* update events spec for handshake cals
* update packet events for spec and code
* add relayer events doc
* update ibc-transfer events
* fix build
* small fix from self review
* update channel msgs types
* acknowledgement_packet -> acknowledge_packet
* Apply suggestions from code review
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
* fix spec issues for ibc and ibc-transfer
* add golang relayer link
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
2020-07-21 12:56:14 -04:00
9ee14ee985
Add pagination flags to x{ibc, bank} ( #6804 )
...
* updated pagination flags
* updated all balances pagination flags
* updated all balances
* some doc updates
Co-authored-by: Anil Kumar Kammari <anil@vitwit.com>
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
2020-07-21 15:36:45 +00:00
69bbb8b327
Rename proto Req/Res to Pagination ( #6796 )
...
* Rename proto Req to Pagination
* Change Res to Pagination
Co-authored-by: Alexander Bezobchuk <alexanderbez@users.noreply.github.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
2020-07-20 16:51:16 +00:00
1d6344888e
Fix query unrelayed packets logic ( #6733 )
...
* add some query functions to channel keeper
* update grpc queries and cli cmd and tests
* rerun proto gen after merging master
* fix build broken from merge conflicts
* add test and update proto
* Update x/ibc/04-channel/client/cli/query.go
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
2020-07-20 12:42:36 +00:00
a65bcdd7e5
add custom relative and absolute timeouts to ibc-transfer ( #6724 )
...
* add custom relative and absolute timeouts
* fix misspell
* Update x/ibc-transfer/client/cli/tx.go
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
2020-07-15 13:32:09 +00:00
5dfc4a2ec9
Standardize connection versioning + channel versioning docs ( #6640 )
...
* update connection versions with feature set flag
* make connection version modular to support channel versioning and registering
* revert IBCVersion renaming, add channel versioning logic
* fix channel version flag
* remove unnecessary godoc
* remove unused func
* fix lint and version test
* add test and fix error
* revert changes
* update docs
* remove unnecessary godoc
* Apply suggestions from code review
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
* update doc
* add test cases for unchecked lines
* go fmt
* begin migration to standardized version
* revert proto changes
* restructure versioning to go from string to proto
* update versionStr to encodedVersion naming
* fix version test build
* fix keeper tests
* fix various tests
* fixes from self review
* update docs
* fix lint
* add more code cov
* rename ToString funcs to Encode/DecodeVersion + GetCompatibleEncodedVersions renaming
* update spec docs
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
2020-07-14 08:43:26 +00:00
e7554bb3b0
Fix Gas Flag Usage + CLI Flag APIs ( #6685 )
...
* Use new APIs
* fix usage
* fix usage of gas flag
* tests: TestParseGasSetting
2020-07-11 08:13:46 +00:00
03fdc9d744
x/ibc: update error messages ( #6659 )
...
* update errors in 02-client
* update errors in 03-connection
* update 04-channel errors + fixes to 03 changes
* update ibc handler errors
* tm, commitment, and verify error updates
* update ics20
* remove unnecessary wrapping
* fix various build issues
2020-07-09 12:06:08 -04:00
3fc5a4dfc6
x/ibc: update CLI queries ( #6647 )
2020-07-08 10:57:42 -04:00
e6bb2e7ed7
x/ibc: refactor CLI ( #6639 )
...
* x/ibc: refactor CLI
* refactor client CLI
* rename version ClientName
* Update x/ibc/09-localhost/client/cli/cli.go
Co-authored-by: Amaury Martiny <amaury.martiny@protonmail.com>
* address comments from review
Co-authored-by: Amaury Martiny <amaury.martiny@protonmail.com>
2020-07-08 05:57:59 -04:00
8670a10564
Merge PR #6595 : Single Binary & Command Refactor
2020-07-07 11:40:46 -04:00
7fdcdc18e0
Enforce Connection Features on Channel Opening ( #6620 )
...
* add channel open checks for supported feature
* add tests and fix bugs
* fix version tests
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
2020-07-07 10:00:12 +00:00
6fa295c857
fix NextSeqAck increment logic ( #6619 )
...
Co-authored-by: Alexander Bezobchuk <alexanderbez@users.noreply.github.com>
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
2020-07-07 08:03:43 +00:00
f35e3b2c02
x/ibc: gRPC query service ( #6466 )
...
* x/ibc: gRPC query service
* fixes
* connection updates
* register channel query service
* update clients
* change proofs to bytes
* implement additional channel grpc queries
* unrelayed packets query
* query.proto files
* move next sequence recv query to channel client
* update REST
* wip test
* add missing cli queries
* install the right tools
* fixes
* build
* lint
* use gRPC when query proof is not requested
* connection gRPC tests
* IBC query server interface
* more gRPC channel tests
* pagination tests
* connection use query server
* connection pagination tests
* channel pagination tests
* typo
* remove buf
* Update x/ibc/03-connection/keeper/grpc_query_test.go
Co-authored-by: colin axner <25233464+colin-axner@users.noreply.github.com>
* address comments from review
* fix tests
* unrelayed packet sequences flag
* remove ClientsConnections query
* fix
Co-authored-by: colin axner <25233464+colin-axner@users.noreply.github.com>
2020-07-06 15:35:35 -04:00
2f44fbf2ab
Add support for protobuf TxGenerator and SIGN_MODE_DIRECT ( #6385 )
...
* Add TxWrapper, encoder, decoder and DirectModeHandler
* fix pkg name
* Update API and leave test TODO's
* Update TxWrapper API
* tests for tx wrapper (#6410 )
* WIP: added test for direct mode handler
* updated code
* Add msg
* Update TxWrapper API
* Fix pubkey declaration
* Add pubkey for tests
* Fix SetFee
* Remove logs
* Avoid global var declaration for tests
* Add test for GetPubKeys
* Fix direct signing tests
* Add more test cases for GetSignBytes
* Revert SetFee API
* Remove logs
* Refactor tests
Co-authored-by: anilCSE <anil@vitwit.com>
Co-authored-by: sahith-narahari <sahithnarahari@gmail.com>
* Refactoring
* Refactoring
* Integrate SignatureV2 API
* Fix wrapper tests
* Fix tests
* Linting and API tweaks
* Update API
* WIP on updating API
* Fix tests
* Update to new SigVerifiableTx
* Rename
* Update docs to reflect ADR 020
* proto-gen
* proto docs
* cleanup
* cleanup
* cleanup
* cleanup
* cleanup
* cleanup
* cleanup
* Add tests
* Refactor and improving test coverage
* WIP on test coverage
* WIP on test coverage
* proto-gen
* Fix CompactBitArray.Size() bug
* Rename
* Remove Builder interface
* Address review comments
* Update x/auth/tx/sigs.go
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
* Update x/auth/tx/encoder.go
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
* Update x/auth/tx/encoder.go
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
* Address review feedback
* Fix build issues
* Resolve conflicts
* Fix ValidateBasic test coverage
* Add test for malicious multisig
Co-authored-by: atheeshp <59333759+atheeshp@users.noreply.github.com>
Co-authored-by: anilCSE <anil@vitwit.com>
Co-authored-by: sahith-narahari <sahithnarahari@gmail.com>
Co-authored-by: Alexander Bezobchuk <alexanderbez@users.noreply.github.com>
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
2020-07-06 17:03:45 +00:00
fd9cdb8ba7
Merge PR #6608 : ibc: remove viper from CLI
2020-07-06 09:25:47 -04:00
4f3efaded4
Add same attributes for all connection/ channel/ packet IBC events ( #6482 )
...
* Emmit events with same attributes in connection handlers
* Emmit events with same attributes in channel handlers
* Add paket_data attribute to EventTypeAcknowledgePacket
* Revert proto changes
* Query channel and connection to emit events with same attributes
* Simplify code
* Update x/ibc/04-channel/keeper/packet.go
* Update x/ibc/04-channel/handler.go
* Apply suggestions from code review
Co-authored-by: Aditya <adityasripal@gmail.com>
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
2020-07-03 15:48:48 +00:00
db60e658f8
refactor connection handshake_test ( #6576 )
...
* refactor connopeninit test
* updated opentry
* refactor openack
* update openconfirm
* fix typo and test issue
* fix missing code cov hits
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
2020-07-02 20:08:29 +00:00
5a22342a24
check ordered channel ordering in RecvPacket ( #6574 )
...
* move nextrecvseq check to recvpacket
* add test for next recv seq not found
* fix test bug, increase cov
* remove dup check and test
* Update x/ibc/04-channel/keeper/packet_test.go
Co-authored-by: Aditya <adityasripal@gmail.com>
Co-authored-by: Aditya <adityasripal@gmail.com>
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
2020-07-02 20:03:45 +00:00
2658175b01
remove alias.go from channel ( #6569 )
...
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
2020-07-01 18:25:23 +00:00
497b27305d
x/ibc: remove returning packet from channel keeper funcs ( #6544 )
...
* remove unnecessary return var
* fix changes lost in merge
2020-06-30 11:04:18 -04:00
e8fb76ae44
x/ibc: remove alias.go from 03-connection ( #6543 )
2020-06-30 09:10:53 -04:00
43b4f2f120
remove alias.go from 02-client ( #6542 )
2020-06-30 10:37:05 +00:00
1c575c95b2
Remove CleanupPacket from 04-channel ( #6533 )
...
* remove cleanup func
* remove unused func
2020-06-29 08:54:45 +00:00
43837b16e7
Refactor 04-channel/keeper tests to ibc testing pkg ( #6400 )
...
* update testing pkg and first keeper test
* fix version bug
* add more helper testing funcs
* move create header to testing pkg
* fix connection state bug
* add staking genesis state
* update simapp with setting validator helper func
* update simapp with valset helper
* fix app hash issue
* update to query from correct iavl proof height
* first keeper test passing
* second test passing 🎉
* fix build
* update tests in all keeper_test
* fix lint
* begin refactoring querier test
* update first querier test and update testing helpers
* finish updating rest of querier tests
* rename ChannelID in TestChannel to ID
* remove usage of chain id for calling helper funcs
* update openinit and opentry tests
* finish opening channel handshake tests
* finish handshake tests
* general testing pkg cleanup
* finish packetsend refactor
* update recvpacket
* packet executed refactored
* finish packet test 🎉
* all tests passing
* cleanup and increase code cov
* remove todos in favor of opened issue #6509
* bump invalid id to meet validation requirements
* bubble up proof height + 1
* Apply suggestions from code review
Co-authored-by: Aditya <adityasripal@gmail.com>
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
* fix uninit conn test
* fix compile and address various pr review issues
* Update x/ibc/04-channel/keeper/handshake_test.go
Co-authored-by: Aditya <adityasripal@gmail.com>
* Update x/ibc/04-channel/keeper/handshake_test.go
Co-authored-by: Aditya <adityasripal@gmail.com>
* address @AdityaSripal comments and increase cov
Co-authored-by: Aditya <adityasripal@gmail.com>
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
2020-06-26 16:36:04 +00:00
4e73e0f817
Update proto files & definitions in accordance with ADR023 ( #6413 )
...
* consolidate proto files into single directory, turn on PACKAGE_DIRECTORY_MATCH linting
* add third_party root for third party proto files
* move ibc proto files to top level folder, rename .proto files to types.proto as before
* update protocgen script, and run code generation
* move vesting proto definition to cosmos namespace, rename from types.proto in alignment with buf.build naming conventions
* update Makefile so proto dependencies are set with new structure when updated
* add comment for sed usage in makefile
* remove unused aliases of proto generated types
* add settings.json instructions to contributing.md for including protobuf paths
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
Co-authored-by: Aaron Craelius <aaron@regen.network>
2020-06-18 10:04:26 -07:00
1c8249e26d
x/ibc: tx client protobuf migration ( #6461 )
...
* ibc/03-connection: tx client migration
* update commands
* update ibc-transfer
* remove unused queryRoute
* initialize clientCtx
2020-06-17 21:56:48 +02:00
d82114df2b
ibc/04-channel: move UNORDERED channel ack to RecvPacket ( #6457 )
2020-06-17 05:36:09 -04:00
35312d098e
JSON Codec Updates ( #6444 )
...
* Initial commit
* More updates
* Fix tests
* CLI test updates
* Updates
* Updates
2020-06-16 00:20:50 +00:00
8cf8098861
x/capability: remove alias.go usage ( #6438 )
2020-06-14 19:05:45 +02:00
14e3aa1265
x/staking: remove alias.go usage ( #6397 )
...
* x/staking: remove alias.go usage
* Fix formatting and Add entry in CHANGELOG.md
* Add missing end curly parenthesis
Co-authored-by: Alessio Treglia <alessio@tendermint.com>
2020-06-12 14:54:37 +00:00
ddbb9a2321
run make format ( #6416 )
2020-06-12 10:17:36 -04:00
55a7226535
x/ibc: channel from client state query ( #6401 )
...
* x/ibc: channel from client state query
* 04-channel/client: add CLI and REST queries
* querier test
2020-06-12 08:06:24 -04:00
d82c2e6a94
Enforce ProofSpecs in 23-Commitment ( #6374 )
...
* enforce spec ordering
* modify clients to pass in specs to verify functions
* start fixing tests
* Apply suggestions from code review
* enforce spec length and proof length match
* fix all tests
* add argument to constructor:
* fixed msg client and tests
* appease linter
* Apply suggestions from code review
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
* finish fixes from review
* add back proof-specific checks
* Apply suggestions from code review
* more robust proof spec checks
* add CHANGELOG entries
* do not hardcode proofspecs in 23-commitment
* fix client modules
* fix tests
* appease linter
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
2020-06-12 10:45:40 +00:00
9048ffa8d3
Update ibc proof to be bytes ( #6393 )
...
* update interfaces to use []byte instead of commitment proof
* update 03/04 msgs with bytes
* fix compile errors
* fix channel tests
* fix connection tests
* fix testing, tm, and localhost tests
* fix ante tests
* update 03-connection spec
* update channel msgs spec
* small fixes after self review
* rm unused import
* Update x/ibc/03-connection/client/utils/utils.go
Co-authored-by: Alessio Treglia <alessio@tendermint.com>
* add empty proof test and rm ics 20 from ibc spec
* fix merge issues
Co-authored-by: Alessio Treglia <alessio@tendermint.com>
2020-06-12 00:19:25 +02:00
b09d6728ec
Rename all methods IsEmpty to Empty to be consistent with all codebase ( #6409 )
...
Co-authored-by: Alessio Treglia <alessio@tendermint.com>
2020-06-11 23:32:24 +02:00
affe7265cb
Update connection and channel to use types_test package name ( #6395 )
...
* convert connection types test pacakge name
* convert channel types test package name
Co-authored-by: Alexander Bezobchuk <alexanderbez@users.noreply.github.com>
2020-06-11 00:31:54 +00:00
744c1ce250
x/ibc: simulation store decoders ( #6247 )
...
* x/ibc: simulation store decoders
* x/ibc: missing decoders
* fixes
* 02-client: decoder test
* 03-connection: decoder test
* x/ibc: decoder test
* address comments from review
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
2020-06-10 08:09:51 +00:00
c44813bcdf
x/ibc: commit timeout timestamp ( #6363 )
...
Co-authored-by: Christopher Goes <cwgoes@pluranimity.org>
2020-06-08 08:03:18 -04:00
52d11acb45
R4R: Fix bug of unordered channel ( #6337 )
...
* fix unordered
* resolve conflicts
2020-06-08 06:19:59 +00:00
b9b578d6de
x/ibc: querying support for unordered channels ( #6294 )
...
* pause
* add querying for packet commitments and unrelayed acks
* add get all packet commitments test
* add query channels test
* add query connection channels test
* add test for query packet commitments
* fix key path and add unrelayed acks test
* fix part of lint
* add unrelayed packetsends func
* fix godoc
* add nolint directive
* fix lint
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
2020-06-06 19:25:45 -04:00
dauTT
Marko
Aditya
Federico Kunze
Anil Kumar Kammari
colin axner
atheeshp
Amaury Martiny
Alexander Bezobchuk
Aaron Craelius
Cory
dauTT
Jonathan Gimeno
Segue