Commit Graph

1522 Commits

Author SHA1 Message Date
Zaki Manian ed2b6bd9a7 Multiple fees in min fees to OR instead of AND (#3239) 2019-01-08 08:21:54 -08:00
Jack Zampolin b6ee053b1a
Fix Governance state import (#3223) 2019-01-07 14:24:04 -08:00
frog power 4000 20f6ff3e60
Merge PR #3230: Remove KV marshalling split
* remove kv seperation for marshalling

* pending

* cleanup

* cleanup x2
2019-01-07 15:42:52 -05:00
Alexander Bezobchuk fa056c9816 Minor cleanup of validator CLI logic (#3221) 2019-01-03 15:28:55 -08:00
Jack Zampolin d1824ad704
R4R: validate sign tx request's body (#3179)
* validate sign tx request's body

Closes: #3176

* Introduce CodeNoSignatures

* Update swagger.yaml

* Fix tests

* Update x/auth/client/rest/sign.go

Co-Authored-By: alessio <quadrispro@ubuntu.com>
2019-01-03 08:30:04 -08:00
Alexander Bezobchuk 15bd1f668f Merge PR #3189: Reset slashing periods on export
* Reset slashing periods on export
* Rename old slashing period setter to SetValidatorSlashingPeriod
* Update export to reset slashing periods
* Fix cons address
* Remove old slashing period reset
* Add pending log entry
* Update slashing period tests
2019-01-03 00:57:13 +01:00
Alexander Bezobchuk 990f3ab4c1 Add IsValid check on sendCoins (#3212) 2019-01-02 13:19:48 -08:00
frog power 4000 5448824efb
Update x/auth/client/rest/sign.go
Co-Authored-By: alessio <quadrispro@ubuntu.com>
2019-01-02 20:51:11 +00:00
frog power 4000 a98a5a056a
Merge PR #2958: Validator Power Dec-> Int
* Validator Power Dec-> Int, working

* non-test code compiles

* working, many test compile fixes

* all test compile errors resolved

* ...

* slashing test fixes minor

* test cover passes

* invariant rounding issue

* comment update

* PENDING and doc updates

* @cwgoes comments

* RemoveDelShares trimmings to the final delegation share

* fixes

* ...

* fix the oopsie

* @alexanderbez comments

* merge fixes

* address @cwgoes comments
2019-01-02 15:29:47 -05:00
Alessio Treglia d78db91944 Fix tests 2019-01-02 10:53:24 +00:00
Alessio Treglia 11585a4abd Introduce CodeNoSignatures 2019-01-02 10:05:56 +00:00
Alessio Treglia 1ebe1844d2 validate sign tx request's body
Closes: #3176
2018-12-27 14:43:23 +01:00
Alexander Bezobchuk b0662aa4f6 Implement Proposal Proposer client interfaces (#3184) 2018-12-21 09:30:46 -08:00
Alexander Bezobchuk 217a2925dc Auth Module Param Store (#2998) 2018-12-20 11:09:43 -08:00
Alexander Bezobchuk 5a13e75367 Tags Cleanup & Docs (#3137) 2018-12-19 19:28:38 -08:00
Jae Kwon 192ad58431
Merge pull request #3166 from cosmos/cwgoes/gos-patch-1
Merge GoS point release back to develop
2018-12-19 16:43:02 -08:00
Federico Kunze f02f7aa5a0 Add fees and memo to REST, updated CLI to receive coins as fees (#3069) 2018-12-19 16:26:33 -08:00
Christopher Goes 3387261e6b Add comment outlining safety of commission-withdraw (#3175) 2018-12-19 14:36:25 -08:00
Jack Zampolin 14ebc65daf Merge PR #3119: Move all store keys into constants
* Move all store keys into constants
* Fix lint issue
* Add Pending.md
* QuerierKey -> QuerierRoute
2018-12-19 20:58:30 +01:00
Jack Zampolin 4b4a2b81a1
Add slashing genesis validation (#3158) 2018-12-19 09:03:16 -08:00
Hendrik Hofstadt 2be19b9d33 Merge PR #3163: Withdraw commission on self bond removal
* Withdraw commission on self bond removal
* Update PENDING.md
2018-12-19 17:05:33 +01:00
Nicolas Pinto f32286d5ff Small typo in stake/client/cli/tx.go (#3157)
* FIX: small typo in stake/client/cli/tx.go
* FIX: another typo in stake/client/cli/tx.go
2018-12-18 15:44:28 -08:00
Sunny Aggarwal f4fb3608c0 Redelegation Querier (#2559) 2018-12-18 13:43:41 -08:00
Alessio Treglia 711a22fde6 Merge PR #3121: x/auth: fetch one account after another
* x/auth: fetch one account after another

- Don't read all accounts in one go as signature verification
  could fail before last signature is checked.

- TestAnteHandlerFees now checks whether fees were actually
  deducted from the account as well as the fee keeper collected
  them.

Thanks: @ValarDragon for pointing this out
Closes: #3093
2018-12-18 21:41:54 +01:00
Alessio Treglia 500fa2b694 Make coins denoms case insensitive (#3092) 2018-12-18 11:14:11 -08:00
Alessio Treglia eac7d6939d Merge PR #3127: Don't fallback to any default values for chain id
- Remove DefaultChainID(). User needs to suplly chain ID
  via either config or flag.
- Mark --chain-id as required by all tx commands.
- Fix gaiacli config values containing underscores.
  Underscore '_' character is not automagically translated
  into hyphen '-'. Viper values wouldn't be affected.
- Refresh gaiacli config tests

Closes: #810
2018-12-18 19:40:01 +01:00
Alexander Bezobchuk 56937714b5 Expose necessary ante handler auxiliary functions (#3135) 2018-12-17 15:43:16 -08:00
Jae Kwon 6666540dbb Revert "Remove GovernancePenalty"
This reverts commit 86a214f10c.
2018-12-17 10:56:45 -08:00
Jae Kwon ac511abc5c
Temporarily revert x/slashing/params json field names to use dashes, for GoS compat (#3132) 2018-12-17 10:11:38 -08:00
Jae Kwon 86a214f10c Remove GovernancePenalty 2018-12-17 02:17:19 -08:00
Alexander Bezobchuk ff6c2f2bad Gov Get Vote(s)/Deposit(s) Updates (#3091) 2018-12-14 11:13:43 -08:00
Alexander Bezobchuk 110fd63e22 Add Slashing Query Params (#3117) 2018-12-14 11:09:39 -08:00
Federico Kunze 65beea4430 Add distribution REST endpoints swagger file (#3038) 2018-12-13 10:42:55 -08:00
Artur Albov 0c6d53dc07 Merge PR #2959: Add TxEncoder to client TxBuilder 2018-12-12 22:29:42 +01:00
Jack Zampolin 582ca8e8b9
Move validator cache to the keeper in stake (#3075) 2018-12-12 08:34:39 -08:00
Jack Zampolin 26a31926f8 Address PR comments 2018-12-11 13:10:42 -08:00
Jack Zampolin 2f9b062cf3 Merge PR #3015: Add Governance genesis checks
* missing genesis verification in gaia, also add distribution verification

* PENDING.md

* Fix error message
2018-12-11 20:05:49 +01:00
Jack Zampolin b9477df546
Reintroduce collect-gentxs's --gentx-dir flag (#3021)
R4R: Reintroduce collect-gentxs's --gentx-dir flag
2018-12-11 08:11:10 -08:00
Federico Kunze 4ecbf0dd5f Merge PR #2997: Split POST delegations endpoint 2018-12-11 15:02:26 +01:00
Alessio Treglia affa1fb3f3 Reintroduce collect-gentxs's --gentx-dir flag
It went lost in last genesis workflow refactoring.

Also address structs initializations as per #2835.
2018-12-11 12:32:28 +00:00
Jack Zampolin e1f0767ba8
R4R: Move generate_only and simulate to POST body in REST txs (#3060)
* Move generate_only and simulate to POST body in REST txs

Closes: #3056

* Run make format

* drop extra else block, outdent its block, and make linter happy

* Update PENDING.md

* Update LCD swagger docs
2018-12-10 14:51:53 -08:00
Jack Zampolin 97efff8af6 Move validator cache to the keeper in stake 2018-12-10 14:14:52 -08:00
Christopher Goes 243576143e
Merge PR #3072: Catch overflows in gas wanted
* Check for overflow

* Only expect block gas meter on DeliverTx

* ErrGasOverflow in tx.ValidateBasic()

* Update unit test
2018-12-10 21:39:29 +01:00
Alexander Bezobchuk 2ce41760e2 Merge PR #3070: Check for gas overflow in tx validation
* Check for gas overflow in tx validation

* Use bitshifting over math.Pow
2018-12-10 20:24:57 +01:00
dongsamb da7f459d44 Merge PR #3050: Add generate-only option to withdraw-rewards 2018-12-10 16:29:10 +01:00
Christopher Goes 7d55bd1a36
Merge PR #3063: Fix linter 2018-12-10 16:13:26 +01:00
Alessio Treglia 2e05d4e3d7 drop extra else block, outdent its block, and make linter happy 2018-12-10 14:36:20 +00:00
Alessio Treglia 24a1670cf0 Run make format 2018-12-10 14:27:25 +00:00
Alessio Treglia ac0a7c0a1d Move generate_only and simulate to POST body in REST txs
Closes: #3056
2018-12-10 14:26:34 +00:00
Sunny Aggarwal 945803d586 Governance Quorum (#3053) 2018-12-10 02:50:20 -08:00
Jae Kwon 133134ca52
Use address instead of bond height / intratxcounter for deduplication (#3055) 2018-12-10 02:49:37 -08:00
Jae Kwon 40a30b738f
Update gas costs to more reasonable numbers for GoS (#3052) 2018-12-10 02:48:19 -08:00
Jae Kwon bc51fa93b6
Fix updateValidatorDistInfoFromPool (#3046)
Fixes regression introduced by #2984.
Continuiation of #3033 , which didn't fix the simulation issues.
(candidate) Complete solution for #3019, 9002 halt bug.

From #2984, it isn't sufficient to take the fee pool rewards of a validator. Since we don't track delegator accums (as we do with validator accums), and because onValidatorModified >updateValidatorDistInfoFromPool is also being called upon delegation updates (or at least I believe this is the reason), it is necessary to also withdraw self delegation.

TODO: I don't think self-delegation should be required to be modified here... consider using a delegation hook to do the self-delegation withdraw part instead, e.g. splitting the updateValidatorDistInfoFromPool function into two. It might not result in cleaner code, however. Think hard.
2018-12-08 07:18:04 -08:00
Jae Kwon 1ba93ea1c1 Merge PR #3033: Fix negative stake & invariance bug
* Fix negative stake & invariance bug

* Merge PR #3037: Updates to negative stake fix

* Update invariant; fix lint

* Fix linter

* Add comment & TODO
2018-12-08 01:04:52 +01:00
frog power 4000 49da96bc09 Merge PR #3010: Add Missing genesis checks in Gaia 2018-12-07 01:22:24 +01:00
Alexander Bezobchuk f11a65dee7 Merge PR #3005: Move auth keeper benchmarks to sep. file 2018-12-06 10:49:30 +01:00
Alexander Bezobchuk 5b42e83bc2 Merge PR #2995: Fully verify the signature in `gaiacli tx sign`
* Implement auxiliary methods/functions for just building a tx sig bytes

* Undo auxiliary methods/functions

* Validate signature

* Remove redundant comment

* Add pending log entry

* Minor cleanup

* Update sign cli doc

* Update cli sign offline flag doc

* Update printAndValidateSigs

* Implement TestGaiaCLIValidateSignatures

* Minor cleanup

* Fix linting

* Update x/auth/client/cli/sign.go

Co-Authored-By: alexanderbez <alexanderbez@users.noreply.github.com>

* Minor reformatting
2018-12-06 02:02:04 -05:00
Christopher Goes ba5e87ca6f x/auth module spec / code reconciliation (#2964) 2018-12-05 16:48:08 -08:00
Alexander Bezobchuk 6395e2a7ab Merge PR #2984: Removal of Mandatory Self-Delegation Reward
* Some minor cleanup and reformatting to make things easier to understand

* Update onDelegationSharesModified hook

* Add pending log

* Address PR comments

* Fix linting
2018-12-04 17:53:52 -05:00
Christopher Goes dfd00a661a Inflation bug fixes (#2982)
* PENDING.md; swap BeginBlocker ordering
* Calculate inflation every block
* Update x/mint spec
* Reset distribution info bond height instead
2018-12-04 10:17:02 -08:00
Alexander Bezobchuk bcfd93f544 Merge PR #2950: AnteHandler Cleanup
* Add and use CodeInvalidAccountNumber in ante handler

* Minor cleanup of ante handler

* Add pending log entry

* Spell check and more minor comment restructuring

* Add additional CodeInvalidAccountNumber

* Update validateAccNumAndSequence

* Revert account number error in favor of CodeInternal

* Update pending log

* Fix pending log
2018-12-04 17:42:15 +01:00
Jack Zampolin 886bd35670
Address gov cli ux issues and add additional input validation for better errors (#2938)
* Fix governance cli ux issues and add additional transaction validation
2018-12-03 12:48:51 -08:00
Dev Ojha 13e78166ee Merge PR #2977: Don't serialize Account Number and Sequence Number in signatures
* Don't serialize Account Number and Sequence Number in signatures

This was not needed to be included within the tx body, as its in the
state.

* fix lint
2018-12-03 18:29:50 +01:00
Christopher Goes 98caf44e35
Merge PR #2853: Write bank module specification, check spec/code consistency
* Update PENDING.md

* New structure

* Start transactions section

* Remove MsgIssue

* Update keepers.md

* Add state.md

* Update keepers.md, discovered #2887

* Move inputOutputCoins to BaseKeeper

* Remove no-loner-applicable tests

* More spec updates

* Tiny cleanup

* Clarify storage rationale

* Warn the user

* Remove extra newline
2018-11-29 22:56:42 +01:00
Hendrik Hofstadt b7736367a8 R4R: Fix duplicate json key in SetWithdrawAddress (#2944)
* Fix duplicate json key

* Update PENDING.md
2018-11-29 09:54:36 -08:00
Hendrik Hofstadt db77117a5b Only allow supported pubKey types (#2949)
* Only allow supported pubKey types
* Add type and supported types to error message
* Add default value for ConsensusParams
2018-11-29 09:21:45 -08:00
Christopher Goes b2b026b5e0
Merge PR #2930: Simulation spring cleaning
* Update PENDING.md
* Add simple period for expensive invariants
* Remove individual module simulations
* Simulate a few more blocks
* Add README explaining reason for shell scripts
* Deduplicate scripts, log exact replication command on failure
* Refactor invariants to take sdk.Context instead of baseapp.BaseApp
* Reference all issues in PENDING.md entry
* Remove no longer used simulation.RandSetup
* Bug fixes
* Address @rigelrozanski comments
* Fix typo
2018-11-29 16:17:10 +01:00
Hendrik Hofstadt ca43225851 Merge PR #2943: Fix tag usage in handlers and EndBlocker
* Fix tag usage in handlers and EndBlocker
* Prepend action tag in baseApp
* Fix LCD
* Remove unnecessary conversion
* Fix invalid consensus pubkey in CLI tests
* Fix tag usage in cli_test
* Shorten bechify in test
* Update docs and PENDING
2018-11-29 15:34:57 +01:00
Tony Stark f8ee8a7f78 Merge PR #2896: Fixed account sequence issue in IBC relay 2018-11-27 18:22:43 +01:00
Jae Kwon d1e76221d8
Jae/simulator improvements (#2900)
* Make simulator operations predetermined
* Use new dbm.ReverseIterator API
* Simulation speed improvements
* Pin exact revisions, not branches
* Rename 'MountStoresIAVL' to 'MountStores'
* Zero Power Block fees to community pool
2018-11-27 00:14:22 -08:00
Jae Kwon 7ec2b9a72b Fix merge conflict issues from previous squash commit 2018-11-26 04:27:23 -08:00
Christopher Goes ad121f1498 Add a flag to export for zero-height start (#2827)
Closes #2812

This PR adds the flag --for-zero-height to gaiad export, which runs several alterations to the application state to prepare for restarting a new chain in a consistent fashion.

It also:

* Moves Gaia's export code to cmd/gaia/app/export.go for cleaner separation.
* Fixes an inconsistency where we treated the initChainer as happening at height -1 - it should now happen at height 0, since the first header sent by Tendermint has height 1.
* Runs the runtime invariant checks on start (in initChainer)
* Adds a few auxiliary functions to clear slashing periods
* Removes the Height field from Delegation objects in x/stake, which was not used anywhere
2018-11-26 04:21:23 -08:00
frog power 4000 7cb1ba625e blockly minting (#2825)
* update mechanism to use average block time
* correctly sets accum height for zero-delegations
* update Decimal Format()
* clip withdrawal tokens
* PositiveDelegationInvariant
* DelegatorSharesInvariant
* DelAccumInvariants
2018-11-26 04:13:47 -08:00
Alessio Treglia 4c36b0fe05 Merge PR #2881: Don't call gaiacli tx sign. Use utils.SignStdTx() instead.
This is to avoid command redirection and reduce the use
of viper's global variables.

Closes: #2875
2018-11-26 12:50:33 +01:00
Sunny Aggarwal b7da2eaa33 Merge PR #2799: Account numbers and sequences to uint64 2018-11-26 12:29:21 +01:00
dongsamb 33d64b6163 Merge PR #2891: Remove redundant temporary code remDelPool when calc DelPool 2018-11-23 17:28:29 +01:00
John McDowall f09fa33cfd Merge PR #2802: Correct the usage of misspelling of English word 'depositor'.
Throughout the codebase the misspelling 'depositer' of the English word
'depositor' has been used. This commit applies a global search and
replace to correct the misspelling.
2018-11-22 00:53:33 +01:00
Alessio Treglia 3e68e44063 Merge PR #2874: gaiad gentx subcommands refactoring
* gaiad gentx subcommands refactoring

- Replace STDIN/STDOUT redirection in `gaiad gentx` with subcommands
  command line options to redirect streams to file since viper does
  not handle redirection well.
- Use `BuildCreateValidatorMsg` to build a `MsgCreateValidator` rather
  than redirecting to `gaiacli tx stake create-validator`.
- `PrintUnsignedStdTx` now takes an `io.Writer` object.
- Mark `--pubkey`, `--amount` and `--moniker` as required flags
  instead of validating them manually.
- Use stake.NewDescription() to make a new Description - ref #2835

* Refresh PENDING.md
2018-11-22 00:44:13 +01:00
Alexander Bezobchuk 1ea0e4c457 Merge PR #2863: Transaction ValidateBasic
* Add ValidateBasic to Tx interface
* Update BaseApp unit tests
* Add missing return in ValidateBasic
* Update ValidateBasic to use IsNotNegative
* Add pending log entry
* Add unit test TestTxValidateBasic
* Fix broken lint regression
* Add sig count check to validation
* Add test case to TestTxValidateBasic
2018-11-21 11:16:56 +01:00
Federico Kunze d227e2a29e Merge PR #2869: Gov tally endpoint
* Added tally endpoint
* Update querier.go
* rename queryable
* Address @alexanderbez comments
2018-11-21 10:54:51 +01:00
Alexander Bezobchuk 41fc538ac7 Add Safety Measures to Coin/Coins (#2797) 2018-11-20 01:22:35 -08:00
Alexander Bezobchuk 6e813ab3a8 Change gas & related fields to unsigned integer type (#2839)
* Change gas & related fields to unsigned integer type
* Implement AddUint64Overflow
2018-11-19 09:13:45 -08:00
Jack Zampolin f525717054
Standardize CLI Exports from Modules (#2840)
* Move query and tx commands to modules
* Move GetAccountDecoder to prevent import cycle and replace calls to it with one call in WithAccountDecoder
* Add moduleClients interface and implement in all applicable modules
* Use module clients in cli initialization
2018-11-19 09:02:34 -08:00
Christopher Goes fd968f7d8f R4R: Remove unused bank.MsgIssue (and prevent possible panic) (#2855)
* Remove all bank.MsgIssue code
2018-11-19 07:42:53 -08:00
Sunny Aggarwal 8d6b0929fb Codespaces as Strings (#2821) 2018-11-16 09:12:24 -08:00
Alessio Treglia 7b7d45ddd2 Merge PR #2800: Limit total number of signatures per transaction
* Limit total number of signatures per transaction
* Fail if limit is exceeded
* Loop over all sigs and count subkeys
* No need for a type switch, adopt early return
* Test rejection logic
* Mention sigs limit
2018-11-15 15:30:24 +01:00
gamarin2 addcfbf5cb Documentation Structure Change and Cleanup (#2808)
* Update docs/sdk/clients.md
* organize ADR directory like tendermint
* docs: move spec-proposals into spec/
* remove lotion, moved to website repo
* move getting-started to cosmos-hub, and voyager to website
* docs: move lite/ into clients/lite/
* move introduction/ content to website repo
* move resources/ content to website repo
* mv sdk/clients.md to clients/clients.md
* mv validators to cosmos-hub/validators
* move deprecated sdk/ content to _attic
* sdk/modules.md is duplicate with modules/README.md
* consolidate remianing sdk/ files into a single sdk.md
* move examples/ to docs/examples/
* mv docs/cosmos-hub to docs/gaia
* Add keys/accounts section to localnet docs
2018-11-14 11:44:17 -08:00
Christopher Goes 2bff5c2838
Merge PR #2748: Fix governance simulation, more import/export work 2018-11-14 19:20:50 +01:00
Sunny Aggarwal d1614ebb7e R4R: Query Gov Params (#2576)
* gov query params
2018-11-13 15:45:37 -08:00
Christopher Goes 267728f025 Clarify comment 2018-11-13 15:46:14 +01:00
Christopher Goes 3686a3f47d Only apply validator set updates on initial genesis 2018-11-13 15:38:29 +01:00
Christopher Goes 10713e3c8a Working on stake import/export 2018-11-13 15:08:14 +01:00
Christopher Goes d2a53539dd Merge branch 'develop' into cwgoes/fix-gov-sim-more-import-export 2018-11-13 14:23:15 +01:00
Federico Kunze a6af76e4be Merge branch 'sunny/get_all_delegations_validator_querier' of https://github.com/cosmos/cosmos-sdk into sunny/get_all_delegations_validator_querier
Merge
2018-11-12 23:13:05 +01:00
Federico Kunze 7dfeb7d27d use newQuery...Params 2018-11-12 23:12:25 +01:00
Jack Zampolin b255a7d59f
Merge branch 'develop' into sunny/get_all_delegations_validator_querier 2018-11-12 14:09:18 -08:00
Jack Zampolin 97c0251bf7 Fix redelegation command 2018-11-12 13:01:00 -08:00
Jack Zampolin b9b6f26c97
Merge pull request #2761 from WALL-E/patch-1
fix typo
2018-11-12 12:21:31 -08:00
Jack Zampolin 0345f38639
Merge pull request #2682 from cosmos/dev/sim_msg_edit_val
R4R: Make the simulator create the new comission rate sensibly
2018-11-12 11:13:00 -08:00
Christopher Goes bbf8e54616
Merge PR #2719: Cleanup bank keeper
* Cleanup bank keeper
* Address style comments
2018-11-12 20:06:28 +01:00