Commit Graph

1775 Commits

Author SHA1 Message Date
Alexander Bezobchuk db6cb238ab x/mint: use internal package (#4513)
Update minting module to utilize internal package
2019-06-08 17:17:21 +01:00
Alexander Bezobchuk dc84c99dee Revert "Generalize auth/types.StdSignature (#4507)" (#4512)
This reverts commit a32d5a46d7.
2019-06-08 11:04:52 +01:00
Alessio Treglia a32d5a46d7
Generalize auth/types.StdSignature (#4507)
New Signature interface available in the top level types package.
auth.StdSignature implements such interface. User defined auth
module can now define their own custom signature types.

Work carried out in the context of the following issues:
- #4488
- #4487
2019-06-07 14:21:35 +01:00
colin axner c777fb9108 Merge PR #4505: Support height queries in REST client 2019-06-07 09:02:07 -04:00
frog power 4000 1a2a54029c Merge PR #4502: InvariantRouter -> InvariantRegistry 2019-06-06 16:32:38 -04:00
Alexander Bezobchuk 86da70d8aa Use LTE instead of Equal (#4503) 2019-06-06 16:32:14 -04:00
Alexander Bezobchuk 3180e68c7b
Merge PR #4499: Remove Client Codec Redundancy 2019-06-06 11:43:15 -04:00
Alexander Bezobchuk 1ccf0c2e8d
Merge PR #4494: Fix validator-outstanding-rewards command 2019-06-06 09:43:13 -04:00
frog power 4000 5f9c3fdf88 Merge PR #4451: Client and Module Modularization 2019-06-05 19:26:16 -04:00
Federico Kunze 9c65e47329 Merge PR #4485: rename expected pkg to exported
* rename expected pkg to exported

* rename pkg
2019-06-05 13:42:25 -04:00
Federico Kunze d322e23425 Merge PR #4417: cleanup staking references from types pkg
* cleanup staking references from types pkg

* check interface on runtime

* fixes

* rename validator set from slashing keeper

* final cleanup

* fix test

* fix querier

* fix tests

* rename interfaces

* update bond status

* fixes

* expected pkg

* ensure expected keepers match used funcs

* cha cha cha
2019-06-04 15:06:58 -07:00
Federico Kunze fe695b8f7b Merge PR #4460: Gov Keys and Iterators
* refactor gov keys

* iterators and renamings

* invert queue key order

* changelog

* fix tests

* update alias.go

* Apply suggestions from code review

Co-Authored-By: Alexander Bezobchuk <alexanderbez@users.noreply.github.com>

* rename keys

* rename functions

* Apply suggestions from code review

Co-Authored-By: Alexander Bezobchuk <alexanderbez@users.noreply.github.com>

* address Aleks' comments

* fix test

* address Karoly's comments
2019-06-04 11:38:11 -07:00
colin axner 6e2f5f3102 R4R: Support "unknown commands" for subcommands (#4465)
Fixes #4284
Now prints:

gaiacli query distr comission --trust-node cosmos1234
ERROR: unknown command "comission" for "distr"

Did you mean this?
	commission

Adds custom argument validation for subcommands with subcommands. Doesn't affect "query" or "tx" subcommands since they reside in gaia repo. All flags except help are disabled for these commands.
2019-06-04 18:07:12 +01:00
Frank Yang 30550257a7 Merge PR #4456: Using `QueryWithData` to query unbonding delegations 2019-06-04 08:05:44 -04:00
colin axner 9c049321a1 Merge PR #4466: Lazy commission validation 2019-06-03 17:14:21 -04:00
4ever9 59ac148061 Merge PR #4469: refactor(querier): use err for return 2019-06-03 09:31:51 -04:00
Alexander Bezobchuk d204afbdae
Merge PR #4461: Port advisory patch to master 2019-05-31 11:14:40 -04:00
Alexander Bezobchuk 2414413e0b
Merge PR #4448: Implement Gov EndBlocker Failed Handler Test 2019-05-30 14:31:35 -04:00
frog power 4000 73e5ef7c13 reduce module interdependancy, /client refactor (#4415)
* abstract staking BuildCreateValidatorMsg, genutil defines its own flags

* client/ refactor

* staking move keys from keeper to types
2019-05-28 09:44:04 +01:00
Joon 91e75cb74a Merge PR #4403: Paramchange proposal skips omitempty fields 2019-05-27 20:47:12 -04:00
frog power 4000 38f49e4114
Merge PR #4389: stake invariance bug
* add trouble seed

* currentStakeRoundUp is now always atleast currentStake + smallest-decimal-precision

* remove unused code

* remove debugs

* @alexanderbez comment

* compile fix

* better comment, increase tolerance to 3 smallest decimal points
2019-05-24 21:23:53 -04:00
Juan Leni 68036ec71f Merge PR #4384: allow splitting withdrawal txs
* allow splitting withdrawal txs

* updating .pending

* small cleanup

* fixing build issue

* Update x/distribution/client/cli/tx.go

Co-Authored-By: Alessio Treglia <quadrispro@ubuntu.com>

* updating usage text

* fixing merge issue

* changes based on the review

* adding unit tests

* Update x/distribution/client/cli/tx.go

Co-Authored-By: Alexander Bezobchuk <alexanderbez@users.noreply.github.com>

* adjustments from review
2019-05-23 19:00:26 -04:00
Alexander Bezobchuk 4f197ff904
Merge PR #4396: Use TxSigLimit instead of default constant value 2019-05-23 14:08:51 -04:00
Alexander Bezobchuk 40518cb655
Merge PR #4395: Improve sig verification error message 2019-05-23 09:45:03 -04:00
Alexander Bezobchuk 80767474d7
Merge PR #4398: Refactor genaccounts genesis state 2019-05-22 17:06:49 -04:00
Christopher Goes dd89c32951 Community pool spend proposal (#4329)
Implement the "CommunityPoolSpendProposal" as described in Cosmos Hub proposal 7.

Also a useful test of Git flow for merging features passed in governance proposals.
2019-05-21 11:02:10 +01:00
Sunny Aggarwal cca3c3cbf2 Merge PR #4374: Don't Burn Deposits for Rejected Governance Proposals Unless Vetoed 2019-05-20 10:13:50 -04:00
frog power 4000 d9ac7d7c33 Merge PR #4349: Autogen alias files 2019-05-20 09:13:32 -04:00
Alexander Bezobchuk cfe31c4090
Merge PR #4372: Use Build's Client/Server Name 2019-05-18 19:06:08 -04:00
Alessio Treglia 71d71f2206
Remove gaia (#4347)
Gaia is removed from cosmos-sdk repository.

Few changes were required to make sure no packages depend on gaia subpackages.

CI config is amended accordingly.

Unnecessary targets are removed from Makefile.

Simulations run through a lightweight version of gaia renamed to simapp.

Closes: #4104
2019-05-18 10:42:24 +02:00
Nicolas Pinto f0b690ba6e Merge PR #4366: Random Fuzzer fix: avoids VotingPeriod=0 2019-05-17 19:46:43 -04:00
frog power 4000 cef788042b Merge PR #4365: Simulator bugfix for multisim 7601778 2019-05-17 19:45:36 -04:00
Nicolas Pinto fd9f322b8c Merge PR #4363: invalid 0stake deposit amount in sim
This fixes the "panic: Governance deposit amount must be a valid sdk.Coins amount, is 0stake" that can happen in the simulator if `DepositParams/MinDeposit` samples the integer `0`.
2019-05-17 16:51:55 -04:00
Alessio Treglia ca4363ffb7 Merge PR #4351: remove x/ dependency on cmd/gaia
* remove x/ dependency on cmd/gaia

This is an alternative patch to what is proposed in #4348

* Add pending entry

* Ditto for CollectGenTxsCmd

* Update pending

* Update tests

* Update pending
2019-05-16 21:34:54 -04:00
frog power 4000 5b7690e5e9
Merge PR #4346: report card minor fixes
* report card minor fixes

* fix
2019-05-16 21:32:20 -04:00
frog power 4000 3fe5869148
Merge PR #4159: Module/Genesis Generalization
* first commit

* gaia cleanup

* ...

* staking multihooks

* missing module function return args

* bank module name constant

* working, module interface for x/

* got this thing compiling

* make test compiles and passes

* remove expanded simulation invariants

* genesis issue

* continued

* continued

* register crisis routes thought mm

* begin blocker to mm

* end blocker to mm

* empty routes not initialized

* move gaia initChainer sanity check to baseapp

* remove codecs from module manager

* reorging genesis stuff

* module manager passed by reference/bugfixes from working last commit

int

int

* move invariant checks from gaia to crisis

* typo

* basic refactors cmd/gaia/init

* working

* MultiStakingHooks from types to x/staking/types

int

* default module manager order of operations from input modules

* working

* typo

* add AppModuleBasic

* moduleBasicManager / non-test code compiles

* working attempting to get tests passing

* make test passes

* sim random genesis fix

* export bug

* ...

* genutil module

* genutil working

* refactored - happy with non-testing code in cmd/

* ...

* lint fixes

* comment improvement

* cli test fix

* compile housing

* working through compile errors

* working gettin' compilin'

* non-test code compiles

* move testnet to its own module

* reworking tests

int

* bez staging PR 1 comments

* concise module function-of names

* moved all tests from genesis_test.go to other genutil tests

* genaccounts package, add genutil and genaccounts to app.go

* docs for genutil genaccounts

* genaccounts iterate fn

* non-test code with genaccounts/ now compiles

* working test compiling

* debugging tests

* resolved all make test compile errors

* test debuggin

* resolved all unit tests, introduced param module

* cli-test compile fixes

* staking initialization bug

* code comment improvements, changelog entries

* BasicGaiaApp -> ModuleBasics

* highlevel explanation in types/module.go

* @alexanderbez comment revisions

* @fedekunze PR comments

* @alexanderbez PR comments (x2)

* @cwgoes comments (minor updates)

* @fedekunze suggestions

* panic on init with multiple validator updates from different modules

* initchain panic makes validate genesis fail

int

* AppModuleGenesis seperation

int

* test

* remove init panic logic in validate genesis replaced with TODO

* set maxprocs to match system's GOMAXPROCS

* Update circleci

* Cap maxprocs in CI to 4

* @alexanderbez recent comments addressed

* less blocks in twouble sims

int

* runsim error output flag

* -e on import_export as well

* error out

int

* Try to fix failures

* runsim
2019-05-16 11:25:32 -04:00
Alexander Bezobchuk 44f972584d
Merge PR #4333: Remove Shares from Client Responses 2019-05-15 10:44:47 -04:00
Alessio Treglia 262c752863
Fix AppendTags usage error (#4336)
Fix AppendTags usage error

Thanks: @mjackson001 for the bug report and patch (original PR: #4274)
Closes: #4273
2019-05-14 16:13:18 +01:00
Frank Yang 7558f76079 Merge PR #4321: Improve offline flag doc 2019-05-13 10:51:48 -04:00
Alexander Bezobchuk 925070ae38
Merge PR #4292: Fix Signing Infos Endpoint 2019-05-09 13:38:15 -04:00
Alexander Bezobchuk 85ffce5f58
Merge PR #4306: Allow generate-only to fully operate offline 2019-05-08 16:06:05 -04:00
Alessio Treglia 06f7b2198a
Replace vet with golangci lint govet (#4277)
Drop go vet in favor of golangci-lint govet check.

Fix golangci-lint warnings.

Upgrade golangci-lint.
2019-05-06 17:50:05 +01:00
Frank Yang 1cfc868d86 Support query txs' TotalCount in GET /txs (#4214)
Closes: #3942
2019-05-04 12:09:02 +01:00
Alexander Bezobchuk 29ed730aff
Merge PR #4244: Param Proposal Simulation Messages; Minting Params Fix 2019-05-02 16:50:01 -04:00
Aaron Craelius 114de631a5 Allow custom key types and address formats (#4232)
Add additional parameter to NewAnteHandler for custom SignatureVerificationGasConsumer (the existing one is now called DefaultSigVerificationGasConsumer).

Add addressVerifier field to sdk.Config which allows for custom address verification (to override the current fixed 20 byte address format).

DefaultSigVerificationGasConsumer now uses type switching as opposed to string comparison.
Other zones like Ethermint can now concretely specify which key types they accept.

Closes: #3685
2019-05-02 20:36:42 +01:00
Alexander Bezobchuk 67f1e12eec
Merge PR #4253: Change User Supplied Param Change Value to json.RawMessage 2019-05-02 14:21:35 -04:00
Alexander Bezobchuk 5653c768bb
Merge PR #4234: Allow tx send (generate-only) to actually work offline 2019-04-30 12:47:26 -04:00
Alexander Bezobchuk 5ca93ac574 Merge PR #4206: Param Change Proposal
* Add params error types

* Update param module keeper to take a codespace

* Update imports

* Implement SetRaw and SetRawWithSubkey

* Implement ParamChange and update aliases

* Add types codec

* Implement ParameterChangeProposal

* Implement TestParameterChangeProposal

* Fix linting errors

* Update tags

* Implement content

* Updata params aliases

* Finish params handler and proposal types

* Move deposit and vote logic to types package

* Move proposal type to types package

* Move errors to types package

* Update proposal

* Move gov messages to types package

* Minor updates to naming

* Move keys to types package

* Move codec to types package

* Move proposal types to types package

* Update aliases

* Add governance alias types

* Implement governance router

* Update gov aliases

* Update gov keeper

* Update private functions needed for the keeper

* Update godocs

* Update the gov message handler

* Update Gaia app

* Make updates to auth

* Update the message codec in the keeper

* Update gov end blocker

* Update types tests

* Minor tweaks

* Add legacy genesis logic

* Update gov aliases

* Move gov keys to types package

* Revertt to using gov/types in params

* Implement params handler test

* Update governance tests

* Fix endblocker tests

* Fix governance querier tests

* Add seal support to gov router

* Update simulationCreateMsgSubmitProposal

* Disable software upgrade proposals

* Move params keys to types package

* Implement param module proposal client logic

* Update gov client logic

* Update gaia app client hooks

* Fix linting errors

* Fix ValidateBasic

* Remove legacy files

* Update paramchange to use strings

* Update paramchange cli cmd

* Update ValidateBasic and errors

* Use PostCommands when adding child cmds

* Fix codec logic

* Update params client and handler

* Update IsValidProposalType

* Update SubmitProposal to test exec

* Implement TestGaiaCLISubmitParamChangeProposal

* Implement TestSubmitParamChangeProposal

* Update swagger.yaml

* Update gaiacli.md

* Update gov spec docs

* Fix linting errors

* Fix unit tests

* Add pending log entries

* Update docs

* Update docs

* Update client/lcd/swagger-ui/swagger.yaml

Co-Authored-By: alexanderbez <alexanderbez@users.noreply.github.com>

* Update docs/cosmos-hub/gaiacli.md

Co-Authored-By: alexanderbez <alexanderbez@users.noreply.github.com>

* Update cmd/gaia/cli_test/test_helpers.go

Co-Authored-By: alexanderbez <alexanderbez@users.noreply.github.com>

* Update client/lcd/test_helpers.go

Co-Authored-By: alexanderbez <alexanderbez@users.noreply.github.com>

* Update docs/cosmos-hub/gaiacli.md

Co-Authored-By: alexanderbez <alexanderbez@users.noreply.github.com>

* Update docs/cosmos-hub/gaiacli.md

Co-Authored-By: alexanderbez <alexanderbez@users.noreply.github.com>

* Update docs/cosmos-hub/gaiacli.md

Co-Authored-By: alexanderbez <alexanderbez@users.noreply.github.com>

* Update x/gov/types/proposal.go

Co-Authored-By: alexanderbez <alexanderbez@users.noreply.github.com>

* Update docs/cosmos-hub/gaiacli.md

Co-Authored-By: alexanderbez <alexanderbez@users.noreply.github.com>

* Update docs/cosmos-hub/gaiacli.md

Co-Authored-By: alexanderbez <alexanderbez@users.noreply.github.com>

* Address PR comments

* Update docs/cosmos-hub/gaiacli.md

Co-Authored-By: alexanderbez <alexanderbez@users.noreply.github.com>

* Update gov docs to include quorum notes

* Add logs to handleParameterChangeProposal

* Update docs/spec/governance/02_state.md

Co-Authored-By: alexanderbez <alexanderbez@users.noreply.github.com>

* Support and use new StatusFailed when proposal passes but fails exec

* Add docs/notes warning on param validity

* Update docs

* Update docs/spec/governance/02_state.md

Co-Authored-By: alexanderbez <alexanderbez@users.noreply.github.com>

* Update docs/spec/governance/02_state.md

Co-Authored-By: alexanderbez <alexanderbez@users.noreply.github.com>

* Minor doc update

* Update x/gov/client/cli/tx.go

Co-Authored-By: alexanderbez <alexanderbez@users.noreply.github.com>

* Fix usage of fromAddr

* Rige code style  suggestion

* Update x/params/types/proposal.go

Co-Authored-By: alexanderbez <alexanderbez@users.noreply.github.com>

* Fix CI lint errors

* Update NewModuleClient godoc

* Add godoc to rtr.Seal() call

* Rename files

* Rename NewProposalHandler
2019-04-30 12:31:38 -04:00
Juan Leni 1306a25e42 Adding support for Ledger Cosmos App v1.5 (#4227)
This PR adds support for the latest version of the Cosmos App (v.1.5).
The app is not been released yet by Ledger but the PR is backwards compatible.
We can later remove backwards compatibility and enforce v1.5 only.

When creating a new account, `gaiacli` now shows the account/index and address in the device and requires user confirmation.

Related PRs:
https://github.com/cosmos/ledger-cosmos-go/pull/3
https://github.com/cosmos/ledger-cosmos-go/pull/4
https://github.com/cosmos/ledger-cosmos-go/pull/5
https://github.com/cosmos/ledger-cosmos-go/pull/6

Changes in the app can be found here:
https://github.com/LedgerHQ/ledger-app-cosmos/pull/5
2019-04-30 09:58:21 +01:00
Alexander Bezobchuk ec4a1e8f2a
Merge PR #4207: Add rewards and commission tags in txs 2019-04-26 19:11:45 -04:00
Jack Zampolin ea75ae5d47
Merge master into develop 2019-04-26 13:56:02 -04:00
Aleksandr Bezobchuk e7ca82d808
Merge branch 'develop' into release/v0.34.2 2019-04-25 21:40:33 -04:00
Alexander Bezobchuk 13bd5b62cf Release v0.34.2
* Merge PR #4163: Fix v0.33.x export script to port gov data correctly

* Remove TOC

* Add missing changelog entry for v0.34.1

* Merge PR #4182: Cherry pick #4083 into v0.34.2

* Merge PR #4181: Cherry pick 4135 v0.34.2

* Merge PR #4183: Cherry pick 4181 into v0.34.2 

* Support pagination and status query params for /staking/validators

* Rename BondStatusToString to String

* Cherry pick 4181

* Remove pending log

* Fix CODEOWNERS
2019-04-25 17:30:23 -04:00
xwartz 95e3d7d05e Merge PR #4189: Fix ErrNoInputs message typo 2019-04-25 09:16:38 -04:00
Alexander Bezobchuk 94bc55ef4f Merge PR #4183: Cherry pick 4181 into v0.34.2
* Support pagination and status query params for /staking/validators

* Rename BondStatusToString to String

* Cherry pick 4181

* Remove pending log
2019-04-24 12:03:55 -04:00
Alexander Bezobchuk c0e6b38394 Merge PR #4182: Cherry pick #4083 into v0.34.2 2019-04-24 11:51:49 -04:00
Alexander Bezobchuk 0e54369850 Merge PR #4177: Update Staking Validators Rest Query
* Support pagination and status query params for /staking/validators

* Rename BondStatusToString to String
2019-04-24 11:48:39 -04:00
Alexander Bezobchuk df6f2d6e25
Merge PR #4140: Fix Failed Simulation Seeds 2019-04-22 10:57:58 -04:00
Alessio Treglia 93e8f467fe
Turn --from into a positional argument in gaiacli tx send (#4146)
Closes: #4142
2019-04-18 19:48:52 +01:00
Alessio Treglia 769370801d Merge PR #4101: Return per-validator rewards when querying delegator rewards 2019-04-16 09:43:08 -04:00
Alessio Treglia 2581fffaa5 Merge PR #4126: Add module-wide named loggers
Closes: #4124
2019-04-15 23:58:06 -04:00
Alexander Bezobchuk 585b68ec70
Merge PR #4100: Return correct error on invalid messages 2019-04-15 12:25:04 -04:00
Aleksandr Bezobchuk 046932b084
Merge branch 'develop' into release/v0.34.0 2019-04-15 10:10:52 -04:00
Alexander Bezobchuk 722d122da7
Merge PR #4079: Implement Invariant Benchmarks 2019-04-12 18:52:16 -04:00
Alessio Treglia 3c88ddc2f5 Merge PR #4083: Replace gaiad --assert-invariants-blockly with --inv-check-period
* Remove old broken flag
* Support --inv-check-period which asserts invariants every nth period
2019-04-10 19:33:50 -04:00
frog power 4000 38e3fdfcea Merge PR #4094: Account for Rounding Errors in Distribution Calculations 2019-04-10 18:53:42 -04:00
Alexander Bezobchuk 94b7d8f467 Fix queryDelegatorTotalRewards (#4078)
Return [] instead of null by making the initial
value an empty slice literal opposed to nil.

Closes: #3705
2019-04-10 18:08:50 +01:00
Marin Basic b50b25d0a9 Replace all REST query empty result HTTP Status codes to 200 (#4065)
All query params that are empty now returns success
(http.StatusOK) instead of mixed http status codes
(http.StatusNoContent/http.StatusBadRequest/
http.StatusInternalServerError)

Closes: #2007
2019-04-10 18:07:21 +01:00
Federico Kunze 8550d87319 unified sender tag (#4057)
Closes: #3775
2019-04-10 18:03:44 +01:00
Alessio Treglia 1bd579dcdb
Fix tiny typo (#4085) 2019-04-10 13:11:02 +01:00
Federico Kunze eb51a6f84b remove duplicated account check and test (#4068) 2019-04-10 13:10:44 +01:00
frog power 4000 02a0e393c5 Run missing invariants during simulations (#4080) 2019-04-10 02:34:38 +01:00
Federico Kunze 2cd2289a11 add category tags (#4049)
Closes: #3774
2019-04-09 13:55:01 +01:00
wangjj9219 65338f6642 There's no check for chain-id in TxBuilder.SignStdTx #3945 (#3946)
Close: #3945
2019-04-09 13:46:13 +01:00
Federico Kunze c0a607ce74 fix and cleanup action tags (#4045)
Closes: #3966 #3793
2019-04-08 23:51:02 +01:00
frog power 4000 cec3065a36
Revert "Return errors instead of panic (#3782)" (#4054)
This reverts commit 985aae5575.
2019-04-05 16:20:58 -04:00
Alexander Bezobchuk 3361871198
Merge PR #4047: Fix queryDelegationRewards 2019-04-04 13:53:22 -04:00
Alessio Treglia 85021d4ca9
No packages must depend on cmd/gaia/ (#4048)
Preparation work for moving gaia out of the SDK.
2019-04-04 15:36:39 +01:00
Marin Basic 985aae5575 Return errors instead of panic (#3782)
This is related to issue #3741 where fetching data from
invalid store, package panic.

Modify subspace.go to return errors instead of panic.

Also update other packages that import subspace and
handle errors.
2019-04-04 08:10:56 +01:00
Alexander Bezobchuk e2928d5b70
Merge PR ##4007: Add Block Time in Txs Responses 2019-04-02 21:09:37 -04:00
Frank Yang bc8d2d4414 R4R: Rename validator.GetJailed() to validator.IsJailed() #3245 (#4017)
Closes: #3245
2019-04-02 15:43:22 +02:00
Alexander Bezobchuk b95ade93bd Merge PR #4011: Mint/Inflation Querier, LCD and CLI
* A few godoc updates

* More minor tweaks and reformatting

* Implement initial minting querier

* Implement stringer interface for minting params

* Minor cleanup

* Add minting CLI commands

* Implement inflation query command

* Implement annual provisions query and CLI command

* Update x/mint/client/module_client.go

Co-Authored-By: alexanderbez <alexanderbez@users.noreply.github.com>

* Update x/mint/client/module_client.go

Co-Authored-By: alexanderbez <alexanderbez@users.noreply.github.com>

* Update x/mint/client/module_client.go

Co-Authored-By: alexanderbez <alexanderbez@users.noreply.github.com>

* Update x/mint/querier.go

Co-Authored-By: alexanderbez <alexanderbez@users.noreply.github.com>

* Add minting REST client routes/handlers

* Fix build issues

* Implement querier unit tests

* Update gaiacli docs

* Implement LCD tests

* Update Swagger docs

* Add pending log entry

* add examples

Signed-off-by: Karoly Albert Szabo <szabo.karoly.a@gmail.com>

* revert adding examples

Signed-off-by: Karoly Albert Szabo <szabo.karoly.a@gmail.com>
2019-04-01 10:28:36 -07:00
frog power 4000 df4394185e
Merge PR #3656: Broken-Invar Tx - aka. Crisis module
* beginning thinking on issue

* ...

* working

* working

* working fee pool distribution

* spek outline

* spec update

* gas refund calculations

* simulation saved to ~/.gaiad/simulations/

* lean simulation output

int

* cleanup bank simulation messages

* operation messges

int

* lint

* move simulation to its own module

* move simulation log code to log.go

* logger overhaul

int

* distribution comments

* fix compiling

* cleanup modifications to x/distribution/keeper/allocation.go

int

int

int

* gov bug

* result.IsOK() minimization

* importExport typo bug

* pending

* address @alexanderbez comments

* simple @cwgoes comments addressed

* event logging unified approach

* distr module name constant

* implementing

* compiles

* gaia integration

* proper constant fee removal

* crisis genesis

* go.sum update

* ...

* debugging

* fix sum errors

* missing err checks

* working implementing CLI

* remove query command

* crisis expected keepers in other modules

* crisis testing infrastructure

* working

* tests complete

* modify handler to still panic if not enough pool coins, docs working

* spec tags

* docs complete

* CL

* assert invariants on a blockly basis gaiad functionality

* gaiad CL

* transaction details in runtime invariance panic

* Apply suggestions from code review

Co-Authored-By: rigelrozanski <rigel.rozanski@gmail.com>

* sender tags

* @mossid suggestions

int

* @cwgoes comments final

* Apply suggestions from code review

Co-Authored-By: rigelrozanski <rigel.rozanski@gmail.com>

* bug seems fixed (#3998)

* delete unused line in zero height export bug
2019-03-28 19:27:47 -04:00
Karoly Albert Szabo 5bb6090e38 Add route for querying signing_info for all validators (#3952)
Also remove duplicate pagination:
- move function to extract query params into types/rest
- adjust pagination values locally until available in tendermint for validators

Code cleanup:
- helper function in test
- fix pagination description in swagger.yaml
- uint instead of int when possible

Closes: #3226
Closes: #3991
2019-03-28 18:43:33 +00:00
Jack Zampolin 38b7c0705c Implement client functionality for the community pool (#3939)
Fixes: #3937
2019-03-28 01:05:36 +00:00
Alexander Bezobchuk f635b1cd14 Fix Proposal Stringer (#3986)
Fix the `Stringer` interface implementation for the `Proposal` type:
- Add missing description.
- Fix indentation.
2019-03-27 21:08:20 +00:00
Alexander Bezobchuk ea46da7126
Merge PR #3970: Fix Tx Sign Offline Mode
- Add shorthand flags `-a` and `-s` for the account and sequence numbers respectively
- Mark the account and sequence numbers required during "offline" mode
- Always do an RPC query for account and sequence number during "online" mode
  - If clients wish to provide such values, they must use `--offline`. This makes the whole flow/UX easier to reason about.

closes: #3893
2019-03-26 10:36:10 -04:00
Alexander Bezobchuk 59765cecb1 Merge PR #3857: Remove Shares Concept from Unbond/Redelegate UX
* Remove shares concept from unbonding and redelegation

* Remove redundant staking REST type declerations

* Rename staking REST request types

* Fix slashing tests

* Fix staking tests

* Fix integration tests

* Add safety checks for when validator tokens are zero

* Attempt to fix simulation

* Add pending log entry

* Update docs

* Implement and use SharesFromTokens

* Rename ShareTokens and ShareTokensTruncated

* Rename Delegation to Amount in DelegateRequest

* Implement and use SharesFromTokensTruncated

* Update MsgDelegate to use Amount instead of Value

* Use constructors in staking sim messages

* Implement and use ValidateUnbondAmount
2019-03-25 17:13:02 -04:00
Jack Zampolin f9c290f42e
Merge PR #3957: Remove requirement that deposit period and voting period linked 2019-03-22 13:47:04 -07:00
Frank Yang 424adf1461 Merge PR #3953: Codespace should be lowercase 2019-03-20 16:45:02 -07:00
Alexander Bezobchuk 386116f9e2 Merge PR: #3918 Allow Unrated Decreases to Validator Commission Rates
* Allow arbitrary decreases to validator commission rates

* Implement TestCommissionValidate

* Implement TestCommissionValidateNewRate

* Add comments to unit tests
2019-03-19 22:04:25 -04:00
Alessio Treglia cdf2b7a7c5
gometalinter -> golangci-lint migration (#3933)
{,scripts/}Makefile:
- Remove gometalinter, install golangci-lint.
- Remove distinction between tools and devtools.
  Just tools is enough.
- test_lint -> lint
  Migrating away from underscore separated names.
- Remove unnecessary targets.
- Drop tendermint/lint. Incompatbile with golangci-lint
  and no longer necessary anyway.
- Fix misleading message in go-mod-cache.
- New ci-target to avoid download tools twice.
- Run tests with -mod=readonly.

Port tools/gometalinter.json to .golangci.yml
Update CircleCI config accordingly.

Closes: #3896
2019-03-19 17:52:43 +01:00
frog power 4000 ea9aecdff4
Merge PR #3894: Minting mechanism explanatory docs
* minting spec concepts

* cl

* Update docs/spec/mint/01_concepts.md

Co-Authored-By: rigelrozanski <rigel.rozanski@gmail.com>

* typo address @alexanderbez

* Apply suggestions from code review

Co-Authored-By: rigelrozanski <rigel.rozanski@gmail.com>

* commit for CI to restart
2019-03-18 11:11:31 -04:00
Joon 465bb02d6a Merge PR #3779: Split Proposal Interface 2019-03-15 17:47:47 +01:00
frog power 4000 f0d1efa43c Merge PR #3819: Simulation Refactor 2019-03-14 19:13:15 +01:00
Frank Yang 7e53da86ee Merge PR #3884: steak to stake 2019-03-14 10:32:46 -04:00
Alexander Bezobchuk b316c477c1 Merge PR #3836: Fix WithdrawValidatorCommission 2019-03-12 16:10:20 +01:00
Alexander Bezobchuk e236607368 Merge PR #3801: BaseApp Security Improvements 2019-03-07 21:52:19 -08:00
Alessio Treglia fbd79d0cad Merge PR #3818: Introduce sdk.NewCoins 2019-03-07 16:55:08 -08:00
Alexander Bezobchuk d7fc4e98ab
Improve iterate validators dist. invariant (#3818) 2019-03-06 21:03:15 -05:00
Christopher Goes 4c50380181
Merge PR #3750: Outstanding per-validator rewards; correctly handle same-BeginBlock redelegation-double-slash 2019-03-06 19:54:12 +01:00
Jack Zampolin 805e7fbfc2 Merge PR #3806: Fix nil returned in Unmarshal functions
* Fix nils returned in unmarshal functions
* Address comments
2019-03-06 12:38:18 +01:00
Alexander Bezobchuk 51c03aa6fe Merge PR #3803: Validator Creation Updates 2019-03-05 17:55:46 +01:00
Samuel E. Moelius c7f6a3e8c6 Merge PR #3797: Have MsgCreateValidator.UnmarshalJSON return an error rather than panic. 2019-03-04 13:28:18 +01:00
Samuel E. Moelius 05529f9c13 Merge PR #3794: Write changes to store. 2019-03-04 13:27:01 +01:00
Samuel E. Moelius ad91605d77 Merge PR #3795: Make Redelgate log message consistent with others. 2019-03-04 13:26:12 +01:00
frog power 4000 52bf9ef9fd Revert "Merge PR #3762: Allow Validator w/ No Self-Delegation to Unjail (Transfers Disabled)"
This reverts commit c2aecb8b0e.
2019-03-01 19:04:37 -05:00
Alexander Bezobchuk 47a44fb580 Merge PR #3748: Multisig Display UX Improvements 2019-03-01 13:29:33 -08:00
Alexander Bezobchuk c2aecb8b0e Merge PR #3762: Allow Validator w/ No Self-Delegation to Unjail (Transfers Disabled) 2019-03-01 13:19:27 -08:00
Jack Zampolin 7ac01bd76a
Merge PR #3767: Added querier for auth module 2019-03-01 12:40:39 -08:00
Jack Zampolin bdf55d9610
Merge PR #3778: Fix improper distr msg tag 2019-03-01 11:15:53 -08:00
Tony Stark b5fa8dbf49
Merge branch 'develop' of https://github.com/cosmos/cosmos-sdk into develop 2019-03-02 00:08:56 +05:30
Alexander Bezobchuk 5d8b94979d Merge PR #3763: Disable ED25519 Account Keys 2019-03-01 09:12:28 -08:00
Tony Stark 7c3251fa26
Added a condition in querier 2019-03-01 08:49:18 +05:30
Sunny Aggarwal 172e2657ba Merge PR #3765: testing sequence increment if not enough balance for send 2019-02-28 12:50:41 -08:00
Tony Stark 2899ff9ce4
Added tests for querier 2019-03-01 01:11:14 +05:30
Tony Stark b42410ea80
Added custom querier 2019-03-01 01:10:32 +05:30
Jae Kwon 10bd98e58e Merge PR #3717: Allow the undelegation of more coins than were delegated; More validity checks. 2019-02-27 22:09:26 +01:00
Jae Kwon 7e08b62f4e Merge PR #3726: Cap(clip) reward to remaining coins in AllocateTokens 2019-02-27 21:38:57 +01:00
Christopher Goes e2baa3806a Merge PR #3758: Remove governance_penalty 2019-02-27 08:44:05 -08:00
Christopher Goes 7cddda7b05 Merge PR #3728: Alternative negative coins fix (floor multiplication) 2019-02-26 10:23:11 -08:00
Alexander Bezobchuk 6ace1fada2 Merge PR #3696: Cleanup Tx Broadcasting and Encoding 2019-02-26 12:34:27 +01:00
Alexander Bezobchuk feb98bcd05 Merge PR #3698: Prompt User Confirmation Prior to Signing & Broadcasting
* Prompt user confirmation prior to sign & broadcasting
* Update confirmation message
* Update and fix existing CLI integration tests
* Implement CLI integration test for tx confirmation
* Fix order of input into tx send
2019-02-26 12:34:01 +01:00
Alexander Bezobchuk b9be1166f7 Merge PR #3673: Message & Codec Registration Consistency 2019-02-25 16:16:52 +01:00
Alexander Bezobchuk c96d8f3e81 Merge PR #3713: Use from instead of name CLI flag for the tx sign cmd
* Use from instead of name CLI flag for the tx sign cmd
* Use cliCtx.GetFromName() instead of direct from value
2019-02-22 17:15:36 +01:00
frog power 4000 a814e5ce66
Merge PR #3679: Consistent Operators
* Minus->Sub Plus->Add Div->Quo

* pending

* Update PENDING.md

Co-Authored-By: rigelrozanski <rigel.rozanski@gmail.com>

* fix

* typo
2019-02-21 12:35:55 -05:00
Alexander Bezobchuk 992dc8b2dc Merge PR #3691: Minor Error Message Cleanup
* cleanup error messages

* Add pending log entry

* Rename Message to Error in ErrorResponse
2019-02-21 03:49:57 -05:00
frog power 4000 ab9de3a7f1
Merge PR #3680: Convenience ToDec()
* NewDecFromInt -> ToDec

* pending

* Update PENDING.md

Co-Authored-By: rigelrozanski <rigel.rozanski@gmail.com>

* test typo

* typo
2019-02-21 03:05:31 -05:00
Alexander Bezobchuk e39debd359 Merge PR #3674: Remove password/keybase from REST Client 2019-02-19 10:15:39 -08:00
frog power 4000 c0eec30840 Merge PR #3654: x/mint now uses total supply instead of bonded supply 2019-02-15 16:55:21 +01:00
Alexander Bezobchuk 26c13b28cd Merge PR #3607: Reconcile DecCoin/s API with Coin/s API 2019-02-15 16:33:23 +01:00
Alessio Treglia 1aa6c197ff Merge PR #3580: Code cleanup of client types 2019-02-14 08:53:36 -08:00
Aleksandr Bezobchuk afd90f88c1 add JSON struct tags to vesting accounts 2019-02-14 10:02:46 -05:00
frog power 4000 d66db6a772 Merge PR #3621: module inter-dependency cleanup 2019-02-13 15:01:50 -08:00
Alexander Bezobchuk 9c23fe68ee Merge PR #3604: Improve REST Error Messages & Allow Unicode 2019-02-11 15:12:43 -08:00
Zaki Manian 16bcf95f8f Other Bond Denom fixes 2019-02-09 12:40:38 -08:00
Zaki Manian e1996048f8 Merge PR #3574: Fixes for non-default staking token 2019-02-09 12:22:36 -08:00
Christopher Goes 02e9dcb3a7
Merge PR #3567: x/gov peer review 2019-02-09 03:33:06 +01:00
frog power 4000 7f74b33e21 Merge PR #3357: Staking spec upgrades / some renaming 2019-02-09 00:57:33 +01:00
Sunny Aggarwal da0426a2dd Merge PR #2601: Bech32 Empty Addresses 2019-02-09 00:54:40 +01:00
Alessio Treglia e7e3c32204 Merge PR #3553: Code cleanup, take #1
* add a bunch of tests, add DONTCOVER text tag

- Also fix flaky test (closes: #3559). Don't test values
  returned by queries since there's no way to query a
  specific height via REST.

* GetTempDir -> NewTestCaseDir
2019-02-08 22:45:41 +01:00
Jack Zampolin 2c9a5bc308 Merge PR #3554: x/auth and x/bank review results 2019-02-08 22:35:19 +01:00
Christopher Goes 6ee9c97a5e Merge PR #3561: Don't store denominations in staking 2019-02-08 13:28:53 -08:00
Ducem Barr 9348750eb4 Merge PR #3523: Add tx/encode endpoint and CLI command 2019-02-08 13:17:25 -08:00
Juan Leni b5fdb83830 Merge PR #3517: Increasing test coverage in keys/client package 2019-02-08 12:45:23 -08:00
Sunny Aggarwal cff985ffc5 Merge PR #3546: Min Self Delegation 2019-02-08 12:44:19 -08:00
Juan Leni ba63eb1801 Merge PR #3557: Removing pkg/errors when not necessary 2019-02-08 11:37:46 -08:00
Alexander Bezobchuk 7bc837aa06 Merge PR #3555: Reintroduce Fees OR Semantics 2019-02-07 18:14:54 -08:00
Christopher Goes 38068a59ea Merge PR #3507: Results from x/staking & x/slashing peer review 2019-02-07 17:41:23 -08:00
Jack Zampolin 408484e6d4
Merge PR #3503: CLI flags to args 2019-02-06 16:15:37 -08:00