a18f0b111a
Enable secp256r1 ( #8786 )
...
* enable secp256r1 in antehandlers
* Add sig verification benchamrk to find a sigverify fee
* adjust the gas fee
* enable secp256r1 in antehandlers
* Add sig verification benchamrk to find a sigverify fee
* adjust the gas fee
* Update the secp256r1 fee factor
* Update changelog
* regenerate docs
2021-03-04 21:31:42 +00:00
90e9370bd8
Replace tmcrypto.PubKey by our own cryptotypes.PubKey ( #7419 )
...
* WIP on removing tm pub/privkey
* Fix part of crypto tests
* Add PrivKeyLedgerSecp256K1 proto type
* Use BasePrivKey for ledger priv key type
* Refacto continued
* First round
* x/staking
* Continue porting
* x/* done
* Make build pass
* More conversion
* Remove IntoTmPubKey
* Fix test
* Remove crypto.PubKey in some other places
* Revert ledger changes
* Fix comment
* Remove useless function
* Add To/FromTmPublicKey
* Add migrate tests
* Fix test
* Fix another test
* Rename tm conversion functions
* Less code
* Rename BasePrivKey to LedgerPrivKey
* Add changelog
* Rename functions
Co-authored-by: Amaury Martiny <amaury.martiny@protonmail.com>
Co-authored-by: Alessio Treglia <alessio@tendermint.com>
2020-11-09 16:01:43 +00:00
91ca8ad3c1
Migrate BaseAccount PubKey to use Any ( #7268 )
...
* WIP on BaseAccount protobuf pub_key
* WIP on BaseAccount.PubKey
* WIP on BaseAccount pub key
* Update PubKey
* Update Account
* Docs
* WIP on protobuf keys
* Use Type() and Bytes() in sr25519 pub key Equals
* Add tests
* Add few more tests
* Update other pub/priv key types Equals
* Fix PrivKey's Sign method
* Rename variables in tests
* Fix infinite recursive calls
* Use tm ed25519 keys
* Add Sign and VerifySignature tests
* Remove ed25519 and sr25519 references
* proto linting
* Add proto crypto file
* Implement some of the new multisig proto type methods
* Add tests for MultisigThresholdPubKey
* Add tests for pubkey pb/amino conversion functions
* Move crypto types.go and register new proto pubkeys
* Add missing pointer ref
* Address review comments
* panic in MultisigThresholdPubKey VerifySignature
* Fix compile errors
* Remove pk conversion in ante handler
* Use internal crypto.PubKey in multisig
* Add tests for MultisigThresholdPubKey VerifyMultisignature
* Only keep LegacyAminoMultisigThresholdPubKey and move to proto keys to v1
* Remove conversion functions and introduce internal PubKey type
* Override Amino marshaling for proto pubkeys
* Merge master
* Make proto-gen
* Start removal of old PubKeyMultisigThreshold references
* Fix tests
* Fix solomachine
* Fix ante handler tests
* Pull latest go-amino
* Remove ed25519
* Remove old secp256k1 PubKey and PrivKey
* Uncomment test case
* Fix linting issues
* More linting
* Revert tests keys values
* Add Amino overrides to proto keys
* Add pubkey test
* Fix tests
* Use threshold isntead of K
* Standardize Type
* Revert standardize types commit
* Fix build
* Fix lint
* Fix lint
* Add comment
* Register crypto.PubKey
* Add empty key in BuildSimTx
* Simplify proto names
* Unpack interfaces for signing desc
* Fix IBC tests?
* Format proto
* Use secp256k1 in ibc
* Fixed merge issues
* Uncomment tests
* Update x/ibc/testing/solomachine.go
* UnpackInterfaces for solomachine types
* Remove old multisig
* Add amino marshal for multisig
* Fix lint
* Correctly register amino
* One test left!
* Remove old struct
* Fix test
* Fix test
* Unpack into tmcrypto
* Remove old threshold pubkey tests
* Fix register amino
* Fix lint
* Use sdk crypto PubKey in multisig UnpackInterfaces
* Potential fix?
* Register LegacyAminoPubKey
* Register our own PubKey
* Register tmcrypto PubKey
* Register both PubKeys
* Register interfaces in test
* Refactor fiels
* Add comments
* Remove old cosmos-sdk/crypto/keys reference
* Use anil's suggestion
* Add norace back
* Use our own ed25519
* Fix pubkey types
* Fix network tests
* Fix more tests
* Make ibc work?
* Use TM pubkey in NewValidator
* Fix lint
* Put interface in tpyes
* rerun CI
* Better name register
* Remove stray code
* Add ed25519 tests
* Check nil
* Correct interface impl assert
* rerun CI
* Add fix for Bech32
* Address comments
* FIx lint
* Add tests for solomachine unpack interfaces
* Fix query tx by hash
* Better name in amino register
* Fix lint
* Add back ed25519 test (fixes #7352 )
* go mod tidy
* Fix merge issues
* Sort import
* Add test for backwards-compatibility
* Fix tests
* Fix merge issue
* Update client/context.go
Co-authored-by: Cory <cjlevinson@gmail.com>
* Update types/address.go
Co-authored-by: Cory <cjlevinson@gmail.com>
* Address feedback
* Add comment
* Fix BaseAccount SetPubKey and address further comments
* Lint
* Remove unnecessary use of copy in getPubKeyFromString
* Update comment
Co-authored-by: Aaron Craelius <aaronc@users.noreply.github.com>
Co-authored-by: Aaron Craelius <aaron@regen.network>
Co-authored-by: Amaury Martiny <amaury.martiny@protonmail.com>
Co-authored-by: Alexander Bezobchuk <alexanderbez@users.noreply.github.com>
Co-authored-by: colin axnér <25233464+colin-axner@users.noreply.github.com>
Co-authored-by: Cory <cjlevinson@gmail.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
2020-09-25 08:41:16 +00:00
f5afdd0117
Robert/move amino stdtx ( #7301 )
...
* x/auth: move amino StdTx... to a legacy package
* legacytx: move RegisterLegacyAminoCodec from init to tests/init
* merge fixes
Co-authored-by: Aaron Craelius <aaron@regen.network>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
2020-09-22 14:35:18 +00:00
62b4aa9a14
Fix sequence number handling for LegacyAmino > SignatureV2 ( #7285 )
...
* add multi-sequence ante_test with explicit amino, test out alternative without SkipSequenceCheck
* add attempt at rest based test for full transactions
* drop extraneous ante_handler explicit amino test
* add rest handler test for multiple broadcasts, remove SkipSequenceCheck flag
* add godoc & cleanups
* add test case for incorrect sequence number
* remove artifact files
* Update x/auth/ante/sigverify.go
Co-authored-by: Zaki Manian <zaki@manian.org>
* Update sigverify.go
Co-authored-by: Alexander Bezobchuk <alexanderbez@users.noreply.github.com>
Co-authored-by: Alessio Treglia <alessio@tendermint.com>
Co-authored-by: Zaki Manian <zaki@manian.org>
2020-09-16 19:35:20 +00:00
320a852ee2
PubKey proto types ( #7147 )
...
* WIP on protobuf keys
* Use Type() and Bytes() in sr25519 pub key Equals
* Add tests
* Add few more tests
* Update other pub/priv key types Equals
* Fix PrivKey's Sign method
* Rename variables in tests
* Fix infinite recursive calls
* Use tm ed25519 keys
* Add Sign and VerifySignature tests
* Remove ed25519 and sr25519 references
* proto linting
* Add proto crypto file
* Implement some of the new multisig proto type methods
* Add tests for MultisigThresholdPubKey
* Add tests for pubkey pb/amino conversion functions
* Move crypto types.go and register new proto pubkeys
* Add missing pointer ref
* Address review comments
* panic in MultisigThresholdPubKey VerifySignature
* Use internal crypto.PubKey in multisig
* Add tests for MultisigThresholdPubKey VerifyMultisignature
* Only keep LegacyAminoMultisigThresholdPubKey and move to proto keys to v1
* Remove conversion functions and introduce internal PubKey type
* Remove old secp256k1 PubKey and PrivKey
* Uncomment test case
* Fix linting issues
* More linting
* Revert tests keys values
* Add Amino overrides to proto keys
* Add pubkey test
* Fix tests
* Use threshold isntead of K
* Standardize Type
* Revert standardize types commit
* Add comment
* Simplify proto names
* Add comment about multisig codec
Co-authored-by: Aaron Craelius <aaronc@users.noreply.github.com>
Co-authored-by: Amaury Martiny <amaury.martiny@protonmail.com>
Co-authored-by: Alexander Bezobchuk <alexanderbez@users.noreply.github.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
2020-09-16 11:08:55 +00:00
bae1399ebc
Add `SkipSequenceCheck` flag in SignatureV2 for Amino signatures ( #7234 )
...
* Add SkipSequenceCheck
* Fix test
* Fix test
* Add explicit amino test
Co-authored-by: Alexander Bezobchuk <alexanderbez@users.noreply.github.com>
2020-09-04 17:49:07 +00:00
3b9b58c931
Add height in exported genesis ( #7089 )
...
* Add height in exported genesis
* +1
* Add test
* Refactor ctx in setupApp
* Use amino in export
* Use tmjson
* Add custom initialVersion (set to 0 for now)
* Add comment
* Add mount in initChainer
* app.LastBlockheight
* InitializeAndSeal in InitChain?
* Revert create store with initial version
* Update to latest iavl
* Check height in test
* Make it work
* Add more tests
* Rename interface
* Use struct isntead of 6 args
* Fix lint
* Remove stray fmt
* Revert go mod/sum
* Install iavl rc3
* Update comments
* Add fee in network
* Typo
* Fix logic in commit
* Fix tests
* Only set initial version on > 1
* Genesis block num = 1
* Fresh chain, genesis block = 0
* Add comments
* Revert Mutable/ImmutableTree
* Allow for zero height
* Fix restart
* Add comments
* Add comments, fix test
* Fix remaining one test
* Add panic test
* Update comment
* Add test for --height
* No cast
* Add check that genesis file exists
* Remove duplicate imports
* Fail early
Co-authored-by: Alexander Bezobchuk <alexanderbez@users.noreply.github.com>
Co-authored-by: Jack Zampolin <jack.zampolin@gmail.com>
Co-authored-by: Cory <cjlevinson@gmail.com>
2020-09-03 10:11:46 +00:00
23a9f46aad
Update tm pubkey references ( #7102 )
...
* Update pubkey references
* Update ledger_mock
* Migrate encoding from tm
* Update pubkey prefix
* revert ed25519 to tendermint key
* random account revert
* Revert ed25519 references
* revert secp key name
* test revert
* remove ed25519
* Update x/staking/types/validator.go
Co-authored-by: Amaury Martiny <amaury.martiny@protonmail.com>
* Revert "remove ed25519"
This reverts commit 66d2e1d061aeae81c4c0a3daf718536b09dda19e.
* remove ed25519 & sr25519
* Apply suggestions from code review
* remove codec
Co-authored-by: Marko Baricevic <marbar3778@yahoo.com>
Co-authored-by: Amaury Martiny <amaury.martiny@protonmail.com>
2020-08-28 16:02:38 +00:00
50bab8f820
Put AccountSequence in SignerInfo ( #6997 )
...
* WIP test the grounds
* Update ADR020
* Fix compile errors
* Fix ADR
* Make ante tests pass
* Fix remaining ante handler tests
* Simplify code
* Fix x/bank app_test
* Fix tests
* Remove useless accSeq from signerdata
* Fix test
* Update simapp/helpers/test_helpers.go
Co-authored-by: Alexander Bezobchuk <alexanderbez@users.noreply.github.com>
* Update simapp/helpers/test_helpers.go
Co-authored-by: Alexander Bezobchuk <alexanderbez@users.noreply.github.com>
* Update x/auth/client/cli/tx_multisign.go
Co-authored-by: Alexander Bezobchuk <alexanderbez@users.noreply.github.com>
* Address rewview
* Update x/auth/ante/sigverify.go
Co-authored-by: Simon Warta <2603011+webmaster128@users.noreply.github.com>
* Update x/auth/ante/sigverify_test.go
Co-authored-by: Simon Warta <2603011+webmaster128@users.noreply.github.com>
* Update x/auth/tx/builder_test.go
Co-authored-by: Simon Warta <2603011+webmaster128@users.noreply.github.com>
* Update x/auth/tx/builder_test.go
Co-authored-by: Simon Warta <2603011+webmaster128@users.noreply.github.com>
* Update x/auth/tx/direct_test.go
Co-authored-by: Simon Warta <2603011+webmaster128@users.noreply.github.com>
* Update x/auth/tx/builder_test.go
Co-authored-by: Simon Warta <2603011+webmaster128@users.noreply.github.com>
* AccSeq -> Seq
* Address reviews
* Better variable naming
* Fix variable assign
* Remove old SetSignerInfo
* Fix test
* proto-gen
* Make proto-gen
* Reput gw comment
* Add Changelog
* Update x/bank/app_test.go
Co-authored-by: Alexander Bezobchuk <alexanderbez@users.noreply.github.com>
* Update x/bank/app_test.go
Co-authored-by: Alexander Bezobchuk <alexanderbez@users.noreply.github.com>
Co-authored-by: Alexander Bezobchuk <alexanderbez@users.noreply.github.com>
Co-authored-by: SaReN <sahithnarahari@gmail.com>
Co-authored-by: Simon Warta <2603011+webmaster128@users.noreply.github.com>
2020-08-21 14:20:47 +00:00
8de96d16f9
tendermint: update to rc3 ( #6892 )
...
* modify light imports
* change abci.header to tmproto.header
* use rc
* rc
* fix import
* Merge PR #6893 : fix key imports
* fix rc2
* tendermint: update 3 (#6899 )
* tendermint: update 4 (#6919 )
Co-authored-by: Alexander Bezobchuk <alexanderbez@users.noreply.github.com>
* tendermint: update 5 (#6923 )
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
* bump to latest master
* tendermint: update (#6972 )
Co-authored-by: Aleksandr Bezobchuk <aleks.bezobchuk@gmail.com>
Co-authored-by: Cory Levinson <cjlevinson@gmail.com>
* Update x/ibc/07-tendermint/types/test_utils.go
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
* address comment
* go mod
* bring back things
* fix test
* update tm proto files
Co-authored-by: Alexander Bezobchuk <alexanderbez@users.noreply.github.com>
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
Co-authored-by: Aleksandr Bezobchuk <aleks.bezobchuk@gmail.com>
Co-authored-by: Cory Levinson <cjlevinson@gmail.com>
Co-authored-by: Federico Kunze <federico.kunze94@gmail.com>
2020-08-14 13:58:53 -04:00
5c0e3b4de5
x/auth/ante: Migrate tests to use the new client.TxConfig ( #6661 )
...
* WIP: using encoding config
* Make it compile, test fails
* test should be okay
* Make tests pass
* Add comments
* Convert more tests
* Make TestAnteHandlerSigErrors work
* Make first 2 tests pass
* TestAnteHandlerAccountNumbers
* Use table tests
* Remove print
* Use test table
* TestAnteHandlerSigErrors
* TestAnteHandlerAccountNumbers
* TestAnteHandlerAccountNumbers
* Refactor TestAccount
* Refactor getSignBytes
* TestAnteHandlerAccountNumbersAtBlockHeightZero
* TestAnteHandlerSequences
* TestAnteHandlerFees
* TestAnteHandlerMultiSigner
* TestAnteHandlerBadSignBytes
* TestAnteHandlerSetPubKey
* TestAnteHandlerSigLimitExceeded
* TestCustomSignatureVerificationGasConsumer
* TestAnteHandlerReCheck
* Make all tests pass
* Refactor a little bit more
* Fee test
* SetupTest
* All tests pass
* Refactor to RunTestCase
* Don't use StdFee
* Revert some little stuff
* Finish up last couple of test cases
* Less verbose
* s/TxGenerator/TxConfig
* Add comments
* Indent
* Move KeyTestPubAddr to testdata
* Move testdata to /testutil
* Revert to use signature: nil step in signing
* Add comments
Co-authored-by: Alexander Bezobchuk <alexanderbez@users.noreply.github.com>
2020-07-20 08:30:12 -04:00
2f44fbf2ab
Add support for protobuf TxGenerator and SIGN_MODE_DIRECT ( #6385 )
...
* Add TxWrapper, encoder, decoder and DirectModeHandler
* fix pkg name
* Update API and leave test TODO's
* Update TxWrapper API
* tests for tx wrapper (#6410 )
* WIP: added test for direct mode handler
* updated code
* Add msg
* Update TxWrapper API
* Fix pubkey declaration
* Add pubkey for tests
* Fix SetFee
* Remove logs
* Avoid global var declaration for tests
* Add test for GetPubKeys
* Fix direct signing tests
* Add more test cases for GetSignBytes
* Revert SetFee API
* Remove logs
* Refactor tests
Co-authored-by: anilCSE <anil@vitwit.com>
Co-authored-by: sahith-narahari <sahithnarahari@gmail.com>
* Refactoring
* Refactoring
* Integrate SignatureV2 API
* Fix wrapper tests
* Fix tests
* Linting and API tweaks
* Update API
* WIP on updating API
* Fix tests
* Update to new SigVerifiableTx
* Rename
* Update docs to reflect ADR 020
* proto-gen
* proto docs
* cleanup
* cleanup
* cleanup
* cleanup
* cleanup
* cleanup
* cleanup
* Add tests
* Refactor and improving test coverage
* WIP on test coverage
* WIP on test coverage
* proto-gen
* Fix CompactBitArray.Size() bug
* Rename
* Remove Builder interface
* Address review comments
* Update x/auth/tx/sigs.go
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
* Update x/auth/tx/encoder.go
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
* Update x/auth/tx/encoder.go
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
* Address review feedback
* Fix build issues
* Resolve conflicts
* Fix ValidateBasic test coverage
* Add test for malicious multisig
Co-authored-by: atheeshp <59333759+atheeshp@users.noreply.github.com>
Co-authored-by: anilCSE <anil@vitwit.com>
Co-authored-by: sahith-narahari <sahithnarahari@gmail.com>
Co-authored-by: Alexander Bezobchuk <alexanderbez@users.noreply.github.com>
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
2020-07-06 17:03:45 +00:00
c0e48e1c43
Update ante handlers to use SignatureV2 ( #6428 )
...
* Update ante handlers to use SignatureV2
* WIP on test fixes
* WIP on test fixes
* Debugging CLI Tests
* CHANGELOG.md
* CHANGELOG
* Add missing tests for ante
* Add tests for verify signatures
* Update verify tests
* Fix register codec issue
* debug
* Cleanup
* Fix verify signature tests
* Remove viper
* remove keyring usage
* Fix review changes
* Fix simapp
* Fix ante tests
* Add reference issue
* Add test for multisignature
* Wrap sign error with sig
* Fix verify sign test
* Fix CHANGELOG.md
Co-authored-by: sahith-narahari <sahithnarahari@gmail.com>
Co-authored-by: anilCSE <anil@vitwit.com>
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
Co-authored-by: Alexander Bezobchuk <alexanderbez@users.noreply.github.com>
2020-06-29 20:48:41 +00:00
60f7edfe3d
Add SignatureV2 infrastructure ( #6373 )
...
* Updte tx generator
* Add sigv2, PublicKeyCodec
* revert changes
* revert changes
* updates
* Updates
* Integrate multisig support
* Undo move
* remove func
* undo
* godocs
* godocs, cleanup
* Cleanup
* godocs, tests
* lint
* Re-enable VerifyBytes
* Address comments
* Fix imports
* Update crypto/types/multisig/multisignature.go
* Add test for MultiSignatureData
* Add nested multisig case
* Add test for AddSignatureV2
* Add changelog
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
Co-authored-by: sahith-narahari <sahithnarahari@gmail.com>
2020-06-12 18:13:20 +00:00
71374d0eca
add contextual info to sigverify err msg ( #6355 )
...
* update sigverify error message
* whoops, use get sequence
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
2020-06-06 08:05:30 +00:00
81d647e505
Move codec.RegisterCrypto and codec.Cdc to new packages ( #6330 )
...
* Move codec.Cdc to legacy_global.Cdc
* Update CHANGELOG.md
* Updates
* nit
* Fix imports
* Updates
* Use cosmos multisig instead of tendermint multisig everywhere
* Fix tests
* Rename legacy_global -> legacy
* Add doc.go
* Linting, move all RegisterCrypto calls to crypto/codec
* Update crypto/codec/amino.go
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
2020-06-04 10:38:24 +00:00
f3962eb29b
fix #6287 sending multiple transactions from an account make nonce sequence stuck ( #6291 )
...
* fix #6287 sending multiple transactions from an account make nonce sequence stuck
* add change log
* fix ante unit test after #6287 fix
* Update x/auth/ante/sigverify.go
Co-authored-by: Alessio Treglia <alessio@tendermint.com>
Co-authored-by: Alessio Treglia <quadrispro@ubuntu.com>
Co-authored-by: Alexander Bezobchuk <alexanderbez@users.noreply.github.com>
2020-05-28 21:07:12 +00:00
bf8809ef98
Update x/auth to use Any ( #6165 )
...
* Migrate keeper codec to use marshaler
* Migrate AccountI to types
* Did go imports
* Fix tests for x/auth
* Cleanup std/codec
* Sort imports
* Fix legacy codec
* Add godoc for RegisterInterfaces
* Add RegisterInterfaces to std
* Fix typo
* Fixed merge changes
* Eliminate vesting import in auth
* Fix lint issues
* Fix tests
* Addressed comments
* Rename interfaces in RegisterInterfaces
* Removed codec.proto from std
* Minor code cleanup
Co-authored-by: Aaron Craelius <aaron@regen.network>
2020-05-20 19:21:00 +00:00
c15f112cf1
x/auth/ante: AccountKeeper expected interface used instead of the str… ( #6040 )
...
* x/auth/ante: AccountKeeper expected interface used instead of the strict auth.AccountKeeper dependency
* CHANGELOG.md update
2020-04-21 16:56:18 +00:00
7b21c54359
Fix IncrementSequenceDecorator ( #5950 )
...
* Fix IncrementSequenceDecorator
* Update PR #
* Update godoc
* Add TestIncrementSequenceDecorator test
2020-04-07 18:32:37 +00:00
794a496892
Merge PR #5533 : Protobuf: x/auth & x/supply
2020-02-18 13:50:13 +01:00
f367087731
Merge PR #5439 : Keybase: Multiple Signature Algorithms
2020-01-14 10:40:10 -05:00
02c6c9fafd
Merge PR #5268 : fix IncrementSequenceDecorator gas estimate
2019-10-31 16:08:35 -04:00
4cd18bcf35
Merge PR 5196: RecheckTx Optimizations
2019-10-23 10:43:58 -04:00
28347bf5f7
Merge PR #5195 : Move Signature Size calculation to TxSizeGasDecorator
2019-10-15 16:21:54 -04:00
c0223a4414
Merge PR #5006 : Modular AnteDecorator
2019-10-10 08:46:09 -04:00
Robert Zaremba
Marie Gauthier
Cory
Amaury Martiny
SaReN
Marko
Aaron Craelius
colin axner
ahmedaly113
Mikhail Kornilov
Alexander Bezobchuk
Sunny Aggarwal
Aditya