9fd720e63b
fix: support output flag on tx commands (backport #9717 ) ( #9771 )
...
* fix: support output flag on tx commands (#9717 )
<!--
The default pull request template is for types feat, fix, or refactor.
For other templates, add one of the following parameters to the url:
- template=docs.md
- template=other.md
-->
## Description
Closes : #9684
<!-- Add a description of the changes that this PR introduces and the files that
are the most critical to review. -->
---
### Author Checklist
*All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.*
I have...
- [ ] included the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json ) in the PR title
- [ ] added `!` to the type prefix if API or client breaking change
- [ ] targeted the correct branch (see [PR Targeting](https://github.com/cosmos/cosmos-sdk/blob/master/CONTRIBUTING.md#pr-targeting ))
- [ ] provided a link to the relevant issue or specification
- [ ] followed the guidelines for [building modules](https://github.com/cosmos/cosmos-sdk/blob/master/docs/building-modules )
- [ ] included the necessary unit and integration [tests](https://github.com/cosmos/cosmos-sdk/blob/master/CONTRIBUTING.md#testing )
- [ ] added a changelog entry to `CHANGELOG.md`
- [ ] included comments for [documenting Go code](https://blog.golang.org/godoc )
- [ ] updated the relevant documentation or specification
- [ ] reviewed "Files changed" and left comments if necessary
- [ ] confirmed all CI checks have passed
### Reviewers Checklist
*All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.*
I have...
- [ ] confirmed the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json ) in the PR title
- [ ] confirmed `!` in the type prefix if API or client breaking change
- [ ] confirmed all author checklist items have been addressed
- [ ] reviewed state machine logic
- [ ] reviewed API design and naming
- [ ] reviewed documentation is accurate
- [ ] reviewed tests and test coverage
- [ ] manually tested (if applicable)
(cherry picked from commit 92535034d6
2021-07-26 17:23:29 +02:00
33c045c3c9
fix memo flag description ( #9436 )
...
Co-authored-by: ryanchrypto <12519942+ryanchrypto@users.noreply.github.com>
Co-authored-by: Amaury <1293565+amaurym@users.noreply.github.com>
2021-06-02 13:50:59 +00:00
e3e89f5260
Rename memo to note inside CLI ( #9134 )
...
* rename Memo to note
* update change log
* typo
* address review changes
Co-authored-by: Amaury <1293565+amaurym@users.noreply.github.com>
Co-authored-by: atheesh <atheesh@vitwit.com>
Co-authored-by: atheeshp <59333759+atheeshp@users.noreply.github.com>
Co-authored-by: Amaury <1293565+amaurym@users.noreply.github.com>
2021-05-04 09:00:54 +00:00
96fe999343
Set proper default command output ( #8628 )
...
* Set proper default command output
* Removed duplicated cmd.SetErr(cmd.ErrOrStderr()) and cmd.SetOut(cmd.OutOrStdout())
* Moved command initialization and added CHANGELOG
* fix: groom all uses of cmd.Print*
* Ran make format
Co-authored-by: Michael FIG <mfig@agoric.com>
Co-authored-by: Alessio Treglia <alessio@tendermint.com>
Co-authored-by: Amaury <1293565+amaurym@users.noreply.github.com>
2021-04-17 00:21:32 +00:00
a78f777ea8
add reverse iteration to pagination ( #8875 )
...
* WIP
* add tests
* add tests
* fix lint
* fix pagination
* add proto message doc
* fix filtered_pagination
* fix test
* cleanup
* add reverse flag to pagination
* changelog
* Update client/flags/flags.go
* Update CHANGELOG.md
Co-authored-by: Alessio Treglia <alessio@tendermint.com>
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
2021-03-23 09:28:20 +00:00
3954c244b6
keyring: update documentation ( #8839 )
...
* keyring: update documentation
* Update docs/run-node/keyring.md
Co-authored-by: Barrie Byron <barrie.byron@tendermint.com>
* Update docs/run-node/keyring.md
Co-authored-by: Barrie Byron <barrie.byron@tendermint.com>
Co-authored-by: Barrie Byron <barrie.byron@tendermint.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
2021-03-11 15:17:43 +00:00
d97e7907f1
Add fee grant module ( #8061 )
...
* Add docs
* Add BasicFeeAllowance implementation
* Add expiration structs and complete basic fee
* Add delegation messages, add validation logic
* Add keeper and helper structs
* Add alias and handler to top level
* Add delegation module
* Add basic querier
* Add types tests
* Add types tests
* More internal test coverage
* Solid internal test coverage
* Expose Querier to top level module
* Add FeeAccount to auth/types, like StdTx, SignDoc
* Fix all tests in x/auth
* All tests pass
* Appease the Golang Linter
* Add fee-account command line flag
* Start on DelegatedDeductFeeDecorator
* Cleanup the Decorator
* Wire up delegation module in simapp
* add basic test for decorator (no delegation)
* Table tests for deduct fees
* Table tests over all conditions of delegated fee decorator
* Build full ante handler stack and test it
* Start genesis
* Implement Genesis
* Rename package delegation to subkeys
* Clarify antes test cases, handle empty account w/o fees
* Allow paying delegated fees with no account
* Pull mempool into delegated ante, for control on StdFee
* Use custom DelegatedTx, DelegatedFee for subkeys
* Revert all changes to x/auth.StdTx
* Appease scopelint
* Register DelegatedTx with codec
* Address PR comments
* Remove unnecessary DelegatedMempoolFeeDecorator
* Cleaned up errors in querier
* Clean up message sign bytes
* Minor PR comments
* Replace GetAllFees... with Iterator variants
* PrepareForExport adjusts grant expiration height
* Panic on de/serialization error in keeper
* Move custom ante handler chain to tests, update docs
* More cleanup
* More doc cleanup
* Renamed subkeys module to fee_grant
* Rename subkeys/delegation to fee grant in all strings
* Modify Msg and Keeper methods to use Grant not Delegate
* Add PeriodicFeeAllowance
* Update aliases
* Cover all accept cases for PeriodicFeeAllowance
* Et tu scopelint?
* Update docs as requested
* Remove error return from GetFeeGrant
* Code cleanup as requested by PR
* Updated all errors to use new sdk/errors package
* Use test suite for keeper tests
* Clean up alias.go file
* Define expected interfaces in exported, rather than importing from account
* Remove dependency on auth/ante
* Improve godoc, Logger
* Cleaned up ExpiresAt
* Improve error reporting with UseGrantedFee
* Enforce period limit subset of basic limit
* Add events
* Rename fee_grant to feegrant
* Ensure KeeperTestSuite actually runs
* Move types/tx to types
* Update alias file, include ante
* I do need nolint in alias.go
* Properly emit events in the handler. Use cosmos-sdk in amino types
* Update godoc
* Linting...
* Update errors
* Update pkg doc and fix ante-handler order
* Merge PR #5782 : Migrate x/feegrant to proto
* fix errors
* proto changes
* proto changes
* fix errors
* fix errors
* genesis state changed to proto
* fix keeper tests
* fix test
* fixed tests
* fix tests
* updated expected keepers
* updated ante tests
* lint
* deleted alias.go
* tx updated to proto tx
* remove explicit signmode
* tests
* Added `cli/query.go`
* Added tx.go in cli
* updated `module.go`
* resolve errors in tx.go
* Add fee payer gentx func
* updated tx
* fixed error
* WIP: cli tests
* fix query error
* fix tests
* Unused types and funcs
* fix tests
* rename helper func to create tx
* remove unused
* update tx cfg
* fix cli tests
* added simulations
* Add `decoder.go`
* fix build fail
* added init genesis code
* update tx.go
* fixed LGTM alert
* modified cli
* remove gogoproto extensions
* change acc address type to string
* lint
* fix simulations
* Add gen simulations
* remove legacy querier
* remove legacy code
* add grpc queries tests
* fix simulations
* update module.go
* lint
* register feegrant NewSimulationManager
* fix sims
* fix sims
* add genesis test
* add periodic grant
* updated cmd
* changed times
* updated flags
* removed days as period clock
* added condition for period and exp
* add periodic fee cli tests
* udpated tests
* fix lint
* fix tests
* fix sims
* renaming to `fee_grant`
* review changes
* fix test
* add condition for duplicate grants
* fix tests
* add `genTxWithFeeGranter` in tests
* fix simulation
* one of changes & test fixes
* fix test
* fix lint
* changed package name `feegrant` to `fee_grant`
* review comments
* review changes
* review change
* review changes
* added fee-account in flags
* address review changes
* read fee granter from cli
* updated create account with mnemonic
* Address review comments
* move `simapp/ante` file to `feegrant/ante`
* update keeper logic to create account
* update docs
* fix tests
* update `serviceMsgClientConn` from `msgservice`
* review changes
* add test case for using more fees than allowed
* eliminate panic checks from keeper
* fix lint
* change store keys string to bytes
* fix tests
* review changes
* review changes
* udpate docs
* make spend limit optional
* fix tests
* fix tests
* review changes
* add norace tag
* proto-docs
* add docs
Co-authored-by: Ethan Frey <ethanfrey@users.noreply.github.com>
Co-authored-by: Alexander Bezobchuk <alexanderbez@users.noreply.github.com>
Co-authored-by: Aleksandr Bezobchuk <aleks.bezobchuk@gmail.com>
Co-authored-by: SaReN <sahithnarahari@gmail.com>
Co-authored-by: aleem1413 <aleem@vitwit.com>
Co-authored-by: MD Aleem <72057206+aleem1314@users.noreply.github.com>
Co-authored-by: Anil Kumar Kammari <anil@vitwit.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
2021-01-29 19:54:51 +00:00
bce5da0e84
Use SignModeLegacyAminoJSON when signer is ledger key ( #8136 )
...
* Use SignModeLegacyAminoJSON when signer is ledger key
* Fix tests
* Fix lint
* Fix tests
* Add warning message
Co-authored-by: Alessio Treglia <alessio@tendermint.com>
2020-12-11 13:54:50 +00:00
5291a8ff31
Refactor Logging using Zerolog ( #8072 )
...
* init commit
* server: use flags
* server: godoc++
* updates
* baseapp: update logging
* logging updates
* x/bank: update logging
* logging updates
* lint++
* logging updates
* logging updates
* logging updates
* logging updates
* cl++
2020-12-03 23:17:21 +00:00
f3733aaecb
Merge PR #7485 : keyring-dir flag
2020-10-08 13:41:35 -04:00
cfb5fc03e5
Merge PR #7094 : Add x/auth cli tests
2020-09-13 09:52:09 -04:00
308c879b11
custom testnet cmd signing algorithms ( #7012 )
...
* custom testnet cmd signing algorithms
* update testutil network Config
* keyring options
* fix test
* typo
2020-08-12 08:34:10 +00:00
9ae17669d6
Tx Height Timeout ( #6089 )
...
* Implement TxHeightTimeoutDecorator
* Update error message
* rename type
* set height timeout
* update tests
* update *SignDoc)
* rename
* remove dup
* fix build
* cli updates
* rest updates
* cl++
* Update x/auth/ante/basic.go
Co-authored-by: colin axnér <25233464+colin-axner@users.noreply.github.com>
* Update x/auth/ante/basic.go
Co-authored-by: colin axnér <25233464+colin-axner@users.noreply.github.com>
* Update x/auth/ante/basic.go
Co-authored-by: colin axnér <25233464+colin-axner@users.noreply.github.com>
* Update x/auth/ante/basic.go
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
* rename
* rename
* remove TimeoutHeight from SignDoc
* updates
* fix tests
* update IBC cmd flags
* use omitempty
* update godoc
* add test case to TestStdSignBytes
Co-authored-by: colin axnér <25233464+colin-axner@users.noreply.github.com>
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
2020-08-07 23:32:22 +00:00
e906c012a0
add page flag for CLI queries ( #6824 )
...
* add page flag for CLI queries
* fix review suggestions
* Fix `page` flag default value
* fix offset calc
* Apply suggestions from code review
Co-authored-by: Aaron Craelius <aaron@regen.network>
* fix review suggestions
* refactor
* fix returning error
Co-authored-by: SaReN <sahithnarahari@gmail.com>
Co-authored-by: Aaron Craelius <aaron@regen.network>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
2020-07-24 08:17:11 +00:00
e6a56226a8
context: remove verifier & trust node ( #6805 )
...
* remove verifier
* more removal of trustnode flag
* add todo
* fix lint
* remove file
* remove viper and add link to issue
* remve mention of trustnode
2020-07-23 06:44:18 +00:00
61d69a978f
Merge PR #6806 : Docs & Cleanup
2020-07-21 11:28:43 -04:00
3123d07ad9
Update x/{mint,slashing,evidence} cli to use gRPC query client ( #6704 )
...
* changes cli to use gRPC in mint, slashing
* added command for signing infos
* gRPC query client migration of evidence
* review changes
* added unpack any
* fixed build error
* fixed failing tests issue
* added read flags
* added pagination flags
* updated docs
* fixed tests issue
* failing tests
* fixed tests
* review changes
* review changes
Co-authored-by: Anil Kumar Kammari <anil@vitwit.com>
2020-07-19 06:16:57 -04:00
c37f683cc1
x/staking: cli migration to use gRPC query client ( #6728 )
...
* migrated to use gRPC query client
* removed codecs usage
* review change
* added read command flags
* added pagination flags
* fixed limit issue
* added helper function for default pagination flags
* review changes
* review change
* review changes
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
2020-07-17 15:23:42 +00:00
a6ac7f496e
Tiny change to flag help description for gas-prices ( #6701 )
...
Co-authored-by: Alessio Treglia <alessio@tendermint.com>
2020-07-13 08:36:34 -04:00
e7554bb3b0
Fix Gas Flag Usage + CLI Flag APIs ( #6685 )
...
* Use new APIs
* fix usage
* fix usage of gas flag
* tests: TestParseGasSetting
2020-07-11 08:13:46 +00:00
e1476c1f9d
x/distribution: CLI & Module Tweaks ( #6684 )
...
* init commit
* cleanup methods
* fix
2020-07-10 19:59:26 +00:00
400c3cb08e
Merge PR #6652 : x/distribution: In-Process Testing & CLI Refactor
2020-07-10 10:45:46 -04:00
57ac28c814
client/flags: remove NewCompletionCmd() ( #6632 )
...
The functionality was adopted tendermint upstream, see
* https://github.com/tendermint/tendermint/pull/4665
2020-07-07 19:29:30 +02:00
d5049413ef
Merge PR #6525 : x/bank: Refactor CLI & Tests
2020-06-30 16:59:21 -04:00
c13809062a
Update TxBuilder to use SignatureV2 ( #6443 )
...
* Update TxBuilder to use SignatureV2
* Fix unit tests
* Lint
* lint
* Cleanup
* Address review feedback
* Add Sign tests
* Add more cases for sign tests
* Fix lint
* Fix gofmt
* Deprecate StdTx
* Undeprecate StdTx, but leave a comment to use the protobuf Tx
* Address review comment
Co-authored-by: anilCSE <anil@vitwit.com>
2020-06-16 19:57:37 +00:00
6a05b83069
Merge PR #6426 : Migrate API Server
2020-06-15 13:39:09 -04:00
8bd8d107a3
flags: fix "max-body-bytes" flag description ( #6180 )
2020-05-10 15:21:24 -04:00
bef3689245
linter: enable nolintlint ( #6162 )
...
* nolintlint enable
* remove space
* fix tests
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
2020-05-08 08:46:12 +00:00
fe9fe87693
REST: Add 'max-body-bytes' Flag ( #6167 )
...
* Add max-body-bytes flag for REST service
* Add changelog entries
* Change types
2020-05-07 17:49:08 +00:00
2414e5bdd4
x/auth: turn sign --validate-sigantures into a standalone command ( #6108 )
...
--validate-signatures should not be a flag of the sign command
as the operation performed (transaction signatures verification)
is logically distinct.
cli_test is and has always been an horrible name for package
directory as it's very much Go anti-idiomatic - _test is the
suffix used by test packages, not directories. Plus, CLI test
cases can and should live alongside other testcases that don't
require binaries to be built beforehand. Thus:
x/module/client/cli_test/*.go -> x/module/client/cli/
Test files that require sim{cli,d} shall be tagged with // +build cli_test
With regard to cli test auxiliary functions, they should live in:
x/module/client/testutil/
Co-authored-by: Alexander Bezobchuk <alexanderbez@users.noreply.github.com>
2020-05-04 13:55:16 +00:00
add93849bd
client/flags: bind keyring flag for query commands ( #5956 )
2020-04-08 15:00:59 +02:00
9cce836c08
crypto/keys: move keybase and keyring to crypto/keyring/ dir ( #5866 )
...
* crypto/keys: move keybase and keyring to crypto/keyring/ dir
* Update client/keys/root.go
* Update crypto/keyring/errors.go
* Update crypto/keyring/keybase.go
* Update crypto/keyring/options.go
* format
* changelog
* fix build
* format
* lint
2020-03-25 15:20:36 +00:00
230a1e8ba3
crypto/keys: improve documentation ( #5833 )
...
* crypto/keys: improve documentation
Remove out of date crypto/keys README.md file.
Populate client keys commands help screen with
more information regarding keyring backends.
* Fix formatting
* Fix lint warning
2020-03-19 16:58:14 +00:00
8c7bb89549
Implementing --offline flag ( #5810 )
...
Closes : #5448
2020-03-19 02:49:33 +01:00
e3dc0fd4a6
Merge PR #5671 : CORS - Add a Flag for CORS
2020-02-21 12:17:27 +01:00
5a0a36a8c9
Merge Pr #5585 : client and types additions for IBC
2020-01-30 10:13:42 -05:00
415eab7a56
Create new generic keyring constructor: NewKeyring ( #5547 )
...
Remove other convenience constructors:
* Remove NewKeyBaseFromHomeFlag
* Remove NewKeyringFromDir
* Remove NewKeyringFromHomeFlag
2020-01-22 17:54:56 +00:00
c1991e31bd
Merge PR #5527 : Bump Tendermint Version to v0.33.0
...
* Bump Tendermint version to v0.33.0
* Deprecate old cmn package with new packages
* Update update DB APIs
* More DB updates
* Bump IAVL to v0.13.0
* Handle error returned by iavl.NewMutableTree
* Fix some IAVL stuffs
* Update IAVL
* More updates
* Passing tests
* Fix unit tests
Co-authored-by: Jack Zampolin <jack.zampolin@gmail.com>
2020-01-16 13:46:51 -08:00
3c82b66347
Merge PR #5427 : Remove code duplication in x/auth/client/cli
2019-12-27 10:23:18 -05:00
394860068d
keyring's encrypted file backend integration ( #5355 )
...
Client commands accept a new `--keyring-backend` option through which users can specify which backend should be used by the new key store:
- os: use OS default credentials storage (default).
- file: use encrypted file-based store.
- test: use password-less key store (highly insecure).
2019-12-11 09:45:26 +00:00
6d5ca0b4f1
Remove print response flag ( #4593 )
...
This flag isn't used anywhere and probably hasn't for quite some time.
2019-06-20 14:26:48 +02:00
8cc708b67c
Remove --cors flag ( #4525 )
...
The feature is long gone.
Thanks: Angelo Recca <a.recca@bitsong.io> for reporting this.
2019-06-10 17:01:48 +01:00
8b1d75caa2
Merge PR #4382 : Support height queries for queriers
2019-05-28 20:58:33 -04:00
73e5ef7c13
reduce module interdependancy, /client refactor ( #4415 )
...
* abstract staking BuildCreateValidatorMsg, genutil defines its own flags
* client/ refactor
* staking move keys from keeper to types
2019-05-28 09:44:04 +01:00
mergify[bot]
Ryan Christoffersen
Anil Kumar Kammari
Riccardo Montagnin
MD Aleem
Alessio Treglia
atheeshp
Amaury
Aleksandr Bezobchuk
Federico Kunze
Marko
billy rennekamp
Aaron Craelius
Jonathan Gimeno
frog power 4000