I removed that stuff about cwwMutex and CacheWraps expiring. It was unnecessary complexity given that users need not write concurrent logic. If you have 2 CacheKVStores and you Write on one and later you Write on the other one, they will both write, and strange things may happen. But that’s OK, it’s kinda the expected (unsurprising) behavior. And now the code is much simpler.
Also I got rid of IterKVStore. It’s not necessary to distinguish them because we can have KVStore.Iterator() return nil or panic or an empty iterator. Further simplification…
KVStore.CacheKVStore() doesn’t exist. No need, just call NewCacheKVStore(parent).
Originally I wanted the .CacheKVStore() method because you can make the implementor be responsible for ensuring that returned CacheWraps don’t trample each other. But as written previously this complicates the code a lot more and it isn’t strictly necessary. It’s a kind of magic that maybe should just be avoided.
sdk.Iterator is dbm.Iterator. The plan is to conservatively add more aliases into the “sdk” namespace.
GetError() is removed from Iterator. We need to just panic to be consistent. More simplification.
rigelrozanski
Sunny Aggarwal
Christopher Goes
Ethan Buchman
Ethan Frey
Jae Kwon