Commit Graph

406 Commits

Author SHA1 Message Date
rigelrozanski 2355e5ae6e ... 2018-07-02 20:05:52 -04:00
rigelrozanski b3d6a59c61 ... 2018-07-02 18:58:52 -04:00
rigelrozanski ab4661f88b bug somewhere here 2018-07-02 18:16:47 -04:00
Ethan Buchman f78f30c67a update for tm v0.22.0. tmlibs->tendermint/libs 2018-07-02 16:34:06 -04:00
Rigel f1937bc0e7
Merge branch 'develop' into rigel/stake-spec-compliance 2018-07-02 12:06:20 -04:00
Dev Ojha 6a864923fa types: Rename rational.Evaluate to rational.Round (#1487)
* rational.Evaluate -> rational.RoundInt64
	* rational.EvaluateInt -> rational.RoundInt

This done to improve clarity of the code.

Closes #1485
2018-07-02 11:57:33 -04:00
Christopher Goes 3654579ea7
Merge PR #1278: Slashing v2
Implement semifinal Gaia slashing spec (#1263), less #1348, #1378, and #1440 which are TBD.
2018-06-30 05:34:55 +02:00
Dev Ojha 955a0c9af7 Switch asserts to require (#1483)
* meta: Switch the majority of asserts to require

Switch most assert statements to require, to ease debugging.
Closes #1418

* Fix imports
2018-06-30 03:10:15 +02:00
Dev Ojha 097dd8a164 tools: Add unparam linter (#1443)
* tools: Add unparam linter

unparam detects unused parameters in functions, and a parameter to
a function which only ever takes on one value. The latter is an
indication that more tests are required.

There are many nolints in this PR, as I believe that writing tests
to fix alot of these situations is out of scope for this PR / it
will be changed in future commits. There are some nolints for
when we have to comply to normal api's.

* crypto/keys no longer used by x/gov/client/rest/rest.go
2018-06-29 18:22:24 -04:00
Dev Ojha 47e4682d9f Merge PR #1415: x/stake: Limit the size of rationals from user input
* x/stake: Limit the size of rationals from user input

This commit sets the maximum number of decimal points that can be
passed in from messages. This is enforced on the validate basic of
MsgBeginUnbonding and MsgBeginRedelegation. The cli has been
updated to truncate the user input to the specified precision. This
also updates types/rational to return big ints for Num() and Den().

Closes #887

* Switch NewFromDecimal to error instead of truncating
2018-06-29 22:30:12 +02:00
Dev Ojha 94a3ce4c83 docs: Explain the expected return type within the store (#1452) 2018-06-29 13:45:11 -04:00
Christopher Goes 59aadf42aa
Ledger integration (#931)
Merges the keybase and Ledger code from go-crypto (which is no more) into the SDK
Adds support for Ledger into gaiacli
Cherry-picks updated error handling from #1158
2018-06-29 02:54:47 +02:00
Dev Ojha ac3adff1e8 Merge PR #1438: Tools: Add errcheck linter
This linter ensures that all errors are checked.
This is disabled in the client directories, since its not needed on
those writes
2018-06-29 00:52:10 +02:00
Dev Ojha 3e14868bd6 Merge PR #1429: tools: Add ineffassign linter
* tools: Add ineffassign linter

This errors on assignments that don't actually do anything. i.e.

x, err := myFunc(1)
y, err = myFunc(2)

This will call out that the first function's call error was never
used.

* Fix makefile, add misspell to makefile
2018-06-28 19:12:02 +02:00
Sherry Ma e7797835e2
Merge branch 'develop' into develop 2018-06-28 10:02:52 +08:00
Dev Ojha 6d9f07dfee tools: Add go vet as a linter (#1421)
* tools: add go vet

* tools: Add go vet as a linter
2018-06-27 20:32:06 -04:00
Rigel 50733f5c22
Merge branch 'develop' into develop 2018-06-27 19:22:48 -04:00
Rigel 6f140d7296 Merge PR #1119: Unbonding, Redelegation
* stake/fees spec updates
* staking overview.md revisions, moving files
* docs reorganization
* staking spec state revisions
* transaction stake updates
* complete staking spec update
* WIP adding unbonding/redelegation commands
* added msg types for unbonding, redelegation
* stake sub-package reorg
* working stake reorg
* modify lcd tests to not use hardcoded json strings
* add description update
* index keys
* key managment for unbonding redelegation complete
* update stake errors
* completed handleMsgCompleteUnbonding fn
* updated to use begin/complete unbonding/redelegation
* fix token shares bug
* develop docs into unbonding
* got non-tests compiling after merge develop
* working fixing tests
* PrivlegedKeeper -> PrivilegedKeeper
* tests compile
* fix some tests
* fixing tests
* remove PrivilegedKeeper
* get unbonding bug
* only rpc sig verification failed tests now
* move percent unbonding/redelegation to the CLI and out of handler logic
* remove min unbonding height
* add lcd txs
* add pool sanity checks, fix a buncha tests
* fix ante. set lcd log to debug (#1322)
* redelegation tests, adding query functionality for bonds
* add self-delegations at genesis ref #1165
* PR comments (mostly) addressed
* cleanup, added Query LCD functionality
* test cleanup/fixes
* fix governance test
* SlashValidatorSet -> ValidatorSet
* changelog
* stake lcd fix
* x/auth: fix chainID in ante
* fix lcd test
* fix lint, update lint make command for spelling
* lowercase error string
* don't expose coinkeeper in staking
* remove a few duplicate lines in changelog
* chain_id in stake lcd tests
* added transient redelegation
* 'transient' => 'transitive'
* Re-add nolint instruction
* Fix tiny linter error
2018-06-27 04:00:12 +02:00
Sunny Aggarwal 9ca3a16bb3 Merge PR #1397: Fix spelling changes
* fixed spelling changes
* extra spelling error
2018-06-27 01:58:42 +02:00
7768 4f57a765ad Merge PR 1354: CLI: Show fractional in human-readable format
Fix https://github.com/cosmos/cosmos-sdk/issues/1353

before:
```
Shares: Status Bonded,  Amount: -6508168128760126341/-3308135364330552608
Delegator Shares: -6508168128760126341/-3308135364330552608
```
after:
```
Shares: Status Bonded,  Amount: 2.0000000000
Delegator Shares: 2.0000000000
```
2018-06-26 19:26:12 +02:00
Sherry Ma 1a67dc5d7c
Changed decode delegator address function
In delegation query, the function to decode the address of delegator should be using Bech32 but not Hex
2018-06-22 18:37:15 +08:00
Joon ec6acda6a4 Merge PR #1331: Remove TxBytes from NewContext 2018-06-22 03:03:05 +02:00
Sunny Aggarwal dc2c8f900b Merge PR #1168: Governance MVP 2018-06-22 02:19:14 +02:00
Aditya f049a56376 Merge PR #1266: Multiple messages
* Started work on multiple msgs, types and x/auth tests pass
* Fix issues in x, examples, and baseapp
* Added baseapp tests for multiple msgs
* Documentation fixes
* Fix baseapp tests with sdk.Int
* Modify test
* Transaction handling is now atomic
* Fix test comment
* Minor doc fixes and code cleanup
* Added baseapp result changes
* Use address in validator update accumulation
* Started work on multiple msgs, types and x/auth tests pass
* Fix issues in x, examples, and baseapp
* Added baseapp tests for multiple msgs
* Documentation fixes
* Fix baseapp tests with sdk.Int
* Modify test
* Transaction handling is now atomic
* Fix test comment
* Minor doc fixes and code cleanup
* Added baseapp result changes
* Use address in validator update accumulation
* Added ante tests for multisigner
* Remove validatorUpdates from tx result
* Better error logs
* Put Memo in StdSignBytes and formatting
* Updated changelog
2018-06-22 00:05:25 +02:00
Dev Ojha e2d23040a8 Merge PR #1325: Refactor Complete Setup to not take in a testing parameter
* Refactor Complete Setup to not take in a testing parameter
* Update changelog
2018-06-21 18:55:08 +02:00
Joon 314b5a854d Merge PR #1218: sdk.Int in sdk.Coin
implement Int, Int256, Uint256
pass ci
pass ci
add to changelog, add boundcheck to test
add comments, fix cli_test.go
fix errors
apply requested changes
panics on New*WithDecimal
fix Int.BigInt()
fix stake tests
* Panic on uint division-by-zero
* Set ok=false on NewIntFromString, NewUintFromString failure
* Nuke CircleCI caches
2018-06-15 23:16:45 +02:00
Ethan Buchman 1cac5e7a0f Merge branch 'develop' into rigel/spec-staking 2018-06-14 11:22:29 -07:00
Fabian 42e72956f4 Merge PR #1252: Query node version
introduce non store queries
add version query
update lcd spec
changelog
moved version query into baseapp
2018-06-14 07:49:21 +02:00
rigelrozanski 14c1ff27f3 Merge remote-tracking branch 'origin/develop' into rigel/spec-staking 2018-06-13 20:50:59 -07:00
David Kajpust ec2fedd36c Merge PR #1227: Set all Error strings 1st letters to lowercase. Fixes issue #1154 2018-06-13 21:13:22 +02:00
Rigel 83c1183e25 Merge PR #1233: Inflation now unbonded
working debug fix
add broken test
fix testnet bug
updated provision test
changelog
cwgoes comments
2018-06-13 09:12:57 +02:00
Sunny Aggarwal 161cb474d4 Account Numbers for Replay Protection with Account Pruning (#1077)
* in progress
* passes current tests
* added tests and got working
* changelog and docs
* removed prints
* oops
* works!
* issue in test_cli
* number 9 number 9 number 9
* at least it does only the 9 issue now
* hallelujah it works!
* removed print statement
* rebased
* gah
2018-06-12 04:30:54 +02:00
Rigel 1b20adcd22 Merge PR #1191: LCD cleanup / add LCD gas field
* remove global variables from lcd
* added make race, fix lcd race condition
* cleanup
* Five-character changelog update
2018-06-12 03:12:37 +02:00
Rigel fc0e401327
Merge pull request #1153 from davekaj/davekaj/addProvisionTests
Writing more provision tests in tick_test.go (updated for refractor)
2018-06-11 02:10:42 -07:00
Rigel 0b9751ac98
Merge pull request #1170 from cosmos/rigel/test_framework
mock test framework for modules
2018-06-08 13:30:24 -07:00
rigelrozanski 17948ccf04 auth-mock simulate block now commits, stake app_test cleanup 2018-06-08 11:28:07 -07:00
rigelrozanski abab7c2e42 modules test within mock application 2018-06-07 20:55:14 -07:00
Christopher Goes 971e1489b2
Bech32ify msg.GetSignBytes() for x/slashing & x/stake 2018-06-08 01:24:08 +02:00
mossid 04d6ce6898 add revoked prefix to key, add condition in getbypower 2018-06-06 18:25:00 -07:00
David Kajpust 78703f027d fixed small breaking changes from pulling in develop 2018-06-06 15:49:22 -04:00
David Kajpust 33a5e01264 fixed merge conflicts 2018-06-06 14:14:51 -04:00
David Kajpust 5352b65078 Added TestInflationWithRandomOperations 2018-06-06 14:05:51 -04:00
David Kajpust 5aa6c96cb6 added Large Bond test for provisions 2018-06-06 13:11:36 -04:00
Christopher Goes 3fbee11ccc
Merge PR #1142: Export validators to genesis
* Validator export skeleton
* Update export command, add tests, update CHANGELOG
* Rename exportAppState to exportAppStateAndTMValidators
2018-06-06 18:38:13 +02:00
David Kajpust 7cb404d578 created a test to check large unbonds lower bonded ratio 2018-06-06 09:55:34 -04:00
Fabian 5f409ce832 Merge PR #1086: Bech32Cosmos output/input for the LCD
* refactored bech32ization
* updated keys endpoints for bech32
* bech32 for sending and querying
* trying to change output of validator addresses
* fixed validator output
* linted
* fixed merge conflict
* added bech32 to staking endpoints
* removed some logging statements
* added GetAccPubKeyBech32Cosmos
* fixed cli tests
* updated swagger
* merged standard bech32 change
* renamed bech32cosmos to bech32
* bech32ify json output for key add
* readded changelog
* fixed changelog merge issue
* Update CHANGELOG.md
2018-06-06 06:53:04 +02:00
David Kajpust 8d470e5410 TestHourlyInflationRateOfChange() added, checks 11.4 years of inflation 2018-06-05 23:12:28 -04:00
David Kajpust 89d6264587 simplified TestProcessProvisions into 4 repeatable funcs. fixed a small bug in it 2018-06-05 23:02:31 -04:00
rigelrozanski 25ae026958 spec complete unbonding, redelegation txs 2018-06-05 09:23:23 -07:00
rigelrozanski e39ba70c08 complete staking spec update 2018-06-05 09:23:23 -07:00
rigelrozanski 35956c1c78 staking spec state revisions 2018-06-05 09:23:23 -07:00
Christopher Goes be7ec5bc07
Merge PR #1115: Update SDK to ABCI v11 2018-06-05 01:42:01 +02:00
rigelrozanski 0ef3259a39 revised use of EndBlock/BeginBlock, basecoin updated for staking/slashing 2018-06-01 14:24:48 -07:00
Zaki Manian ce850dca3b Switch from bech32cosmos to bech32 2018-06-01 16:23:58 +02:00
David Kajpust 424ce545ef autogen addr func updated for 999 addrs if needed 2018-06-01 11:39:23 +01:00
David Kajpust 7b4c632066 autogenerate testaddrs func created 2018-06-01 10:51:38 +01:00
rigelrozanski 952aedc4f1 get rid of candidacy references 2018-05-31 14:57:09 -07:00
rigelrozanski afc2bbfe09 working through cli 2018-05-31 14:56:17 -07:00
Christopher Goes 12a7c0373a
Merge pull request #1072 from ValarDragon/dev/tx_encoding
Change to go-wire UnmarshalJSON for bank transactions
2018-05-31 23:51:27 +02:00
ValarDragon 0371109039 Register crypto on amino codecs, update changelog 2018-05-31 12:55:21 -07:00
ValarDragon e9545d69ed Switch the default modules to use wire.codec's MarshalJSON instead of json.Marshal 2018-05-31 11:51:15 -07:00
Rigel 0fb2bbdfef
Merge pull request #1011 from cosmos/cwgoes/slashing
Implement slashing (v1)
2018-05-31 11:09:44 -07:00
rigelrozanski 81e4a9797b genesis validator index setting 2018-05-30 18:28:02 -07:00
Christopher Goes e0b5118fce
Staking InitGenesis fixes 2018-05-31 03:00:11 +02:00
Christopher Goes 7e9192f513
Separate validator pub key index updates 2018-05-31 00:41:28 +02:00
Christopher Goes 0324be4189
Clarify comment on removePoolShares 2018-05-31 00:38:20 +02:00
Christopher Goes 1a3ef51129
PubKeyKey => PubKeyIndexKey 2018-05-31 00:21:00 +02:00
Christopher Goes 5f03e370c3
Remove ValidatorByPubKey, don't marshal sdk.Address 2018-05-31 00:19:23 +02:00
Christopher Goes 4e266013a8
store.Delete instead of store.Set to nil 2018-05-31 00:13:13 +02:00
rigelrozanski 40526d3e77 unbond validator return updated validator 2018-05-30 14:52:56 -07:00
rigelrozanski c8133a0f6a fix revoke validator bug 2018-05-30 14:43:22 -07:00
rigelrozanski ecf800810c remove append usage from lcd, fix address order test issue in lcd 2018-05-30 09:00:00 -07:00
rigelrozanski 6207d4131c minor fixes 2018-05-30 08:16:09 -07:00
Rigel 1c462013a9
Merge branch 'develop' into matt/stake-rest 2018-05-30 10:53:12 -04:00
rigelrozanski 52cd8b8c1f fix endPath missing bug for query 2018-05-30 07:42:59 -07:00
Christopher Goes 91f14e1b48
Merge branch 'develop' into cwgoes/slashing 2018-05-29 21:39:45 +02:00
Christopher Goes 9dfaf1797c
Staking InitGenesis fix II 2018-05-29 08:56:53 +02:00
Christopher Goes 74e8159c3f
Force update staking store 2018-05-29 08:49:37 +02:00
Matt Bell 99e5c5a18f Restored validators query endpoint 2018-05-29 15:07:03 +09:00
Christopher Goes 0dae7f8e4c
Panic on revoke/unrevoke nonexistent validator 2018-05-29 02:27:43 +02:00
Christopher Goes aed5d94b1c
Remove absent validators from sdk.NewContext 2018-05-29 02:26:17 +02:00
Christopher Goes f4f8cc66d9
Add some explanatory comments 2018-05-29 00:10:52 +02:00
Christopher Goes e4b0d0a618
Reorganization in progress 2018-05-28 21:55:54 +02:00
Christopher Goes 9cfc6de055
Linter fix 2018-05-28 21:55:53 +02:00
Christopher Goes 97b084b842
Fix ForceUnbond() testcase 2018-05-28 21:55:53 +02:00
Christopher Goes e614799d0f
ForceUnbond() implementation WIP 2018-05-28 21:55:53 +02:00
Christopher Goes be4b140003
Add testcase past max evidence age 2018-05-28 21:55:53 +02:00
Christopher Goes 7da5833b81
Implement ValidatorSet.Slash 2018-05-28 21:55:52 +02:00
Christopher Goes 366d8f9323
Slash() and ForceUnbond() are functions of ValidatorSet, not Validator 2018-05-28 21:55:52 +02:00
Christopher Goes 66b4461543
Update pointer-by-pubkey store on set and delete 2018-05-28 21:55:52 +02:00
Christopher Goes b005f9f18d
Validator by pubkey, tests work-in-progress 2018-05-28 21:55:52 +02:00
Christopher Goes 95c5baf449
Rebase & squash slashing 2018-05-28 21:55:27 +02:00
Zaki Manian 4fd998c669
Merge branch 'develop' into bech32cosmos 2018-05-27 19:14:15 +02:00
Zaki Manian ba7d1c0b8e Use the account encoding for the validator address 2018-05-27 14:24:18 +02:00
Zaki Manian a163a3558f Use public keys consistently for validators and all addresses are for accounts 2018-05-27 14:21:15 +02:00
Zaki Manian f33f49a840 Almost from scratch reimplementation of bech32cosmos integration. 2018-05-27 13:47:23 +02:00
Matt Bell 5c1a7694e5 Merge branch 'develop' into matt/stake-rest 2018-05-27 16:02:33 +09:00
sunnya97 caf8c77dce works 2018-05-26 18:00:39 -07:00
Rigel ae82931b7c
Merge pull request #1049 from cosmos/std_to_auth
Move stuff from types to auth
2018-05-26 04:43:27 -04:00
rigelrozanski 57d86cc04c fix many lcd errors, restructure lcd init 2018-05-25 10:17:49 -04:00