b52ffa08e1
Implement ADR 026 ( #7029 )
...
* Add allow_governance_override_after_expiry flag to tendermint NewCreateClientCmd
* 1) Add LatestTimestamp to ClientState struct by adding a new attribute latest_timestamp to the message ClientState in proto/ibc/tendermint/tendermint.proto
2) Autogenerate x/ibc/07-tendermint/types/tendermint.pb.go by running 'make proto-gen'. Strangely, as a side effect x/distribution/types/genesis.pb.go, x/evidence/types/genesis.pb.go were also modified by the command 'make proto-gen'
3) Add Expired() function
* Fix tests
* 1) Add allow_governance_override_after_expiry flag to tendemint clientStatus
2) Add allow_governance_override_after_misbehaviour flag to tendermint ClientStatus
* Cosmetic changes
* Fix tests
* Add Unfreeze function
* Add new ClientUpdateProposal type
* Add minor fixes
* Add NewClientUpdateProposalHandler unit tests
* Fix proto-lint-docker
* Delete x/ibc/07-tendermint/tendermint_test.go
* Follow convention to put signer last in msg function signature
* 1) Add GetLatestTimestamp function to ClientStatus interface
2) Change Expired() signature to Expired(now time.Time)
* 1) Add override flag to UpdateClient function
2) Fix tests
* Refactor HandleClientUpdateProposal
* 1) Extend exported Header interface with MarshalBinaryBare and UnmarshalBinaryBare methods
2) Move ClientUpdateProposal message to from ibc.proto to client.proto
3) Refactoring code
4) Add override flag to UpdateClient method
5) Fix tests
* 1) Uncomment tests and clean up code
2) Add basic validation of the header (ValidateBasic) when the override flag is true
* Cosmetic changes
* Add TODO comments
* Fix header MarshalBinaryBare, UnmarshalBinaryBare by using protobuf encoding/decoding
* Fix proto comments
* Fix override logic
* undo gettimestamp for solo machine and localhost
* add update after proposal func, some major refactoring in progress, various issues addressed
* fix tendermint proposal update handling
* run make proto-gen
* remove timestamp from tendemint client
* fix build issue for tm types
* apply various review comments
* add tests for 02-client functionality
* self review fixes
* typo
* update tests slightly
* update tendermint proposal handling tests
* Update x/ibc/02-client/keeper/proposal.go
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
* Update x/ibc/07-tendermint/types/proposal_handle.go
Co-authored-by: Aditya <adityasripal@gmail.com>
* Update x/ibc/07-tendermint/types/proposal_handle.go
Co-authored-by: Aditya <adityasripal@gmail.com>
* apply most of @fedekunze and some of @AdityaSripal suggestions
* convert test to bools
* update docs and increase code cov
* fix build
* fix typo, remove omitempty
* add switch
* apply @fedekunze latest suggestions
* fix lint
* Update x/ibc/02-client/keeper/proposal_test.go
Co-authored-by: Christopher Goes <cwgoes@pluranimity.org>
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
Co-authored-by: Colin Axner <colinaxner@berkeley.edu>
Co-authored-by: colin axnér <25233464+colin-axner@users.noreply.github.com>
Co-authored-by: Aditya <adityasripal@gmail.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
2020-09-04 20:59:22 +00:00
4f9e31ea21
x/ibc: implement Height interface ( #7211 )
...
* change interfaces
* fix tendermint client interfaces
* fix other clients interfaces
* fix queries
* fix tendermint build
* fix builds of clients
* fix 02-build
* start fixing connection and make queries non-nullable
* fix connection keepers and queries
* fix connection build
* fix channel build
* fix all non-test files
* fix testing build
* cleanup
* lint
* fix timeout height interface
* fix tendermint tests
* fix rest of clients
* fix connection tests
* fix client tests
* fix channel tests
* fix all ibc tests
* fix transfer tests:
* docs
* fix connection query
* Apply suggestions from code review
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
* wrap-up review
Co-authored-by: Jack Zampolin <jack.zampolin@gmail.com>
Co-authored-by: colin axnér <25233464+colin-axner@users.noreply.github.com>
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
2020-09-03 16:23:20 -04:00
979e8144fb
move IBC exported files to one location to avoid circular deps ( #7224 )
...
* move exported files to one location to avoid circular deps
* gofmt
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
2020-09-02 16:38:50 +00:00
d208d2bed8
Make clients use proto Height ( #7184 )
...
* start using Height in TM client
* fix client tests
* fix client tests
* fix connection tests
* fix rest of tests
* Apply suggestions from code review
Co-authored-by: colin axnér <25233464+colin-axner@users.noreply.github.com>
* fix simple issues
* add and use LTE and GTE methods
* remove TM-specific height semantics from 02-client
* fix lint and build
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
Co-authored-by: colin axnér <25233464+colin-axner@users.noreply.github.com>
2020-08-31 17:57:08 +00:00
843bd24bca
Add a mock application module to test core IBC ( #7187 )
...
* update setup to use channeltype and add mock app module
* rm print statement
* claim channel cap
* fix up test
* Update x/ibc/testing/coordinator.go
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
* apply @fedekunze review suggestions
Co-authored-by: Aditya Sripal <adityasripal@gmail.com>
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
2020-08-31 13:58:23 +00:00
be0cc63808
Migrate IBC tendermint header to proto ( #7120 )
...
* gen header proto file
* fix tm type to proto conversion issues
* fix tendermint type tests
* fix remaining tests
* fix lint
* Update x/ibc/07-tendermint/types/header.go
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
* Update x/ibc/07-tendermint/types/header.go
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
* apply @fedekunze review suggestions
* fix build
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
2020-08-20 11:46:11 -04:00
3368dae5f5
x/ibc: final gRPC migration ( #7077 )
...
* x/ibc: final gRPC migration
* grpc test
* query client consensus states
* remove dup type
* query constructors
* CLI queries
* missing cmd
* latest consensus state
* parser test
* register query service
* Update x/ibc/02-client/client/cli/query.go
Co-authored-by: colin axnér <25233464+colin-axner@users.noreply.github.com>
* Update x/ibc/module.go
Co-authored-by: colin axnér <25233464+colin-axner@users.noreply.github.com>
* few grpc tests
* fix tests
* final gRPC tests
* rm comment
* address @colin-axner comment
Co-authored-by: colin axnér <25233464+colin-axner@users.noreply.github.com>
2020-08-20 10:23:19 -04:00
2079576cbe
Replaced hardcoded 'cosmos' and 'cosmosvaloper' help references ( #7056 )
...
* Replaced hardcoded 'cosmos' and 'cosmosvaloper' help references
* Ran make format target
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
2020-08-17 09:04:50 +00:00
8de96d16f9
tendermint: update to rc3 ( #6892 )
...
* modify light imports
* change abci.header to tmproto.header
* use rc
* rc
* fix import
* Merge PR #6893 : fix key imports
* fix rc2
* tendermint: update 3 (#6899 )
* tendermint: update 4 (#6919 )
Co-authored-by: Alexander Bezobchuk <alexanderbez@users.noreply.github.com>
* tendermint: update 5 (#6923 )
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
* bump to latest master
* tendermint: update (#6972 )
Co-authored-by: Aleksandr Bezobchuk <aleks.bezobchuk@gmail.com>
Co-authored-by: Cory Levinson <cjlevinson@gmail.com>
* Update x/ibc/07-tendermint/types/test_utils.go
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
* address comment
* go mod
* bring back things
* fix test
* update tm proto files
Co-authored-by: Alexander Bezobchuk <alexanderbez@users.noreply.github.com>
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
Co-authored-by: Aleksandr Bezobchuk <aleks.bezobchuk@gmail.com>
Co-authored-by: Cory Levinson <cjlevinson@gmail.com>
Co-authored-by: Federico Kunze <federico.kunze94@gmail.com>
2020-08-14 13:58:53 -04:00
20c5ee3624
Enable proto JSON for genesis ( #7000 )
...
* Enable proto JSON for genesis
* Test fixes
* Cleanup
* Cleanup
* Cleanup
* Update CHANGELOG.md
* Protogen
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
Co-authored-by: SaReN <sahithnarahari@gmail.com>
2020-08-11 14:22:30 +00:00
ceba0cb45d
x/ibc migrate genesis proto ( #6878 )
...
* migrated channel genesis types to proto
* connection genesis types migrated to proto
* client proto migration
* failing tests due to tendermint part incomplete
* add genesis test
* x/ibc: ClientState Any
* add genesis test
* suite NotPanics
* comment tests
* update export logic
* refactor
* update test
* fix non-determinism
* castrepeated
* x/ibc: migrate simulations to protobuf
* add proto genesis
* add UnpackInterfaces func to genclientstate
* add unpackinterfaces for consensus states
* formatting
* fix genesis tests
* add modified genesis test
* update comments
* remove localhost register codec
* use app registry
* fix bug
* Update simapp/app.go
* Update x/ibc/02-client/types/genesis.go
* unmarshaler interface
Co-authored-by: Colin Axner <colinaxner@berkeley.edu>
Co-authored-by: Federico Kunze <federico.kunze94@gmail.com>
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
Co-authored-by: colin axnér <25233464+colin-axner@users.noreply.github.com>
2020-08-07 08:33:47 +00:00
e3391ff447
Remove ValidatorSet from ConsensusState ( #6942 )
...
* fix stash merge
* fix build errors
* fix tendermint types test
* fix tendermint tests
* fix client tests
* fix rest of ibc tests
* include TrustedHeight in Header
* fix all tests
* fix all tests
* remove validatorshash from consensus state
* lint
* add evidence checks
* Apply suggestions from code review
Co-authored-by: colin axnér <25233464+colin-axner@users.noreply.github.com>
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
* refix build
* remove redundant hashing in tests
* complete rest of minor review requests
* make format
* suite.valsetHash
* fix test
* Update x/ibc/07-tendermint/misbehaviour.go
Co-authored-by: colin axnér <25233464+colin-axner@users.noreply.github.com>
Co-authored-by: colin axnér <25233464+colin-axner@users.noreply.github.com>
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
Co-authored-by: Federico Kunze <federico.kunze94@gmail.com>
2020-08-06 08:32:19 +00:00
79cee06967
Migrate Tendermint client state to proto ( #6932 )
...
* add tm client state proto file
* migrate tm client state to proto
* bump ics23 dep
* add issue link to makefile
2020-08-04 16:31:50 +00:00
9b61e0947e
Remove Last Header from ClientState ( #6873 )
...
* implement features, fix tendermint tests
* allow test headers to pass in custom nextvalidatorset
* allow updates to previous heights and test
* remove unnecessary testing feature
* fix client tests
* fix ibc tests, and updating consensus state
* fix ibc-transfer tests
* appease linter
* Apply suggestions from code review
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
* add chainID test case
* fix expPass value
* Apply suggestions from code review
Co-authored-by: colin axner <25233464+colin-axner@users.noreply.github.com>
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
* address rest of @colin-axner review
* fix bug and errors
* Apply suggestions from code review
Co-authored-by: colin axnér <25233464+colin-axner@users.noreply.github.com>
* address rest of @colin-axner review
* implement updating before frozen height
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
Co-authored-by: colin axner <25233464+colin-axner@users.noreply.github.com>
2020-08-04 05:05:03 -04:00
5676e7293f
Remove ID from ClientState ( #6823 )
...
* remove id from clients, build works
* fix client state tests
* fix tests
* address @fedekunze review
* Apply suggestions from code review
Co-authored-by: colin axner <25233464+colin-axner@users.noreply.github.com>
* lint
* remove commented-out test case
* Update x/ibc/02-client/keeper/keeper_test.go
Co-authored-by: colin axner <25233464+colin-axner@users.noreply.github.com>
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
Co-authored-by: colin axner <25233464+colin-axner@users.noreply.github.com>
2020-07-27 18:43:09 +00:00
ef0a7344af
x/ibc: remove ID from ConnectionEnd ( #6814 )
...
* remove connection id
* various test and code fixes
* fix tests
* Update proto/ibc/connection/connection.proto
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
* rename utils.go to parse.go in host
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
2020-07-22 09:59:15 -04:00
5dfc4a2ec9
Standardize connection versioning + channel versioning docs ( #6640 )
...
* update connection versions with feature set flag
* make connection version modular to support channel versioning and registering
* revert IBCVersion renaming, add channel versioning logic
* fix channel version flag
* remove unnecessary godoc
* remove unused func
* fix lint and version test
* add test and fix error
* revert changes
* update docs
* remove unnecessary godoc
* Apply suggestions from code review
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
* update doc
* add test cases for unchecked lines
* go fmt
* begin migration to standardized version
* revert proto changes
* restructure versioning to go from string to proto
* update versionStr to encodedVersion naming
* fix version test build
* fix keeper tests
* fix various tests
* fixes from self review
* update docs
* fix lint
* add more code cov
* rename ToString funcs to Encode/DecodeVersion + GetCompatibleEncodedVersions renaming
* update spec docs
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
2020-07-14 08:43:26 +00:00
73757243c2
Update connection handshake version negotiation ( #6534 )
...
* update version negotiation and add basic testing
* add integration tests
* update spec
* apply @fedekunze suggestions
* update to enforce connection validation checks
* add test
* update godoc and spec
* small doc fix
* update versioning to feature set
* update version code and tests to specified version tuple
* update docs/spec
* merge and fix bug
* Update x/ibc/03-connection/types/version.go
Co-authored-by: Aditya <adityasripal@gmail.com>
* Apply suggestions from code review
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
* add verify proposed feature set test
* fix formatting bug
* add safety check
* merge tests into existing handshake tests
Co-authored-by: Aditya <adityasripal@gmail.com>
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
2020-07-03 09:28:02 +00:00
2658175b01
remove alias.go from channel ( #6569 )
...
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
2020-07-01 18:25:23 +00:00
e8fb76ae44
x/ibc: remove alias.go from 03-connection ( #6543 )
2020-06-30 09:10:53 -04:00
43b4f2f120
remove alias.go from 02-client ( #6542 )
2020-06-30 10:37:05 +00:00
560398cfdc
x:ibc: remove alias.go usage ( #6429 )
...
* x:ibc: remove alias.go usage
* Replace ibc24host with ibchost
2020-06-13 14:29:00 +00:00
d82c2e6a94
Enforce ProofSpecs in 23-Commitment ( #6374 )
...
* enforce spec ordering
* modify clients to pass in specs to verify functions
* start fixing tests
* Apply suggestions from code review
* enforce spec length and proof length match
* fix all tests
* add argument to constructor:
* fixed msg client and tests
* appease linter
* Apply suggestions from code review
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
* finish fixes from review
* add back proof-specific checks
* Apply suggestions from code review
* more robust proof spec checks
* add CHANGELOG entries
* do not hardcode proofspecs in 23-commitment
* fix client modules
* fix tests
* appease linter
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
2020-06-12 10:45:40 +00:00
ca20a39962
x/ibc: constrain acks processing order ( #6244 )
...
* x/ibc: constrain acks processing order
* test
* address @AdityaSripal comments
* address @colin-axner comments
* address @alexanderbez comments
2020-05-18 16:50:07 +00:00
b2ad4d2a23
x/ibc: alter id requirements ( #6227 )
...
* x/ibc: alter id requirements
* add regex to validations
* comment
* update error
* test all validators:
* fix tests
* check for only separators
2020-05-15 17:24:31 +00:00
48aebed2ea
x/ibc: /types cleanup ( #6169 )
...
* x/ibc: move /types to /common
* x/ibc/types: remove errors
* remove mocked proofs
* remove invalidProof{}
* create new ibc/types dir
* format
* move keys to host
* move order to channel
* move channel state
* move connection state
* lint
2020-05-13 19:23:33 -04:00
a08aa41213
ibc/07-tendermint: variable trust-level ( #6206 )
...
* ibc/07-tendermint: variable trust-level
* update client state and tests
* fix tests
* address comments from review
* cli: define trust-level as flag
2020-05-13 01:10:25 +00:00
b93300288e
x/ibc: stateful clients ( #6202 )
...
Closes : #6198
2020-05-12 21:13:41 +02:00
f88d9ab586
x/ibc: create localhost client on InitGenesis ( #6170 )
...
closes : #6159
2020-05-11 17:46:00 +02:00
bef3689245
linter: enable nolintlint ( #6162 )
...
* nolintlint enable
* remove space
* fix tests
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
2020-05-08 08:46:12 +00:00
d7ebee74e7
x/ibc: proto migration pt 1 ( #6097 )
...
* x/ibc: proto migration pt 1
* fix tests
* fixes and godoc
* yaml tags
* rm changelog
* address comments from review
* fix some tests
* fix tests
* add _UNSPECIFIED suffix for default enums
* Update app
* protobuf Any fixes
* use gogoproto
* fix tests
* wrap all messages
* address @alexanderbez comments
* update proto files
Co-authored-by: Alexander Bezobchuk <alexanderbez@users.noreply.github.com>
Co-authored-by: Aleksandr Bezobchuk <aleks.bezobchuk@gmail.com>
Co-authored-by: Aaron Craelius <aaron@regen.network>
2020-05-06 11:17:50 -04:00
2d3a8525b9
ibc/04-channel: import export GenesisState ( #6087 )
...
* ibc/04-channel: import export GenesisState
* update tests
* add missing genesis fields
* genesis tests
* keeper tests
* update genesis test
* typo
* rename types
* address comments from review
* minor updates
* typo
2020-04-29 09:17:20 -04:00
9b51908597
ibc/02-client: import export GenesisState ( #6073 )
...
* ibc/02-client: import export GenesisState
* client validation
* genesis validation
* ibc genesis tests
* GetAllConsensusStates test
* fix non-determinism
* lint
* fix test
2020-04-27 14:04:26 -04:00
e9b5fc9716
ibc/03-connection: import export GenesisState ( #6067 )
...
* ibc/03-connection: import export GenesisState
* add connection paths
* add genesis to ibc module root package
* genesis tests
* iterator and fixes
* changelog
* lint fixes
* godoc
* revert validation
2020-04-24 15:52:07 +00:00
dauTT
Aditya
colin axnér
Federico Kunze
Neeraj Murarka
Marko
Aaron Craelius
atheeshp
dauTT