Commit Graph

1452 Commits

Author SHA1 Message Date
Jack Zampolin 4b4a2b81a1
Add slashing genesis validation (#3158) 2018-12-19 09:03:16 -08:00
Nicolas Pinto f32286d5ff Small typo in stake/client/cli/tx.go (#3157)
* FIX: small typo in stake/client/cli/tx.go
* FIX: another typo in stake/client/cli/tx.go
2018-12-18 15:44:28 -08:00
Sunny Aggarwal f4fb3608c0 Redelegation Querier (#2559) 2018-12-18 13:43:41 -08:00
Alessio Treglia 711a22fde6 Merge PR #3121: x/auth: fetch one account after another
* x/auth: fetch one account after another

- Don't read all accounts in one go as signature verification
  could fail before last signature is checked.

- TestAnteHandlerFees now checks whether fees were actually
  deducted from the account as well as the fee keeper collected
  them.

Thanks: @ValarDragon for pointing this out
Closes: #3093
2018-12-18 21:41:54 +01:00
Alessio Treglia 500fa2b694 Make coins denoms case insensitive (#3092) 2018-12-18 11:14:11 -08:00
Alessio Treglia eac7d6939d Merge PR #3127: Don't fallback to any default values for chain id
- Remove DefaultChainID(). User needs to suplly chain ID
  via either config or flag.
- Mark --chain-id as required by all tx commands.
- Fix gaiacli config values containing underscores.
  Underscore '_' character is not automagically translated
  into hyphen '-'. Viper values wouldn't be affected.
- Refresh gaiacli config tests

Closes: #810
2018-12-18 19:40:01 +01:00
Alexander Bezobchuk 56937714b5 Expose necessary ante handler auxiliary functions (#3135) 2018-12-17 15:43:16 -08:00
Jae Kwon 6666540dbb Revert "Remove GovernancePenalty"
This reverts commit 86a214f10c.
2018-12-17 10:56:45 -08:00
Jae Kwon ac511abc5c
Temporarily revert x/slashing/params json field names to use dashes, for GoS compat (#3132) 2018-12-17 10:11:38 -08:00
Jae Kwon 86a214f10c Remove GovernancePenalty 2018-12-17 02:17:19 -08:00
Alexander Bezobchuk ff6c2f2bad Gov Get Vote(s)/Deposit(s) Updates (#3091) 2018-12-14 11:13:43 -08:00
Alexander Bezobchuk 110fd63e22 Add Slashing Query Params (#3117) 2018-12-14 11:09:39 -08:00
Federico Kunze 65beea4430 Add distribution REST endpoints swagger file (#3038) 2018-12-13 10:42:55 -08:00
Artur Albov 0c6d53dc07 Merge PR #2959: Add TxEncoder to client TxBuilder 2018-12-12 22:29:42 +01:00
Jack Zampolin 582ca8e8b9
Move validator cache to the keeper in stake (#3075) 2018-12-12 08:34:39 -08:00
Jack Zampolin 26a31926f8 Address PR comments 2018-12-11 13:10:42 -08:00
Jack Zampolin 2f9b062cf3 Merge PR #3015: Add Governance genesis checks
* missing genesis verification in gaia, also add distribution verification

* PENDING.md

* Fix error message
2018-12-11 20:05:49 +01:00
Jack Zampolin b9477df546
Reintroduce collect-gentxs's --gentx-dir flag (#3021)
R4R: Reintroduce collect-gentxs's --gentx-dir flag
2018-12-11 08:11:10 -08:00
Federico Kunze 4ecbf0dd5f Merge PR #2997: Split POST delegations endpoint 2018-12-11 15:02:26 +01:00
Alessio Treglia affa1fb3f3 Reintroduce collect-gentxs's --gentx-dir flag
It went lost in last genesis workflow refactoring.

Also address structs initializations as per #2835.
2018-12-11 12:32:28 +00:00
Jack Zampolin e1f0767ba8
R4R: Move generate_only and simulate to POST body in REST txs (#3060)
* Move generate_only and simulate to POST body in REST txs

Closes: #3056

* Run make format

* drop extra else block, outdent its block, and make linter happy

* Update PENDING.md

* Update LCD swagger docs
2018-12-10 14:51:53 -08:00
Jack Zampolin 97efff8af6 Move validator cache to the keeper in stake 2018-12-10 14:14:52 -08:00
Christopher Goes 243576143e
Merge PR #3072: Catch overflows in gas wanted
* Check for overflow

* Only expect block gas meter on DeliverTx

* ErrGasOverflow in tx.ValidateBasic()

* Update unit test
2018-12-10 21:39:29 +01:00
Alexander Bezobchuk 2ce41760e2 Merge PR #3070: Check for gas overflow in tx validation
* Check for gas overflow in tx validation

* Use bitshifting over math.Pow
2018-12-10 20:24:57 +01:00
dongsamb da7f459d44 Merge PR #3050: Add generate-only option to withdraw-rewards 2018-12-10 16:29:10 +01:00
Christopher Goes 7d55bd1a36
Merge PR #3063: Fix linter 2018-12-10 16:13:26 +01:00
Alessio Treglia 2e05d4e3d7 drop extra else block, outdent its block, and make linter happy 2018-12-10 14:36:20 +00:00
Alessio Treglia 24a1670cf0 Run make format 2018-12-10 14:27:25 +00:00
Alessio Treglia ac0a7c0a1d Move generate_only and simulate to POST body in REST txs
Closes: #3056
2018-12-10 14:26:34 +00:00
Sunny Aggarwal 945803d586 Governance Quorum (#3053) 2018-12-10 02:50:20 -08:00
Jae Kwon 133134ca52
Use address instead of bond height / intratxcounter for deduplication (#3055) 2018-12-10 02:49:37 -08:00
Jae Kwon 40a30b738f
Update gas costs to more reasonable numbers for GoS (#3052) 2018-12-10 02:48:19 -08:00
Jae Kwon bc51fa93b6
Fix updateValidatorDistInfoFromPool (#3046)
Fixes regression introduced by #2984.
Continuiation of #3033 , which didn't fix the simulation issues.
(candidate) Complete solution for #3019, 9002 halt bug.

From #2984, it isn't sufficient to take the fee pool rewards of a validator. Since we don't track delegator accums (as we do with validator accums), and because onValidatorModified >updateValidatorDistInfoFromPool is also being called upon delegation updates (or at least I believe this is the reason), it is necessary to also withdraw self delegation.

TODO: I don't think self-delegation should be required to be modified here... consider using a delegation hook to do the self-delegation withdraw part instead, e.g. splitting the updateValidatorDistInfoFromPool function into two. It might not result in cleaner code, however. Think hard.
2018-12-08 07:18:04 -08:00
Jae Kwon 1ba93ea1c1 Merge PR #3033: Fix negative stake & invariance bug
* Fix negative stake & invariance bug

* Merge PR #3037: Updates to negative stake fix

* Update invariant; fix lint

* Fix linter

* Add comment & TODO
2018-12-08 01:04:52 +01:00
frog power 4000 49da96bc09 Merge PR #3010: Add Missing genesis checks in Gaia 2018-12-07 01:22:24 +01:00
Alexander Bezobchuk f11a65dee7 Merge PR #3005: Move auth keeper benchmarks to sep. file 2018-12-06 10:49:30 +01:00
Alexander Bezobchuk 5b42e83bc2 Merge PR #2995: Fully verify the signature in `gaiacli tx sign`
* Implement auxiliary methods/functions for just building a tx sig bytes

* Undo auxiliary methods/functions

* Validate signature

* Remove redundant comment

* Add pending log entry

* Minor cleanup

* Update sign cli doc

* Update cli sign offline flag doc

* Update printAndValidateSigs

* Implement TestGaiaCLIValidateSignatures

* Minor cleanup

* Fix linting

* Update x/auth/client/cli/sign.go

Co-Authored-By: alexanderbez <alexanderbez@users.noreply.github.com>

* Minor reformatting
2018-12-06 02:02:04 -05:00
Christopher Goes ba5e87ca6f x/auth module spec / code reconciliation (#2964) 2018-12-05 16:48:08 -08:00
Alexander Bezobchuk 6395e2a7ab Merge PR #2984: Removal of Mandatory Self-Delegation Reward
* Some minor cleanup and reformatting to make things easier to understand

* Update onDelegationSharesModified hook

* Add pending log

* Address PR comments

* Fix linting
2018-12-04 17:53:52 -05:00
Christopher Goes dfd00a661a Inflation bug fixes (#2982)
* PENDING.md; swap BeginBlocker ordering
* Calculate inflation every block
* Update x/mint spec
* Reset distribution info bond height instead
2018-12-04 10:17:02 -08:00
Alexander Bezobchuk bcfd93f544 Merge PR #2950: AnteHandler Cleanup
* Add and use CodeInvalidAccountNumber in ante handler

* Minor cleanup of ante handler

* Add pending log entry

* Spell check and more minor comment restructuring

* Add additional CodeInvalidAccountNumber

* Update validateAccNumAndSequence

* Revert account number error in favor of CodeInternal

* Update pending log

* Fix pending log
2018-12-04 17:42:15 +01:00
Jack Zampolin 886bd35670
Address gov cli ux issues and add additional input validation for better errors (#2938)
* Fix governance cli ux issues and add additional transaction validation
2018-12-03 12:48:51 -08:00
Dev Ojha 13e78166ee Merge PR #2977: Don't serialize Account Number and Sequence Number in signatures
* Don't serialize Account Number and Sequence Number in signatures

This was not needed to be included within the tx body, as its in the
state.

* fix lint
2018-12-03 18:29:50 +01:00
Christopher Goes 98caf44e35
Merge PR #2853: Write bank module specification, check spec/code consistency
* Update PENDING.md

* New structure

* Start transactions section

* Remove MsgIssue

* Update keepers.md

* Add state.md

* Update keepers.md, discovered #2887

* Move inputOutputCoins to BaseKeeper

* Remove no-loner-applicable tests

* More spec updates

* Tiny cleanup

* Clarify storage rationale

* Warn the user

* Remove extra newline
2018-11-29 22:56:42 +01:00
Hendrik Hofstadt b7736367a8 R4R: Fix duplicate json key in SetWithdrawAddress (#2944)
* Fix duplicate json key

* Update PENDING.md
2018-11-29 09:54:36 -08:00
Hendrik Hofstadt db77117a5b Only allow supported pubKey types (#2949)
* Only allow supported pubKey types
* Add type and supported types to error message
* Add default value for ConsensusParams
2018-11-29 09:21:45 -08:00
Christopher Goes b2b026b5e0
Merge PR #2930: Simulation spring cleaning
* Update PENDING.md
* Add simple period for expensive invariants
* Remove individual module simulations
* Simulate a few more blocks
* Add README explaining reason for shell scripts
* Deduplicate scripts, log exact replication command on failure
* Refactor invariants to take sdk.Context instead of baseapp.BaseApp
* Reference all issues in PENDING.md entry
* Remove no longer used simulation.RandSetup
* Bug fixes
* Address @rigelrozanski comments
* Fix typo
2018-11-29 16:17:10 +01:00
Hendrik Hofstadt ca43225851 Merge PR #2943: Fix tag usage in handlers and EndBlocker
* Fix tag usage in handlers and EndBlocker
* Prepend action tag in baseApp
* Fix LCD
* Remove unnecessary conversion
* Fix invalid consensus pubkey in CLI tests
* Fix tag usage in cli_test
* Shorten bechify in test
* Update docs and PENDING
2018-11-29 15:34:57 +01:00
Tony Stark f8ee8a7f78 Merge PR #2896: Fixed account sequence issue in IBC relay 2018-11-27 18:22:43 +01:00
Jae Kwon d1e76221d8
Jae/simulator improvements (#2900)
* Make simulator operations predetermined
* Use new dbm.ReverseIterator API
* Simulation speed improvements
* Pin exact revisions, not branches
* Rename 'MountStoresIAVL' to 'MountStores'
* Zero Power Block fees to community pool
2018-11-27 00:14:22 -08:00