Commit Graph

112 Commits

Author SHA1 Message Date
Alexander Bezobchuk 6ec9b26cef
Merge PR #4454: Implement MarshalJSON for Coins Type 2019-05-31 11:16:08 -04:00
Alessio Treglia 85ebf5f72e
Implement private keys export/import symmetric functionalities (#4436)
Add Keybase's ExportPrivKey()/ImportPrivKey() API calls to export/import
ASCII-armored private keys. Relevant keys subcommands are provided as well.

Closes: #2020
2019-05-30 16:44:28 +01:00
Frank Yang 1db10b0033 Configurable Bip44 CoinType & HdPath for SDK users (#4300)
Closes: #4144
2019-05-30 13:46:38 +01:00
Alexander Bezobchuk 8b1d75caa2
Merge PR #4382: Support height queries for queriers 2019-05-28 20:58:33 -04:00
frog power 4000 73e5ef7c13 reduce module interdependancy, /client refactor (#4415)
* abstract staking BuildCreateValidatorMsg, genutil defines its own flags

* client/ refactor

* staking move keys from keeper to types
2019-05-28 09:44:04 +01:00
Joon 91e75cb74a Merge PR #4403: Paramchange proposal skips omitempty fields 2019-05-27 20:47:12 -04:00
frog power 4000 38f49e4114
Merge PR #4389: stake invariance bug
* add trouble seed

* currentStakeRoundUp is now always atleast currentStake + smallest-decimal-precision

* remove unused code

* remove debugs

* @alexanderbez comment

* compile fix

* better comment, increase tolerance to 3 smallest decimal points
2019-05-24 21:23:53 -04:00
Juan Leni 68036ec71f Merge PR #4384: allow splitting withdrawal txs
* allow splitting withdrawal txs

* updating .pending

* small cleanup

* fixing build issue

* Update x/distribution/client/cli/tx.go

Co-Authored-By: Alessio Treglia <quadrispro@ubuntu.com>

* updating usage text

* fixing merge issue

* changes based on the review

* adding unit tests

* Update x/distribution/client/cli/tx.go

Co-Authored-By: Alexander Bezobchuk <alexanderbez@users.noreply.github.com>

* adjustments from review
2019-05-23 19:00:26 -04:00
Alexander Bezobchuk 4f197ff904
Merge PR #4396: Use TxSigLimit instead of default constant value 2019-05-23 14:08:51 -04:00
Alexander Bezobchuk 40518cb655
Merge PR #4395: Improve sig verification error message 2019-05-23 09:45:03 -04:00
Yumin Xia 65be4dbf09 close db write batch after use (#4379)
Closes: #4381
2019-05-22 01:42:33 +01:00
Christopher Goes dd89c32951 Community pool spend proposal (#4329)
Implement the "CommunityPoolSpendProposal" as described in Cosmos Hub proposal 7.

Also a useful test of Git flow for merging features passed in governance proposals.
2019-05-21 11:02:10 +01:00
Sunny Aggarwal cca3c3cbf2 Merge PR #4374: Don't Burn Deposits for Rejected Governance Proposals Unless Vetoed 2019-05-20 10:13:50 -04:00
Alexander Bezobchuk 722b314835 Merge PR #4375: Add pending log entry 2019-05-20 04:17:04 -04:00
Alessio Treglia 71d71f2206
Remove gaia (#4347)
Gaia is removed from cosmos-sdk repository.

Few changes were required to make sure no packages depend on gaia subpackages.

CI config is amended accordingly.

Unnecessary targets are removed from Makefile.

Simulations run through a lightweight version of gaia renamed to simapp.

Closes: #4104
2019-05-18 10:42:24 +02:00
frog power 4000 cef788042b Merge PR #4365: Simulator bugfix for multisim 7601778 2019-05-17 19:45:36 -04:00
Alessio Treglia ca4363ffb7 Merge PR #4351: remove x/ dependency on cmd/gaia
* remove x/ dependency on cmd/gaia

This is an alternative patch to what is proposed in #4348

* Add pending entry

* Ditto for CollectGenTxsCmd

* Update pending

* Update tests

* Update pending
2019-05-16 21:34:54 -04:00
Juan Leni e09ebf9ffa Merge PR #4345: Upgrade ledger-cosmos-go 2019-05-16 13:06:02 -04:00
frog power 4000 3fe5869148
Merge PR #4159: Module/Genesis Generalization
* first commit

* gaia cleanup

* ...

* staking multihooks

* missing module function return args

* bank module name constant

* working, module interface for x/

* got this thing compiling

* make test compiles and passes

* remove expanded simulation invariants

* genesis issue

* continued

* continued

* register crisis routes thought mm

* begin blocker to mm

* end blocker to mm

* empty routes not initialized

* move gaia initChainer sanity check to baseapp

* remove codecs from module manager

* reorging genesis stuff

* module manager passed by reference/bugfixes from working last commit

int

int

* move invariant checks from gaia to crisis

* typo

* basic refactors cmd/gaia/init

* working

* MultiStakingHooks from types to x/staking/types

int

* default module manager order of operations from input modules

* working

* typo

* add AppModuleBasic

* moduleBasicManager / non-test code compiles

* working attempting to get tests passing

* make test passes

* sim random genesis fix

* export bug

* ...

* genutil module

* genutil working

* refactored - happy with non-testing code in cmd/

* ...

* lint fixes

* comment improvement

* cli test fix

* compile housing

* working through compile errors

* working gettin' compilin'

* non-test code compiles

* move testnet to its own module

* reworking tests

int

* bez staging PR 1 comments

* concise module function-of names

* moved all tests from genesis_test.go to other genutil tests

* genaccounts package, add genutil and genaccounts to app.go

* docs for genutil genaccounts

* genaccounts iterate fn

* non-test code with genaccounts/ now compiles

* working test compiling

* debugging tests

* resolved all make test compile errors

* test debuggin

* resolved all unit tests, introduced param module

* cli-test compile fixes

* staking initialization bug

* code comment improvements, changelog entries

* BasicGaiaApp -> ModuleBasics

* highlevel explanation in types/module.go

* @alexanderbez comment revisions

* @fedekunze PR comments

* @alexanderbez PR comments (x2)

* @cwgoes comments (minor updates)

* @fedekunze suggestions

* panic on init with multiple validator updates from different modules

* initchain panic makes validate genesis fail

int

* AppModuleGenesis seperation

int

* test

* remove init panic logic in validate genesis replaced with TODO

* set maxprocs to match system's GOMAXPROCS

* Update circleci

* Cap maxprocs in CI to 4

* @alexanderbez recent comments addressed

* less blocks in twouble sims

int

* runsim error output flag

* -e on import_export as well

* error out

int

* Try to fix failures

* runsim
2019-05-16 11:25:32 -04:00
Alessio Treglia 805de8b9f5 Merge PR #4343: Update go to 1.12.5 2019-05-15 11:17:20 -04:00
Alexander Bezobchuk 44f972584d
Merge PR #4333: Remove Shares from Client Responses 2019-05-15 10:44:47 -04:00
Joon dfef88dea8 Merge PR #4265: CacheKVStore keep sorted items 2019-05-15 10:42:06 -04:00
Alexander Bezobchuk d8bd7bcba8
Merge PR #4342: Upgrade to go-amino v0.15.0 2019-05-15 09:42:16 -04:00
Alessio Treglia 262c752863
Fix AppendTags usage error (#4336)
Fix AppendTags usage error

Thanks: @mjackson001 for the bug report and patch (original PR: #4274)
Closes: #4273
2019-05-14 16:13:18 +01:00
Alessio Treglia c0486aa532
R4R: Infrastructure for reproducible builds (#4262)
This change set introduces support for building gaia with gitian
on the following GOOS/GOARCH pairs:

- darwin/386
- darwin/amd64
- linux/386
- linux/amd64
- linux/arm
- linux/arm64
- windows/386
- windows/amd64

cmd/gaia/contrib/gitian-descriptors/ contains gitian descriptor files.

cmd/gaia/contrib/gitian-keys/ contains:
- a keys.txt file that is meant to list core developers and gitian
  builders PGP keys. 
- README.me to provide instructions on how to import the keys
  into one's personal GPG keyring.

The gosum utility is removed, so is the go.sum hashsum bit from
gaiacli/gaiad version string. It was meant to be a provisional
mitigation to the lack of a reproducible build process.

GOBIN is removed from all Makefiles. When GOBIN is set, go
refuses to cross-compiles binaries for foreign architectures.
export GOBIN=$GOPATH/bin is unnecessary anyway as by
default go install places built binaries in $GOPATH/bin.
Developers are required to update their enviornment files and
replace $GOBIN with $GOPATH/bin in PATH.

circleci configuration file is amended accordingly.

Closes: #4027
Closes: #4280
2019-05-14 00:33:34 +02:00
Alexander Bezobchuk 829ce17d06
Merge PR #4307: Don't pass height to RPC calls 2019-05-09 16:42:25 -04:00
Alexander Bezobchuk 925070ae38
Merge PR #4292: Fix Signing Infos Endpoint 2019-05-09 13:38:15 -04:00
Alexander Bezobchuk 85ffce5f58
Merge PR #4306: Allow generate-only to fully operate offline 2019-05-08 16:06:05 -04:00
Alessio Treglia 04ed12dd2a Merge PR #4303: Fix coins findDup() 2019-05-08 09:51:30 -04:00
Alexander Bezobchuk 1bd70a238d
Merge PR #4281: Fix addGenesisAccount 2019-05-07 13:10:35 -04:00
Alexander Bezobchuk 99df748dda
Merge PR #4285: Update REST Client to Support Custom R/W Timeouts 2019-05-07 13:04:48 -04:00
Alessio Treglia 7301dc9a49 Merge PR #4290: Upgrade IAVL v0.12.2 2019-05-07 10:18:32 -04:00
Alessio Treglia 5060187d3d
Merge gaiareplay into gaiad to reduce number of binaries (#4272) 2019-05-06 17:43:37 +01:00
Frank Yang 8bb2569abc R4R: Fix /txs/encode endpoint (#4212)
Closes: #4141
2019-05-06 15:53:12 +01:00
Frank Yang 1cfc868d86 Support query txs' TotalCount in GET /txs (#4214)
Closes: #3942
2019-05-04 12:09:02 +01:00
Alessio Treglia df362ff3e6
Upgrade Go to 1.12.4 (#4261) 2019-05-03 11:33:41 +01:00
Alexander Bezobchuk 29ed730aff
Merge PR #4244: Param Proposal Simulation Messages; Minting Params Fix 2019-05-02 16:50:01 -04:00
Alessio Treglia 38f93128eb
Remove baseapp dependency on the version package (#4250)
The version package is meant to be a convenience utility
that provides SDK consumers with a ready-to-use version
command that produces app's versioning information from
flags passed at compile time.
It will not make sense anymore for the baseapp package
to depend on the version package once gaia will have been
migrated away from the SDK main repository as we neither
want to make assumptions nor set expectations on downstream
apps buildsystems. Thus BaseApp now provides SetAppVersion()
and AppVersion() to to allow SDK consumers to set BaseApp's
version information string once the struct is initialised.
2019-05-02 20:37:44 +01:00
Aaron Craelius 114de631a5 Allow custom key types and address formats (#4232)
Add additional parameter to NewAnteHandler for custom SignatureVerificationGasConsumer (the existing one is now called DefaultSigVerificationGasConsumer).

Add addressVerifier field to sdk.Config which allows for custom address verification (to override the current fixed 20 byte address format).

DefaultSigVerificationGasConsumer now uses type switching as opposed to string comparison.
Other zones like Ethermint can now concretely specify which key types they accept.

Closes: #3685
2019-05-02 20:36:42 +01:00
Alessio Treglia 4e70a37c6b Merge PR #4228: gaiakeyutil -> gaiacli keys parse 2019-05-02 09:34:02 -04:00
Alexander Bezobchuk 5653c768bb
Merge PR #4234: Allow tx send (generate-only) to actually work offline 2019-04-30 12:47:26 -04:00
Alexander Bezobchuk 5ca93ac574 Merge PR #4206: Param Change Proposal
* Add params error types

* Update param module keeper to take a codespace

* Update imports

* Implement SetRaw and SetRawWithSubkey

* Implement ParamChange and update aliases

* Add types codec

* Implement ParameterChangeProposal

* Implement TestParameterChangeProposal

* Fix linting errors

* Update tags

* Implement content

* Updata params aliases

* Finish params handler and proposal types

* Move deposit and vote logic to types package

* Move proposal type to types package

* Move errors to types package

* Update proposal

* Move gov messages to types package

* Minor updates to naming

* Move keys to types package

* Move codec to types package

* Move proposal types to types package

* Update aliases

* Add governance alias types

* Implement governance router

* Update gov aliases

* Update gov keeper

* Update private functions needed for the keeper

* Update godocs

* Update the gov message handler

* Update Gaia app

* Make updates to auth

* Update the message codec in the keeper

* Update gov end blocker

* Update types tests

* Minor tweaks

* Add legacy genesis logic

* Update gov aliases

* Move gov keys to types package

* Revertt to using gov/types in params

* Implement params handler test

* Update governance tests

* Fix endblocker tests

* Fix governance querier tests

* Add seal support to gov router

* Update simulationCreateMsgSubmitProposal

* Disable software upgrade proposals

* Move params keys to types package

* Implement param module proposal client logic

* Update gov client logic

* Update gaia app client hooks

* Fix linting errors

* Fix ValidateBasic

* Remove legacy files

* Update paramchange to use strings

* Update paramchange cli cmd

* Update ValidateBasic and errors

* Use PostCommands when adding child cmds

* Fix codec logic

* Update params client and handler

* Update IsValidProposalType

* Update SubmitProposal to test exec

* Implement TestGaiaCLISubmitParamChangeProposal

* Implement TestSubmitParamChangeProposal

* Update swagger.yaml

* Update gaiacli.md

* Update gov spec docs

* Fix linting errors

* Fix unit tests

* Add pending log entries

* Update docs

* Update docs

* Update client/lcd/swagger-ui/swagger.yaml

Co-Authored-By: alexanderbez <alexanderbez@users.noreply.github.com>

* Update docs/cosmos-hub/gaiacli.md

Co-Authored-By: alexanderbez <alexanderbez@users.noreply.github.com>

* Update cmd/gaia/cli_test/test_helpers.go

Co-Authored-By: alexanderbez <alexanderbez@users.noreply.github.com>

* Update client/lcd/test_helpers.go

Co-Authored-By: alexanderbez <alexanderbez@users.noreply.github.com>

* Update docs/cosmos-hub/gaiacli.md

Co-Authored-By: alexanderbez <alexanderbez@users.noreply.github.com>

* Update docs/cosmos-hub/gaiacli.md

Co-Authored-By: alexanderbez <alexanderbez@users.noreply.github.com>

* Update docs/cosmos-hub/gaiacli.md

Co-Authored-By: alexanderbez <alexanderbez@users.noreply.github.com>

* Update x/gov/types/proposal.go

Co-Authored-By: alexanderbez <alexanderbez@users.noreply.github.com>

* Update docs/cosmos-hub/gaiacli.md

Co-Authored-By: alexanderbez <alexanderbez@users.noreply.github.com>

* Update docs/cosmos-hub/gaiacli.md

Co-Authored-By: alexanderbez <alexanderbez@users.noreply.github.com>

* Address PR comments

* Update docs/cosmos-hub/gaiacli.md

Co-Authored-By: alexanderbez <alexanderbez@users.noreply.github.com>

* Update gov docs to include quorum notes

* Add logs to handleParameterChangeProposal

* Update docs/spec/governance/02_state.md

Co-Authored-By: alexanderbez <alexanderbez@users.noreply.github.com>

* Support and use new StatusFailed when proposal passes but fails exec

* Add docs/notes warning on param validity

* Update docs

* Update docs/spec/governance/02_state.md

Co-Authored-By: alexanderbez <alexanderbez@users.noreply.github.com>

* Update docs/spec/governance/02_state.md

Co-Authored-By: alexanderbez <alexanderbez@users.noreply.github.com>

* Minor doc update

* Update x/gov/client/cli/tx.go

Co-Authored-By: alexanderbez <alexanderbez@users.noreply.github.com>

* Fix usage of fromAddr

* Rige code style  suggestion

* Update x/params/types/proposal.go

Co-Authored-By: alexanderbez <alexanderbez@users.noreply.github.com>

* Fix CI lint errors

* Update NewModuleClient godoc

* Add godoc to rtr.Seal() call

* Rename files

* Rename NewProposalHandler
2019-04-30 12:31:38 -04:00
Juan Leni 1306a25e42 Adding support for Ledger Cosmos App v1.5 (#4227)
This PR adds support for the latest version of the Cosmos App (v.1.5).
The app is not been released yet by Ledger but the PR is backwards compatible.
We can later remove backwards compatibility and enforce v1.5 only.

When creating a new account, `gaiacli` now shows the account/index and address in the device and requires user confirmation.

Related PRs:
https://github.com/cosmos/ledger-cosmos-go/pull/3
https://github.com/cosmos/ledger-cosmos-go/pull/4
https://github.com/cosmos/ledger-cosmos-go/pull/5
https://github.com/cosmos/ledger-cosmos-go/pull/6

Changes in the app can be found here:
https://github.com/LedgerHQ/ledger-app-cosmos/pull/5
2019-04-30 09:58:21 +01:00
Alexander Bezobchuk f0f7b7dab7
Merge PR #4230: Minor cleanup in tx tags and response format 2019-04-29 23:50:44 -04:00
Frank Yang 5344e8d768 Merge PR #4220: Empty mnemonic should return error during key recovery 2019-04-29 12:49:35 -04:00
Alexander Bezobchuk ec4a1e8f2a
Merge PR #4207: Add rewards and commission tags in txs 2019-04-26 19:11:45 -04:00
Aleksandr Bezobchuk e7ca82d808
Merge branch 'develop' into release/v0.34.2 2019-04-25 21:40:33 -04:00
Alexander Bezobchuk 0e54369850 Merge PR #4177: Update Staking Validators Rest Query
* Support pagination and status query params for /staking/validators

* Rename BondStatusToString to String
2019-04-24 11:48:39 -04:00
Alexander Bezobchuk c6cb84c558
Merge PR #4059: Add support for graceful halt via server config 2019-04-23 09:33:11 -04:00
Alessio Treglia 93e8f467fe
Turn --from into a positional argument in gaiacli tx send (#4146)
Closes: #4142
2019-04-18 19:48:52 +01:00