* fix DiffKVStores(), store/types gets 100% coverage
DiffKVStores() used to return duplicated entries
in some cases.
Add test cases, aiming to reach 100% coverage for
store package.
Remove duplicate Cp function from the store package.
Same functionality is provided by types.CopyBytes().
* More test cases
Co-authored-by: Alexander Bezobchuk <alexanderbez@users.noreply.github.com>
* Bump Tendermint version to v0.33.0
* Deprecate old cmn package with new packages
* Update update DB APIs
* More DB updates
* Bump IAVL to v0.13.0
* Handle error returned by iavl.NewMutableTree
* Fix some IAVL stuffs
* Update IAVL
* More updates
* Passing tests
* Fix unit tests
Co-authored-by: Jack Zampolin <jack.zampolin@gmail.com>
I removed that stuff about cwwMutex and CacheWraps expiring. It was unnecessary complexity given that users need not write concurrent logic. If you have 2 CacheKVStores and you Write on one and later you Write on the other one, they will both write, and strange things may happen. But that’s OK, it’s kinda the expected (unsurprising) behavior. And now the code is much simpler.
Also I got rid of IterKVStore. It’s not necessary to distinguish them because we can have KVStore.Iterator() return nil or panic or an empty iterator. Further simplification…
KVStore.CacheKVStore() doesn’t exist. No need, just call NewCacheKVStore(parent).
Originally I wanted the .CacheKVStore() method because you can make the implementor be responsible for ensuring that returned CacheWraps don’t trample each other. But as written previously this complicates the code a lot more and it isn’t strictly necessary. It’s a kind of magic that maybe should just be avoided.
sdk.Iterator is dbm.Iterator. The plan is to conservatively add more aliases into the “sdk” namespace.
GetError() is removed from Iterator. We need to just panic to be consistent. More simplification.
Marko
Alessio Treglia
Alexander Bezobchuk
Joon
Christopher Goes
Ethan Buchman
rigelrozanski
Jae Kwon