Alessio Treglia
2ba21d33ab
types: better Dec.MarshalTo's performance ( #6691 )
...
Use big.Int.Cmp() and compare against zeroInt instead
of checking Bytes() against a 0-length byte slice.
Closes : #6680
Thanks: @odeke-em for the patch.
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
2020-07-12 13:26:51 +00:00
Emmanuel T Odeke
7f69b088d9
types: fix invalid int->string conversion in benchmarks ( #6678 )
...
Fixes an invalid int->string conversion that will become
a vet error for Go1.15. The correct conversion was to use
fmt.Sprintf("COINZ_%d", i)
instead of
"COINZ_" + string(i)
Noticed during a coverage audit.
2020-07-10 12:34:43 +02:00
Al
d269eaf74c
Document types/context.go code ( #6654 )
...
* document context.go code
* update CHANGELOG.md unreleased
* creates -> returns
* Update CHANGELOG.md
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
* Apply suggestions from code review
Co-authored-by: Alessio Treglia <quadrispro@ubuntu.com>
* Update types/context.go
Co-authored-by: Alexander Bezobchuk <alexanderbez@users.noreply.github.com>
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
Co-authored-by: Alessio Treglia <quadrispro@ubuntu.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
2020-07-09 19:14:18 +00:00
Alexander Bezobchuk
3de1c7d4fd
x/crisis: In-Process CLI Integration Tests ( #6634 )
...
* init commit
* fix tests
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
2020-07-08 08:23:34 +00:00
Alexander Bezobchuk
8670a10564
Merge PR #6595 : Single Binary & Command Refactor
2020-07-07 11:40:46 -04:00
Aaron Craelius
2f44fbf2ab
Add support for protobuf TxGenerator and SIGN_MODE_DIRECT ( #6385 )
...
* Add TxWrapper, encoder, decoder and DirectModeHandler
* fix pkg name
* Update API and leave test TODO's
* Update TxWrapper API
* tests for tx wrapper (#6410 )
* WIP: added test for direct mode handler
* updated code
* Add msg
* Update TxWrapper API
* Fix pubkey declaration
* Add pubkey for tests
* Fix SetFee
* Remove logs
* Avoid global var declaration for tests
* Add test for GetPubKeys
* Fix direct signing tests
* Add more test cases for GetSignBytes
* Revert SetFee API
* Remove logs
* Refactor tests
Co-authored-by: anilCSE <anil@vitwit.com>
Co-authored-by: sahith-narahari <sahithnarahari@gmail.com>
* Refactoring
* Refactoring
* Integrate SignatureV2 API
* Fix wrapper tests
* Fix tests
* Linting and API tweaks
* Update API
* WIP on updating API
* Fix tests
* Update to new SigVerifiableTx
* Rename
* Update docs to reflect ADR 020
* proto-gen
* proto docs
* cleanup
* cleanup
* cleanup
* cleanup
* cleanup
* cleanup
* cleanup
* Add tests
* Refactor and improving test coverage
* WIP on test coverage
* WIP on test coverage
* proto-gen
* Fix CompactBitArray.Size() bug
* Rename
* Remove Builder interface
* Address review comments
* Update x/auth/tx/sigs.go
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
* Update x/auth/tx/encoder.go
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
* Update x/auth/tx/encoder.go
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
* Address review feedback
* Fix build issues
* Resolve conflicts
* Fix ValidateBasic test coverage
* Add test for malicious multisig
Co-authored-by: atheeshp <59333759+atheeshp@users.noreply.github.com>
Co-authored-by: anilCSE <anil@vitwit.com>
Co-authored-by: sahith-narahari <sahithnarahari@gmail.com>
Co-authored-by: Alexander Bezobchuk <alexanderbez@users.noreply.github.com>
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
2020-07-06 17:03:45 +00:00
Alexander Bezobchuk
9ebda4edb9
Server/simd: Viper Removal ( #6599 )
...
* init commit
* remove viper from tm cmds
* updates
* Undo x/bank/client/cli/tx.go
* Fix unit tests
* lint++
* rename var
* Fix genutil test
* fix test
* prefer cmd.Flags() over direct viper usage
* update
* fix ABCI error tests
* fix integration tests
* Add viper to context
* fix build
* fix unit test
* Implement and use AppOptions
* Revert Redact godoc
Co-authored-by: Alessio Treglia <alessio@tendermint.com>
2020-07-05 16:56:17 +00:00
Aaron Craelius
849429ecda
Add proper support for Any in gRPC queries ( #6594 )
...
* Add proper gRPC Any support via AnyUnpacker
* Wire up grpc query router AnyUnpacker
2020-07-03 16:42:12 +00:00
Anil Kumar Kammari
a966f1f9b7
Fix nextKey bug in filteredPaginate ( #6578 )
...
* Fix nextKey in filteredpaginate
* Fix example
* Fix example
* cleanup
* cleanup
* refactor
Co-authored-by: sahith-narahari <sahithnarahari@gmail.com>
2020-07-03 12:36:37 +00:00
Alexander Bezobchuk
14d1ee5437
Use Context in Command instead of Argument + Util ( #6572 )
...
* Use context
* use PersistentPreRunE
* undo
* use init context
* Update types
* update tests
* implement tests
* Update simapp/cmd/simcli/main.go
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
* Update simapp/cmd/simcli/main.go
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
* Update x/bank/client/cli/tx.go
Co-authored-by: Alessio Treglia <alessio@tendermint.com>
* fix build
Co-authored-by: Alessio Treglia <alessio@tendermint.com>
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
2020-07-02 13:02:28 +00:00
Jonathan Gimeno
8f96ec0585
REST bank transfers fail due to encoding. ( #6536 )
...
Bank module REST endpoint bank/accounts/{addr}/transfers
was returning invalid StdTx format.
2020-07-02 05:16:39 +02:00
Anil Kumar Kammari
0f0723dd78
Add filtered pagination ( #6514 )
...
* Add filtered pagination
* Add example for filtered pagination
* Fix typo
* Fix counter
* Fix paginate
* fix accumulate
* Fix example
* rename count to numHits
* Add default PageRequest
* Add tests for filtered pagination
* Fix filteredPaginate tests
* Add test cases
* Add example for filtered pagination
* Add more test case
* Add iterate error
* Add error check for iterator
* Update godoc
* Update godoc
Co-authored-by: sahith-narahari <sahithnarahari@gmail.com>
Co-authored-by: Aaron Craelius <aaron@regen.network>
2020-07-01 14:04:26 +00:00
Alexander Bezobchuk
d5049413ef
Merge PR #6525 : x/bank: Refactor CLI & Tests
2020-06-30 16:59:21 -04:00
Jonathan Gimeno
c44ca8ae34
add string test for coin and coins ( #6547 )
...
Co-authored-by: Alexander Bezobchuk <alexanderbez@users.noreply.github.com>
2020-06-30 14:11:29 -04:00
Alexander Bezobchuk
9bf3ff75f5
Merge PR #6489 : Test Network Testing Framework
2020-06-26 12:30:49 -04:00
SaReN
4b0c66982a
Add pagination ( #6452 )
...
* Add pagination types and helper func
* Update API
* Add pagination to queryBalance
* Add QueryBalance to use Paginate
* Update GetAllBalances usage
* Add tests for QueryAllBalances
* Fix bank get balance querier tests
* Add pagination test setup
* revert simapp changes
* Fix pagenation tests
* Add more tests for pagination
* Add offset nullable
* Add more tests
* Fix paginate for offset
* Add grpc queryconn for query
* Fix paginate
* Fix maxlimit
* Fix queryClient
* Fix pagination tests
* refacor
* Fix grpc tests
* Revert
* review changes
* Fix lint
* Update types/query/pagination.go
* Fix review suggestions
* Remove maxLimit and use defaultLimit
* change example paginate as a testable fun
* Fix review comments
* Merge master
* Add bank query.pb.go
* Add missing import
* Add pageReq to queryBalance
* Add example for pagenate
* Fix cli tests
* Remove example for pagination
* Update paginate example
Co-authored-by: Aaron Craelius <aaronc@users.noreply.github.com>
Co-authored-by: Aaron Craelius <aaron@regen.network>
Co-authored-by: anilCSE <anil@vitwit.com>
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
2020-06-20 23:44:04 +00:00
Cory
4e73e0f817
Update proto files & definitions in accordance with ADR023 ( #6413 )
...
* consolidate proto files into single directory, turn on PACKAGE_DIRECTORY_MATCH linting
* add third_party root for third party proto files
* move ibc proto files to top level folder, rename .proto files to types.proto as before
* update protocgen script, and run code generation
* move vesting proto definition to cosmos namespace, rename from types.proto in alignment with buf.build naming conventions
* update Makefile so proto dependencies are set with new structure when updated
* add comment for sed usage in makefile
* remove unused aliases of proto generated types
* add settings.json instructions to contributing.md for including protobuf paths
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
Co-authored-by: Aaron Craelius <aaron@regen.network>
2020-06-18 10:04:26 -07:00
Aaron Craelius
c13809062a
Update TxBuilder to use SignatureV2 ( #6443 )
...
* Update TxBuilder to use SignatureV2
* Fix unit tests
* Lint
* lint
* Cleanup
* Address review feedback
* Add Sign tests
* Add more cases for sign tests
* Fix lint
* Fix gofmt
* Deprecate StdTx
* Undeprecate StdTx, but leave a comment to use the protobuf Tx
* Address review comment
Co-authored-by: anilCSE <anil@vitwit.com>
2020-06-16 19:57:37 +00:00
Aaron Craelius
60f7edfe3d
Add SignatureV2 infrastructure ( #6373 )
...
* Updte tx generator
* Add sigv2, PublicKeyCodec
* revert changes
* revert changes
* updates
* Updates
* Integrate multisig support
* Undo move
* remove func
* undo
* godocs
* godocs, cleanup
* Cleanup
* godocs, tests
* lint
* Re-enable VerifyBytes
* Address comments
* Fix imports
* Update crypto/types/multisig/multisignature.go
* Add test for MultiSignatureData
* Add nested multisig case
* Add test for AddSignatureV2
* Add changelog
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
Co-authored-by: sahith-narahari <sahithnarahari@gmail.com>
2020-06-12 18:13:20 +00:00
Jonathan Gimeno
ddbb9a2321
run make format ( #6416 )
2020-06-12 10:17:36 -04:00
Jonathan Gimeno
49597b19ec
module: pass route by value ( #6404 )
...
* use instance
* add some comments
* Update types/router.go
* rename Nil to Empty
* run make mocks
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
Co-authored-by: Alessio Treglia <alessio@tendermint.com>
2020-06-11 15:37:23 +00:00
Jonathan Gimeno
79c308ae4a
Concept PR simplify Module ( #6231 )
...
* add test of alternative impl
* simplify query route too
* change name querier
* simplify register routes
* revert change
* add route
* add router
* first step refactor
* refactor
* update documentation
* update
* add format
* simplify appmodule
* update changelog
* rename vars
* remove interface
* Update CHANGELOG.md
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
2020-06-10 18:48:16 +00:00
Alexander Bezobchuk
c0aff2e1f5
baseapp: Enhance Tx Message Data ( #6384 )
...
* Enhance tx message data
* Fix allocation
* cl++
* Fix lint
2020-06-10 04:02:01 -04:00
Aaron Craelius
43947ca2ef
Add RegisterQueryService to AppModule ( #6336 )
...
* Add RegisterQueryService to AppModule
* Update CHANGELOG.md
* Update CHANGELOG.md
* Wire up BaseApp, fix tests
* Add mock test
* add missing file
* Update types/module/module.go
* Update CHANGELOG.md
Co-authored-by: Alexander Bezobchuk <alexanderbez@users.noreply.github.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
2020-06-06 07:59:57 +00:00
Aaron Craelius
81d647e505
Move codec.RegisterCrypto and codec.Cdc to new packages ( #6330 )
...
* Move codec.Cdc to legacy_global.Cdc
* Update CHANGELOG.md
* Updates
* nit
* Fix imports
* Updates
* Use cosmos multisig instead of tendermint multisig everywhere
* Fix tests
* Rename legacy_global -> legacy
* Add doc.go
* Linting, move all RegisterCrypto calls to crypto/codec
* Update crypto/codec/amino.go
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
2020-06-04 10:38:24 +00:00
Aaron Craelius
fed0c2317d
Change GetQueryCmd to take client.Context ( #6326 )
...
* Change GetQueryCmd to take a client.Context
* Update CHANGELOG
Co-authored-by: Alexander Bezobchuk <alexanderbez@users.noreply.github.com>
2020-06-03 20:15:11 +00:00
Aaron Craelius
2e11c81668
Make sdk.Msg implement proto.Message ( #6327 )
...
* Make sdk.Msg implement proto.Message
* Cleaning up
* Cleaning up
* Update CHANGELOG.md
* Lint fixes
* Lint fixes
* fix tests
Co-authored-by: Alexander Bezobchuk <alexanderbez@users.noreply.github.com>
2020-06-03 19:52:05 +00:00
Aaron Craelius
e94b6736ed
Merge PR #6325 : Add GRPCRouter
2020-06-03 09:33:51 -04:00
SaReN
39f53ac22f
client: rename CliContext to Context ( #6290 )
...
* Refactor CliContext as Context
* Fix lint issues
* Fix goimports
* Fix gov tests
* Resolved ci-lint issues
* Add changelog
* Rename cliCtx to clientCtx
* Fix mocks and routes
* Add changelog
* Update changelog
* Apply suggestions from code review
Co-authored-by: Alessio Treglia <alessio@tendermint.com>
* merge client/rpc/ro{ot,utes}.go
* Update docs
* client/rpc: remove redundant client/rpc.RegisterRPCRoutes
* regenerate mocks
* Update ADRs
Co-authored-by: Alessio Treglia <alessio@tendermint.com>
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
2020-06-01 12:46:03 +00:00
Marko
1daf5dadf5
ci: split unit tests across 4 machines ( #6297 )
...
Try reduce the overall build time by splitting test coverage
across 4 instances.
Co-authored-by: Alessio Treglia <alessio@tendermint.com>
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
2020-05-29 15:25:27 +02:00
dauTT
7cd0caba7a
Merge PR #6278 : Add msg type sim operations
2020-05-26 12:52:23 -04:00
colin axner
6973c56457
x/ibc: fix internal errors messages ( #6268 )
...
* update errors in ibc client and localhost
* update code 1 errors
* fix misisng import
* add import
* fix compile and lint issues
* fix lint
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
2020-05-22 17:17:52 -04:00
Aaron Craelius
850419fffd
Tx CLI proto module interface ( #5989 )
...
* WIP
* WIP
* WIP on removing x/auth dependency from client/tx
* Revert unneeded changes
* Simplify cli tx UX
* Wire up bank tx REST routes
* Fix assignment issue
* Wire up bank NewSendTxCmd
* fix lint
* revert file
* revert file
* fix simcli
* Refactor AccountRetriever
* Fix build
* Fix build
* Fix build
* Fix integration tests
* Fix tests
* Docs, linting
* Linting
* WIP on all modules
* Implement other module new tx cmd's
* Fix cmd's
* Refactor existing GetTxCmd
* Fix cmd
* Removing deprecated code
* Update ADR 020 & CHANGELOG
* Lint
* Lint
* Lint
* Lint
* Lint
* Lint
* Lint
* Fix client/tx tests
* Fix mocks
* Fix tests
* Lint fixes
* REST tx migration
* Wire up REST
* Linting
* Update CHANGELOG, docs
* Fix tests
* lint
* Address review feedback
* Update CHANGELOG.md
Co-authored-by: Alexander Bezobchuk <alexanderbez@users.noreply.github.com>
* Update CHANGELOG.md
Co-authored-by: Alexander Bezobchuk <alexanderbez@users.noreply.github.com>
* group vars
Co-authored-by: Alexander Bezobchuk <alexanderbez@users.noreply.github.com>
2020-05-21 21:29:34 +00:00
Marko
a201967fd1
multisig: add type and bitarray ( #6241 )
...
* add multisig and bitarray
* remove random message
* add changelog entry
* bring back the concrete type
* move changelog entry
* move bitarray to crypto/types
* fix build
* remove commented code
Co-authored-by: Aaron Craelius <aaron@regen.network>
2020-05-20 20:10:49 +00:00
Aaron Craelius
70767c87c4
Update x/gov to use Any ( #6147 )
...
* Update x/gov to use Any
* Fixes
* Remove MsgSubmitProposalLegacy
* Update CHANGELOG.md
* Add RegisterInterfaces for x/distribution, x/params, & x/upgrade
* Fix query JSON issue
* Fix gov tests
* Revert custom Any Equals
* Re-remove types
* Rename receivers
* Fix imports in gov
* Sort imports
* Make amino JSON signing work with Any
* Run proto-gen
* Create full amino wrapper
* Fix errors
* Fixes
* Fix tests
* Test fixes
* Fix tests
* Linting
* Update ADR 019 and CHANGELOG
* Updated ADR 019
* Extract Marshal/UnmarshalProposal
* fix error
* lint
* linting
* linting
* Update client/keys/parse.go
Co-authored-by: Marko <marbar3778@yahoo.com>
* linting
* Update docs/architecture/adr-019-protobuf-state-encoding.md
Co-authored-by: Alexander Bezobchuk <alexanderbez@users.noreply.github.com>
* Update docs/architecture/adr-019-protobuf-state-encoding.md
Co-authored-by: Alexander Bezobchuk <alexanderbez@users.noreply.github.com>
* Address review feedback
* Add godocs
* Fix errors
* fix errors
* revert file
* Address review feedback
* Address review feedback
* Stacktrace debug flag
* Fix tests
* Address review feedback
Co-authored-by: sahith-narahari <sahithnarahari@gmail.com>
Co-authored-by: Marko <marbar3778@yahoo.com>
Co-authored-by: Alexander Bezobchuk <alexanderbez@users.noreply.github.com>
2020-05-19 20:17:29 +00:00
Marko
d7677e0871
ci: test paths directive ( #6251 )
...
* test paths directive
* change proto files
* test paths on code coverage
* have parts of ci only run when go files are touched
* add readme badge
* bring back green checks
* remove paths
* green check linting
* add tests no run
2020-05-19 13:32:35 +00:00
Aaron Craelius
49ae8800d1
Merge PR #6214 : Add Tx, SignDoc, etc. proto types from #6111
2020-05-14 15:27:48 -04:00
Riccardo Montagnin
bd90d6b344
Merge PR #6219 : Different db support
2020-05-14 09:41:05 -04:00
Federico Kunze
48aebed2ea
x/ibc: /types cleanup ( #6169 )
...
* x/ibc: move /types to /common
* x/ibc/types: remove errors
* remove mocked proofs
* remove invalidProof{}
* create new ibc/types dir
* format
* move keys to host
* move order to channel
* move channel state
* move connection state
* lint
2020-05-13 19:23:33 -04:00
Marko
2f68c4166d
fix import to sdk ( #6201 )
2020-05-12 17:12:26 +00:00
Marko
4173ea5eba
types: add bech32 ( #6200 )
...
* bring over bech32 from tendermint
* fix spacing
* address comment
* change to fmt.Errorf
* space dem comments
* remove err cheks
2020-05-12 16:53:30 +00:00
Yongwoo Lee
d4882606d5
Merge PR #6195 : Add codespace to broadcast(sync/async) response
2020-05-12 11:26:54 -04:00
Marko
bef3689245
linter: enable nolintlint ( #6162 )
...
* nolintlint enable
* remove space
* fix tests
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
2020-05-08 08:46:12 +00:00
Adam Bozanich
4e328d75db
client/keys/parse: honor config changes ( #6172 )
...
`keys parse` uses the global configuration before
before client applications have had a chance to
apply their settings.
This change adds a `GetSealedConfig()` helper
that waits for the config to be sealed before
returning it.
fixes #5091
addresses #5283
2020-05-08 10:30:55 +02:00
Aaron Craelius
386217209d
Merge PR #6076 : Proto Any init + evidence
2020-05-05 10:28:20 -04:00
Marko
218ec99508
various linter fixes ( #6106 )
...
x/staking: Fix all linter warnings.
Fixed warnings across base packages.
New linters:
- unparam
- nolintlint
Co-authored-by: Alessio Treglia <alessio@tendermint.com>
2020-05-02 21:26:59 +02:00
Alessio Treglia
2879c0702c
x/ibc: fix missing return statement ( #6099 )
...
* enable the wsl linter
Fix various wsl-related warnings.
x/ibc/04-channel/keeper/handshake.go: fix missing return statement in ChanOpenTry().
* goimports -w files
* remove unknown linter references
* run make format
* Revert "run make format"
This reverts commit f810b62b9e4993f08506663d4e5f2ec2228a9863.
* run make format
2020-04-29 22:36:34 -04:00
Federico Kunze
3ee975c57b
Merge PR #6037 : refactor simulation decoder
2020-04-21 17:33:56 -04:00
Aditya
d247184157
Revert Capabilities on Failed Tx ( #5999 )
...
Reintroduce memKVStore to keep track of fwd and reverse mappings.
On reverse mapping, rather than store a mapping to marshalled
capability; we store the index.
capability.Keeper and all scopedKeeper have access to a capability
map that maps index to the capability pointer.
This is done to make sure that all writes to memKVStore get reverted
on a fail tx, while also allowing GetCapability to retrieve the original
memory pointer from the go map.
Go map must be accessed only by first going through the
memKVStore. SInce writes to go map cannot be automatically
reverted on tx failure, it gets cleaned up on failed GetCapability calls.
Closes : #5965
2020-04-16 18:42:13 +02:00
Aaron Craelius
bb4642ad0d
Decouple client/tx from x/auth ( #5992 )
...
As part of #5864 part 2), this PR decouples the new client/tx
package from x/auth (as an incremental step to deprecating
all the tx logic in x/auth) and adds StdFee, StdSignature,
StdSignMsgBase and StdTxBase to codec/std, while
deprecating the corresponding types in x/auth.
2020-04-15 23:55:02 +02:00