Fixes regression introduced by #2984.
Continuiation of #3033 , which didn't fix the simulation issues.
(candidate) Complete solution for #3019, 9002 halt bug.
From #2984, it isn't sufficient to take the fee pool rewards of a validator. Since we don't track delegator accums (as we do with validator accums), and because onValidatorModified >updateValidatorDistInfoFromPool is also being called upon delegation updates (or at least I believe this is the reason), it is necessary to also withdraw self delegation.
TODO: I don't think self-delegation should be required to be modified here... consider using a delegation hook to do the self-delegation withdraw part instead, e.g. splitting the updateValidatorDistInfoFromPool function into two. It might not result in cleaner code, however. Think hard.
* Some minor cleanup and reformatting to make things easier to understand
* Update onDelegationSharesModified hook
* Add pending log
* Address PR comments
* Fix linting
* Add and use CodeInvalidAccountNumber in ante handler
* Minor cleanup of ante handler
* Add pending log entry
* Spell check and more minor comment restructuring
* Add additional CodeInvalidAccountNumber
* Update validateAccNumAndSequence
* Revert account number error in favor of CodeInternal
* Update pending log
* Fix pending log
* Add shorthand flag to address output on gaiacli keys show
* Update docs and add PENDING
* Update client/keys/show.go
Co-Authored-By: jackzampolin <jack.zampolin@gmail.com>
* pk -> p
* Fix gaiacli config and make it non-interactive only
Closes: #2734
* Update cli tests
* Remove --list, by default and with no args print config
* Small improvements
* Warn user when file doesn't exist
* Fix integration tests
* Add check that account is in genesis and contains enough funds to gentx command
* Fix CLI tests and make them parallel
* Update makefile to take advantage of parallel tests
* Add path seperator back in
* Don
't check error on key delete
* Add debuggin printout for debugging remote test failures
* Update cmd/gaia/init/gentx.go
Co-Authored-By: jackzampolin <jack.zampolin@gmail.com>
* Update cmd/gaia/init/gentx.go
Co-Authored-By: jackzampolin <jack.zampolin@gmail.com>
* Change to bondDenom from the stake section in genesis
* Add PENDING.md
* Push changes
* Fix CI failure
* Address PR comments
* Fix broken gov tests
* Address PR comments
* Address PR comments
* Don't serialize Account Number and Sequence Number in signatures
This was not needed to be included within the tx body, as its in the
state.
* fix lint
* Cleanup dirs when testcases exit with success
Also remove unnecessary tests.WaitForNextNBlocksTM() calls
which slow down tests execution.
* Don't wait for 2 blocks
* add --force to keys delete for unattended execution
Skip password check when --force is on and delete
keys unconditionally.
Closes: #2961
* Forcibly cleanup keys on fixtures initialization
* Force password to 'yes' when deleting ledger-offline keys
* Improve UX, better docs on removing offline/ledger keys
* Ask for confirmation on offline/ledger keys deletion
* Update PENDING.md
* Add simple period for expensive invariants
* Remove individual module simulations
* Simulate a few more blocks
* Add README explaining reason for shell scripts
* Deduplicate scripts, log exact replication command on failure
* Refactor invariants to take sdk.Context instead of baseapp.BaseApp
* Reference all issues in PENDING.md entry
* Remove no longer used simulation.RandSetup
* Bug fixes
* Address @rigelrozanski comments
* Fix typo
Christopher Goes
Alessio Treglia
Sunny Aggarwal
Jae Kwon
Jack Zampolin
frog power 4000
Alexander Bezobchuk
Alessio Treglia
Dev Ojha
Zach
gamarin2
mircea-c
Ethan Buchman
Juan Leni
Hendrik Hofstadt