64b6bb5270
rename RegisterCodec to RegisterLegacyAminoCodec ( #7243 )
...
* rename RegisterCodec to RegisterLegacyAminoCodec
* Add changelog
* gofmt
* rename codec.New() to codec.NewLegacyAmino()
* Add change log
* Update CHANGELOG.md
Co-authored-by: Amaury Martiny <amaury.martiny@protonmail.com>
* Fix
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
Co-authored-by: Amaury Martiny <amaury.martiny@protonmail.com>
2020-09-07 14:47:12 +00:00
9e85e81e0e
Remove GetSignatures from SigVerifiableTx ( #6550 )
...
* Remove GetSignatures from SigVerifiableTx
* Fix conflicts
* update client tests
* fix x/auth tests
* add MultiSignatureData test case for ConsumeTxSizeGasDecorator test
Co-authored-by: Alexander Bezobchuk <alexanderbez@users.noreply.github.com>
Co-authored-by: sahith-narahari <sahithnarahari@gmail.com>
Co-authored-by: Cory Levinson <cjlevinson@gmail.com>
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
2020-09-02 20:41:13 +00:00
23a9f46aad
Update tm pubkey references ( #7102 )
...
* Update pubkey references
* Update ledger_mock
* Migrate encoding from tm
* Update pubkey prefix
* revert ed25519 to tendermint key
* random account revert
* Revert ed25519 references
* revert secp key name
* test revert
* remove ed25519
* Update x/staking/types/validator.go
Co-authored-by: Amaury Martiny <amaury.martiny@protonmail.com>
* Revert "remove ed25519"
This reverts commit 66d2e1d061aeae81c4c0a3daf718536b09dda19e.
* remove ed25519 & sr25519
* Apply suggestions from code review
* remove codec
Co-authored-by: Marko Baricevic <marbar3778@yahoo.com>
Co-authored-by: Amaury Martiny <amaury.martiny@protonmail.com>
2020-08-28 16:02:38 +00:00
50bab8f820
Put AccountSequence in SignerInfo ( #6997 )
...
* WIP test the grounds
* Update ADR020
* Fix compile errors
* Fix ADR
* Make ante tests pass
* Fix remaining ante handler tests
* Simplify code
* Fix x/bank app_test
* Fix tests
* Remove useless accSeq from signerdata
* Fix test
* Update simapp/helpers/test_helpers.go
Co-authored-by: Alexander Bezobchuk <alexanderbez@users.noreply.github.com>
* Update simapp/helpers/test_helpers.go
Co-authored-by: Alexander Bezobchuk <alexanderbez@users.noreply.github.com>
* Update x/auth/client/cli/tx_multisign.go
Co-authored-by: Alexander Bezobchuk <alexanderbez@users.noreply.github.com>
* Address rewview
* Update x/auth/ante/sigverify.go
Co-authored-by: Simon Warta <2603011+webmaster128@users.noreply.github.com>
* Update x/auth/ante/sigverify_test.go
Co-authored-by: Simon Warta <2603011+webmaster128@users.noreply.github.com>
* Update x/auth/tx/builder_test.go
Co-authored-by: Simon Warta <2603011+webmaster128@users.noreply.github.com>
* Update x/auth/tx/builder_test.go
Co-authored-by: Simon Warta <2603011+webmaster128@users.noreply.github.com>
* Update x/auth/tx/direct_test.go
Co-authored-by: Simon Warta <2603011+webmaster128@users.noreply.github.com>
* Update x/auth/tx/builder_test.go
Co-authored-by: Simon Warta <2603011+webmaster128@users.noreply.github.com>
* AccSeq -> Seq
* Address reviews
* Better variable naming
* Fix variable assign
* Remove old SetSignerInfo
* Fix test
* proto-gen
* Make proto-gen
* Reput gw comment
* Add Changelog
* Update x/bank/app_test.go
Co-authored-by: Alexander Bezobchuk <alexanderbez@users.noreply.github.com>
* Update x/bank/app_test.go
Co-authored-by: Alexander Bezobchuk <alexanderbez@users.noreply.github.com>
Co-authored-by: Alexander Bezobchuk <alexanderbez@users.noreply.github.com>
Co-authored-by: SaReN <sahithnarahari@gmail.com>
Co-authored-by: Simon Warta <2603011+webmaster128@users.noreply.github.com>
2020-08-21 14:20:47 +00:00
8de96d16f9
tendermint: update to rc3 ( #6892 )
...
* modify light imports
* change abci.header to tmproto.header
* use rc
* rc
* fix import
* Merge PR #6893 : fix key imports
* fix rc2
* tendermint: update 3 (#6899 )
* tendermint: update 4 (#6919 )
Co-authored-by: Alexander Bezobchuk <alexanderbez@users.noreply.github.com>
* tendermint: update 5 (#6923 )
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
* bump to latest master
* tendermint: update (#6972 )
Co-authored-by: Aleksandr Bezobchuk <aleks.bezobchuk@gmail.com>
Co-authored-by: Cory Levinson <cjlevinson@gmail.com>
* Update x/ibc/07-tendermint/types/test_utils.go
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
* address comment
* go mod
* bring back things
* fix test
* update tm proto files
Co-authored-by: Alexander Bezobchuk <alexanderbez@users.noreply.github.com>
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
Co-authored-by: Aleksandr Bezobchuk <aleks.bezobchuk@gmail.com>
Co-authored-by: Cory Levinson <cjlevinson@gmail.com>
Co-authored-by: Federico Kunze <federico.kunze94@gmail.com>
2020-08-14 13:58:53 -04:00
9ae17669d6
Tx Height Timeout ( #6089 )
...
* Implement TxHeightTimeoutDecorator
* Update error message
* rename type
* set height timeout
* update tests
* update *SignDoc)
* rename
* remove dup
* fix build
* cli updates
* rest updates
* cl++
* Update x/auth/ante/basic.go
Co-authored-by: colin axnér <25233464+colin-axner@users.noreply.github.com>
* Update x/auth/ante/basic.go
Co-authored-by: colin axnér <25233464+colin-axner@users.noreply.github.com>
* Update x/auth/ante/basic.go
Co-authored-by: colin axnér <25233464+colin-axner@users.noreply.github.com>
* Update x/auth/ante/basic.go
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
* rename
* rename
* remove TimeoutHeight from SignDoc
* updates
* fix tests
* update IBC cmd flags
* use omitempty
* update godoc
* add test case to TestStdSignBytes
Co-authored-by: colin axnér <25233464+colin-axner@users.noreply.github.com>
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
2020-08-07 23:32:22 +00:00
6d937443b2
Reject unknown fields in TxDecoder and sign mode handlers ( #6883 )
...
* WIP on unknown field rejection in TxDecoder
* WIP on unknown field rejection in TxDecoder
* WIP
* WIP
* WIP
* WIP
* Fix bugs with RejectUnknownFields
* Fix tests
* Fix bug and update docs
* Lint
* Add tests
* Add unknown field tests
* Lint
* Address review comments
2020-08-03 19:47:25 +00:00
ef6dc2f180
Revert change of StdSignature PubKey to []byte ( #6885 )
...
* Revert change of StdSignature.PubKey to []byte
* Fixes
2020-07-30 09:29:43 +00:00
9592f34cde
Fully remove StdTx usage in ante handler tests ( #6845 )
...
* WIP on removing StdTx from ante handler tests
* Fix recheck
* Fix basic_test
* Don't use StdTx in ante_test
* Use TxConfig sign mode handler in anteHandler
* Fix TestAnteHandlerAccountNumbers
* Amino don't panic
* Fix more tests
* All proto ante tests pass
* Fix last tests
* Amino register concrete
* Add tests
Co-authored-by: Amaury Martiny <amaury.martiny@protonmail.com>
2020-07-29 15:52:22 +00:00
cde3f46d52
Add validation to prevent empty store keys ( #6754 )
...
Co-authored-by: Alexander Bezobchuk <alexanderbez@users.noreply.github.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
2020-07-20 18:05:01 +02:00
5c0e3b4de5
x/auth/ante: Migrate tests to use the new client.TxConfig ( #6661 )
...
* WIP: using encoding config
* Make it compile, test fails
* test should be okay
* Make tests pass
* Add comments
* Convert more tests
* Make TestAnteHandlerSigErrors work
* Make first 2 tests pass
* TestAnteHandlerAccountNumbers
* Use table tests
* Remove print
* Use test table
* TestAnteHandlerSigErrors
* TestAnteHandlerAccountNumbers
* TestAnteHandlerAccountNumbers
* Refactor TestAccount
* Refactor getSignBytes
* TestAnteHandlerAccountNumbersAtBlockHeightZero
* TestAnteHandlerSequences
* TestAnteHandlerFees
* TestAnteHandlerMultiSigner
* TestAnteHandlerBadSignBytes
* TestAnteHandlerSetPubKey
* TestAnteHandlerSigLimitExceeded
* TestCustomSignatureVerificationGasConsumer
* TestAnteHandlerReCheck
* Make all tests pass
* Refactor a little bit more
* Fee test
* SetupTest
* All tests pass
* Refactor to RunTestCase
* Don't use StdFee
* Revert some little stuff
* Finish up last couple of test cases
* Less verbose
* s/TxGenerator/TxConfig
* Add comments
* Indent
* Move KeyTestPubAddr to testdata
* Move testdata to /testutil
* Revert to use signature: nil step in signing
* Add comments
Co-authored-by: Alexander Bezobchuk <alexanderbez@users.noreply.github.com>
2020-07-20 08:30:12 -04:00
1d711f537c
x/auth/signing/direct: increase test coverage to 100% from 83.3% ( #6731 )
...
Ensure that all known routes for GetSignBytes are explored for
DirectHandler.
2020-07-16 03:48:36 -04:00
2f44fbf2ab
Add support for protobuf TxGenerator and SIGN_MODE_DIRECT ( #6385 )
...
* Add TxWrapper, encoder, decoder and DirectModeHandler
* fix pkg name
* Update API and leave test TODO's
* Update TxWrapper API
* tests for tx wrapper (#6410 )
* WIP: added test for direct mode handler
* updated code
* Add msg
* Update TxWrapper API
* Fix pubkey declaration
* Add pubkey for tests
* Fix SetFee
* Remove logs
* Avoid global var declaration for tests
* Add test for GetPubKeys
* Fix direct signing tests
* Add more test cases for GetSignBytes
* Revert SetFee API
* Remove logs
* Refactor tests
Co-authored-by: anilCSE <anil@vitwit.com>
Co-authored-by: sahith-narahari <sahithnarahari@gmail.com>
* Refactoring
* Refactoring
* Integrate SignatureV2 API
* Fix wrapper tests
* Fix tests
* Linting and API tweaks
* Update API
* WIP on updating API
* Fix tests
* Update to new SigVerifiableTx
* Rename
* Update docs to reflect ADR 020
* proto-gen
* proto docs
* cleanup
* cleanup
* cleanup
* cleanup
* cleanup
* cleanup
* cleanup
* Add tests
* Refactor and improving test coverage
* WIP on test coverage
* WIP on test coverage
* proto-gen
* Fix CompactBitArray.Size() bug
* Rename
* Remove Builder interface
* Address review comments
* Update x/auth/tx/sigs.go
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
* Update x/auth/tx/encoder.go
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
* Update x/auth/tx/encoder.go
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
* Address review feedback
* Fix build issues
* Resolve conflicts
* Fix ValidateBasic test coverage
* Add test for malicious multisig
Co-authored-by: atheeshp <59333759+atheeshp@users.noreply.github.com>
Co-authored-by: anilCSE <anil@vitwit.com>
Co-authored-by: sahith-narahari <sahithnarahari@gmail.com>
Co-authored-by: Alexander Bezobchuk <alexanderbez@users.noreply.github.com>
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
2020-07-06 17:03:45 +00:00
c0e48e1c43
Update ante handlers to use SignatureV2 ( #6428 )
...
* Update ante handlers to use SignatureV2
* WIP on test fixes
* WIP on test fixes
* Debugging CLI Tests
* CHANGELOG.md
* CHANGELOG
* Add missing tests for ante
* Add tests for verify signatures
* Update verify tests
* Fix register codec issue
* debug
* Cleanup
* Fix verify signature tests
* Remove viper
* remove keyring usage
* Fix review changes
* Fix simapp
* Fix ante tests
* Add reference issue
* Add test for multisignature
* Wrap sign error with sig
* Fix verify sign test
* Fix CHANGELOG.md
Co-authored-by: sahith-narahari <sahithnarahari@gmail.com>
Co-authored-by: anilCSE <anil@vitwit.com>
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
Co-authored-by: Alexander Bezobchuk <alexanderbez@users.noreply.github.com>
2020-06-29 20:48:41 +00:00
c13809062a
Update TxBuilder to use SignatureV2 ( #6443 )
...
* Update TxBuilder to use SignatureV2
* Fix unit tests
* Lint
* lint
* Cleanup
* Address review feedback
* Add Sign tests
* Add more cases for sign tests
* Fix lint
* Fix gofmt
* Deprecate StdTx
* Undeprecate StdTx, but leave a comment to use the protobuf Tx
* Address review comment
Co-authored-by: anilCSE <anil@vitwit.com>
2020-06-16 19:57:37 +00:00
24b9be0ef8
x/bank: remove alias.go usage ( #6439 )
...
* x/bank: remove alias.go usage
* Fix simd_test.go
2020-06-14 23:06:16 +00:00
60f7edfe3d
Add SignatureV2 infrastructure ( #6373 )
...
* Updte tx generator
* Add sigv2, PublicKeyCodec
* revert changes
* revert changes
* updates
* Updates
* Integrate multisig support
* Undo move
* remove func
* undo
* godocs
* godocs, cleanup
* Cleanup
* godocs, tests
* lint
* Re-enable VerifyBytes
* Address comments
* Fix imports
* Update crypto/types/multisig/multisignature.go
* Add test for MultiSignatureData
* Add nested multisig case
* Add test for AddSignatureV2
* Add changelog
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
Co-authored-by: sahith-narahari <sahithnarahari@gmail.com>
2020-06-12 18:13:20 +00:00
08b7557fe5
Add basic sign mode infrastructure ( #6371 )
...
* Add SignModeHandler and LegacyAminoJSONHandler
* Simplify, add tests
* Add godocs
* Add handler map
* Rename HandlerMap
* Don't use pointer
* Lint
* Lint
* Update x/auth/signing/amino/amino.go
Co-authored-by: Marko <marbar3778@yahoo.com>
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
Co-authored-by: Marko <marbar3778@yahoo.com>
2020-06-09 15:19:18 +00:00
Anil Kumar Kammari
Aaron Craelius
SaReN
Amaury Martiny
Marko
Alexander Bezobchuk
billy rennekamp
Emmanuel T Odeke
dauTT