b5a6587291
x/ibc: IBC alpha ( #5277 )
...
* IBC alpha
* ICS 23 Implementation (#4515 )
* add mapping
* rm unused mapping/*, rm interfaces
* rm unused code
* mv mapping -> state, rm x/ibc
* rm GetIfExists
* add key
* rm custom encoding/decoding in enum/bool
* fix lint
* rm tests
* add commitment
* newtyped remote values
* newtyped context
* revert context newtype
* add README, keypath
* reflect downstream ics
* add merkle
* add test for proving
* soft coded root keypath
* add update
* remove RootUpdate
* separate keypath and keuprefix
* add codec
* separate root/path
* add path to codec
* add docs in progre
* add comments
* add comments
* Apply suggestions from code review
Co-Authored-By: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
* add comments in progress
* add comments
* fix comment
* add comments in progress
* recover IntEncoding scheme for integer
* add uint tests, don't use codec in custom types
* finalize merge
* add godoc
* reformat test
* rm XXX
* add godoc
* add query
* update query.go
* update query.go
* add Query to boolean.go
* fix key
* godoc cleanup
* godoc cleanup
* godoc cleanup
* godoc cleanup
* godoc cleanup
* merge from ics04 branch
* merge from ics04 branch
* fix lint
* Apply suggestions from code review
Co-Authored-By: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
* applying review in progress
* apply review - make querier interface
* fix dependency
* revise querier interface to work both on cli & store
* rm commented lines
* rename Path -> Prefix
* Store accessor upstream changes (#5119 )
* Store accessor upstream changes (#5119 )
* add comments, reformat merkle querier
* rm merkle/utils
* ICS 23 upstream changes (#5120 )
* ICS 23 upstream changes (#5120 )
* update Value
* remove Mapping
* remove store accessors
* refactor ICS23
* cleanup types
* implement batch verification
* gosimple suggestion
* alias
* add tests
* ICS 24 Implementation (#5229 )
* add validation functions
* validate path in ics-23
* address @fede comments
* move errors into host package
* flatten ICS23 structure
* fix ApplyPrefix
* complete types testing
* delete empty test file
* remove ibc errors from core error package
* start batch-verify tests
* minor changes on commitment types
* use testsuite
* upstream changes
* context changes
* ICS 02 Implementation (#4516 )
* add mapping
* rm unused mapping/*, rm interfaces
* rm unused code
* mv mapping -> state, rm x/ibc
* rm GetIfExists
* add key
* rm custom encoding/decoding in enum/bool
* fix lint
* rm tests
* add commitment
* newtyped remote values
* newtyped context
* revert context newtype
* add README, keypath
* reflect downstream ics
* add merkle
* add test for proving
* soft coded root keypath
* add update
* remove RootUpdate
* separate keypath and keuprefix
* add codec
* separate root/path
* add path to codec
* add client
* add counterpartymanager
* fix manager
* add Is() to counterobject
* add readme, reflect ICS02 revision
* reflect downstream ics
* test in progress
* add test
* in progres
* fin rebase
* in progress
* fin rebase
* add CLIObject in progress
* cli in progress
* add CLIObject
* separate testing from tendermint
* add key to node
* add root and storekey to tests/node, add codec
* rm cli/query.go
* fix test
* fix lint
* fix lint
* add handler/msgs/client
* rm relay
* finalize rebase on 23 root/path sep
* fix lint, fix syntax
* rm freebase, reformat query
* add docs in progre
* add comments
* add comments
* Apply suggestions from code review
Co-Authored-By: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
* add comments in progress
* add comments
* fix comment
* add comments in progress
* recover IntEncoding scheme for integer
* add uint tests, don't use codec in custom types
* finalize merge
* add godoc
* add godoc in progress
* reformat test
* rm XXX
* add godoc
* modify store
* add query
* update query.go
* update query.go
* cli refactor in progress
* cli refactor in progress
* add Query to boolean.go
* fix key
* fix cli / merkle test
* godoc cleanup
* godoc cleanup
* godoc cleanup
* godoc cleanup
* godoc cleanup
* merge from ics04 branch
* merge from ics04 branch
* merge from ics04 branch
* fix lint
* Apply suggestions from code review
Co-Authored-By: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
* applying review in progress
* apply review - make querier interface
* fix dependency
* fix dependency
* revise querier interface to work both on cli & store
* revise querier interface to work both on cli & store
* reflect downstream change
* fix cli
* rm commented lines
* address review in progress
* rename Path -> Prefix
* Store accessor upstream changes (#5119 )
* Store accessor upstream changes (#5119 )
* add comments, reformat merkle querier
* rm merkle/utils
* ICS 23 upstream changes (#5120 )
* ICS 23 upstream changes (#5120 )
* update Value
* update test
* fix
* ICS 02 upstream changes (#5122 )
* ICS 02 upstream changes (#5122 )
* cleanup types and submodule
* more cleanup and godocs
* remove counterPartyManager/State and cleanup
* implement SubmitMisbehaviour and refactor
* errors
* events
* fix test
* refactors
* remove Mapping
* remove store accessors
* proposed refactor
* remove store accessors from ICS02
* refactor queriers, handler and clean keeper
* logger and tx long description
* ineffassign
* Apply suggestions from code review
Co-Authored-By: Jack Zampolin <jack.zampolin@gmail.com>
* Apply suggestions from code review
Co-Authored-By: Jack Zampolin <jack.zampolin@gmail.com>
* add verification functions
* ICS02 module.go
* top level x/ibc structure
* Update x/ibc/02-client/client/cli/query.go
Co-Authored-By: Jack Zampolin <jack.zampolin@gmail.com>
* Update x/ibc/02-client/types/tendermint/consensus_state.go
Co-Authored-By: Jack Zampolin <jack.zampolin@gmail.com>
* address some of the review comments
* minor UX improvements
* rename pkg
* fixes
* refactor ICS23
* cleanup types
* implement batch verification
* gosimple suggestion
* various fixes; remove legacy tests; remove commitment path query
* alias
* minor updates from ICS23
* renaming
* update verification and rename root funcs
* move querier to x/ibc
* update query.go to use 'custom/...' query path
* add tests
* ICS 24 Implementation (#5229 )
* add validation functions
* validate path in ics-23
* address @fede comments
* move errors into host package
* flatten ICS23 structure
* fix ApplyPrefix
* updates from ICS23 and ICS24
* msg.ValidateBasic and ADR09 evidence interface
* complete types testing
* delete empty test file
* remove ibc errors from core error package
* custom JSON marshaling
* start batch-verify tests
* minor changes on commitment types
* R4R - Store consensus state correctly (#5242 )
* store consensus state correctly
* fix client example
* update alias
* use testsuite
* Integrate Evidence Implementation into ICS-02 (#5258 )
* implement evidence in ics-02
* fix build errors and import cycles
* address fede comments
* remove unnecessary pubkey and fix init
* add tests
* finish tendermint tests
* complete merge
* Add tests for msgs
* upstream changes
* fix
* upstream changes
* fix cons state
* context changes
* ICS 03 Implementation (#4517 )
* add test
* in progres
* fin rebase
* in progress
* fin rebase
* add CLIObject in progress
* cli in progress
* add CLIObject
* separate testing from tendermint
* add key to node
* add root and storekey to tests/node, add codec
* rm cli/query.go
* fix test
* fix lint
* fix lint
* add handler/msgs/client
* rm relay
* finalize rebase on 23 root/path sep
* fix lint, fix syntax
* fix querying
* extract out context withstore
* fix 02-client test
* fix 23-commitment test
* add query in progress
* rm freebase, reformat query
* add cli/handler/msg in progress
* add cli/msg/handler
* add CLIQuery, fix tests
* fix golangci
* add docs in progre
* add comments
* add comments
* Apply suggestions from code review
Co-Authored-By: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
* add comments in progress
* add comments
* fix comment
* add comments in progress
* recover IntEncoding scheme for integer
* add uint tests, don't use codec in custom types
* finalize merge
* add godoc
* add godoc in progress
* reformat test
* rm XXX
* add godoc
* modify store
* add query
* update query.go
* update query.go
* cli refactor in progress
* cli refactor in progress
* add Query to boolean.go
* fix key
* fix cli / merkle test
* godoc cleanup
* godoc cleanup
* godoc cleanup
* godoc cleanup
* godoc cleanup
* fix test
* fix client
* merge from ics04 branch
* merge from ics04 branch
* merge from ics04 branch
* merge from ics04 branch
* fix lint
* Apply suggestions from code review
Co-Authored-By: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
* applying review in progress
* apply review - make querier interface
* fix dependency
* fix dependency
* revise querier interface to work both on cli & store
* revise querier interface to work both on cli & store
* reflect downstream change
* fix cli
* reflect downstream changes
* rm commented lines
* address review in progress
* address review, rm cleanup/closing
* rename Path -> Prefix
* Store accessor upstream changes (#5119 )
* Store accessor upstream changes (#5119 )
* add comments, reformat merkle querier
* rm merkle/utils
* ICS 23 upstream changes (#5120 )
* ICS 23 upstream changes (#5120 )
* update Value
* update test
* fix
* ICS 02 upstream changes (#5122 )
* ICS 02 upstream changes (#5122 )
* ICS 03 upstream changes (#5123 )
* ICS 03 upstream changes (#5123 )
* cleanup types and submodule
* more cleanup and godocs
* remove counterPartyManager/State and cleanup
* implement SubmitMisbehaviour and refactor
* errors
* events
* fix test
* refactors
* WIP refactor ICS03
* remove Mapping
* remove store accessors
* proposed refactor
* remove store accessors from ICS02
* refactor queriers, handler and clean keeper
* logger and tx long description
* ineffassign
* Apply suggestions from code review
Co-Authored-By: Jack Zampolin <jack.zampolin@gmail.com>
* Apply suggestions from code review
Co-Authored-By: Jack Zampolin <jack.zampolin@gmail.com>
* remove store accessors
* refactor handshake to update it to the latest ICS03 spec
* update handler and msgs
* add verification functions
* update verification
* ICS02 module.go
* top level x/ibc structure
* update connection queries
* update connection tx
* remove extra files
* update expected client keeper and export verification funcs
* Update x/ibc/02-client/client/cli/query.go
Co-Authored-By: Jack Zampolin <jack.zampolin@gmail.com>
* Update x/ibc/02-client/types/tendermint/consensus_state.go
Co-Authored-By: Jack Zampolin <jack.zampolin@gmail.com>
* address some of the review comments
* resolve some TODOs and address comments from review
* update connection versioning
* minor error updates
* minor UX improvements
* rename pkg
* fixes
* refactor ICS23
* cleanup types
* rename pkg and fix import
* implement batch verification
* gosimple suggestion
* various fixes; remove legacy tests; remove commitment path query
* alias
* minor updates from ICS23
* renaming
* update verification and rename root funcs
* move querier to x/ibc
* update query.go to use 'custom/...' query path
* add tests
* ICS 24 Implementation (#5229 )
* add validation functions
* validate path in ics-23
* address @fede comments
* move errors into host package
* flatten ICS23 structure
* fix ApplyPrefix
* updates from ICS23 and ICS24
* msg.ValidateBasic and ADR09 evidence interface
* complete types testing
* delete empty test file
* remove ibc errors from core error package
* custom JSON marshaling; msg.ValidateBasic; renaming of variables
* minor update
* custom JSON marshaling
* start batch-verify tests
* minor changes on commitment types
* R4R - Store consensus state correctly (#5242 )
* store consensus state correctly
* fix client example
* update alias
* update alias
* use testsuite
* Integrate Evidence Implementation into ICS-02 (#5258 )
* implement evidence in ics-02
* fix build errors and import cycles
* address fede comments
* remove unnecessary pubkey and fix init
* add tests
* finish tendermint tests
* complete merge
* Add tests for msgs
* upstream changes
* fix
* upstream changes
* fix cons state
* context changes
* fix cli tx
* upstream changes
* fix
* ICS 05 implementation (#5193 )
* fix lint
* fix lint
* add handler/msgs/client
* rm relay
* finalize rebase on 23 root/path sep
* fix lint, fix syntax
* fix querying
* extract out context withstore
* fix 02-client test
* fix 23-commitment test
* add query in progress
* rm freebase, reformat query
* add cli/handler/msg in progress
* add cli/msg/handler
* add CLIQuery, fix tests
* fix golangci
* add docs in progre
* add comments
* add comments
* Apply suggestions from code review
Co-Authored-By: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
* add comments in progress
* add comments
* fix comment
* add comments in progress
* recover IntEncoding scheme for integer
* add uint tests, don't use codec in custom types
* finalize merge
* add godoc
* add godoc in progress
* reformat test
* rm XXX
* add godoc
* modify store
* add query
* update query.go
* update query.go
* cli refactor in progress
* cli refactor in progress
* add Query to boolean.go
* fix key
* fix cli / merkle test
* godoc cleanup
* godoc cleanup
* godoc cleanup
* godoc cleanup
* godoc cleanup
* fix test
* fix client
* merge from ics04 branch
* merge from ics04 branch
* merge from ics04 branch
* merge from ics04 branch
* fix lint
* Apply suggestions from code review
Co-Authored-By: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
* applying review in progress
* apply review - make querier interface
* fix dependency
* fix dependency
* revise querier interface to work both on cli & store
* revise querier interface to work both on cli & store
* reflect downstream change
* fix cli
* reflect downstream changes
* rm commented lines
* address review in progress
* address review, rm cleanup/closing
* rename Path -> Prefix
* Store accessor upstream changes (#5119 )
* Store accessor upstream changes (#5119 )
* add comments, reformat merkle querier
* rm merkle/utils
* ICS 23 upstream changes (#5120 )
* ICS 23 upstream changes (#5120 )
* update Value
* update test
* fix
* ICS 02 upstream changes (#5122 )
* ICS 02 upstream changes (#5122 )
* ICS 03 upstream changes (#5123 )
* ICS 03 upstream changes (#5123 )
* cleanup types and submodule
* more cleanup and godocs
* remove counterPartyManager/State and cleanup
* implement SubmitMisbehaviour and refactor
* errors
* events
* fix test
* refactors
* WIP refactor ICS03
* remove Mapping
* remove store accessors
* proposed refactor
* remove store accessors from ICS02
* refactor queriers, handler and clean keeper
* logger and tx long description
* ineffassign
* Apply suggestions from code review
Co-Authored-By: Jack Zampolin <jack.zampolin@gmail.com>
* Apply suggestions from code review
Co-Authored-By: Jack Zampolin <jack.zampolin@gmail.com>
* remove store accessors
* refactor handshake to update it to the latest ICS03 spec
* update handler and msgs
* add verification functions
* update verification
* ICS02 module.go
* top level x/ibc structure
* update connection queries
* update connection tx
* remove extra files
* update expected client keeper and export verification funcs
* ICS 05 Implementation
* release port and godocs
* Update x/ibc/02-client/client/cli/query.go
Co-Authored-By: Jack Zampolin <jack.zampolin@gmail.com>
* Update x/ibc/02-client/types/tendermint/consensus_state.go
Co-Authored-By: Jack Zampolin <jack.zampolin@gmail.com>
* address some of the review comments
* resolve some TODOs and address comments from review
* update connection versioning
* minor error updates
* update errors and add port Keeper to ibc Keeper
* minor UX improvements
* rename pkg
* fixes
* refactor ICS23
* cleanup types
* ICS 5 updates (#5222 )
* Validate port identifiers
* Refactor to static bind
* Add comments
* Add 'GetPorts' query function
* rename pkg and fix import
* implement batch verification
* gosimple suggestion
* various fixes; remove legacy tests; remove commitment path query
* alias
* minor updates from ICS23
* renaming
* update verification and rename root funcs
* move querier to x/ibc
* update query.go to use 'custom/...' query path
* add tests
* ICS 24 Implementation (#5229 )
* add validation functions
* validate path in ics-23
* address @fede comments
* move errors into host package
* flatten ICS23 structure
* fix ApplyPrefix
* updates from ICS23 and ICS24
* msg.ValidateBasic and ADR09 evidence interface
* complete types testing
* delete empty test file
* remove ibc errors from core error package
* custom JSON marshaling; msg.ValidateBasic; renaming of variables
* minor update
* custom JSON marshaling
* use host validation for port ids
* start batch-verify tests
* minor changes on commitment types
* R4R - Store consensus state correctly (#5242 )
* store consensus state correctly
* fix client example
* update alias
* update alias
* update alias and keeper.GetPort()
* use testsuite
* Integrate Evidence Implementation into ICS-02 (#5258 )
* implement evidence in ics-02
* fix build errors and import cycles
* address fede comments
* remove unnecessary pubkey and fix init
* add tests
* finish tendermint tests
* complete merge
* Add tests for msgs
* upstream changes
* fix
* upstream changes
* fix cons state
* context changes
* fix cli tx
* upstream changes
* upstream changes
* ICS 04 Implementation (#4548 )
* merge from ics04 branch
* merge from ics04 branch
* fix lint
* add port
* fix test
* add mocks
* fix connid -> portid in handshake.go
* add mock
* add ibc module.go, finalize mock
* add keeper
* add StoreKey const
* fix test
* Apply suggestions from code review
Co-Authored-By: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
* applying review in progress
* apply review - make querier interface
* fix cli errors
* fix dependency
* fix dependency
* reflect method name change
* revise querier interface to work both on cli & store
* revise querier interface to work both on cli & store
* revise querier interface to work both on cli & store
* reflect downstream change
* fix cli
* reflect downstream changes
* reflect downstream changes
* fix from address in tx cli
* fix cli in progress(squash later)
* fix cli
* remove timeout, add channel cli
* fix golangci
* fix cli
* Clean up
* fix mock cli in progress
* finalize cleanup, mock cli wip
* add cli for mocksend
* fix handler
* rm commented lines
* address review in progress
* address review, rm cleanup/closing
* rename mock packages
* fix interface for gaia
* rename Path -> Prefix
* Store accessor upstream changes (#5119 )
* Store accessor upstream changes (#5119 )
* add comments, reformat merkle querier
* rm merkle/utils
* ICS 23 upstream changes (#5120 )
* ICS 23 upstream changes (#5120 )
* update Value
* update test
* fix
* ICS 02 upstream changes (#5122 )
* ICS 02 upstream changes (#5122 )
* ICS 03 upstream changes (#5123 )
* ICS 03 upstream changes (#5123 )
* update test
* cleanup types and submodule
* more cleanup and godocs
* remove counterPartyManager/State and cleanup
* implement SubmitMisbehaviour and refactor
* errors
* events
* fix test
* refactors
* WIP refactor ICS03
* remove Mapping
* remove store accessors
* proposed refactor
* remove store accessors from ICS02
* refactor queriers, handler and clean keeper
* logger and tx long description
* ineffassign
* Apply suggestions from code review
Co-Authored-By: Jack Zampolin <jack.zampolin@gmail.com>
* Apply suggestions from code review
Co-Authored-By: Jack Zampolin <jack.zampolin@gmail.com>
* remove store accessors
* refactor handshake to update it to the latest ICS03 spec
* update handler and msgs
* add verification functions
* update verification
* ICS02 module.go
* top level x/ibc structure
* update connection queries
* update connection tx
* remove extra files
* refactor: remove store accessors, update keeper and types to match spec (WIP)
* update handshake and packet
* implement packet timeouts
* implement send and receive packet
* implement packet ACK
* update handler
* add channel errors
* channel querier
* update expected client keeper and export verification funcs
* ICS 05 Implementation
* release port and godocs
* Update x/ibc/02-client/client/cli/query.go
Co-Authored-By: Jack Zampolin <jack.zampolin@gmail.com>
* Update x/ibc/02-client/types/tendermint/consensus_state.go
Co-Authored-By: Jack Zampolin <jack.zampolin@gmail.com>
* address some of the review comments
* resolve some TODOs and address comments from review
* update connection versioning
* minor error updates
* update ICS04 with downstream changes
* Implement tx cli actions
* add MsgSendPacket handler; msg validation, errors and events
* update errors and add port Keeper to ibc Keeper
* minor UX improvements
* rename pkg
* fixes
* refactor ICS23
* cleanup types
* ICS 5 updates (#5222 )
* Validate port identifiers
* Refactor to static bind
* Add comments
* Add 'GetPorts' query function
* rename pkg and fix import
* implement batch verification
* gosimple suggestion
* various fixes; remove legacy tests; remove commitment path query
* alias
* minor updates from ICS23
* renaming
* update verification and rename root funcs
* rm legacy tests; add query proofs support
* remove capability key generation and authentication logic
* move querier to x/ibc
* update query.go to use 'custom/...' query path
* add tests
* ICS 24 Implementation (#5229 )
* add validation functions
* validate path in ics-23
* address @fede comments
* move errors into host package
* flatten ICS23 structure
* fix ApplyPrefix
* updates from ICS23 and ICS24
* msg.ValidateBasic and ADR09 evidence interface
* complete types testing
* delete empty test file
* remove ibc errors from core error package
* custom JSON marshaling; msg.ValidateBasic; renaming of variables
* minor update
* custom JSON marshaling
* use host validation for port ids
* downstream changes; custom marshal JSON; msg validation, and update errors
* update errors and aliases
* start batch-verify tests
* update msg validation and CLI UX
* minor changes on commitment types
* fix channel and packet check (#5243 )
* R4R - Store consensus state correctly (#5242 )
* store consensus state correctly
* fix client example
* update alias
* update alias
* update alias and keeper.GetPort()
* authenticate port ID; remove send packet msg from CLI
* comment out handlers
* use testsuite
* Integrate Evidence Implementation into ICS-02 (#5258 )
* implement evidence in ics-02
* fix build errors and import cycles
* address fede comments
* remove unnecessary pubkey and fix init
* add tests
* finish tendermint tests
* complete merge
* Add tests for msgs
* upstream changes
* fix
* upstream changes
* fix cons state
* context changes
* fix cli tx
* upstream changes
* upstream changes
* upstream changes
* IBC v1.0.0 (#5245 )
* applying review in progress
* apply review - make querier interface
* fix cli errors
* fix dependency
* fix dependency
* reflect method name change
* revise querier interface to work both on cli & store
* revise querier interface to work both on cli & store
* revise querier interface to work both on cli & store
* reflect downstream change
* fix cli
* reflect downstream changes
* reflect downstream changes
* fix from address in tx cli
* fix cli in progress(squash later)
* fix cli
* remove timeout, add channel cli
* fix golangci
* fix cli
* Clean up
* fix mock cli in progress
* finalize cleanup, mock cli wip
* add cli for mocksend
* fix handler
* rm commented lines
* address review in progress
* address review, rm cleanup/closing
* rename mock packages
* fix interface for gaia
* rename Path -> Prefix
* Store accessor upstream changes (#5119 )
* Store accessor upstream changes (#5119 )
* add comments, reformat merkle querier
* rm merkle/utils
* ICS 23 upstream changes (#5120 )
* ICS 23 upstream changes (#5120 )
* update Value
* update test
* fix
* ICS 02 upstream changes (#5122 )
* ICS 02 upstream changes (#5122 )
* ICS 03 upstream changes (#5123 )
* ICS 03 upstream changes (#5123 )
* update test
* cleanup types and submodule
* more cleanup and godocs
* remove counterPartyManager/State and cleanup
* implement SubmitMisbehaviour and refactor
* errors
* events
* fix test
* refactors
* WIP refactor ICS03
* remove Mapping
* remove store accessors
* proposed refactor
* remove store accessors from ICS02
* refactor queriers, handler and clean keeper
* logger and tx long description
* ineffassign
* Apply suggestions from code review
Co-Authored-By: Jack Zampolin <jack.zampolin@gmail.com>
* Apply suggestions from code review
Co-Authored-By: Jack Zampolin <jack.zampolin@gmail.com>
* remove store accessors
* refactor handshake to update it to the latest ICS03 spec
* update handler and msgs
* add verification functions
* update verification
* ICS02 module.go
* top level x/ibc structure
* update connection queries
* update connection tx
* remove extra files
* refactor: remove store accessors, update keeper and types to match spec (WIP)
* update handshake and packet
* implement packet timeouts
* implement send and receive packet
* implement packet ACK
* update handler
* add channel errors
* channel querier
* update expected client keeper and export verification funcs
* ICS 05 Implementation
* release port and godocs
* Update x/ibc/02-client/client/cli/query.go
Co-Authored-By: Jack Zampolin <jack.zampolin@gmail.com>
* Update x/ibc/02-client/types/tendermint/consensus_state.go
Co-Authored-By: Jack Zampolin <jack.zampolin@gmail.com>
* address some of the review comments
* resolve some TODOs and address comments from review
* update connection versioning
* minor error updates
* update ICS04 with downstream changes
* Implement tx cli actions
* add MsgSendPacket handler; msg validation, errors and events
* update errors and add port Keeper to ibc Keeper
* minor UX improvements
* rename pkg
* fixes
* refactor ICS23
* cleanup types
* ICS 5 updates (#5222 )
* Validate port identifiers
* Refactor to static bind
* Add comments
* Add 'GetPorts' query function
* rename pkg and fix import
* implement batch verification
* gosimple suggestion
* various fixes; remove legacy tests; remove commitment path query
* alias
* minor updates from ICS23
* renaming
* update verification and rename root funcs
* rm legacy tests; add query proofs support
* remove capability key generation and authentication logic
* move querier to x/ibc
* update query.go to use 'custom/...' query path
* add tests
* ICS 24 Implementation (#5229 )
* add validation functions
* validate path in ics-23
* address @fede comments
* move errors into host package
* flatten ICS23 structure
* fix ApplyPrefix
* updates from ICS23 and ICS24
* msg.ValidateBasic and ADR09 evidence interface
* complete types testing
* delete empty test file
* remove ibc errors from core error package
* custom JSON marshaling; msg.ValidateBasic; renaming of variables
* minor update
* custom JSON marshaling
* use host validation for port ids
* downstream changes; custom marshal JSON; msg validation, and update errors
* update errors and aliases
* start batch-verify tests
* update msg validation and CLI UX
* minor changes on commitment types
* fix channel and packet check (#5243 )
* R4R - Store consensus state correctly (#5242 )
* store consensus state correctly
* fix client example
* update alias
* update alias
* update alias and keeper.GetPort()
* authenticate port ID; remove send packet msg from CLI
* comment out handlers
* add ibc module to simapp
* ICS20 implementation (#5204 )
* add ibc bank mock
* modify handler
* import channel
* add receiving logic
* add cli proof handling
* modify cli
* modify receiver type
* modify errcode
* optimize codes
* add denom prefix when source is true
* refactor code
* error return
* switch ibc antehandler to decorator pattern
* fix name/comment
* ICS 20 implementation (#5250 )
* move ics20 code to 20-transfer
* clean code
* fix compiling error
* add transfer module
* address ICS20 comments from review
* add routing callbacks
* clean code
* add missing err return
* modify err type
* modify err type
* add supply handling
* modify proof type
* add comments for msg and packet data
* add timeout supply handling
* modify module account name
* use supply keeper for burn and mint coins
* restructure keeper
* update alias and module.go
* golangci linter
* add ics20 handler to IBC handler
* update callbacks
* update ICS20 escrow address
* fix querier routes
* fix create client cli
* minor updates
* ibc querier test
* Refactor ibc/mock/bank into ICS 20 (#5264 )
* Most of code port from mock module to ICS 20
* A few minor fixes
* Apply suggestions from code review
Co-Authored-By: Bot from GolangCI <42910462+golangcibot@users.noreply.github.com>
* Fix suggestions from autolinter
* Apply suggestions from code review
Co-Authored-By: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
* Fix order of messages
* Add invalid height error code, check non-nil proof
* Fix linter error
* Return the underlying error
* Tendermint starts at height 1
* Apply suggestions from code review
* setup ics20 test suite
* add event to MsgRecvPacket
* update ibc keeper test to use test suite
* Add handshake commands
* WIP connection handshake
* WIP Connection Handshake
* use testsuite
* Add cliCtx.WaitForNBlocks
* fix connection handshake in progress
* fix connection handshake in progress
* Integrate Evidence Implementation into ICS-02 (#5258 )
* implement evidence in ics-02
* fix build errors and import cycles
* address fede comments
* remove unnecessary pubkey and fix init
* add tests
* finish tendermint tests
* complete merge
* Add tests for msgs
* upstream changes
* fix
* upstream changes
* fix cons state
* context changes
* fix cli tx
* upstream changes
* upstream changes
* upstream changes
* upstream changes
* IBC demo fixes (#5267 )
* WIP refactor ICS03
* remove Mapping
* remove store accessors
* proposed refactor
* remove store accessors from ICS02
* refactor queriers, handler and clean keeper
* logger and tx long description
* ineffassign
* Apply suggestions from code review
Co-Authored-By: Jack Zampolin <jack.zampolin@gmail.com>
* Apply suggestions from code review
Co-Authored-By: Jack Zampolin <jack.zampolin@gmail.com>
* remove store accessors
* refactor handshake to update it to the latest ICS03 spec
* update handler and msgs
* add verification functions
* update verification
* ICS02 module.go
* top level x/ibc structure
* update connection queries
* update connection tx
* remove extra files
* refactor: remove store accessors, update keeper and types to match spec (WIP)
* update handshake and packet
* implement packet timeouts
* implement send and receive packet
* implement packet ACK
* update handler
* add channel errors
* channel querier
* update expected client keeper and export verification funcs
* ICS 05 Implementation
* release port and godocs
* Update x/ibc/02-client/client/cli/query.go
Co-Authored-By: Jack Zampolin <jack.zampolin@gmail.com>
* Update x/ibc/02-client/types/tendermint/consensus_state.go
Co-Authored-By: Jack Zampolin <jack.zampolin@gmail.com>
* address some of the review comments
* resolve some TODOs and address comments from review
* update connection versioning
* minor error updates
* update ICS04 with downstream changes
* Implement tx cli actions
* add MsgSendPacket handler; msg validation, errors and events
* update errors and add port Keeper to ibc Keeper
* minor UX improvements
* rename pkg
* fixes
* refactor ICS23
* cleanup types
* ICS 5 updates (#5222 )
* Validate port identifiers
* Refactor to static bind
* Add comments
* Add 'GetPorts' query function
* rename pkg and fix import
* implement batch verification
* gosimple suggestion
* various fixes; remove legacy tests; remove commitment path query
* alias
* minor updates from ICS23
* renaming
* update verification and rename root funcs
* rm legacy tests; add query proofs support
* remove capability key generation and authentication logic
* move querier to x/ibc
* update query.go to use 'custom/...' query path
* add tests
* ICS 24 Implementation (#5229 )
* add validation functions
* validate path in ics-23
* address @fede comments
* move errors into host package
* flatten ICS23 structure
* fix ApplyPrefix
* updates from ICS23 and ICS24
* msg.ValidateBasic and ADR09 evidence interface
* complete types testing
* delete empty test file
* remove ibc errors from core error package
* custom JSON marshaling; msg.ValidateBasic; renaming of variables
* minor update
* custom JSON marshaling
* use host validation for port ids
* downstream changes; custom marshal JSON; msg validation, and update errors
* update errors and aliases
* start batch-verify tests
* update msg validation and CLI UX
* minor changes on commitment types
* fix channel and packet check (#5243 )
* R4R - Store consensus state correctly (#5242 )
* store consensus state correctly
* fix client example
* update alias
* update alias
* update alias and keeper.GetPort()
* authenticate port ID; remove send packet msg from CLI
* comment out handlers
* add ibc module to simapp
* ICS20 implementation (#5204 )
* add ibc bank mock
* modify handler
* import channel
* add receiving logic
* add cli proof handling
* modify cli
* modify receiver type
* modify errcode
* optimize codes
* add denom prefix when source is true
* refactor code
* error return
* switch ibc antehandler to decorator pattern
* fix name/comment
* ICS 20 implementation (#5250 )
* move ics20 code to 20-transfer
* clean code
* fix compiling error
* add transfer module
* address ICS20 comments from review
* add routing callbacks
* clean code
* add missing err return
* modify err type
* modify err type
* add supply handling
* modify proof type
* add comments for msg and packet data
* add timeout supply handling
* modify module account name
* use supply keeper for burn and mint coins
* restructure keeper
* update alias and module.go
* golangci linter
* add ics20 handler to IBC handler
* update callbacks
* update ICS20 escrow address
* fix querier routes
* fix create client cli
* minor updates
* ibc querier test
* Refactor ibc/mock/bank into ICS 20 (#5264 )
* Most of code port from mock module to ICS 20
* A few minor fixes
* Apply suggestions from code review
Co-Authored-By: Bot from GolangCI <42910462+golangcibot@users.noreply.github.com>
* Fix suggestions from autolinter
* Apply suggestions from code review
Co-Authored-By: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
* Fix order of messages
* Add invalid height error code, check non-nil proof
* Fix linter error
* Return the underlying error
* Tendermint starts at height 1
* Apply suggestions from code review
* setup ics20 test suite
* add event to MsgRecvPacket
* update ibc keeper test to use test suite
* Add handshake commands
* WIP connection handshake
* WIP Connection Handshake
* use testsuite
* Add cliCtx.WaitForNBlocks
* fix connection handshake in progress
* fix connection handshake in progress
* Add print debugging (old-school)
* Add log line
* More debugging
* Set prove flag to true
* More debugging
* Use store query
* Fix query, hopefully
* Fix query path
* Hmm
* Fix context bug
* Generate & return & use consensus state proof
* Print debugging
* Add debugging
* Begin working on the channel creation command
* remove submodule prefix from keypath, fix addConnectionToClients to treat nil as empty array
* fix OpenConfirm, rm debugging code
* WIP channel shake 🕺
* WIP channel shake 🕺
* WIP channel shake 🕺
* WIP channel shake 🕺
* WIP channel shake 🕺
* WIP channel shake 🕺
* WIP channel shake 🕺
* Update bound port
* Add from flag to ICS 20 commands
* Undefine flag
* add debug
* Uncomment channel message handlers
* fix validatebasic identifier failure
* Fix printing
* add debug code
* CLI debugging
* fix counterpartyHops, channel handshake working w/o port
* Fix compilation error
* Push channel query command update
* Remove unused code
* Add gaiacli keys test
* Update error
* Add printf
* fix token restriciton
* comment out port
* fix querier to retrieve the next sequence
* Alter command to take arguments
* Name it packet-sequence
* add packet query utils
* Use the querier
* Packet is JSON
* printf the value
* fix query packet
* fix packet receive in progress
* lol
* export Packet fields, rename Packet.XXX() -> Packet.GetXXX()
* fix route
* add debug
* comment out port logic from packet.go
* token transfer now working
* fix client tx
* Integrate Evidence Implementation into ICS-02 (#5258 )
* implement evidence in ics-02
* fix build errors and import cycles
* address fede comments
* remove unnecessary pubkey and fix init
* add tests
* Apply suggestions from code review
* clean up
* finish tendermint tests
* complete merge
* Add tests for msgs
* ICS02 changes
* upstream changes
* fix
* upstream changes
* fix cons state
* context changes
* fix cli tx
* upstream changes
* upstream changes
* upstream changes
* upstream changes
* more cleanup
* Add unit tests for ICS03 (#5275 )
* add Is() to counterobject
* add readme, reflect ICS02 revision
* reflect downstream ics
* test in progress
* add test
* in progres
* fin rebase
* in progress
* fin rebase
* add CLIObject in progress
* cli in progress
* add CLIObject
* separate testing from tendermint
* add key to node
* add root and storekey to tests/node, add codec
* rm cli/query.go
* fix test
* fix lint
* fix lint
* add handler/msgs/client
* rm relay
* finalize rebase on 23 root/path sep
* fix lint, fix syntax
* fix querying
* extract out context withstore
* fix 02-client test
* fix 23-commitment test
* add query in progress
* rm freebase, reformat query
* add cli/handler/msg in progress
* add cli/msg/handler
* add CLIQuery, fix tests
* fix golangci
* add docs in progre
* add comments
* add comments
* Apply suggestions from code review
Co-Authored-By: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
* add comments in progress
* add comments
* fix comment
* add comments in progress
* recover IntEncoding scheme for integer
* add uint tests, don't use codec in custom types
* finalize merge
* add godoc
* add godoc in progress
* reformat test
* rm XXX
* add godoc
* modify store
* add query
* update query.go
* update query.go
* cli refactor in progress
* cli refactor in progress
* add Query to boolean.go
* fix key
* fix cli / merkle test
* godoc cleanup
* godoc cleanup
* godoc cleanup
* godoc cleanup
* godoc cleanup
* fix test
* fix client
* merge from ics04 branch
* merge from ics04 branch
* merge from ics04 branch
* merge from ics04 branch
* fix lint
* Apply suggestions from code review
Co-Authored-By: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
* applying review in progress
* apply review - make querier interface
* fix dependency
* fix dependency
* revise querier interface to work both on cli & store
* revise querier interface to work both on cli & store
* reflect downstream change
* fix cli
* reflect downstream changes
* rm commented lines
* address review in progress
* address review, rm cleanup/closing
* rename Path -> Prefix
* Store accessor upstream changes (#5119 )
* Store accessor upstream changes (#5119 )
* add comments, reformat merkle querier
* rm merkle/utils
* ICS 23 upstream changes (#5120 )
* ICS 23 upstream changes (#5120 )
* update Value
* update test
* fix
* ICS 02 upstream changes (#5122 )
* ICS 02 upstream changes (#5122 )
* ICS 03 upstream changes (#5123 )
* ICS 03 upstream changes (#5123 )
* cleanup types and submodule
* more cleanup and godocs
* remove counterPartyManager/State and cleanup
* implement SubmitMisbehaviour and refactor
* errors
* events
* fix test
* refactors
* WIP refactor ICS03
* remove Mapping
* remove store accessors
* proposed refactor
* remove store accessors from ICS02
* refactor queriers, handler and clean keeper
* logger and tx long description
* ineffassign
* Apply suggestions from code review
Co-Authored-By: Jack Zampolin <jack.zampolin@gmail.com>
* Apply suggestions from code review
Co-Authored-By: Jack Zampolin <jack.zampolin@gmail.com>
* remove store accessors
* refactor handshake to update it to the latest ICS03 spec
* update handler and msgs
* add verification functions
* update verification
* ICS02 module.go
* top level x/ibc structure
* update connection queries
* update connection tx
* remove extra files
* update expected client keeper and export verification funcs
* Update x/ibc/02-client/client/cli/query.go
Co-Authored-By: Jack Zampolin <jack.zampolin@gmail.com>
* Update x/ibc/02-client/types/tendermint/consensus_state.go
Co-Authored-By: Jack Zampolin <jack.zampolin@gmail.com>
* address some of the review comments
* resolve some TODOs and address comments from review
* update connection versioning
* minor error updates
* minor UX improvements
* rename pkg
* fixes
* refactor ICS23
* cleanup types
* rename pkg and fix import
* implement batch verification
* gosimple suggestion
* various fixes; remove legacy tests; remove commitment path query
* alias
* minor updates from ICS23
* renaming
* update verification and rename root funcs
* move querier to x/ibc
* update query.go to use 'custom/...' query path
* add tests
* ICS 24 Implementation (#5229 )
* add validation functions
* validate path in ics-23
* address @fede comments
* move errors into host package
* flatten ICS23 structure
* fix ApplyPrefix
* updates from ICS23 and ICS24
* msg.ValidateBasic and ADR09 evidence interface
* complete types testing
* delete empty test file
* remove ibc errors from core error package
* custom JSON marshaling; msg.ValidateBasic; renaming of variables
* minor update
* custom JSON marshaling
* minor changes on commitment types
* R4R - Store consensus state correctly (#5242 )
* store consensus state correctly
* fix client example
* update alias
* update alias
* implement ics25
* update comment
* refactor method name
* fix file name
* add test case
* refactor code
* refactor code
* blocked the consensusState check
* refactor code
* fix golangci comments
* refactor testcase
* replace rootMultiStore with simApp
* remove unless code
* remove unless code & refactor test case
* refactor testcase
* goimports code
* clean up
* Add unit tests for ICS04 (#5286 )
* fix test
* Apply suggestions from code review
Co-Authored-By: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
* applying review in progress
* apply review - make querier interface
* fix cli errors
* fix dependency
* fix dependency
* reflect method name change
* revise querier interface to work both on cli & store
* revise querier interface to work both on cli & store
* revise querier interface to work both on cli & store
* reflect downstream change
* fix cli
* reflect downstream changes
* reflect downstream changes
* fix from address in tx cli
* fix cli in progress(squash later)
* fix cli
* remove timeout, add channel cli
* fix golangci
* fix cli
* Clean up
* fix mock cli in progress
* finalize cleanup, mock cli wip
* add cli for mocksend
* fix handler
* rm commented lines
* address review in progress
* address review, rm cleanup/closing
* rename mock packages
* fix interface for gaia
* rename Path -> Prefix
* Store accessor upstream changes (#5119 )
* Store accessor upstream changes (#5119 )
* add comments, reformat merkle querier
* rm merkle/utils
* ICS 23 upstream changes (#5120 )
* ICS 23 upstream changes (#5120 )
* update Value
* update test
* fix
* ICS 02 upstream changes (#5122 )
* ICS 02 upstream changes (#5122 )
* ICS 03 upstream changes (#5123 )
* ICS 03 upstream changes (#5123 )
* update test
* cleanup types and submodule
* more cleanup and godocs
* remove counterPartyManager/State and cleanup
* implement SubmitMisbehaviour and refactor
* errors
* events
* fix test
* refactors
* WIP refactor ICS03
* remove Mapping
* remove store accessors
* proposed refactor
* remove store accessors from ICS02
* refactor queriers, handler and clean keeper
* logger and tx long description
* ineffassign
* Apply suggestions from code review
Co-Authored-By: Jack Zampolin <jack.zampolin@gmail.com>
* Apply suggestions from code review
Co-Authored-By: Jack Zampolin <jack.zampolin@gmail.com>
* remove store accessors
* refactor handshake to update it to the latest ICS03 spec
* update handler and msgs
* add verification functions
* update verification
* ICS02 module.go
* top level x/ibc structure
* update connection queries
* update connection tx
* remove extra files
* refactor: remove store accessors, update keeper and types to match spec (WIP)
* update handshake and packet
* implement packet timeouts
* implement send and receive packet
* implement packet ACK
* update handler
* add channel errors
* channel querier
* update expected client keeper and export verification funcs
* ICS 05 Implementation
* release port and godocs
* Update x/ibc/02-client/client/cli/query.go
Co-Authored-By: Jack Zampolin <jack.zampolin@gmail.com>
* Update x/ibc/02-client/types/tendermint/consensus_state.go
Co-Authored-By: Jack Zampolin <jack.zampolin@gmail.com>
* address some of the review comments
* resolve some TODOs and address comments from review
* update connection versioning
* minor error updates
* update ICS04 with downstream changes
* Implement tx cli actions
* add MsgSendPacket handler; msg validation, errors and events
* update errors and add port Keeper to ibc Keeper
* minor UX improvements
* rename pkg
* fixes
* refactor ICS23
* cleanup types
* ICS 5 updates (#5222 )
* Validate port identifiers
* Refactor to static bind
* Add comments
* Add 'GetPorts' query function
* rename pkg and fix import
* implement batch verification
* gosimple suggestion
* various fixes; remove legacy tests; remove commitment path query
* alias
* minor updates from ICS23
* renaming
* update verification and rename root funcs
* rm legacy tests; add query proofs support
* remove capability key generation and authentication logic
* move querier to x/ibc
* update query.go to use 'custom/...' query path
* add tests
* ICS 24 Implementation (#5229 )
* add validation functions
* validate path in ics-23
* address @fede comments
* move errors into host package
* flatten ICS23 structure
* fix ApplyPrefix
* updates from ICS23 and ICS24
* msg.ValidateBasic and ADR09 evidence interface
* complete types testing
* delete empty test file
* remove ibc errors from core error package
* custom JSON marshaling; msg.ValidateBasic; renaming of variables
* minor update
* custom JSON marshaling
* use host validation for port ids
* downstream changes; custom marshal JSON; msg validation, and update errors
* update errors and aliases
* update msg validation and CLI UX
* minor changes on commitment types
* fix channel and packet check (#5243 )
* R4R - Store consensus state correctly (#5242 )
* store consensus state correctly
* fix client example
* update alias
* update alias
* update alias and keeper.GetPort()
* authenticate port ID; remove send packet msg from CLI
* comment out handlers
* add ibc module to simapp
* ICS20 implementation (#5204 )
* add ibc bank mock
* modify handler
* import channel
* add receiving logic
* add cli proof handling
* modify cli
* modify receiver type
* modify errcode
* optimize codes
* add denom prefix when source is true
* refactor code
* error return
* switch ibc antehandler to decorator pattern
* fix name/comment
* ICS 20 implementation (#5250 )
* move ics20 code to 20-transfer
* clean code
* fix compiling error
* add transfer module
* address ICS20 comments from review
* add routing callbacks
* clean code
* add missing err return
* modify err type
* modify err type
* add supply handling
* modify proof type
* add comments for msg and packet data
* add timeout supply handling
* modify module account name
* use supply keeper for burn and mint coins
* restructure keeper
* update alias and module.go
* golangci linter
* add ics20 handler to IBC handler
* update callbacks
* update ICS20 escrow address
* fix querier routes
* fix create client cli
* minor updates
* ibc querier test
* Refactor ibc/mock/bank into ICS 20 (#5264 )
* Most of code port from mock module to ICS 20
* A few minor fixes
* Apply suggestions from code review
Co-Authored-By: Bot from GolangCI <42910462+golangcibot@users.noreply.github.com>
* Fix suggestions from autolinter
* Apply suggestions from code review
Co-Authored-By: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
* Fix order of messages
* Add invalid height error code, check non-nil proof
* Fix linter error
* Return the underlying error
* Tendermint starts at height 1
* Apply suggestions from code review
* setup ics20 test suite
* add event to MsgRecvPacket
* update ibc keeper test to use test suite
* Add handshake commands
* WIP connection handshake
* WIP Connection Handshake
* Add cliCtx.WaitForNBlocks
* fix connection handshake in progress
* fix connection handshake in progress
* add channel unit test
* add more channel tests
* fix channel test
* refactor channel test
* add capability test for channel
* make channel testing work
* optimize channel test
* delete types/errors.go
* modify capability test
* uncomment
* add msg tests for channel
* fix port capability store
* fix channel test
* use simapp
* modify channel test
* refactor channel msg test
* go fmt
* IBC alpha general cleanup (#5291 )
* remove prefix from keeper; update client queries; address ICS02 comments from @cwgoes
* add proof for root query
* golangci
* remove hardcoded bind port logic
* space
* WIP: register errors
* register errors; make format
* use new instead of register; unescape path
* golangci
* Fix codec issue in ics23
* Modify codec registration style to match previous working state
* write port tests
* ICS-02: Keeper Tests (#5329 )
* add keeper tests
* fix tendermint tests
* Fix proof verification; remove store key prefixes; add additional path validations (#5313 )
* fix poof verify
* minor cleanup
* fix tests
* remove key prefixes
* fix tests
* Add ICS20 tests (#5308 )
* add ics20 test
* delete debug
* fix ics20 test
* revert and modify
* optimize test
* add ics20 msg test
* fix test
* add packet tests and more msgs tests
* add ReceivePacket and callbacks tests
* fix callbacks test
* add handler tests for ics20
* fix handler tests
* minor cleanup
* test all positive amounts
* update test suite NotNil to Error
* fix ics20 tests
* expected error
* Add IBC REST endpoints (#5310 )
* add rest framework
* add rest endpoints for ibc connection
* add rest endpoints for ibc client
* add rest endpoints for ibc channel
* modify ibc rest api
* add rest endpoints for ibc transfer
* fix query route
* fix receive packet
* fix query client state api
* use sub module name instead of icsxx
* use const for prove judgement
* modify ibc rest api
* add api docs to swagger
* add ibc config
* fix proof path in swagger
* return query result proof
* update swagger docs
* parse prove
* clean up
* fix ibc rest api and swagger docs
* fix host validate
* fix typo
* add submitMisbehaviour error response in swagger
* fix rest queryRoot and swagger doc
* add response comments for each REST functions
* fix rest function comments
* fix IBC proofs (#5351 )
* fix ICS02 proofs
* fix ICS03 proofs
* fix ICS04 proofs
* fix ICS20 proofs
* make format
* fix build; comment handshakes
* ICS-2 Implement Misbehavior (#5321 )
* ibc client evidence route
* split evidence from misbehaviour
* clean up client events
* test misbehaviour and evidence
* remove comments
* remove frozen comments from demo
* Update x/ibc/02-client/types/tendermint/evidence_test.go
Co-Authored-By: Aditya <adityasripal@gmail.com>
* change evidence to detect malicious chain
* remove unnecessary sort
* fix evidence and persist committers to check misbehaviour
* minor fixes and remove incorrect tests
* add evidence tests
* remove debug statements
* cleanup evidence test
* start misbehaviour tests
* fix nondeterministic bug
* add same height and next height checks in misbehaviour
* fix bugs
* apply fede review suggestions
* finish code review changes
* fix GetCommitter and write keeper-level misbehaviour tests
* remove incorrect special case checking
* save
* final fixes
* save
* fix conflict
* fix conflicts and add back submit misbehaviour msg
* Apply suggestions from code review
Co-Authored-By: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
* save
* add godocs and fix test
* fix test panics in other modules
* Update x/ibc/02-client/keeper/client.go
Co-Authored-By: Bot from GolangCI <42910462+golangcibot@users.noreply.github.com>
* add back aliases
* Misc ibc fixes (#5357 )
* fix cli ExactArgs
* remove full handshakes
* rm dup flag
* fix error handling
* Implement Query Committer methods in ICS-02 (#5402 )
* add query methods for committers in ICS-02
* Update x/ibc/02-client/keeper/keeper.go
* add REST docs
* fix test
* IBC UX improvements (#5364 )
* ICS02 iterators
* ICS03 iterators
* ICS04 iterators
* ICS02 client updates
* CLI connections
* setup queriers
* clean up queriers
* add tests
* IBC top-level querier tests
* update ICS02 keys
* update ICS03 keys
* make format
* update ICS04 keys
* fix a few tests
* fix ICS20 tests
* update keys
* fix ICS02 queries (#5425 )
* fix CLI JSON param unmarshaling (#5431 )
* Fix inconsistent string lookup functions (#5437 )
* fix inconsistent string lookup functions
* test client type and ordering
* channel and connection state tests
* address golangcibot comments
* fix test
* Update x/ibc error handling (#5462 )
* Merge PR #5428 : Add mod, exponentiation for uint
* Modified examples in distribution module (#5441 )
* Merge PR #5442 : Remove of the client/alias.go
* Merge PR #5445 : Mock rpcclient in tests for votes pagination
* Merge PR #5435 : Added iterator that allows to read only requested values
* Merge PR #5427 : Remove code duplication in x/auth/client/cli
* Merge PR #5421 : Refactor Error Handling
* update x/ibc error handling
* update ICS24 and ICS02 errors
* ICS03, ICS23 and common errors
* updates from master and errors from ICS04
* build
* fix ics20 tests
* fix tests
* golangcibot fixes
Co-authored-by: Kevin Davis <karzak@users.noreply.github.com>
Co-authored-by: kaustubhkapatral <54210167+kaustubhkapatral@users.noreply.github.com>
Co-authored-by: Ferenc Fabian <qwer.kocka@gmail.com>
Co-authored-by: Dmitry Shulyak <yashulyak@gmail.com>
Co-authored-by: Alessio Treglia <quadrispro@ubuntu.com>
Co-authored-by: Alexander Bezobchuk <alexanderbez@users.noreply.github.com>
* ADR 015 Implementation (#5401 )
* implement in progress
* rm unneccessary change under simapp, modify baseapp for codetxbreak
* fix test in progress
* fix test error
* fix golangci
* address minor comments
* mv antehandler to ante/, address comments
* fix GetCommitment => GetData, fix syntax
* checkout types/ to ibc-alpha
* checkout to origin/ibc-alpha
* fix branch problem
* fix syntax error
* recover PacketI interface
* mv recvpacket rest from 20 -> 04
* address minor comments
* Apply suggestions from code review
Co-Authored-By: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
* rm wrong files
* Apply suggestions from code review
* PacketDataI field is now named, not embed
* add acknowledgement hashing
* rename finalization functiosn
* Apply suggestions from code review
Co-Authored-By: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
* Rename GetCommitment() to GetBytes()
* Add recv sequence incr to RecvPacket()
* Revert but where is PacketExecuted() called
* Call PacketExecuted(), check seq in RecvPacket()
* The port is called "bank"
* Apply suggestions from code review
Co-Authored-By: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
* Update simapp/app.go
Co-Authored-By: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
* Remove omitempty
* Add godoc
* Move events
* set ProofVerificationDecorator on AnteHandler
* Apply suggestions from code review
Co-Authored-By: Bot from GolangCI <42910462+golangcibot@users.noreply.github.com>
* format
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
Co-authored-by: Christopher Goes <cwgoes@pluranimity.org>
Co-authored-by: Bot from GolangCI <42910462+golangcibot@users.noreply.github.com>
* IBC alpha
* ICS 23 Implementation (#4515 )
* add mapping
* rm unused mapping/*, rm interfaces
* rm unused code
* mv mapping -> state, rm x/ibc
* rm GetIfExists
* add key
* rm custom encoding/decoding in enum/bool
* fix lint
* rm tests
* add commitment
* newtyped remote values
* newtyped context
* revert context newtype
* add README, keypath
* reflect downstream ics
* add merkle
* add test for proving
* soft coded root keypath
* add update
* remove RootUpdate
* separate keypath and keuprefix
* add codec
* separate root/path
* add path to codec
* add docs in progre
* add comments
* add comments
* Apply suggestions from code review
Co-Authored-By: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
* add comments in progress
* add comments
* fix comment
* add comments in progress
* recover IntEncoding scheme for integer
* add uint tests, don't use codec in custom types
* finalize merge
* add godoc
* reformat test
* rm XXX
* add godoc
* add query
* update query.go
* update query.go
* add Query to boolean.go
* fix key
* godoc cleanup
* godoc cleanup
* godoc cleanup
* godoc cleanup
* godoc cleanup
* merge from ics04 branch
* merge from ics04 branch
* fix lint
* Apply suggestions from code review
Co-Authored-By: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
* applying review in progress
* apply review - make querier interface
* fix dependency
* revise querier interface to work both on cli & store
* rm commented lines
* rename Path -> Prefix
* Store accessor upstream changes (#5119 )
* Store accessor upstream changes (#5119 )
* add comments, reformat merkle querier
* rm merkle/utils
* ICS 23 upstream changes (#5120 )
* ICS 23 upstream changes (#5120 )
* update Value
* remove Mapping
* remove store accessors
* refactor ICS23
* cleanup types
* implement batch verification
* gosimple suggestion
* alias
* add tests
* ICS 24 Implementation (#5229 )
* add validation functions
* validate path in ics-23
* address @fede comments
* move errors into host package
* flatten ICS23 structure
* fix ApplyPrefix
* complete types testing
* delete empty test file
* remove ibc errors from core error package
* start batch-verify tests
* minor changes on commitment types
* use testsuite
* upstream changes
* context changes
* ICS 02 Implementation (#4516 )
* add mapping
* rm unused mapping/*, rm interfaces
* rm unused code
* mv mapping -> state, rm x/ibc
* rm GetIfExists
* add key
* rm custom encoding/decoding in enum/bool
* fix lint
* rm tests
* add commitment
* newtyped remote values
* newtyped context
* revert context newtype
* add README, keypath
* reflect downstream ics
* add merkle
* add test for proving
* soft coded root keypath
* add update
* remove RootUpdate
* separate keypath and keuprefix
* add codec
* separate root/path
* add path to codec
* add client
* add counterpartymanager
* fix manager
* add Is() to counterobject
* add readme, reflect ICS02 revision
* reflect downstream ics
* test in progress
* add test
* in progres
* fin rebase
* in progress
* fin rebase
* add CLIObject in progress
* cli in progress
* add CLIObject
* separate testing from tendermint
* add key to node
* add root and storekey to tests/node, add codec
* rm cli/query.go
* fix test
* fix lint
* fix lint
* add handler/msgs/client
* rm relay
* finalize rebase on 23 root/path sep
* fix lint, fix syntax
* rm freebase, reformat query
* add docs in progre
* add comments
* add comments
* Apply suggestions from code review
Co-Authored-By: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
* add comments in progress
* add comments
* fix comment
* add comments in progress
* recover IntEncoding scheme for integer
* add uint tests, don't use codec in custom types
* finalize merge
* add godoc
* add godoc in progress
* reformat test
* rm XXX
* add godoc
* modify store
* add query
* update query.go
* update query.go
* cli refactor in progress
* cli refactor in progress
* add Query to boolean.go
* fix key
* fix cli / merkle test
* godoc cleanup
* godoc cleanup
* godoc cleanup
* godoc cleanup
* godoc cleanup
* merge from ics04 branch
* merge from ics04 branch
* merge from ics04 branch
* fix lint
* Apply suggestions from code review
Co-Authored-By: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
* applying review in progress
* apply review - make querier interface
* fix dependency
* fix dependency
* revise querier interface to work both on cli & store
* revise querier interface to work both on cli & store
* reflect downstream change
* fix cli
* rm commented lines
* address review in progress
* rename Path -> Prefix
* Store accessor upstream changes (#5119 )
* Store accessor upstream changes (#5119 )
* add comments, reformat merkle querier
* rm merkle/utils
* ICS 23 upstream changes (#5120 )
* ICS 23 upstream changes (#5120 )
* update Value
* update test
* fix
* ICS 02 upstream changes (#5122 )
* ICS 02 upstream changes (#5122 )
* cleanup types and submodule
* more cleanup and godocs
* remove counterPartyManager/State and cleanup
* implement SubmitMisbehaviour and refactor
* errors
* events
* fix test
* refactors
* remove Mapping
* remove store accessors
* proposed refactor
* remove store accessors from ICS02
* refactor queriers, handler and clean keeper
* logger and tx long description
* ineffassign
* Apply suggestions from code review
Co-Authored-By: Jack Zampolin <jack.zampolin@gmail.com>
* Apply suggestions from code review
Co-Authored-By: Jack Zampolin <jack.zampolin@gmail.com>
* add verification functions
* ICS02 module.go
* top level x/ibc structure
* Update x/ibc/02-client/client/cli/query.go
Co-Authored-By: Jack Zampolin <jack.zampolin@gmail.com>
* Update x/ibc/02-client/types/tendermint/consensus_state.go
Co-Authored-By: Jack Zampolin <jack.zampolin@gmail.com>
* address some of the review comments
* minor UX improvements
* rename pkg
* fixes
* refactor ICS23
* cleanup types
* implement batch verification
* gosimple suggestion
* various fixes; remove legacy tests; remove commitment path query
* alias
* minor updates from ICS23
* renaming
* update verification and rename root funcs
* move querier to x/ibc
* update query.go to use 'custom/...' query path
* add tests
* ICS 24 Implementation (#5229 )
* add validation functions
* validate path in ics-23
* address @fede comments
* move errors into host package
* flatten ICS23 structure
* fix ApplyPrefix
* updates from ICS23 and ICS24
* msg.ValidateBasic and ADR09 evidence interface
* complete types testing
* delete empty test file
* remove ibc errors from core error package
* custom JSON marshaling
* start batch-verify tests
* minor changes on commitment types
* R4R - Store consensus state correctly (#5242 )
* store consensus state correctly
* fix client example
* update alias
* use testsuite
* Integrate Evidence Implementation into ICS-02 (#5258 )
* implement evidence in ics-02
* fix build errors and import cycles
* address fede comments
* remove unnecessary pubkey and fix init
* add tests
* finish tendermint tests
* complete merge
* Add tests for msgs
* upstream changes
* fix
* upstream changes
* fix cons state
* context changes
* ICS 03 Implementation (#4517 )
* add test
* in progres
* fin rebase
* in progress
* fin rebase
* add CLIObject in progress
* cli in progress
* add CLIObject
* separate testing from tendermint
* add key to node
* add root and storekey to tests/node, add codec
* rm cli/query.go
* fix test
* fix lint
* fix lint
* add handler/msgs/client
* rm relay
* finalize rebase on 23 root/path sep
* fix lint, fix syntax
* fix querying
* extract out context withstore
* fix 02-client test
* fix 23-commitment test
* add query in progress
* rm freebase, reformat query
* add cli/handler/msg in progress
* add cli/msg/handler
* add CLIQuery, fix tests
* fix golangci
* add docs in progre
* add comments
* add comments
* Apply suggestions from code review
Co-Authored-By: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
* add comments in progress
* add comments
* fix comment
* add comments in progress
* recover IntEncoding scheme for integer
* add uint tests, don't use codec in custom types
* finalize merge
* add godoc
* add godoc in progress
* reformat test
* rm XXX
* add godoc
* modify store
* add query
* update query.go
* update query.go
* cli refactor in progress
* cli refactor in progress
* add Query to boolean.go
* fix key
* fix cli / merkle test
* godoc cleanup
* godoc cleanup
* godoc cleanup
* godoc cleanup
* godoc cleanup
* fix test
* fix client
* merge from ics04 branch
* merge from ics04 branch
* merge from ics04 branch
* merge from ics04 branch
* fix lint
* Apply suggestions from code review
Co-Authored-By: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
* applying review in progress
* apply review - make querier interface
* fix dependency
* fix dependency
* revise querier interface to work both on cli & store
* revise querier interface to work both on cli & store
* reflect downstream change
* fix cli
* reflect downstream changes
* rm commented lines
* address review in progress
* address review, rm cleanup/closing
* rename Path -> Prefix
* Store accessor upstream changes (#5119 )
* Store accessor upstream changes (#5119 )
* add comments, reformat merkle querier
* rm merkle/utils
* ICS 23 upstream changes (#5120 )
* ICS 23 upstream changes (#5120 )
* update Value
* update test
* fix
* ICS 02 upstream changes (#5122 )
* ICS 02 upstream changes (#5122 )
* ICS 03 upstream changes (#5123 )
* ICS 03 upstream changes (#5123 )
* cleanup types and submodule
* more cleanup and godocs
* remove counterPartyManager/State and cleanup
* implement SubmitMisbehaviour and refactor
* errors
* events
* fix test
* refactors
* WIP refactor ICS03
* remove Mapping
* remove store accessors
* proposed refactor
* remove store accessors from ICS02
* refactor queriers, handler and clean keeper
* logger and tx long description
* ineffassign
* Apply suggestions from code review
Co-Authored-By: Jack Zampolin <jack.zampolin@gmail.com>
* Apply suggestions from code review
Co-Authored-By: Jack Zampolin <jack.zampolin@gmail.com>
* remove store accessors
* refactor handshake to update it to the latest ICS03 spec
* update handler and msgs
* add verification functions
* update verification
* ICS02 module.go
* top level x/ibc structure
* update connection queries
* update connection tx
* remove extra files
* update expected client keeper and export verification funcs
* Update x/ibc/02-client/client/cli/query.go
Co-Authored-By: Jack Zampolin <jack.zampolin@gmail.com>
* Update x/ibc/02-client/types/tendermint/consensus_state.go
Co-Authored-By: Jack Zampolin <jack.zampolin@gmail.com>
* address some of the review comments
* resolve some TODOs and address comments from review
* update connection versioning
* minor error updates
* minor UX improvements
* rename pkg
* fixes
* refactor ICS23
* cleanup types
* rename pkg and fix import
* implement batch verification
* gosimple suggestion
* various fixes; remove legacy tests; remove commitment path query
* alias
* minor updates from ICS23
* renaming
* update verification and rename root funcs
* move querier to x/ibc
* update query.go to use 'custom/...' query path
* add tests
* ICS 24 Implementation (#5229 )
* add validation functions
* validate path in ics-23
* address @fede comments
* move errors into host package
* flatten ICS23 structure
* fix ApplyPrefix
* updates from ICS23 and ICS24
* msg.ValidateBasic and ADR09 evidence interface
* complete types testing
* delete empty test file
* remove ibc errors from core error package
* custom JSON marshaling; msg.ValidateBasic; renaming of variables
* minor update
* custom JSON marshaling
* start batch-verify tests
* minor changes on commitment types
* R4R - Store consensus state correctly (#5242 )
* store consensus state correctly
* fix client example
* update alias
* update alias
* use testsuite
* Integrate Evidence Implementation into ICS-02 (#5258 )
* implement evidence in ics-02
* fix build errors and import cycles
* address fede comments
* remove unnecessary pubkey and fix init
* add tests
* finish tendermint tests
* complete merge
* Add tests for msgs
* upstream changes
* fix
* upstream changes
* fix cons state
* context changes
* fix cli tx
* upstream changes
* fix
* ICS 05 implementation (#5193 )
* fix lint
* fix lint
* add handler/msgs/client
* rm relay
* finalize rebase on 23 root/path sep
* fix lint, fix syntax
* fix querying
* extract out context withstore
* fix 02-client test
* fix 23-commitment test
* add query in progress
* rm freebase, reformat query
* add cli/handler/msg in progress
* add cli/msg/handler
* add CLIQuery, fix tests
* fix golangci
* add docs in progre
* add comments
* add comments
* Apply suggestions from code review
Co-Authored-By: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
* add comments in progress
* add comments
* fix comment
* add comments in progress
* recover IntEncoding scheme for integer
* add uint tests, don't use codec in custom types
* finalize merge
* add godoc
* add godoc in progress
* reformat test
* rm XXX
* add godoc
* modify store
* add query
* update query.go
* update query.go
* cli refactor in progress
* cli refactor in progress
* add Query to boolean.go
* fix key
* fix cli / merkle test
* godoc cleanup
* godoc cleanup
* godoc cleanup
* godoc cleanup
* godoc cleanup
* fix test
* fix client
* merge from ics04 branch
* merge from ics04 branch
* merge from ics04 branch
* merge from ics04 branch
* fix lint
* Apply suggestions from code review
Co-Authored-By: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
* applying review in progress
* apply review - make querier interface
* fix dependency
* fix dependency
* revise querier interface to work both on cli & store
* revise querier interface to work both on cli & store
* reflect downstream change
* fix cli
* reflect downstream changes
* rm commented lines
* address review in progress
* address review, rm cleanup/closing
* rename Path -> Prefix
* Store accessor upstream changes (#5119 )
* Store accessor upstream changes (#5119 )
* add comments, reformat merkle querier
* rm merkle/utils
* ICS 23 upstream changes (#5120 )
* ICS 23 upstream changes (#5120 )
* update Value
* update test
* fix
* ICS 02 upstream changes (#5122 )
* ICS 02 upstream changes (#5122 )
* ICS 03 upstream changes (#5123 )
* ICS 03 upstream changes (#5123 )
* cleanup types and submodule
* more cleanup and godocs
* remove counterPartyManager/State and cleanup
* implement SubmitMisbehaviour and refactor
* errors
* events
* fix test
* refactors
* WIP refactor ICS03
* remove Mapping
* remove store accessors
* proposed refactor
* remove store accessors from ICS02
* refactor queriers, handler and clean keeper
* logger and tx long description
* ineffassign
* Apply suggestions from code review
Co-Authored-By: Jack Zampolin <jack.zampolin@gmail.com>
* Apply suggestions from code review
Co-Authored-By: Jack Zampolin <jack.zampolin@gmail.com>
* remove store accessors
* refactor handshake to update it to the latest ICS03 spec
* update handler and msgs
* add verification functions
* update verification
* ICS02 module.go
* top level x/ibc structure
* update connection queries
* update connection tx
* remove extra files
* update expected client keeper and export verification funcs
* ICS 05 Implementation
* release port and godocs
* Update x/ibc/02-client/client/cli/query.go
Co-Authored-By: Jack Zampolin <jack.zampolin@gmail.com>
* Update x/ibc/02-client/types/tendermint/consensus_state.go
Co-Authored-By: Jack Zampolin <jack.zampolin@gmail.com>
* address some of the review comments
* resolve some TODOs and address comments from review
* update connection versioning
* minor error updates
* update errors and add port Keeper to ibc Keeper
* minor UX improvements
* rename pkg
* fixes
* refactor ICS23
* cleanup types
* ICS 5 updates (#5222 )
* Validate port identifiers
* Refactor to static bind
* Add comments
* Add 'GetPorts' query function
* rename pkg and fix import
* implement batch verification
* gosimple suggestion
* various fixes; remove legacy tests; remove commitment path query
* alias
* minor updates from ICS23
* renaming
* update verification and rename root funcs
* move querier to x/ibc
* update query.go to use 'custom/...' query path
* add tests
* ICS 24 Implementation (#5229 )
* add validation functions
* validate path in ics-23
* address @fede comments
* move errors into host package
* flatten ICS23 structure
* fix ApplyPrefix
* updates from ICS23 and ICS24
* msg.ValidateBasic and ADR09 evidence interface
* complete types testing
* delete empty test file
* remove ibc errors from core error package
* custom JSON marshaling; msg.ValidateBasic; renaming of variables
* minor update
* custom JSON marshaling
* use host validation for port ids
* start batch-verify tests
* minor changes on commitment types
* R4R - Store consensus state correctly (#5242 )
* store consensus state correctly
* fix client example
* update alias
* update alias
* update alias and keeper.GetPort()
* use testsuite
* Integrate Evidence Implementation into ICS-02 (#5258 )
* implement evidence in ics-02
* fix build errors and import cycles
* address fede comments
* remove unnecessary pubkey and fix init
* add tests
* finish tendermint tests
* complete merge
* Add tests for msgs
* upstream changes
* fix
* upstream changes
* fix cons state
* context changes
* fix cli tx
* upstream changes
* upstream changes
* ICS 04 Implementation (#4548 )
* merge from ics04 branch
* merge from ics04 branch
* fix lint
* add port
* fix test
* add mocks
* fix connid -> portid in handshake.go
* add mock
* add ibc module.go, finalize mock
* add keeper
* add StoreKey const
* fix test
* Apply suggestions from code review
Co-Authored-By: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
* applying review in progress
* apply review - make querier interface
* fix cli errors
* fix dependency
* fix dependency
* reflect method name change
* revise querier interface to work both on cli & store
* revise querier interface to work both on cli & store
* revise querier interface to work both on cli & store
* reflect downstream change
* fix cli
* reflect downstream changes
* reflect downstream changes
* fix from address in tx cli
* fix cli in progress(squash later)
* fix cli
* remove timeout, add channel cli
* fix golangci
* fix cli
* Clean up
* fix mock cli in progress
* finalize cleanup, mock cli wip
* add cli for mocksend
* fix handler
* rm commented lines
* address review in progress
* address review, rm cleanup/closing
* rename mock packages
* fix interface for gaia
* rename Path -> Prefix
* Store accessor upstream changes (#5119 )
* Store accessor upstream changes (#5119 )
* add comments, reformat merkle querier
* rm merkle/utils
* ICS 23 upstream changes (#5120 )
* ICS 23 upstream changes (#5120 )
* update Value
* update test
* fix
* ICS 02 upstream changes (#5122 )
* ICS 02 upstream changes (#5122 )
* ICS 03 upstream changes (#5123 )
* ICS 03 upstream changes (#5123 )
* update test
* cleanup types and submodule
* more cleanup and godocs
* remove counterPartyManager/State and cleanup
* implement SubmitMisbehaviour and refactor
* errors
* events
* fix test
* refactors
* WIP refactor ICS03
* remove Mapping
* remove store accessors
* proposed refactor
* remove store accessors from ICS02
* refactor queriers, handler and clean keeper
* logger and tx long description
* ineffassign
* Apply suggestions from code review
Co-Authored-By: Jack Zampolin <jack.zampolin@gmail.com>
* Apply suggestions from code review
Co-Authored-By: Jack Zampolin <jack.zampolin@gmail.com>
* remove store accessors
* refactor handshake to update it to the latest ICS03 spec
* update handler and msgs
* add verification functions
* update verification
* ICS02 module.go
* top level x/ibc structure
* update connection queries
* update connection tx
* remove extra files
* refactor: remove store accessors, update keeper and types to match spec (WIP)
* update handshake and packet
* implement packet timeouts
* implement send and receive packet
* implement packet ACK
* update handler
* add channel errors
* channel querier
* update expected client keeper and export verification funcs
* ICS 05 Implementation
* release port and godocs
* Update x/ibc/02-client/client/cli/query.go
Co-Authored-By: Jack Zampolin <jack.zampolin@gmail.com>
* Update x/ibc/02-client/types/tendermint/consensus_state.go
Co-Authored-By: Jack Zampolin <jack.zampolin@gmail.com>
* address some of the review comments
* resolve some TODOs and address comments from review
* update connection versioning
* minor error updates
* update ICS04 with downstream changes
* Implement tx cli actions
* add MsgSendPacket handler; msg validation, errors and events
* update errors and add port Keeper to ibc Keeper
* minor UX improvements
* rename pkg
* fixes
* refactor ICS23
* cleanup types
* ICS 5 updates (#5222 )
* Validate port identifiers
* Refactor to static bind
* Add comments
* Add 'GetPorts' query function
* rename pkg and fix import
* implement batch verification
* gosimple suggestion
* various fixes; remove legacy tests; remove commitment path query
* alias
* minor updates from ICS23
* renaming
* update verification and rename root funcs
* rm legacy tests; add query proofs support
* remove capability key generation and authentication logic
* move querier to x/ibc
* update query.go to use 'custom/...' query path
* add tests
* ICS 24 Implementation (#5229 )
* add validation functions
* validate path in ics-23
* address @fede comments
* move errors into host package
* flatten ICS23 structure
* fix ApplyPrefix
* updates from ICS23 and ICS24
* msg.ValidateBasic and ADR09 evidence interface
* complete types testing
* delete empty test file
* remove ibc errors from core error package
* custom JSON marshaling; msg.ValidateBasic; renaming of variables
* minor update
* custom JSON marshaling
* use host validation for port ids
* downstream changes; custom marshal JSON; msg validation, and update errors
* update errors and aliases
* start batch-verify tests
* update msg validation and CLI UX
* minor changes on commitment types
* fix channel and packet check (#5243 )
* R4R - Store consensus state correctly (#5242 )
* store consensus state correctly
* fix client example
* update alias
* update alias
* update alias and keeper.GetPort()
* authenticate port ID; remove send packet msg from CLI
* comment out handlers
* use testsuite
* Integrate Evidence Implementation into ICS-02 (#5258 )
* implement evidence in ics-02
* fix build errors and import cycles
* address fede comments
* remove unnecessary pubkey and fix init
* add tests
* finish tendermint tests
* complete merge
* Add tests for msgs
* upstream changes
* fix
* upstream changes
* fix cons state
* context changes
* fix cli tx
* upstream changes
* upstream changes
* upstream changes
* IBC v1.0.0 (#5245 )
* applying review in progress
* apply review - make querier interface
* fix cli errors
* fix dependency
* fix dependency
* reflect method name change
* revise querier interface to work both on cli & store
* revise querier interface to work both on cli & store
* revise querier interface to work both on cli & store
* reflect downstream change
* fix cli
* reflect downstream changes
* reflect downstream changes
* fix from address in tx cli
* fix cli in progress(squash later)
* fix cli
* remove timeout, add channel cli
* fix golangci
* fix cli
* Clean up
* fix mock cli in progress
* finalize cleanup, mock cli wip
* add cli for mocksend
* fix handler
* rm commented lines
* address review in progress
* address review, rm cleanup/closing
* rename mock packages
* fix interface for gaia
* rename Path -> Prefix
* Store accessor upstream changes (#5119 )
* Store accessor upstream changes (#5119 )
* add comments, reformat merkle querier
* rm merkle/utils
* ICS 23 upstream changes (#5120 )
* ICS 23 upstream changes (#5120 )
* update Value
* update test
* fix
* ICS 02 upstream changes (#5122 )
* ICS 02 upstream changes (#5122 )
* ICS 03 upstream changes (#5123 )
* ICS 03 upstream changes (#5123 )
* update test
* cleanup types and submodule
* more cleanup and godocs
* remove counterPartyManager/State and cleanup
* implement SubmitMisbehaviour and refactor
* errors
* events
* fix test
* refactors
* WIP refactor ICS03
* remove Mapping
* remove store accessors
* proposed refactor
* remove store accessors from ICS02
* refactor queriers, handler and clean keeper
* logger and tx long description
* ineffassign
* Apply suggestions from code review
Co-Authored-By: Jack Zampolin <jack.zampolin@gmail.com>
* Apply suggestions from code review
Co-Authored-By: Jack Zampolin <jack.zampolin@gmail.com>
* remove store accessors
* refactor handshake to update it to the latest ICS03 spec
* update handler and msgs
* add verification functions
* update verification
* ICS02 module.go
* top level x/ibc structure
* update connection queries
* update connection tx
* remove extra files
* refactor: remove store accessors, update keeper and types to match spec (WIP)
* update handshake and packet
* implement packet timeouts
* implement send and receive packet
* implement packet ACK
* update handler
* add channel errors
* channel querier
* update expected client keeper and export verification funcs
* ICS 05 Implementation
* release port and godocs
* Update x/ibc/02-client/client/cli/query.go
Co-Authored-By: Jack Zampolin <jack.zampolin@gmail.com>
* Update x/ibc/02-client/types/tendermint/consensus_state.go
Co-Authored-By: Jack Zampolin <jack.zampolin@gmail.com>
* address some of the review comments
* resolve some TODOs and address comments from review
* update connection versioning
* minor error updates
* update ICS04 with downstream changes
* Implement tx cli actions
* add MsgSendPacket handler; msg validation, errors and events
* update errors and add port Keeper to ibc Keeper
* minor UX improvements
* rename pkg
* fixes
* refactor ICS23
* cleanup types
* ICS 5 updates (#5222 )
* Validate port identifiers
* Refactor to static bind
* Add comments
* Add 'GetPorts' query function
* rename pkg and fix import
* implement batch verification
* gosimple suggestion
* various fixes; remove legacy tests; remove commitment path query
* alias
* minor updates from ICS23
* renaming
* update verification and rename root funcs
* rm legacy tests; add query proofs support
* remove capability key generation and authentication logic
* move querier to x/ibc
* update query.go to use 'custom/...' query path
* add tests
* ICS 24 Implementation (#5229 )
* add validation functions
* validate path in ics-23
* address @fede comments
* move errors into host package
* flatten ICS23 structure
* fix ApplyPrefix
* updates from ICS23 and ICS24
* msg.ValidateBasic and ADR09 evidence interface
* complete types testing
* delete empty test file
* remove ibc errors from core error package
* custom JSON marshaling; msg.ValidateBasic; renaming of variables
* minor update
* custom JSON marshaling
* use host validation for port ids
* downstream changes; custom marshal JSON; msg validation, and update errors
* update errors and aliases
* start batch-verify tests
* update msg validation and CLI UX
* minor changes on commitment types
* fix channel and packet check (#5243 )
* R4R - Store consensus state correctly (#5242 )
* store consensus state correctly
* fix client example
* update alias
* update alias
* update alias and keeper.GetPort()
* authenticate port ID; remove send packet msg from CLI
* comment out handlers
* add ibc module to simapp
* ICS20 implementation (#5204 )
* add ibc bank mock
* modify handler
* import channel
* add receiving logic
* add cli proof handling
* modify cli
* modify receiver type
* modify errcode
* optimize codes
* add denom prefix when source is true
* refactor code
* error return
* switch ibc antehandler to decorator pattern
* fix name/comment
* ICS 20 implementation (#5250 )
* move ics20 code to 20-transfer
* clean code
* fix compiling error
* add transfer module
* address ICS20 comments from review
* add routing callbacks
* clean code
* add missing err return
* modify err type
* modify err type
* add supply handling
* modify proof type
* add comments for msg and packet data
* add timeout supply handling
* modify module account name
* use supply keeper for burn and mint coins
* restructure keeper
* update alias and module.go
* golangci linter
* add ics20 handler to IBC handler
* update callbacks
* update ICS20 escrow address
* fix querier routes
* fix create client cli
* minor updates
* ibc querier test
* Refactor ibc/mock/bank into ICS 20 (#5264 )
* Most of code port from mock module to ICS 20
* A few minor fixes
* Apply suggestions from code review
Co-Authored-By: Bot from GolangCI <42910462+golangcibot@users.noreply.github.com>
* Fix suggestions from autolinter
* Apply suggestions from code review
Co-Authored-By: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
* Fix order of messages
* Add invalid height error code, check non-nil proof
* Fix linter error
* Return the underlying error
* Tendermint starts at height 1
* Apply suggestions from code review
* setup ics20 test suite
* add event to MsgRecvPacket
* update ibc keeper test to use test suite
* Add handshake commands
* WIP connection handshake
* WIP Connection Handshake
* use testsuite
* Add cliCtx.WaitForNBlocks
* fix connection handshake in progress
* fix connection handshake in progress
* Integrate Evidence Implementation into ICS-02 (#5258 )
* implement evidence in ics-02
* fix build errors and import cycles
* address fede comments
* remove unnecessary pubkey and fix init
* add tests
* finish tendermint tests
* complete merge
* Add tests for msgs
* upstream changes
* fix
* upstream changes
* fix cons state
* context changes
* fix cli tx
* upstream changes
* upstream changes
* upstream changes
* upstream changes
* IBC demo fixes (#5267 )
* WIP refactor ICS03
* remove Mapping
* remove store accessors
* proposed refactor
* remove store accessors from ICS02
* refactor queriers, handler and clean keeper
* logger and tx long description
* ineffassign
* Apply suggestions from code review
Co-Authored-By: Jack Zampolin <jack.zampolin@gmail.com>
* Apply suggestions from code review
Co-Authored-By: Jack Zampolin <jack.zampolin@gmail.com>
* remove store accessors
* refactor handshake to update it to the latest ICS03 spec
* update handler and msgs
* add verification functions
* update verification
* ICS02 module.go
* top level x/ibc structure
* update connection queries
* update connection tx
* remove extra files
* refactor: remove store accessors, update keeper and types to match spec (WIP)
* update handshake and packet
* implement packet timeouts
* implement send and receive packet
* implement packet ACK
* update handler
* add channel errors
* channel querier
* update expected client keeper and export verification funcs
* ICS 05 Implementation
* release port and godocs
* Update x/ibc/02-client/client/cli/query.go
Co-Authored-By: Jack Zampolin <jack.zampolin@gmail.com>
* Update x/ibc/02-client/types/tendermint/consensus_state.go
Co-Authored-By: Jack Zampolin <jack.zampolin@gmail.com>
* address some of the review comments
* resolve some TODOs and address comments from review
* update connection versioning
* minor error updates
* update ICS04 with downstream changes
* Implement tx cli actions
* add MsgSendPacket handler; msg validation, errors and events
* update errors and add port Keeper to ibc Keeper
* minor UX improvements
* rename pkg
* fixes
* refactor ICS23
* cleanup types
* ICS 5 updates (#5222 )
* Validate port identifiers
* Refactor to static bind
* Add comments
* Add 'GetPorts' query function
* rename pkg and fix import
* implement batch verification
* gosimple suggestion
* various fixes; remove legacy tests; remove commitment path query
* alias
* minor updates from ICS23
* renaming
* update verification and rename root funcs
* rm legacy tests; add query proofs support
* remove capability key generation and authentication logic
* move querier to x/ibc
* update query.go to use 'custom/...' query path
* add tests
* ICS 24 Implementation (#5229 )
* add validation functions
* validate path in ics-23
* address @fede comments
* move errors into host package
* flatten ICS23 structure
* fix ApplyPrefix
* updates from ICS23 and ICS24
* msg.ValidateBasic and ADR09 evidence interface
* complete types testing
* delete empty test file
* remove ibc errors from core error package
* custom JSON marshaling; msg.ValidateBasic; renaming of variables
* minor update
* custom JSON marshaling
* use host validation for port ids
* downstream changes; custom marshal JSON; msg validation, and update errors
* update errors and aliases
* start batch-verify tests
* update msg validation and CLI UX
* minor changes on commitment types
* fix channel and packet check (#5243 )
* R4R - Store consensus state correctly (#5242 )
* store consensus state correctly
* fix client example
* update alias
* update alias
* update alias and keeper.GetPort()
* authenticate port ID; remove send packet msg from CLI
* comment out handlers
* add ibc module to simapp
* ICS20 implementation (#5204 )
* add ibc bank mock
* modify handler
* import channel
* add receiving logic
* add cli proof handling
* modify cli
* modify receiver type
* modify errcode
* optimize codes
* add denom prefix when source is true
* refactor code
* error return
* switch ibc antehandler to decorator pattern
* fix name/comment
* ICS 20 implementation (#5250 )
* move ics20 code to 20-transfer
* clean code
* fix compiling error
* add transfer module
* address ICS20 comments from review
* add routing callbacks
* clean code
* add missing err return
* modify err type
* modify err type
* add supply handling
* modify proof type
* add comments for msg and packet data
* add timeout supply handling
* modify module account name
* use supply keeper for burn and mint coins
* restructure keeper
* update alias and module.go
* golangci linter
* add ics20 handler to IBC handler
* update callbacks
* update ICS20 escrow address
* fix querier routes
* fix create client cli
* minor updates
* ibc querier test
* Refactor ibc/mock/bank into ICS 20 (#5264 )
* Most of code port from mock module to ICS 20
* A few minor fixes
* Apply suggestions from code review
Co-Authored-By: Bot from GolangCI <42910462+golangcibot@users.noreply.github.com>
* Fix suggestions from autolinter
* Apply suggestions from code review
Co-Authored-By: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
* Fix order of messages
* Add invalid height error code, check non-nil proof
* Fix linter error
* Return the underlying error
* Tendermint starts at height 1
* Apply suggestions from code review
* setup ics20 test suite
* add event to MsgRecvPacket
* update ibc keeper test to use test suite
* Add handshake commands
* WIP connection handshake
* WIP Connection Handshake
* use testsuite
* Add cliCtx.WaitForNBlocks
* fix connection handshake in progress
* fix connection handshake in progress
* Add print debugging (old-school)
* Add log line
* More debugging
* Set prove flag to true
* More debugging
* Use store query
* Fix query, hopefully
* Fix query path
* Hmm
* Fix context bug
* Generate & return & use consensus state proof
* Print debugging
* Add debugging
* Begin working on the channel creation command
* remove submodule prefix from keypath, fix addConnectionToClients to treat nil as empty array
* fix OpenConfirm, rm debugging code
* WIP channel shake 🕺
* WIP channel shake 🕺
* WIP channel shake 🕺
* WIP channel shake 🕺
* WIP channel shake 🕺
* WIP channel shake 🕺
* WIP channel shake 🕺
* Update bound port
* Add from flag to ICS 20 commands
* Undefine flag
* add debug
* Uncomment channel message handlers
* fix validatebasic identifier failure
* Fix printing
* add debug code
* CLI debugging
* fix counterpartyHops, channel handshake working w/o port
* Fix compilation error
* Push channel query command update
* Remove unused code
* Add gaiacli keys test
* Update error
* Add printf
* fix token restriciton
* comment out port
* fix querier to retrieve the next sequence
* Alter command to take arguments
* Name it packet-sequence
* add packet query utils
* Use the querier
* Packet is JSON
* printf the value
* fix query packet
* fix packet receive in progress
* lol
* export Packet fields, rename Packet.XXX() -> Packet.GetXXX()
* fix route
* add debug
* comment out port logic from packet.go
* token transfer now working
* fix client tx
* Integrate Evidence Implementation into ICS-02 (#5258 )
* implement evidence in ics-02
* fix build errors and import cycles
* address fede comments
* remove unnecessary pubkey and fix init
* add tests
* Apply suggestions from code review
* clean up
* finish tendermint tests
* complete merge
* Add tests for msgs
* ICS02 changes
* upstream changes
* fix
* upstream changes
* fix cons state
* context changes
* fix cli tx
* upstream changes
* upstream changes
* upstream changes
* upstream changes
* more cleanup
* Add unit tests for ICS03 (#5275 )
* add Is() to counterobject
* add readme, reflect ICS02 revision
* reflect downstream ics
* test in progress
* add test
* in progres
* fin rebase
* in progress
* fin rebase
* add CLIObject in progress
* cli in progress
* add CLIObject
* separate testing from tendermint
* add key to node
* add root and storekey to tests/node, add codec
* rm cli/query.go
* fix test
* fix lint
* fix lint
* add handler/msgs/client
* rm relay
* finalize rebase on 23 root/path sep
* fix lint, fix syntax
* fix querying
* extract out context withstore
* fix 02-client test
* fix 23-commitment test
* add query in progress
* rm freebase, reformat query
* add cli/handler/msg in progress
* add cli/msg/handler
* add CLIQuery, fix tests
* fix golangci
* add docs in progre
* add comments
* add comments
* Apply suggestions from code review
Co-Authored-By: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
* add comments in progress
* add comments
* fix comment
* add comments in progress
* recover IntEncoding scheme for integer
* add uint tests, don't use codec in custom types
* finalize merge
* add godoc
* add godoc in progress
* reformat test
* rm XXX
* add godoc
* modify store
* add query
* update query.go
* update query.go
* cli refactor in progress
* cli refactor in progress
* add Query to boolean.go
* fix key
* fix cli / merkle test
* godoc cleanup
* godoc cleanup
* godoc cleanup
* godoc cleanup
* godoc cleanup
* fix test
* fix client
* merge from ics04 branch
* merge from ics04 branch
* merge from ics04 branch
* merge from ics04 branch
* fix lint
* Apply suggestions from code review
Co-Authored-By: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
* applying review in progress
* apply review - make querier interface
* fix dependency
* fix dependency
* revise querier interface to work both on cli & store
* revise querier interface to work both on cli & store
* reflect downstream change
* fix cli
* reflect downstream changes
* rm commented lines
* address review in progress
* address review, rm cleanup/closing
* rename Path -> Prefix
* Store accessor upstream changes (#5119 )
* Store accessor upstream changes (#5119 )
* add comments, reformat merkle querier
* rm merkle/utils
* ICS 23 upstream changes (#5120 )
* ICS 23 upstream changes (#5120 )
* update Value
* update test
* fix
* ICS 02 upstream changes (#5122 )
* ICS 02 upstream changes (#5122 )
* ICS 03 upstream changes (#5123 )
* ICS 03 upstream changes (#5123 )
* cleanup types and submodule
* more cleanup and godocs
* remove counterPartyManager/State and cleanup
* implement SubmitMisbehaviour and refactor
* errors
* events
* fix test
* refactors
* WIP refactor ICS03
* remove Mapping
* remove store accessors
* proposed refactor
* remove store accessors from ICS02
* refactor queriers, handler and clean keeper
* logger and tx long description
* ineffassign
* Apply suggestions from code review
Co-Authored-By: Jack Zampolin <jack.zampolin@gmail.com>
* Apply suggestions from code review
Co-Authored-By: Jack Zampolin <jack.zampolin@gmail.com>
* remove store accessors
* refactor handshake to update it to the latest ICS03 spec
* update handler and msgs
* add verification functions
* update verification
* ICS02 module.go
* top level x/ibc structure
* update connection queries
* update connection tx
* remove extra files
* update expected client keeper and export verification funcs
* Update x/ibc/02-client/client/cli/query.go
Co-Authored-By: Jack Zampolin <jack.zampolin@gmail.com>
* Update x/ibc/02-client/types/tendermint/consensus_state.go
Co-Authored-By: Jack Zampolin <jack.zampolin@gmail.com>
* address some of the review comments
* resolve some TODOs and address comments from review
* update connection versioning
* minor error updates
* minor UX improvements
* rename pkg
* fixes
* refactor ICS23
* cleanup types
* rename pkg and fix import
* implement batch verification
* gosimple suggestion
* various fixes; remove legacy tests; remove commitment path query
* alias
* minor updates from ICS23
* renaming
* update verification and rename root funcs
* move querier to x/ibc
* update query.go to use 'custom/...' query path
* add tests
* ICS 24 Implementation (#5229 )
* add validation functions
* validate path in ics-23
* address @fede comments
* move errors into host package
* flatten ICS23 structure
* fix ApplyPrefix
* updates from ICS23 and ICS24
* msg.ValidateBasic and ADR09 evidence interface
* complete types testing
* delete empty test file
* remove ibc errors from core error package
* custom JSON marshaling; msg.ValidateBasic; renaming of variables
* minor update
* custom JSON marshaling
* minor changes on commitment types
* R4R - Store consensus state correctly (#5242 )
* store consensus state correctly
* fix client example
* update alias
* update alias
* implement ics25
* update comment
* refactor method name
* fix file name
* add test case
* refactor code
* refactor code
* blocked the consensusState check
* refactor code
* fix golangci comments
* refactor testcase
* replace rootMultiStore with simApp
* remove unless code
* remove unless code & refactor test case
* refactor testcase
* goimports code
* clean up
* Add unit tests for ICS04 (#5286 )
* fix test
* Apply suggestions from code review
Co-Authored-By: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
* applying review in progress
* apply review - make querier interface
* fix cli errors
* fix dependency
* fix dependency
* reflect method name change
* revise querier interface to work both on cli & store
* revise querier interface to work both on cli & store
* revise querier interface to work both on cli & store
* reflect downstream change
* fix cli
* reflect downstream changes
* reflect downstream changes
* fix from address in tx cli
* fix cli in progress(squash later)
* fix cli
* remove timeout, add channel cli
* fix golangci
* fix cli
* Clean up
* fix mock cli in progress
* finalize cleanup, mock cli wip
* add cli for mocksend
* fix handler
* rm commented lines
* address review in progress
* address review, rm cleanup/closing
* rename mock packages
* fix interface for gaia
* rename Path -> Prefix
* Store accessor upstream changes (#5119 )
* Store accessor upstream changes (#5119 )
* add comments, reformat merkle querier
* rm merkle/utils
* ICS 23 upstream changes (#5120 )
* ICS 23 upstream changes (#5120 )
* update Value
* update test
* fix
* ICS 02 upstream changes (#5122 )
* ICS 02 upstream changes (#5122 )
* ICS 03 upstream changes (#5123 )
* ICS 03 upstream changes (#5123 )
* update test
* cleanup types and submodule
* more cleanup and godocs
* remove counterPartyManager/State and cleanup
* implement SubmitMisbehaviour and refactor
* errors
* events
* fix test
* refactors
* WIP refactor ICS03
* remove Mapping
* remove store accessors
* proposed refactor
* remove store accessors from ICS02
* refactor queriers, handler and clean keeper
* logger and tx long description
* ineffassign
* Apply suggestions from code review
Co-Authored-By: Jack Zampolin <jack.zampolin@gmail.com>
* Apply suggestions from code review
Co-Authored-By: Jack Zampolin <jack.zampolin@gmail.com>
* remove store accessors
* refactor handshake to update it to the latest ICS03 spec
* update handler and msgs
* add verification functions
* update verification
* ICS02 module.go
* top level x/ibc structure
* update connection queries
* update connection tx
* remove extra files
* refactor: remove store accessors, update keeper and types to match spec (WIP)
* update handshake and packet
* implement packet timeouts
* implement send and receive packet
* implement packet ACK
* update handler
* add channel errors
* channel querier
* update expected client keeper and export verification funcs
* ICS 05 Implementation
* release port and godocs
* Update x/ibc/02-client/client/cli/query.go
Co-Authored-By: Jack Zampolin <jack.zampolin@gmail.com>
* Update x/ibc/02-client/types/tendermint/consensus_state.go
Co-Authored-By: Jack Zampolin <jack.zampolin@gmail.com>
* address some of the review comments
* resolve some TODOs and address comments from review
* update connection versioning
* minor error updates
* update ICS04 with downstream changes
* Implement tx cli actions
* add MsgSendPacket handler; msg validation, errors and events
* update errors and add port Keeper to ibc Keeper
* minor UX improvements
* rename pkg
* fixes
* refactor ICS23
* cleanup types
* ICS 5 updates (#5222 )
* Validate port identifiers
* Refactor to static bind
* Add comments
* Add 'GetPorts' query function
* rename pkg and fix import
* implement batch verification
* gosimple suggestion
* various fixes; remove legacy tests; remove commitment path query
* alias
* minor updates from ICS23
* renaming
* update verification and rename root funcs
* rm legacy tests; add query proofs support
* remove capability key generation and authentication logic
* move querier to x/ibc
* update query.go to use 'custom/...' query path
* add tests
* ICS 24 Implementation (#5229 )
* add validation functions
* validate path in ics-23
* address @fede comments
* move errors into host package
* flatten ICS23 structure
* fix ApplyPrefix
* updates from ICS23 and ICS24
* msg.ValidateBasic and ADR09 evidence interface
* complete types testing
* delete empty test file
* remove ibc errors from core error package
* custom JSON marshaling; msg.ValidateBasic; renaming of variables
* minor update
* custom JSON marshaling
* use host validation for port ids
* downstream changes; custom marshal JSON; msg validation, and update errors
* update errors and aliases
* update msg validation and CLI UX
* minor changes on commitment types
* fix channel and packet check (#5243 )
* R4R - Store consensus state correctly (#5242 )
* store consensus state correctly
* fix client example
* update alias
* update alias
* update alias and keeper.GetPort()
* authenticate port ID; remove send packet msg from CLI
* comment out handlers
* add ibc module to simapp
* ICS20 implementation (#5204 )
* add ibc bank mock
* modify handler
* import channel
* add receiving logic
* add cli proof handling
* modify cli
* modify receiver type
* modify errcode
* optimize codes
* add denom prefix when source is true
* refactor code
* error return
* switch ibc antehandler to decorator pattern
* fix name/comment
* ICS 20 implementation (#5250 )
* move ics20 code to 20-transfer
* clean code
* fix compiling error
* add transfer module
* address ICS20 comments from review
* add routing callbacks
* clean code
* add missing err return
* modify err type
* modify err type
* add supply handling
* modify proof type
* add comments for msg and packet data
* add timeout supply handling
* modify module account name
* use supply keeper for burn and mint coins
* restructure keeper
* update alias and module.go
* golangci linter
* add ics20 handler to IBC handler
* update callbacks
* update ICS20 escrow address
* fix querier routes
* fix create client cli
* minor updates
* ibc querier test
* Refactor ibc/mock/bank into ICS 20 (#5264 )
* Most of code port from mock module to ICS 20
* A few minor fixes
* Apply suggestions from code review
Co-Authored-By: Bot from GolangCI <42910462+golangcibot@users.noreply.github.com>
* Fix suggestions from autolinter
* Apply suggestions from code review
Co-Authored-By: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
* Fix order of messages
* Add invalid height error code, check non-nil proof
* Fix linter error
* Return the underlying error
* Tendermint starts at height 1
* Apply suggestions from code review
* setup ics20 test suite
* add event to MsgRecvPacket
* update ibc keeper test to use test suite
* Add handshake commands
* WIP connection handshake
* WIP Connection Handshake
* Add cliCtx.WaitForNBlocks
* fix connection handshake in progress
* fix connection handshake in progress
* add channel unit test
* add more channel tests
* fix channel test
* refactor channel test
* add capability test for channel
* make channel testing work
* optimize channel test
* delete types/errors.go
* modify capability test
* uncomment
* add msg tests for channel
* fix port capability store
* fix channel test
* use simapp
* modify channel test
* refactor channel msg test
* go fmt
* IBC alpha general cleanup (#5291 )
* remove prefix from keeper; update client queries; address ICS02 comments from @cwgoes
* add proof for root query
* golangci
* remove hardcoded bind port logic
* space
* WIP: register errors
* register errors; make format
* use new instead of register; unescape path
* golangci
* Fix codec issue in ics23
* Modify codec registration style to match previous working state
* write port tests
* ICS-02: Keeper Tests (#5329 )
* add keeper tests
* fix tendermint tests
* Fix proof verification; remove store key prefixes; add additional path validations (#5313 )
* fix poof verify
* minor cleanup
* fix tests
* remove key prefixes
* fix tests
* Add ICS20 tests (#5308 )
* add ics20 test
* delete debug
* fix ics20 test
* revert and modify
* optimize test
* add ics20 msg test
* fix test
* add packet tests and more msgs tests
* add ReceivePacket and callbacks tests
* fix callbacks test
* add handler tests for ics20
* fix handler tests
* minor cleanup
* test all positive amounts
* update test suite NotNil to Error
* fix ics20 tests
* expected error
* Add IBC REST endpoints (#5310 )
* add rest framework
* add rest endpoints for ibc connection
* add rest endpoints for ibc client
* add rest endpoints for ibc channel
* modify ibc rest api
* add rest endpoints for ibc transfer
* fix query route
* fix receive packet
* fix query client state api
* use sub module name instead of icsxx
* use const for prove judgement
* modify ibc rest api
* add api docs to swagger
* add ibc config
* fix proof path in swagger
* return query result proof
* update swagger docs
* parse prove
* clean up
* fix ibc rest api and swagger docs
* fix host validate
* fix typo
* add submitMisbehaviour error response in swagger
* fix rest queryRoot and swagger doc
* add response comments for each REST functions
* fix rest function comments
* fix IBC proofs (#5351 )
* fix ICS02 proofs
* fix ICS03 proofs
* fix ICS04 proofs
* fix ICS20 proofs
* make format
* fix build; comment handshakes
* ICS-2 Implement Misbehavior (#5321 )
* ibc client evidence route
* split evidence from misbehaviour
* clean up client events
* test misbehaviour and evidence
* remove comments
* remove frozen comments from demo
* Update x/ibc/02-client/types/tendermint/evidence_test.go
Co-Authored-By: Aditya <adityasripal@gmail.com>
* change evidence to detect malicious chain
* remove unnecessary sort
* fix evidence and persist committers to check misbehaviour
* minor fixes and remove incorrect tests
* add evidence tests
* remove debug statements
* cleanup evidence test
* start misbehaviour tests
* fix nondeterministic bug
* add same height and next height checks in misbehaviour
* fix bugs
* apply fede review suggestions
* finish code review changes
* fix GetCommitter and write keeper-level misbehaviour tests
* remove incorrect special case checking
* save
* final fixes
* save
* fix conflict
* fix conflicts and add back submit misbehaviour msg
* Apply suggestions from code review
Co-Authored-By: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
* save
* add godocs and fix test
* fix test panics in other modules
* Update x/ibc/02-client/keeper/client.go
Co-Authored-By: Bot from GolangCI <42910462+golangcibot@users.noreply.github.com>
* add back aliases
* Misc ibc fixes (#5357 )
* fix cli ExactArgs
* remove full handshakes
* rm dup flag
* fix error handling
* Implement Query Committer methods in ICS-02 (#5402 )
* add query methods for committers in ICS-02
* Update x/ibc/02-client/keeper/keeper.go
* add REST docs
* fix test
* IBC UX improvements (#5364 )
* ICS02 iterators
* ICS03 iterators
* ICS04 iterators
* ICS02 client updates
* CLI connections
* setup queriers
* clean up queriers
* add tests
* IBC top-level querier tests
* update ICS02 keys
* update ICS03 keys
* make format
* update ICS04 keys
* fix a few tests
* fix ICS20 tests
* update keys
* fix ICS02 queries (#5425 )
* fix CLI JSON param unmarshaling (#5431 )
* Fix inconsistent string lookup functions (#5437 )
* fix inconsistent string lookup functions
* test client type and ordering
* channel and connection state tests
* address golangcibot comments
* fix test
* Update x/ibc error handling (#5462 )
* Merge PR #5428 : Add mod, exponentiation for uint
* Modified examples in distribution module (#5441 )
* Merge PR #5442 : Remove of the client/alias.go
* Merge PR #5445 : Mock rpcclient in tests for votes pagination
* Merge PR #5435 : Added iterator that allows to read only requested values
* Merge PR #5427 : Remove code duplication in x/auth/client/cli
* Merge PR #5421 : Refactor Error Handling
* update x/ibc error handling
* update ICS24 and ICS02 errors
* ICS03, ICS23 and common errors
* updates from master and errors from ICS04
* build
* fix ics20 tests
* fix tests
* golangcibot fixes
Co-authored-by: Kevin Davis <karzak@users.noreply.github.com>
Co-authored-by: kaustubhkapatral <54210167+kaustubhkapatral@users.noreply.github.com>
Co-authored-by: Ferenc Fabian <qwer.kocka@gmail.com>
Co-authored-by: Dmitry Shulyak <yashulyak@gmail.com>
Co-authored-by: Alessio Treglia <quadrispro@ubuntu.com>
Co-authored-by: Alexander Bezobchuk <alexanderbez@users.noreply.github.com>
* ADR 015 Implementation (#5401 )
* implement in progress
* rm unneccessary change under simapp, modify baseapp for codetxbreak
* fix test in progress
* fix test error
* fix golangci
* address minor comments
* mv antehandler to ante/, address comments
* fix GetCommitment => GetData, fix syntax
* checkout types/ to ibc-alpha
* checkout to origin/ibc-alpha
* fix branch problem
* fix syntax error
* recover PacketI interface
* mv recvpacket rest from 20 -> 04
* address minor comments
* Apply suggestions from code review
Co-Authored-By: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
* rm wrong files
* Apply suggestions from code review
* PacketDataI field is now named, not embed
* add acknowledgement hashing
* rename finalization functiosn
* Apply suggestions from code review
Co-Authored-By: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
* Rename GetCommitment() to GetBytes()
* Add recv sequence incr to RecvPacket()
* Revert but where is PacketExecuted() called
* Call PacketExecuted(), check seq in RecvPacket()
* The port is called "bank"
* Apply suggestions from code review
Co-Authored-By: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
* Update simapp/app.go
Co-Authored-By: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
* Remove omitempty
* Add godoc
* Move events
* set ProofVerificationDecorator on AnteHandler
* Apply suggestions from code review
Co-Authored-By: Bot from GolangCI <42910462+golangcibot@users.noreply.github.com>
* format
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
Co-authored-by: Christopher Goes <cwgoes@pluranimity.org>
Co-authored-by: Bot from GolangCI <42910462+golangcibot@users.noreply.github.com>
* Fix build errors
* remove tmcmn instance
* remove tmcmn instance
* Fix compliation errors
* Fix build errors
* Fix build errors
* ICS07 Tendermint Client implementation (#5485 )
* implement ICS07
* build
* update tests and cleanup
* x/ibc/02-client/types: remove misbehaviour in favor of evidence
* remove root query, update queriers, implement verification funcs
* remove committer; cleanup
* move keys to ibc/types
* fix paths
* update ICS03 connection verification
* move order and states to exported pkg
* update ICS04 to latest spec
* fix build
* move ics02 types/errors package to /types
* update a few tests
* update tests; fix codec registration
* minor changes from code review
* ibc/client/types: fix tests
* ibc/02-client/keeper: fix tests
* ibc/03-connection/keeper: begin tests for verify.go
* ibc/23-commitment: add IsEmpty() to Prefix, Path and Proof
* address comments from review
* add tests for evidence
* x/ibc/07-tendermint: add tests for consensus state, header and update
* ibc/07-tendermint: fix verification panic and add tests
* ibc/07-tendermint: add failure test cases
* x/ibc/03-connection/keeper: add verification tests for failing cases
* remove unused queriers
* Update ICS 7 tests (#5556 )
* Update ICS 7 tests
* Fix one problem
* Also set consensus state for height 1
* Apply same fixes to ICS 4 tests
* Remove unnecessary change
* Fix ante tests; remove printfs
* Remove printf
* Update x/ibc/ante/ante_test.go
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
* add TODOs for ADR 03 dynamic store
* add tests for msgs and packet (#5559 )
* Add skeleton for ValidateBasic tests
* Move tests; basic one passes
* Add more ValidateBasic tests
* Add more ValidateBasic testcases
* Fix minor typo
* Add `ValidateBasic` tests for Packet
* Move to packet_test.go
* use app.Commit for tests
* update verify.go
* Fix all ICS 07 Tests (#5565 )
* ICS 07 Debugging
* WIP Debugging
* Foo bar baz, baz bar foo, 🤷♂️
* cleanup print statements
* cleanup verification test
* add return err for proof verification
* cleanup; start handshake testing
* connection handshake tests
* scopelint
* WIP Test refactor
* fix ICS03 tests
* fix ICS04 tests
* nolint
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
* cleanup comments and add a few tests
* typo
Co-authored-by: Christopher Goes <cwgoes@pluranimity.org>
Co-authored-by: Jack Zampolin <jack.zampolin@gmail.com>
* fix build
* IBC historical info support (#5475 )
* implement GetConsensusState
* introspect past consensus states on ICS03 handshake
* implement ToTmValidator staking util function
* add test cases
* update tests
* Fix various compile erros
* fix historical info
* fix dep cycle
* Fix golint issues
* Fix proto docs lint fail
* move consensus state query downstream to ICS03
* remove unused funcs on expected keeper
* update tests and move get consensus state to ICS03
* increase cov for verification funcs
* fix tests
* interfacer fix
* fix expected keeper
* remove TODOs
Co-authored-by: Jack Zampolin <jack.zampolin@gmail.com>
* cleanup ibc-alpha diff with master
* Add bank alias for gaia
* Moar bank alias gaia
* Moar bank alias gaia
* Fix query all clients
* update to current Tendermint master
* TxSearchMock: add orderBy field to TxSearch method
* fix build errors
* Small changes for compilation of gaia
* Small changes for compilation of gaia
* Add 07-tm.Header.ConsensusState() to make conversions easy
* Add additional IBC Channel Tests (#5578 )
* Add stubbed out tests
* one working testcase and mocked packet types
* Finish TestSendPacket
* Move mocked proofs to ibc/types and finish TestRecvPacket
* Implement TestPacketExecuted
* WIP TestAckPacket
* Start on timeout tests, 1 passing
* WIP Tests
* first cleanup
* test send transfer
* add packet tests
* fixes and more tests
* finish tests
* Update x/ibc/04-channel/keeper/packet.go
* golangcibot fixes
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
Co-authored-by: Christopher Goes <cwgoes@pluranimity.org>
* merge master
* ICS07 follow up changes (#5606 )
* ADR07 follow up changes
* add assertion checks
* update ICS02 tests
* update ICS07 tests
* add trusting and ubd period to msg
* tests
* more test updates
* ICS07 follow ups (#5631 )
* refactor tendermint package to move msgs here
* fix rest of package to accomadate 07 refactor
* added GetHeight to ConsensusState and moved clientstate struct creation to 07-tendermint
* start work on making misbehavior retrieve consensusState LTE misbehavior
* allow misbehavior submission at height not equal to persisted consensusState
* optimize submitMisbehavior by erroring earlier
* cleanup misbehavior and propose lazy fix
* fix bug
* Update x/ibc/02-client/keeper/client.go
Co-Authored-By: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
* address fede review
* add chain-id into clientstate
* address necessary fede review
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
Co-authored-by: Aditya <adityasripal@gmail.com>
* IBC SDK specification (#5426 )
* IBC SDK specification
* update events
* add implementation mapping
* minor additions to readme
* fix conflicts
* add missing ADRs, modules and ICS
* fix build
* Merge PR #5670 : Fix Packet Timeout Bug
* add destination height to MsgSendTransger
* quick fix
* Add defensive checks before setting param keytables in keeprs
* ICS 20 Cleanup and Tests (#5577 )
* Add comments, remove unused code and attempt to point to places where the spec is being implemented
* close channel when transfer fails
* rename packer data transfer to align to spec; refactor table tests
* ICS 20 implementation cleanup work (#5602 )
* Simulation docs (#5033 )
* simulation docs
* update docs with the latest simulation changes
* minor imporvments
* clean up of simulation.md
* expand section on weights
* minor reword
* minor wording fix
Co-authored-by: Marko <marbar3778@yahoo.com>
* Merge PR #5597 : Include Amount in Complete Unbonding/Redelegation Events
* Add bank alias for gaia
* Moar bank alias gaia
* Moar bank alias gaia
* Call `TimeoutExecuted`, add wrappers
* Remove unused `MsgRecvPacket`
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
Co-authored-by: Marko <marbar3778@yahoo.com>
Co-authored-by: Alexander Bezobchuk <alexanderbez@users.noreply.github.com>
Co-authored-by: Jack Zampolin <jack.zampolin@gmail.com>
* Merge PR #5603 : Remove acknowledgement interface in favour of []byte
* fixes and cleanup
* spec compliance
* refactor relay prefixes and tests
* Fix test compilation
* cleanup; add notes and additional test case
* Receive transfer test
* Apply suggestions from code review
Co-Authored-By: Bot from GolangCI <42910462+golangcibot@users.noreply.github.com>
* Fix autolinter application
* Add testcase with incorrect prefix
* golangcibot fixes
* delete extra comment
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
Co-authored-by: Christopher Goes <cwgoes@pluranimity.org>
Co-authored-by: Marko <marbar3778@yahoo.com>
Co-authored-by: Alexander Bezobchuk <alexanderbez@users.noreply.github.com>
Co-authored-by: Bot from GolangCI <42910462+golangcibot@users.noreply.github.com>
* Merge PR #5666 : Use Tendermint lite client verification
* Disambiguate error codes
* Fix binary marshalling for state storage
* readd MsgSubmitClientMisbehaviour
* Fix double flag registration
* ICS23 refactor (#5710 )
* ICS23 restructure directories
* more fixes
* format
* Merge PR #5711 : Switch mock proofs to real proofs
* Add key, path, value to mock proofs
* Also alter mock types (why are there duplicates)
* Remove mock proofs from handshake_test.go
* Use actual proofs
* Try to fix historical info, no luck
* Have test-cases produce consensus heights
* Fix consensus height / proof height difference in verifyClientConsensusState
* Bug fixes contd.
* Fix some identifier issues
* `TestConnOpenConfirm` now works
* further on proof
* fix debugger print statement
* IT PASSES
* revert identifier changes
* refactor query proof to generate proofs from either chain
* fix ack and confirm
* Remove temporary break
* fix connection and channel verify tests
* fix everything but verify client consensusstate
* fix all verify tests
* fix ics07 tests
* fix handshake tests
* fix packet tests
* fix timeout tests
Co-authored-by: Aditya Sripal <adityasripal@gmail.com>
Co-authored-by: Federico Kunze <federico.kunze94@gmail.com>
* Try to fix store decoding issue
* Sim issue update
* add error in msg
* remove next validator set from ibctmtypes.Header
* remove warning msg
* Make IBC updating more robust
* blh
* bump tm dependency
* remove redundant clockdrift correction
* remove blh commit
* fix test build failures
* Change time from PST to UTC
* Merge PR #5770 : Update error message in connection keeper
* Merge PR #5774 : Debug timestamp issues
* Merge PR #5786 : Fix MsgTransfer routing
* Fix test-case
* register MsgPacket
* Flip boolean
* emit packet event on SendPacket
* Fix attribute setting
* Implement in-memory KVStore
* Start keeper and types
* Add codec
* Add keys logic
* Update types
* Update keeper
* Implement NewCapability
* Implement InitializeAndSeal
* Update simapp
* Implement GetCapability
* Add logging for new and claimed caps
* Call InitializeAndSeal in SimApp
* Update keeper semantics + unit tests
* Use big endian
* More unit tests
* Increase keeper test coverage
* Remove TODO
* Add module doc
* Update doc
* Apply suggestions from code review
Co-Authored-By: Aditya <adityasripal@gmail.com>
* Update NewCapability godoc
* Clarify owner
* Add forgery test case to TestAuthenticateCapability
* Format doc
* Update to tm@v0.33.2
* Update ADR
* Explicitly take pointer in FwdCapabilityKey
* Update set to be logn
* Update app module
* Lint
* Fix broken test after packet format changed
* Add stub and unit tests for ReleaseCapability
* Finish implementation
* Add test case to TestAuthenticateCapability for releasing a cap
* remove swagger files from ibc module (#5893 )
* Move IBC packet data interpretation to the application module (#5890 )
* fix: move IBC packet data interpretation to the application module
This also adds a channelexported.NewOpaquePacketData(rawBytes)
implementation to assist apps in being able to manipulate the
raw packet data using the codec layer.
* feat: use an internal-to-module PacketDataI type
This one only has a GetBytes() method, which is implemented by
OpaquePacketData.
* fix: remove OpaquePacketData
No need to wrap the []byte packet.GetData(). If the caller wants
it, they can use it directly.
* docs: update adr-015
* fix: put the TimeoutHeight back into the packet commitment
* refactor: simplify unmarshalling of transfer packet
* docs: update for new unmarshal steps
* fix: clean up usage of sdkerrors.Wrapf
* Apply suggestions from code review
Co-Authored-By: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
* chore: remove unnecessary "encoding/binary" import
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
* fix ibc-alpha sims (#5909 )
* fix some simulations
* fix HistoricalInfo sim decoders
* add staking sim decoder test case for HistInfo
* Merge PR #5901 : Add & update IBC queriers for relayer use
* Add identifier to connection responses (ref #5829 )
* Update querier as well
* Fix test-case
* Update for consistency
* Add querier for connection channels; fix linter
* Fix build (?)
* Add JSON & Yaml tags
* Add tags
* Add identifiers to channels as well
* fix test
* Merge PR #5914 : x/capability: Fix Object Capability Model
* Merge PR #5918 : Remove source field from ICS 20 packet & message types per latest spec
* fix ics20 client args (#5924 )
* Merge PR #5930 : Add GetChainID to ClientState interface
* Merge PR #5925 : Add additional events to x/ibc
* Migrate x/capability to Protobuf (#5926 )
* migrate x/capability to protobuf
* fixes
* format
* remove capability from codec std
* return pointer for getOwners
* remove &
* Update x/capability/keeper/keeper.go
Co-Authored-By: Bot from GolangCI <42910462+golangcibot@users.noreply.github.com>
* rename remove Capability interface; rename CapabilityKey -> Capaility; cc @cwgoes
* x/capability: remove RegisterCapabilityTypeCodec and seal amino cdc
Co-authored-by: Alexander Bezobchuk <alexanderbez@users.noreply.github.com>
Co-authored-by: Bot from GolangCI <42910462+golangcibot@users.noreply.github.com>
* Merge PR #5939 : Unmarshal packets as JSON
* Merge PR #5888 : Dynamic Capabilities with Routing
* cleanup ibc-alpha (#5945 )
* cleanup ibc-alpha
* remove HasKeyTable()
* add preexisting checks
* undo remove checks
* x/staking: import and export HistoricalInfo
* staking/types: add HistoricalInfo to GenesisState
* changelog
* add staking module to app BeginBlockers
* remove JSON files
* address comments from review
* cleanup ibc-alpha
* fix ibc-alpha lint (#5959 )
* x/ibc: changelog (#5960 )
* x/ibc: changelog
* add reference to the spec
* Merge PR #5954 : Bind Transfer Port on InitChain
* Bind transfer port in InitChain
* push fixes
* address @fedekunze review
* Apply suggestions from code review
* lint
Co-authored-by: Jack Zampolin <jack.zampolin@gmail.com>
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
Co-authored-by: Federico Kunze <federico.kunze94@gmail.com>
Co-authored-by: Joon <torecursedivine@gmail.com>
Co-authored-by: Christopher Goes <cwgoes@pluranimity.org>
Co-authored-by: vincent <vincent.ch.cn@gmail.com>
Co-authored-by: Jack Zampolin <jack.zampolin@gmail.com>
Co-authored-by: Aditya Sripal <adityasripal@gmail.com>
Co-authored-by: Kevin Davis <karzak@users.noreply.github.com>
Co-authored-by: kaustubhkapatral <54210167+kaustubhkapatral@users.noreply.github.com>
Co-authored-by: Ferenc Fabian <qwer.kocka@gmail.com>
Co-authored-by: Dmitry Shulyak <yashulyak@gmail.com>
Co-authored-by: Alessio Treglia <quadrispro@ubuntu.com>
Co-authored-by: Alexander Bezobchuk <alexanderbez@users.noreply.github.com>
Co-authored-by: Bot from GolangCI <42910462+golangcibot@users.noreply.github.com>
Co-authored-by: Anton Kaliaev <anton.kalyaev@gmail.com>
Co-authored-by: Marko <marbar3778@yahoo.com>
Co-authored-by: Aleksandr Bezobchuk <aleks.bezobchuk@gmail.com>
Co-authored-by: Michael FIG <michael+github@fig.org>
Co-authored-by: Segue <huoda.china@163.com>
2020-04-08 20:57:52 -04:00
Aaron Craelius
Anil Kumar Kammari
Marie
atheeshp
Marko
Amaury Martiny
Cory
Alexander Bezobchuk
dauTT
SaReN
Federico Kunze
dauTT
Jonathan Gimeno
Jack Zampolin
Aditya