7cd25abb87
Proto Tx with Any ( #7276 )
...
* WIP on protobuf keys
* Use Type() and Bytes() in sr25519 pub key Equals
* Add tests
* Add few more tests
* Update other pub/priv key types Equals
* Fix PrivKey's Sign method
* Rename variables in tests
* Fix infinite recursive calls
* Use tm ed25519 keys
* Add Sign and VerifySignature tests
* Remove ed25519 and sr25519 references
* proto linting
* Add proto crypto file
* Implement some of the new multisig proto type methods
* Add tests for MultisigThresholdPubKey
* Add tests for pubkey pb/amino conversion functions
* Move crypto types.go and register new proto pubkeys
* Add missing pointer ref
* Address review comments
* panic in MultisigThresholdPubKey VerifySignature
* Use internal crypto.PubKey in multisig
* Add tests for MultisigThresholdPubKey VerifyMultisignature
* Only keep LegacyAminoMultisigThresholdPubKey and move to proto keys to v1
* Remove conversion functions and introduce internal PubKey type
* Override Amino marshaling for proto pubkeys
* Merge master
* Make proto-gen
* Start removal of old PubKeyMultisigThreshold references
* Fix tests
* Fix solomachine
* Fix ante handler tests
* Pull latest go-amino
* Remove ed25519
* Remove old secp256k1 PubKey and PrivKey
* Uncomment test case
* Fix linting issues
* More linting
* Revert tests keys values
* Add Amino overrides to proto keys
* Add pubkey test
* Fix tests
* Use threshold isntead of K
* Standardize Type
* Revert standardize types commit
* Fix build
* Fix lint
* Fix lint
* Add comment
* Register crypto.PubKey
* Add empty key in BuildSimTx
* Simplify proto names
* Unpack interfaces for signing desc
* Fix IBC tests?
* Format proto
* Use secp256k1 in ibc
* Fixed merge issues
* Uncomment tests
* Update x/ibc/testing/solomachine.go
* UnpackInterfaces for solomachine types
* Remove old multisig
* Add amino marshal for multisig
* Fix lint
* Correctly register amino
* One test left!
* Remove old struct
* Fix test
* Fix test
* Unpack into tmcrypto
* Remove old threshold pubkey tests
* Fix register amino
* Fix lint
* Use sdk crypto PubKey in multisig UnpackInterfaces
* Potential fix?
* Register LegacyAminoPubKey
* Register our own PubKey
* Register tmcrypto PubKey
* Register both PubKeys
* Register interfaces in test
* Refactor fiels
* Add comments
* Use anil's suggestion
* Add norace back
* Check nil
* Address comments
* FIx lint
* Add tests for solomachine unpack interfaces
* Fix query tx by hash
* Better name in amino register
* Display StdTx instead of proto Tx
* Remove useless check
Co-authored-by: Aaron Craelius <aaronc@users.noreply.github.com>
Co-authored-by: blushi <marie.gauthier63@gmail.com>
Co-authored-by: Alexander Bezobchuk <alexanderbez@users.noreply.github.com>
Co-authored-by: colin axnér <25233464+colin-axner@users.noreply.github.com>
2020-09-21 16:48:28 +00:00
984c2d4179
Retrieve Epoch from ChainID ( #7280 )
...
* add functions to parse epoch from height
* remove 0 epoch hardcoding
* fix tendermint tests
* fix tests
* start update docs
* progress
* better parsing of chainID
* fix update and misbehaviour logic and add tests
* update docs
* docfix
* Apply suggestions from code review
Co-authored-by: colin axnér <25233464+colin-axner@users.noreply.github.com>
* Update x/ibc/07-tendermint/types/misbehaviour_handle_test.go
* change self checks to use epochs
* address rest of reviews
* rename epoch number to version in docs
* wrap up rest of TODOs
* Update x/ibc/02-client/genesis.go
* add self validate test
* Apply suggestions from code review
Co-authored-by: colin axnér <25233464+colin-axner@users.noreply.github.com>
* fix godoc
Co-authored-by: colin axnér <25233464+colin-axner@users.noreply.github.com>
2020-09-15 21:09:48 +00:00
ec74416276
x/ibc: move solo machine sequence to client state ( #7271 )
...
* update proto
* move solo machine sequence to client state
Co-authored-by: Christopher Goes <cwgoes@pluranimity.org>
2020-09-09 12:14:11 -03:00
d61fa43108
x/ibc: mock own privValidator rather than relying on the one from tendermint ( #7241 )
...
* 1) Create PrivValidator mock in x/ibc/testing/mock/privval.go
2) Adjust tests accordingly
* Add tests
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
2020-09-07 21:44:23 +00:00
64b6bb5270
rename RegisterCodec to RegisterLegacyAminoCodec ( #7243 )
...
* rename RegisterCodec to RegisterLegacyAminoCodec
* Add changelog
* gofmt
* rename codec.New() to codec.NewLegacyAmino()
* Add change log
* Update CHANGELOG.md
Co-authored-by: Amaury Martiny <amaury.martiny@protonmail.com>
* Fix
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
Co-authored-by: Amaury Martiny <amaury.martiny@protonmail.com>
2020-09-07 14:47:12 +00:00
2f25c9a0d8
x/ibc: solo machine signature format ( #7237 )
...
* x/ibc: solo machine signature format
* update tests and verification
* diversifier updates
* update tests
* fix lint
* Update x/ibc/light-clients/solomachine/types/header_test.go
Co-authored-by: Aditya <adityasripal@gmail.com>
* Apply suggestions from code review
Co-authored-by: colin axnér <25233464+colin-axner@users.noreply.github.com>
* update test
* misbehaviour sign bytes
* consensus state tests
* fix tests
* more fixes
Co-authored-by: Aditya <adityasripal@gmail.com>
Co-authored-by: colin axnér <25233464+colin-axner@users.noreply.github.com>
2020-09-07 12:46:48 +00:00
b52ffa08e1
Implement ADR 026 ( #7029 )
...
* Add allow_governance_override_after_expiry flag to tendermint NewCreateClientCmd
* 1) Add LatestTimestamp to ClientState struct by adding a new attribute latest_timestamp to the message ClientState in proto/ibc/tendermint/tendermint.proto
2) Autogenerate x/ibc/07-tendermint/types/tendermint.pb.go by running 'make proto-gen'. Strangely, as a side effect x/distribution/types/genesis.pb.go, x/evidence/types/genesis.pb.go were also modified by the command 'make proto-gen'
3) Add Expired() function
* Fix tests
* 1) Add allow_governance_override_after_expiry flag to tendemint clientStatus
2) Add allow_governance_override_after_misbehaviour flag to tendermint ClientStatus
* Cosmetic changes
* Fix tests
* Add Unfreeze function
* Add new ClientUpdateProposal type
* Add minor fixes
* Add NewClientUpdateProposalHandler unit tests
* Fix proto-lint-docker
* Delete x/ibc/07-tendermint/tendermint_test.go
* Follow convention to put signer last in msg function signature
* 1) Add GetLatestTimestamp function to ClientStatus interface
2) Change Expired() signature to Expired(now time.Time)
* 1) Add override flag to UpdateClient function
2) Fix tests
* Refactor HandleClientUpdateProposal
* 1) Extend exported Header interface with MarshalBinaryBare and UnmarshalBinaryBare methods
2) Move ClientUpdateProposal message to from ibc.proto to client.proto
3) Refactoring code
4) Add override flag to UpdateClient method
5) Fix tests
* 1) Uncomment tests and clean up code
2) Add basic validation of the header (ValidateBasic) when the override flag is true
* Cosmetic changes
* Add TODO comments
* Fix header MarshalBinaryBare, UnmarshalBinaryBare by using protobuf encoding/decoding
* Fix proto comments
* Fix override logic
* undo gettimestamp for solo machine and localhost
* add update after proposal func, some major refactoring in progress, various issues addressed
* fix tendermint proposal update handling
* run make proto-gen
* remove timestamp from tendemint client
* fix build issue for tm types
* apply various review comments
* add tests for 02-client functionality
* self review fixes
* typo
* update tests slightly
* update tendermint proposal handling tests
* Update x/ibc/02-client/keeper/proposal.go
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
* Update x/ibc/07-tendermint/types/proposal_handle.go
Co-authored-by: Aditya <adityasripal@gmail.com>
* Update x/ibc/07-tendermint/types/proposal_handle.go
Co-authored-by: Aditya <adityasripal@gmail.com>
* apply most of @fedekunze and some of @AdityaSripal suggestions
* convert test to bools
* update docs and increase code cov
* fix build
* fix typo, remove omitempty
* add switch
* apply @fedekunze latest suggestions
* fix lint
* Update x/ibc/02-client/keeper/proposal_test.go
Co-authored-by: Christopher Goes <cwgoes@pluranimity.org>
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
Co-authored-by: Colin Axner <colinaxner@berkeley.edu>
Co-authored-by: colin axnér <25233464+colin-axner@users.noreply.github.com>
Co-authored-by: Aditya <adityasripal@gmail.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
2020-09-04 20:59:22 +00:00
4f9e31ea21
x/ibc: implement Height interface ( #7211 )
...
* change interfaces
* fix tendermint client interfaces
* fix other clients interfaces
* fix queries
* fix tendermint build
* fix builds of clients
* fix 02-build
* start fixing connection and make queries non-nullable
* fix connection keepers and queries
* fix connection build
* fix channel build
* fix all non-test files
* fix testing build
* cleanup
* lint
* fix timeout height interface
* fix tendermint tests
* fix rest of clients
* fix connection tests
* fix client tests
* fix channel tests
* fix all ibc tests
* fix transfer tests:
* docs
* fix connection query
* Apply suggestions from code review
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
* wrap-up review
Co-authored-by: Jack Zampolin <jack.zampolin@gmail.com>
Co-authored-by: colin axnér <25233464+colin-axner@users.noreply.github.com>
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
2020-09-03 16:23:20 -04:00
979e8144fb
move IBC exported files to one location to avoid circular deps ( #7224 )
...
* move exported files to one location to avoid circular deps
* gofmt
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
2020-09-02 16:38:50 +00:00
0fffaf589b
ibc: modular client messages ( #7160 )
...
* ibc: modular client messages
* more updates
* remove client messages
* fixes
* fix tests
* lint
* Apply suggestions from code review
Co-authored-by: colin axnér <25233464+colin-axner@users.noreply.github.com>
* codec.go tests
* cleanup exported
* MsgCreateClient test
* msg tests
* Apply suggestions from code review
Co-authored-by: colin axnér <25233464+colin-axner@users.noreply.github.com>
* fix tests
* proto files update
* errors
* address comments
* spec changes
* add sanity check test cases
* add additional sanity check
* fix expPass
* fix build and remove unnecessary test since validatebasic is checked in the msg
Co-authored-by: colin axnér <25233464+colin-axner@users.noreply.github.com>
Co-authored-by: Aditya Sripal <adityasripal@gmail.com>
Co-authored-by: Colin Axner <colinaxner@berkeley.edu>
2020-09-01 10:40:31 +00:00
d208d2bed8
Make clients use proto Height ( #7184 )
...
* start using Height in TM client
* fix client tests
* fix client tests
* fix connection tests
* fix rest of tests
* Apply suggestions from code review
Co-authored-by: colin axnér <25233464+colin-axner@users.noreply.github.com>
* fix simple issues
* add and use LTE and GTE methods
* remove TM-specific height semantics from 02-client
* fix lint and build
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
Co-authored-by: colin axnér <25233464+colin-axner@users.noreply.github.com>
2020-08-31 17:57:08 +00:00
fc75d14c88
Rename PacketExecuted to ReceiveExecuted ( #7206 )
...
* update ibc-transfer
* rename PacketExecuted -> ReceiveExecuted
2020-08-31 15:36:01 +00:00
843bd24bca
Add a mock application module to test core IBC ( #7187 )
...
* update setup to use channeltype and add mock app module
* rm print statement
* claim channel cap
* fix up test
* Update x/ibc/testing/coordinator.go
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
* apply @fedekunze review suggestions
Co-authored-by: Aditya Sripal <adityasripal@gmail.com>
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
2020-08-31 13:58:23 +00:00
23a9f46aad
Update tm pubkey references ( #7102 )
...
* Update pubkey references
* Update ledger_mock
* Migrate encoding from tm
* Update pubkey prefix
* revert ed25519 to tendermint key
* random account revert
* Revert ed25519 references
* revert secp key name
* test revert
* remove ed25519
* Update x/staking/types/validator.go
Co-authored-by: Amaury Martiny <amaury.martiny@protonmail.com>
* Revert "remove ed25519"
This reverts commit 66d2e1d061aeae81c4c0a3daf718536b09dda19e.
* remove ed25519 & sr25519
* Apply suggestions from code review
* remove codec
Co-authored-by: Marko Baricevic <marbar3778@yahoo.com>
Co-authored-by: Amaury Martiny <amaury.martiny@protonmail.com>
2020-08-28 16:02:38 +00:00
9fc0dbbe05
Rename Evidence to Misbehaviour in IBC ( #7151 )
...
* rename Evidence to Misbehaviour in IBC code
* tidy go.sum
* remove more references to evidence
* Apply suggestions from code review
Co-authored-by: colin axnér <25233464+colin-axner@users.noreply.github.com>
* Update x/ibc/07-tendermint/client/cli/tx.go
* nit and doc
Co-authored-by: colin axnér <25233464+colin-axner@users.noreply.github.com>
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
2020-08-26 17:51:13 +00:00
e09c8d9360
Fix AcknowledgePacket and AcknowledgementExecuted bug + update testing pkg ( #7170 )
...
* upstream cosm wasm testing pkg fixes
* fix bug, tests and undo rand addition
* fix lint
* go mod tidy
2020-08-26 12:11:31 +00:00
1f7a2787aa
Final IBC migration and Amino removal ( #7157 )
...
* migrate tm messages and change header/evidence to pointers
* remove amino
* add nil checks and test for pointer changes
* fix format
2020-08-25 10:17:38 -04:00
46927c31cf
implement solo machine client ( #6267 )
...
* pause work until client refactor resolved
* continued scaffolding
* add msgs and evidence
* add update and misbehaviour functionality
* implement cli
* various types compile issues
* add sig proof and various bug fixes
* added rest routes
* verification funcs now update sequence number
* add sm suite and header test
* msgcreateclient and msgupdateclient tests
* add basic evidence test
* evidence validate basic test
* consensus state tests
* rm accidental file
* add verify con state and channel state, pause work for counterparty commitment type
* client state tests added
* update clienttype numbers
* update test added
* add misbehaviour tests
* update alias
* update cli tx
* update import alias
* cleanup code
* remove todo, tested by evidence tests
* add info to err msg
* wrapf
* Update x/ibc/06-solomachine/client/cli/tx.go
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
* Update x/ibc/06-solomachine/client/cli/tx.go
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
* Update x/ibc/06-solomachine/client/cli/tx.go
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
* Update x/ibc/06-solomachine/client/cli/tx.go
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
* Update x/ibc/06-solomachine/update.go
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
* Update x/ibc/23-commitment/types/signature.go
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
* Update x/ibc/06-solomachine/types/header.go
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
* apply most of the review suggestions from @fedekunze
* remove alias.go
* update cli context with master changes
* merge selective downstream changes from colin/solomachine
* fix build issues
* remove signature proof
* try to migrate to proto
* rm go structs for consensus state and header
* address @fedekunze review and continue proto migration
* fix proto issues
* fix compile bugs in types, proto panics on getpubkey currently
* add timestamp
* update pubkey to be type sdkcrypto.PublicKey
* update timestamp handling
* begin removing amino, migrate to proto
* fix various build issues
* fix most test in types
* change sanitize to produce, fix bug, types test passing
* begin updating cli
* move solomachine into light-clients/
* fix merge issue
* update proto and fix cli
* more fixes and update proto again
* update pubkey to be any
* fix string func issue
* update tests to use testing pkg
* update from tm crypto keys ref to sdk
* fix tests 🎉
* increase codecov
* address TODOs
* address most of @fedekunze comments
* add test case for misbehaviour frozen client
* fix lint
* fix proto lint?
* rename Signature to TimestampedSignature
* remove chainID
* rename FrozenHeight to FrozenSequence
* apply verify consensus state changes requested by @AdityaSripal
* remove dup check
* fix typo in proto file comment
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
Co-authored-by: Federico Kunze <federico.kunze94@gmail.com>
Co-authored-by: Christopher Goes <cwgoes@pluranimity.org>
2020-08-24 10:06:48 +00:00
97df8b605c
Verify Client on Connection Handshake ( #7057 )
...
* verify client state
* add client state to msgs and retrieve in handler
* fix connection msgs
* fixed handshake tests
* fix tests
* fix sim tests
* revert pb edit
* add ValidateClient tests
* Apply suggestions from code review
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
* fix tests
* fixed msgs test
* use ibctesting for client state consts
* Apply suggestions from code review
Co-authored-by: colin axnér <25233464+colin-axner@users.noreply.github.com>
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
* address rest of comments
* rename to ValidateSelfClient and update spec
* lint
* Update x/ibc/02-client/keeper/keeper_test.go
* Update x/ibc/02-client/keeper/keeper_test.go
* complete rest of review
* improve cov
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
Co-authored-by: colin axnér <25233464+colin-axner@users.noreply.github.com>
2020-08-20 22:05:41 +00:00
be0cc63808
Migrate IBC tendermint header to proto ( #7120 )
...
* gen header proto file
* fix tm type to proto conversion issues
* fix tendermint type tests
* fix remaining tests
* fix lint
* Update x/ibc/07-tendermint/types/header.go
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
* Update x/ibc/07-tendermint/types/header.go
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
* apply @fedekunze review suggestions
* fix build
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
2020-08-20 11:46:11 -04:00
16435a0f4d
ibc: TimeoutOnClose support ( #7066 )
...
* ibc: TimeoutOnClose support
* revert added callback
* update proto
* update spec and add msg test
* update handler and add test
* apply self-review changes
* apply @fedekunze review suggestion
Co-authored-by: Colin Axner <colinaxner@berkeley.edu>
Co-authored-by: colin axnér <25233464+colin-axner@users.noreply.github.com>
2020-08-20 07:19:57 -04:00
3022fe9044
x/ibc-transfer: ADR001 source tracing implementation ( #6871 )
...
* x/ibc-transfer: ADR001 source tracing implementation
* gRPC proto file
* validation
* fix validation
* import export genesis
* relay.go updates
* gRPC service methods
* client CLI
* update implementation
* build
* trace test
* fix CLI tx args
* genesis import/export tests
* update comments
* update proto files
* GRPC tests
* remove field from packet
* fix coin validation bug
* more validations
* update comments
* minor refactor
* update relay.go
* try fix test
* minor updates
* fix tests
* fix test
* ADR updates and comments
* build
* Apply suggestions from code review
Co-authored-by: Aditya <adityasripal@gmail.com>
Co-authored-by: colin axnér <25233464+colin-axner@users.noreply.github.com>
* address a few comments from review
* gRPC annotations
* update proto files
* Apply suggestions from code review
Co-authored-by: colin axnér <25233464+colin-axner@users.noreply.github.com>
* address comments
* docs and changelog
* sort traces
* final changes to ADR
* client support for full path denom prefixes
* address @AdityaSripal comments
* address TODO
* increase test timeouts
Co-authored-by: Aditya <adityasripal@gmail.com>
Co-authored-by: colin axnér <25233464+colin-axner@users.noreply.github.com>
2020-08-14 17:46:26 -04:00
8de96d16f9
tendermint: update to rc3 ( #6892 )
...
* modify light imports
* change abci.header to tmproto.header
* use rc
* rc
* fix import
* Merge PR #6893 : fix key imports
* fix rc2
* tendermint: update 3 (#6899 )
* tendermint: update 4 (#6919 )
Co-authored-by: Alexander Bezobchuk <alexanderbez@users.noreply.github.com>
* tendermint: update 5 (#6923 )
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
* bump to latest master
* tendermint: update (#6972 )
Co-authored-by: Aleksandr Bezobchuk <aleks.bezobchuk@gmail.com>
Co-authored-by: Cory Levinson <cjlevinson@gmail.com>
* Update x/ibc/07-tendermint/types/test_utils.go
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
* address comment
* go mod
* bring back things
* fix test
* update tm proto files
Co-authored-by: Alexander Bezobchuk <alexanderbez@users.noreply.github.com>
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
Co-authored-by: Aleksandr Bezobchuk <aleks.bezobchuk@gmail.com>
Co-authored-by: Cory Levinson <cjlevinson@gmail.com>
Co-authored-by: Federico Kunze <federico.kunze94@gmail.com>
2020-08-14 13:58:53 -04:00
3735b182bc
Modular IBC Client ( #7028 )
...
* start modular client work
* fix panic
* reuse keeper marshal methods
* readd TODO
* add nil checks for misbehaviour
* address reviews
* address rest of reviews and fix builds
* fixed tests
* address rest of reviews
* fix expired blocks bug
* fix expired bug
2020-08-14 04:47:13 -04:00
d752a7b21f
ConsensusState is retrieved by light clients in verifyXYZ as necessary ( #7005 )
...
* move con state retrieval to verify funcs
* refactor tm client state tests
* fix build
* Apply suggestions from code review
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
Co-authored-by: Aditya <adityasripal@gmail.com>
* apply @fedekunze review comments
* apply @AdityaSripal review comment
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
Co-authored-by: Aditya <adityasripal@gmail.com>
2020-08-12 05:20:29 -04:00
1744194e71
x/ibc: migrate rest of 04-channel to gRPC ( #6964 )
...
* migrate channel querier to grpc
* fix various issues in channel grpc migration
* remove querier and add tests
* fix lint
* update utils based on self review
* Update x/ibc/24-host/keys.go
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
* apply @fedekunze review suggestions
* fix build
* fix build
* run make proto gen again
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
2020-08-11 08:29:29 -04:00
20c80cfd44
Rename *codec.Codec to *codec.LegacyAmino ( #6991 )
...
* Rename *codec.Codec to *codec.LegacyAmino
* Implement requested changes
Co-authored-by: Aaron Craelius <aaron@regen.network>
2020-08-10 19:41:21 +00:00
e3391ff447
Remove ValidatorSet from ConsensusState ( #6942 )
...
* fix stash merge
* fix build errors
* fix tendermint types test
* fix tendermint tests
* fix client tests
* fix rest of ibc tests
* include TrustedHeight in Header
* fix all tests
* fix all tests
* remove validatorshash from consensus state
* lint
* add evidence checks
* Apply suggestions from code review
Co-authored-by: colin axnér <25233464+colin-axner@users.noreply.github.com>
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
* refix build
* remove redundant hashing in tests
* complete rest of minor review requests
* make format
* suite.valsetHash
* fix test
* Update x/ibc/07-tendermint/misbehaviour.go
Co-authored-by: colin axnér <25233464+colin-axner@users.noreply.github.com>
Co-authored-by: colin axnér <25233464+colin-axner@users.noreply.github.com>
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
Co-authored-by: Federico Kunze <federico.kunze94@gmail.com>
2020-08-06 08:32:19 +00:00
79cee06967
Migrate Tendermint client state to proto ( #6932 )
...
* add tm client state proto file
* migrate tm client state to proto
* bump ics23 dep
* add issue link to makefile
2020-08-04 16:31:50 +00:00
9b61e0947e
Remove Last Header from ClientState ( #6873 )
...
* implement features, fix tendermint tests
* allow test headers to pass in custom nextvalidatorset
* allow updates to previous heights and test
* remove unnecessary testing feature
* fix client tests
* fix ibc tests, and updating consensus state
* fix ibc-transfer tests
* appease linter
* Apply suggestions from code review
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
* add chainID test case
* fix expPass value
* Apply suggestions from code review
Co-authored-by: colin axner <25233464+colin-axner@users.noreply.github.com>
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
* address rest of @colin-axner review
* fix bug and errors
* Apply suggestions from code review
Co-authored-by: colin axnér <25233464+colin-axner@users.noreply.github.com>
* address rest of @colin-axner review
* implement updating before frozen height
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
Co-authored-by: colin axner <25233464+colin-axner@users.noreply.github.com>
2020-08-04 05:05:03 -04:00
b3bbca343f
fix ibc-transfer source bug ( #6865 )
...
* update proto and refactor types test
* cleanup SendTransfer
* fix build and prep to update handler tests
* fix handler tests
* fix tests
* update spec
* fix lint
* Apply suggestions from code review
Co-authored-by: Aditya <adityasripal@gmail.com>
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
* rename amount to token
* merge send transfer and createOutgoingPacket
* apply rest of @fedekunze review suggestions
* apply review suggestions from @AdityaSripal
* update spec to token renaming
* split token in denom and amount when creating fungible token packet
* remove source flag, add prefix on recv
* fix lint
* fix proto numbers
* Update x/ibc-transfer/keeper/relay.go
Co-authored-by: Christopher Goes <cwgoes@pluranimity.org>
* apply @cwgoes review suggestions
* Apply suggestions from code review
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
* apply @fedekunze suggestions
* Apply suggestions from code review
* fix lint
* apply @AdityaSripal review requests
* Update x/ibc-transfer/types/coin.go
* apply @AdityaSpripal last suggestions
Co-authored-by: Aditya <adityasripal@gmail.com>
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
Co-authored-by: Christopher Goes <cwgoes@pluranimity.org>
2020-08-01 09:16:22 +00:00
2651427ab4
x/ibc-transfer: use ibc testing package ( #6641 )
...
* x/ibc-transfer: use ibc testing package
* coin denom failure
* update handler tests
* refactor first test in relay
* update onrecvtest, failing tests expected due to existing bug
* update on acknowledgement test, failing test is expected
* refactor timeout test
* revert coin validation changed, comment out tests
* minor fix
* update coordinator.go
* update coordinator.go
* add comment to fix handler test
* add link to issue in handler test
* fix test
Co-authored-by: Colin Axner <colinaxner@berkeley.edu>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
2020-07-28 08:24:13 +00:00
3bafd8255a
Remove hybrid codec usage ( #6843 )
...
* remove hybrid codec for slashing, staking and upgrade
* Remove hybridcodec from params and mint
* revert staking
* Fix gov
* Fix ibc and evidence
* Fix ibc-transfer
* Fix staking
* remove evidence json marshaling
* Fix tests
Co-authored-by: Aaron Craelius <aaron@regen.network>
Co-authored-by: Aaron Craelius <aaronc@users.noreply.github.com>
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
2020-07-25 08:03:58 +00:00
79fa06b26c
remove IBC ante handler in favor of using handler ( #6793 )
...
* remove IBC ante handler, add calls to handler
* move some events upstream to handler
* remove change log entry
* move ante handler tests to handler
* fix build
* update docs
Co-authored-by: Alexander Bezobchuk <alexanderbez@users.noreply.github.com>
2020-07-20 15:25:57 +00:00
5c0e3b4de5
x/auth/ante: Migrate tests to use the new client.TxConfig ( #6661 )
...
* WIP: using encoding config
* Make it compile, test fails
* test should be okay
* Make tests pass
* Add comments
* Convert more tests
* Make TestAnteHandlerSigErrors work
* Make first 2 tests pass
* TestAnteHandlerAccountNumbers
* Use table tests
* Remove print
* Use test table
* TestAnteHandlerSigErrors
* TestAnteHandlerAccountNumbers
* TestAnteHandlerAccountNumbers
* Refactor TestAccount
* Refactor getSignBytes
* TestAnteHandlerAccountNumbersAtBlockHeightZero
* TestAnteHandlerSequences
* TestAnteHandlerFees
* TestAnteHandlerMultiSigner
* TestAnteHandlerBadSignBytes
* TestAnteHandlerSetPubKey
* TestAnteHandlerSigLimitExceeded
* TestCustomSignatureVerificationGasConsumer
* TestAnteHandlerReCheck
* Make all tests pass
* Refactor a little bit more
* Fee test
* SetupTest
* All tests pass
* Refactor to RunTestCase
* Don't use StdFee
* Revert some little stuff
* Finish up last couple of test cases
* Less verbose
* s/TxGenerator/TxConfig
* Add comments
* Indent
* Move KeyTestPubAddr to testdata
* Move testdata to /testutil
* Revert to use signature: nil step in signing
* Add comments
Co-authored-by: Alexander Bezobchuk <alexanderbez@users.noreply.github.com>
2020-07-20 08:30:12 -04:00
a65bcdd7e5
add custom relative and absolute timeouts to ibc-transfer ( #6724 )
...
* add custom relative and absolute timeouts
* fix misspell
* Update x/ibc-transfer/client/cli/tx.go
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
2020-07-15 13:32:09 +00:00
b9f86dd7fe
Update simapp helpers to use Tx generator ( #6655 )
...
* update helpers to use tx generator
* update modules to use tx generator
* add todo
* update ibc to use txG
* fix lint
* Eliminate panics from Gentx
* update module ops
* fix lgtm alert
* update ibc with txG
* Remove todo
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
* move simapp/helpers to test_helpers
* revert simapp/helpers to test_helpers
* revert renaming
* address suggestion
Co-authored-by: Aaron Craelius <aaron@regen.network>
* fix tests
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
Co-authored-by: Aaron Craelius <aaron@regen.network>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
2020-07-14 17:33:31 +00:00
5dfc4a2ec9
Standardize connection versioning + channel versioning docs ( #6640 )
...
* update connection versions with feature set flag
* make connection version modular to support channel versioning and registering
* revert IBCVersion renaming, add channel versioning logic
* fix channel version flag
* remove unnecessary godoc
* remove unused func
* fix lint and version test
* add test and fix error
* revert changes
* update docs
* remove unnecessary godoc
* Apply suggestions from code review
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
* update doc
* add test cases for unchecked lines
* go fmt
* begin migration to standardized version
* revert proto changes
* restructure versioning to go from string to proto
* update versionStr to encodedVersion naming
* fix version test build
* fix keeper tests
* fix various tests
* fixes from self review
* update docs
* fix lint
* add more code cov
* rename ToString funcs to Encode/DecodeVersion + GetCompatibleEncodedVersions renaming
* update spec docs
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
2020-07-14 08:43:26 +00:00
f163ec6765
refactor ibc ante_test ( #6610 )
...
* remove old code from ante test
* add recv packet test
* add acknowledge test
* add timeout tests
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
2020-07-07 08:30:23 +00:00
f35e3b2c02
x/ibc: gRPC query service ( #6466 )
...
* x/ibc: gRPC query service
* fixes
* connection updates
* register channel query service
* update clients
* change proofs to bytes
* implement additional channel grpc queries
* unrelayed packets query
* query.proto files
* move next sequence recv query to channel client
* update REST
* wip test
* add missing cli queries
* install the right tools
* fixes
* build
* lint
* use gRPC when query proof is not requested
* connection gRPC tests
* IBC query server interface
* more gRPC channel tests
* pagination tests
* connection use query server
* connection pagination tests
* channel pagination tests
* typo
* remove buf
* Update x/ibc/03-connection/keeper/grpc_query_test.go
Co-authored-by: colin axner <25233464+colin-axner@users.noreply.github.com>
* address comments from review
* fix tests
* unrelayed packet sequences flag
* remove ClientsConnections query
* fix
Co-authored-by: colin axner <25233464+colin-axner@users.noreply.github.com>
2020-07-06 15:35:35 -04:00
bbe245ac1d
refactor connection verify_test ( #6588 )
...
* refactor verify consensus state
* refactor connection verification
* simplify code, channel + packet commitment tests
* refactor verify ack
* refactor verify ack absence
* refactor next seq recv test
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
Co-authored-by: Christopher Goes <cwgoes@pluranimity.org>
2020-07-06 13:37:12 +00:00
73757243c2
Update connection handshake version negotiation ( #6534 )
...
* update version negotiation and add basic testing
* add integration tests
* update spec
* apply @fedekunze suggestions
* update to enforce connection validation checks
* add test
* update godoc and spec
* small doc fix
* update versioning to feature set
* update version code and tests to specified version tuple
* update docs/spec
* merge and fix bug
* Update x/ibc/03-connection/types/version.go
Co-authored-by: Aditya <adityasripal@gmail.com>
* Apply suggestions from code review
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
* add verify proposed feature set test
* fix formatting bug
* add safety check
* merge tests into existing handshake tests
Co-authored-by: Aditya <adityasripal@gmail.com>
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
2020-07-03 09:28:02 +00:00
db60e658f8
refactor connection handshake_test ( #6576 )
...
* refactor connopeninit test
* updated opentry
* refactor openack
* update openconfirm
* fix typo and test issue
* fix missing code cov hits
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
2020-07-02 20:08:29 +00:00
43837b16e7
Refactor 04-channel/keeper tests to ibc testing pkg ( #6400 )
...
* update testing pkg and first keeper test
* fix version bug
* add more helper testing funcs
* move create header to testing pkg
* fix connection state bug
* add staking genesis state
* update simapp with setting validator helper func
* update simapp with valset helper
* fix app hash issue
* update to query from correct iavl proof height
* first keeper test passing
* second test passing 🎉
* fix build
* update tests in all keeper_test
* fix lint
* begin refactoring querier test
* update first querier test and update testing helpers
* finish updating rest of querier tests
* rename ChannelID in TestChannel to ID
* remove usage of chain id for calling helper funcs
* update openinit and opentry tests
* finish opening channel handshake tests
* finish handshake tests
* general testing pkg cleanup
* finish packetsend refactor
* update recvpacket
* packet executed refactored
* finish packet test 🎉
* all tests passing
* cleanup and increase code cov
* remove todos in favor of opened issue #6509
* bump invalid id to meet validation requirements
* bubble up proof height + 1
* Apply suggestions from code review
Co-authored-by: Aditya <adityasripal@gmail.com>
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
* fix uninit conn test
* fix compile and address various pr review issues
* Update x/ibc/04-channel/keeper/handshake_test.go
Co-authored-by: Aditya <adityasripal@gmail.com>
* Update x/ibc/04-channel/keeper/handshake_test.go
Co-authored-by: Aditya <adityasripal@gmail.com>
* address @AdityaSripal comments and increase cov
Co-authored-by: Aditya <adityasripal@gmail.com>
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
2020-06-26 16:36:04 +00:00
d82c2e6a94
Enforce ProofSpecs in 23-Commitment ( #6374 )
...
* enforce spec ordering
* modify clients to pass in specs to verify functions
* start fixing tests
* Apply suggestions from code review
* enforce spec length and proof length match
* fix all tests
* add argument to constructor:
* fixed msg client and tests
* appease linter
* Apply suggestions from code review
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
* finish fixes from review
* add back proof-specific checks
* Apply suggestions from code review
* more robust proof spec checks
* add CHANGELOG entries
* do not hardcode proofspecs in 23-commitment
* fix client modules
* fix tests
* appease linter
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
2020-06-12 10:45:40 +00:00
9048ffa8d3
Update ibc proof to be bytes ( #6393 )
...
* update interfaces to use []byte instead of commitment proof
* update 03/04 msgs with bytes
* fix compile errors
* fix channel tests
* fix connection tests
* fix testing, tm, and localhost tests
* fix ante tests
* update 03-connection spec
* update channel msgs spec
* small fixes after self review
* rm unused import
* Update x/ibc/03-connection/client/utils/utils.go
Co-authored-by: Alessio Treglia <alessio@tendermint.com>
* add empty proof test and rm ics 20 from ibc spec
* fix merge issues
Co-authored-by: Alessio Treglia <alessio@tendermint.com>
2020-06-12 00:19:25 +02:00
6851c844b3
x/ibc: testing pkg ( #6356 )
...
* add ibc testing pkg with testchain
* add ibctestsuite
* add create connection and channel support
* lint fixes
* lint
* revert
* simplify code via lint
* change suite to coordinator
* Update x/ibc/testing/chain.go
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
* Apply suggestions from code review
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
* make trust level var and remove get from channel test struct
* apply most suggestions from pr review
* split conn handshake into single step funcs
* split channel handshake into separate funcs
* apply @fedekunze suggestions
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
2020-06-10 09:00:13 +00:00
Amaury Martiny
Aditya
colin axnér
dauTT
Anil Kumar Kammari
Federico Kunze
SaReN
Marko