colin axnér
843bd24bca
Add a mock application module to test core IBC ( #7187 )
...
* update setup to use channeltype and add mock app module
* rm print statement
* claim channel cap
* fix up test
* Update x/ibc/testing/coordinator.go
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
* apply @fedekunze review suggestions
Co-authored-by: Aditya Sripal <adityasripal@gmail.com>
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
2020-08-31 13:58:23 +00:00
Aditya
41bc9fb8e6
Fix setting NextSequenceAck ( #7181 )
...
* Fix setting NextSequenceAck
* Update x/ibc/04-channel/keeper/packet_test.go
Co-authored-by: colin axnér <25233464+colin-axner@users.noreply.github.com>
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
Co-authored-by: colin axnér <25233464+colin-axner@users.noreply.github.com>
2020-08-27 19:01:12 +00:00
colin axnér
e09c8d9360
Fix AcknowledgePacket and AcknowledgementExecuted bug + update testing pkg ( #7170 )
...
* upstream cosm wasm testing pkg fixes
* fix bug, tests and undo rand addition
* fix lint
* go mod tidy
2020-08-26 12:11:31 +00:00
Federico Kunze
16435a0f4d
ibc: TimeoutOnClose support ( #7066 )
...
* ibc: TimeoutOnClose support
* revert added callback
* update proto
* update spec and add msg test
* update handler and add test
* apply self-review changes
* apply @fedekunze review suggestion
Co-authored-by: Colin Axner <colinaxner@berkeley.edu>
Co-authored-by: colin axnér <25233464+colin-axner@users.noreply.github.com>
2020-08-20 07:19:57 -04:00
Amaury Martiny
5559af8b97
Proto Auditing: Replace ID with Id ( #7032 )
...
* Proto Auditing: Replace ID with Id
* make proto-gen
* Update docs
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
2020-08-14 08:55:54 +00:00
colin axnér
3a4e608930
Add clientState and consensusState gRPC support to connection ( #7017 )
...
* add proto querys for connection
* add client state and consensus state grpc for connection
* update client utils
2020-08-12 08:54:38 -04:00
colin axnér
1744194e71
x/ibc: migrate rest of 04-channel to gRPC ( #6964 )
...
* migrate channel querier to grpc
* fix various issues in channel grpc migration
* remove querier and add tests
* fix lint
* update utils based on self review
* Update x/ibc/24-host/keys.go
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
* apply @fedekunze review suggestions
* fix build
* fix build
* run make proto gen again
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
2020-08-11 08:29:29 -04:00
Anil Kumar Kammari
3bafd8255a
Remove hybrid codec usage ( #6843 )
...
* remove hybrid codec for slashing, staking and upgrade
* Remove hybridcodec from params and mint
* revert staking
* Fix gov
* Fix ibc and evidence
* Fix ibc-transfer
* Fix staking
* remove evidence json marshaling
* Fix tests
Co-authored-by: Aaron Craelius <aaron@regen.network>
Co-authored-by: Aaron Craelius <aaronc@users.noreply.github.com>
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
2020-07-25 08:03:58 +00:00
colin axner
ef0a7344af
x/ibc: remove ID from ConnectionEnd ( #6814 )
...
* remove connection id
* various test and code fixes
* fix tests
* Update proto/ibc/connection/connection.proto
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
* rename utils.go to parse.go in host
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
2020-07-22 09:59:15 -04:00
colin axner
97a83e9c78
Update IBC events docs and code ( #6798 )
...
* update msgs type from opaque
* update spec for createclient
* update events spec for handshake cals
* update packet events for spec and code
* add relayer events doc
* update ibc-transfer events
* fix build
* small fix from self review
* update channel msgs types
* acknowledgement_packet -> acknowledge_packet
* Apply suggestions from code review
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
* fix spec issues for ibc and ibc-transfer
* add golang relayer link
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
2020-07-21 12:56:14 -04:00
Amaury Martiny
69bbb8b327
Rename proto Req/Res to Pagination ( #6796 )
...
* Rename proto Req to Pagination
* Change Res to Pagination
Co-authored-by: Alexander Bezobchuk <alexanderbez@users.noreply.github.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
2020-07-20 16:51:16 +00:00
colin axner
1d6344888e
Fix query unrelayed packets logic ( #6733 )
...
* add some query functions to channel keeper
* update grpc queries and cli cmd and tests
* rerun proto gen after merging master
* fix build broken from merge conflicts
* add test and update proto
* Update x/ibc/04-channel/client/cli/query.go
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
2020-07-20 12:42:36 +00:00
colin axner
5dfc4a2ec9
Standardize connection versioning + channel versioning docs ( #6640 )
...
* update connection versions with feature set flag
* make connection version modular to support channel versioning and registering
* revert IBCVersion renaming, add channel versioning logic
* fix channel version flag
* remove unnecessary godoc
* remove unused func
* fix lint and version test
* add test and fix error
* revert changes
* update docs
* remove unnecessary godoc
* Apply suggestions from code review
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
* update doc
* add test cases for unchecked lines
* go fmt
* begin migration to standardized version
* revert proto changes
* restructure versioning to go from string to proto
* update versionStr to encodedVersion naming
* fix version test build
* fix keeper tests
* fix various tests
* fixes from self review
* update docs
* fix lint
* add more code cov
* rename ToString funcs to Encode/DecodeVersion + GetCompatibleEncodedVersions renaming
* update spec docs
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
2020-07-14 08:43:26 +00:00
colin axner
03fdc9d744
x/ibc: update error messages ( #6659 )
...
* update errors in 02-client
* update errors in 03-connection
* update 04-channel errors + fixes to 03 changes
* update ibc handler errors
* tm, commitment, and verify error updates
* update ics20
* remove unnecessary wrapping
* fix various build issues
2020-07-09 12:06:08 -04:00
Aditya
7fdcdc18e0
Enforce Connection Features on Channel Opening ( #6620 )
...
* add channel open checks for supported feature
* add tests and fix bugs
* fix version tests
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
2020-07-07 10:00:12 +00:00
Aditya
6fa295c857
fix NextSeqAck increment logic ( #6619 )
...
Co-authored-by: Alexander Bezobchuk <alexanderbez@users.noreply.github.com>
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
2020-07-07 08:03:43 +00:00
Federico Kunze
f35e3b2c02
x/ibc: gRPC query service ( #6466 )
...
* x/ibc: gRPC query service
* fixes
* connection updates
* register channel query service
* update clients
* change proofs to bytes
* implement additional channel grpc queries
* unrelayed packets query
* query.proto files
* move next sequence recv query to channel client
* update REST
* wip test
* add missing cli queries
* install the right tools
* fixes
* build
* lint
* use gRPC when query proof is not requested
* connection gRPC tests
* IBC query server interface
* more gRPC channel tests
* pagination tests
* connection use query server
* connection pagination tests
* channel pagination tests
* typo
* remove buf
* Update x/ibc/03-connection/keeper/grpc_query_test.go
Co-authored-by: colin axner <25233464+colin-axner@users.noreply.github.com>
* address comments from review
* fix tests
* unrelayed packet sequences flag
* remove ClientsConnections query
* fix
Co-authored-by: colin axner <25233464+colin-axner@users.noreply.github.com>
2020-07-06 15:35:35 -04:00
Aaron Craelius
2f44fbf2ab
Add support for protobuf TxGenerator and SIGN_MODE_DIRECT ( #6385 )
...
* Add TxWrapper, encoder, decoder and DirectModeHandler
* fix pkg name
* Update API and leave test TODO's
* Update TxWrapper API
* tests for tx wrapper (#6410 )
* WIP: added test for direct mode handler
* updated code
* Add msg
* Update TxWrapper API
* Fix pubkey declaration
* Add pubkey for tests
* Fix SetFee
* Remove logs
* Avoid global var declaration for tests
* Add test for GetPubKeys
* Fix direct signing tests
* Add more test cases for GetSignBytes
* Revert SetFee API
* Remove logs
* Refactor tests
Co-authored-by: anilCSE <anil@vitwit.com>
Co-authored-by: sahith-narahari <sahithnarahari@gmail.com>
* Refactoring
* Refactoring
* Integrate SignatureV2 API
* Fix wrapper tests
* Fix tests
* Linting and API tweaks
* Update API
* WIP on updating API
* Fix tests
* Update to new SigVerifiableTx
* Rename
* Update docs to reflect ADR 020
* proto-gen
* proto docs
* cleanup
* cleanup
* cleanup
* cleanup
* cleanup
* cleanup
* cleanup
* Add tests
* Refactor and improving test coverage
* WIP on test coverage
* WIP on test coverage
* proto-gen
* Fix CompactBitArray.Size() bug
* Rename
* Remove Builder interface
* Address review comments
* Update x/auth/tx/sigs.go
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
* Update x/auth/tx/encoder.go
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
* Update x/auth/tx/encoder.go
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
* Address review feedback
* Fix build issues
* Resolve conflicts
* Fix ValidateBasic test coverage
* Add test for malicious multisig
Co-authored-by: atheeshp <59333759+atheeshp@users.noreply.github.com>
Co-authored-by: anilCSE <anil@vitwit.com>
Co-authored-by: sahith-narahari <sahithnarahari@gmail.com>
Co-authored-by: Alexander Bezobchuk <alexanderbez@users.noreply.github.com>
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
2020-07-06 17:03:45 +00:00
colin axner
db60e658f8
refactor connection handshake_test ( #6576 )
...
* refactor connopeninit test
* updated opentry
* refactor openack
* update openconfirm
* fix typo and test issue
* fix missing code cov hits
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
2020-07-02 20:08:29 +00:00
colin axner
5a22342a24
check ordered channel ordering in RecvPacket ( #6574 )
...
* move nextrecvseq check to recvpacket
* add test for next recv seq not found
* fix test bug, increase cov
* remove dup check and test
* Update x/ibc/04-channel/keeper/packet_test.go
Co-authored-by: Aditya <adityasripal@gmail.com>
Co-authored-by: Aditya <adityasripal@gmail.com>
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
2020-07-02 20:03:45 +00:00
colin axner
497b27305d
x/ibc: remove returning packet from channel keeper funcs ( #6544 )
...
* remove unnecessary return var
* fix changes lost in merge
2020-06-30 11:04:18 -04:00
colin axner
e8fb76ae44
x/ibc: remove alias.go from 03-connection ( #6543 )
2020-06-30 09:10:53 -04:00
colin axner
43b4f2f120
remove alias.go from 02-client ( #6542 )
2020-06-30 10:37:05 +00:00
colin axner
1c575c95b2
Remove CleanupPacket from 04-channel ( #6533 )
...
* remove cleanup func
* remove unused func
2020-06-29 08:54:45 +00:00
colin axner
43837b16e7
Refactor 04-channel/keeper tests to ibc testing pkg ( #6400 )
...
* update testing pkg and first keeper test
* fix version bug
* add more helper testing funcs
* move create header to testing pkg
* fix connection state bug
* add staking genesis state
* update simapp with setting validator helper func
* update simapp with valset helper
* fix app hash issue
* update to query from correct iavl proof height
* first keeper test passing
* second test passing 🎉
* fix build
* update tests in all keeper_test
* fix lint
* begin refactoring querier test
* update first querier test and update testing helpers
* finish updating rest of querier tests
* rename ChannelID in TestChannel to ID
* remove usage of chain id for calling helper funcs
* update openinit and opentry tests
* finish opening channel handshake tests
* finish handshake tests
* general testing pkg cleanup
* finish packetsend refactor
* update recvpacket
* packet executed refactored
* finish packet test 🎉
* all tests passing
* cleanup and increase code cov
* remove todos in favor of opened issue #6509
* bump invalid id to meet validation requirements
* bubble up proof height + 1
* Apply suggestions from code review
Co-authored-by: Aditya <adityasripal@gmail.com>
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
* fix uninit conn test
* fix compile and address various pr review issues
* Update x/ibc/04-channel/keeper/handshake_test.go
Co-authored-by: Aditya <adityasripal@gmail.com>
* Update x/ibc/04-channel/keeper/handshake_test.go
Co-authored-by: Aditya <adityasripal@gmail.com>
* address @AdityaSripal comments and increase cov
Co-authored-by: Aditya <adityasripal@gmail.com>
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
2020-06-26 16:36:04 +00:00
Federico Kunze
d82114df2b
ibc/04-channel: move UNORDERED channel ack to RecvPacket ( #6457 )
2020-06-17 05:36:09 -04:00
dauTT
8cf8098861
x/capability: remove alias.go usage ( #6438 )
2020-06-14 19:05:45 +02:00
dauTT
14e3aa1265
x/staking: remove alias.go usage ( #6397 )
...
* x/staking: remove alias.go usage
* Fix formatting and Add entry in CHANGELOG.md
* Add missing end curly parenthesis
Co-authored-by: Alessio Treglia <alessio@tendermint.com>
2020-06-12 14:54:37 +00:00
Jonathan Gimeno
ddbb9a2321
run make format ( #6416 )
2020-06-12 10:17:36 -04:00
Federico Kunze
55a7226535
x/ibc: channel from client state query ( #6401 )
...
* x/ibc: channel from client state query
* 04-channel/client: add CLI and REST queries
* querier test
2020-06-12 08:06:24 -04:00
Aditya
d82c2e6a94
Enforce ProofSpecs in 23-Commitment ( #6374 )
...
* enforce spec ordering
* modify clients to pass in specs to verify functions
* start fixing tests
* Apply suggestions from code review
* enforce spec length and proof length match
* fix all tests
* add argument to constructor:
* fixed msg client and tests
* appease linter
* Apply suggestions from code review
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
* finish fixes from review
* add back proof-specific checks
* Apply suggestions from code review
* more robust proof spec checks
* add CHANGELOG entries
* do not hardcode proofspecs in 23-commitment
* fix client modules
* fix tests
* appease linter
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
2020-06-12 10:45:40 +00:00
colin axner
9048ffa8d3
Update ibc proof to be bytes ( #6393 )
...
* update interfaces to use []byte instead of commitment proof
* update 03/04 msgs with bytes
* fix compile errors
* fix channel tests
* fix connection tests
* fix testing, tm, and localhost tests
* fix ante tests
* update 03-connection spec
* update channel msgs spec
* small fixes after self review
* rm unused import
* Update x/ibc/03-connection/client/utils/utils.go
Co-authored-by: Alessio Treglia <alessio@tendermint.com>
* add empty proof test and rm ics 20 from ibc spec
* fix merge issues
Co-authored-by: Alessio Treglia <alessio@tendermint.com>
2020-06-12 00:19:25 +02:00
Segue
52d11acb45
R4R: Fix bug of unordered channel ( #6337 )
...
* fix unordered
* resolve conflicts
2020-06-08 06:19:59 +00:00
colin axner
b9b578d6de
x/ibc: querying support for unordered channels ( #6294 )
...
* pause
* add querying for packet commitments and unrelayed acks
* add get all packet commitments test
* add query channels test
* add query connection channels test
* add test for query packet commitments
* fix key path and add unrelayed acks test
* fix part of lint
* add unrelayed packetsends func
* fix godoc
* add nolint directive
* fix lint
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
2020-06-06 19:25:45 -04:00
colin axner
b1f483fe24
move packet executed call to ibc handler ( #6312 )
...
* move packet executed to within ibc handler
* add spec updates
* godoc and nil check to lenght
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
2020-06-04 11:24:21 +00:00
colin axner
654b2fdd10
x/ibc: packet commitment deletion after ack verification ( #6292 )
...
* add deletion of packet commitments to AcknowledgePacket and remove CleanupPacket
* update tests
* add replay test for unordered channels
* add cleanup back, update tests
* remove nolint
* add timeoutonclose handling and fix
* add check for deleted packets
* Update x/ibc/04-channel/keeper/keeper.go
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
* add ackexecuted and update tests
* add timeoutexecuted back and update test
* move events to executed funcs
* update handler
* update godoc
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
2020-05-30 21:18:43 -04:00
Federico Kunze
ca20a39962
x/ibc: constrain acks processing order ( #6244 )
...
* x/ibc: constrain acks processing order
* test
* address @AdityaSripal comments
* address @colin-axner comments
* address @alexanderbez comments
2020-05-18 16:50:07 +00:00
Federico Kunze
3dcdc582af
x/ibc-transfer: move ICS20 out from x/ibc ( #6222 )
...
* x/transfer: move ICS20 out from x/ibc
* rename to ibc-transfer
2020-05-15 20:36:47 +00:00
Federico Kunze
48aebed2ea
x/ibc: /types cleanup ( #6169 )
...
* x/ibc: move /types to /common
* x/ibc/types: remove errors
* remove mocked proofs
* remove invalidProof{}
* create new ibc/types dir
* format
* move keys to host
* move order to channel
* move channel state
* move connection state
* lint
2020-05-13 19:23:33 -04:00
Federico Kunze
a08aa41213
ibc/07-tendermint: variable trust-level ( #6206 )
...
* ibc/07-tendermint: variable trust-level
* update client state and tests
* fix tests
* address comments from review
* cli: define trust-level as flag
2020-05-13 01:10:25 +00:00
Federico Kunze
138e0b074f
x/ibc: log fixes ( #6184 )
...
* x/ibc: log fixes
* fix test
2020-05-11 17:17:05 +00:00
Federico Kunze
d7ebee74e7
x/ibc: proto migration pt 1 ( #6097 )
...
* x/ibc: proto migration pt 1
* fix tests
* fixes and godoc
* yaml tags
* rm changelog
* address comments from review
* fix some tests
* fix tests
* add _UNSPECIFIED suffix for default enums
* Update app
* protobuf Any fixes
* use gogoproto
* fix tests
* wrap all messages
* address @alexanderbez comments
* update proto files
Co-authored-by: Alexander Bezobchuk <alexanderbez@users.noreply.github.com>
Co-authored-by: Aleksandr Bezobchuk <aleks.bezobchuk@gmail.com>
Co-authored-by: Aaron Craelius <aaron@regen.network>
2020-05-06 11:17:50 -04:00
Aditya
f2a331fddb
Fix Timeout Handling ( #6118 )
...
* fix timeout
* remove print statement
* fix tests
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
Co-authored-by: Alexander Bezobchuk <alexanderbez@users.noreply.github.com>
2020-05-05 14:46:13 +00:00
Marko
218ec99508
various linter fixes ( #6106 )
...
x/staking: Fix all linter warnings.
Fixed warnings across base packages.
New linters:
- unparam
- nolintlint
Co-authored-by: Alessio Treglia <alessio@tendermint.com>
2020-05-02 21:26:59 +02:00
Federico Kunze
7143d092c4
x/ibc: add logs ( #6104 )
2020-04-30 08:37:02 -04:00
Alessio Treglia
2879c0702c
x/ibc: fix missing return statement ( #6099 )
...
* enable the wsl linter
Fix various wsl-related warnings.
x/ibc/04-channel/keeper/handshake.go: fix missing return statement in ChanOpenTry().
* goimports -w files
* remove unknown linter references
* run make format
* Revert "run make format"
This reverts commit f810b62b9e4993f08506663d4e5f2ec2228a9863.
* run make format
2020-04-29 22:36:34 -04:00
Federico Kunze
2d3a8525b9
ibc/04-channel: import export GenesisState ( #6087 )
...
* ibc/04-channel: import export GenesisState
* update tests
* add missing genesis fields
* genesis tests
* keeper tests
* update genesis test
* typo
* rename types
* address comments from review
* minor updates
* typo
2020-04-29 09:17:20 -04:00
Aaron Craelius
cc90f2e002
Merge pull request #6085 : Move codec/std to std
2020-04-27 15:40:50 -04:00
colin axner
f6e9ee7623
x/ibc: Implement Timeout Timestamp ( #6022 )
...
* add timeout timestamp to packet and timestamp to consensus state
* add timeout timestamp event attribute
* update various issues with adding timestamp
* fix tests, add default timeout timestamp
* add unit test and minor fixes
* remove unnecessary code
* code review fix
* Update x/ibc/03-connection/keeper/keeper.go
Co-Authored-By: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
* Update x/ibc/02-client/exported/exported.go
Co-Authored-By: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
* Update x/ibc/04-channel/types/packet.go
Co-Authored-By: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
* Update x/ibc/07-tendermint/types/consensus_state.go
Co-Authored-By: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
* return time.Time in error message
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
2020-04-22 22:23:42 +00:00
Alexander Bezobchuk
72a2dae3db
Bump Tendermint v0.33.4 ( #6055 )
...
* Bump go.{mod,sum}
* Update APIs from Tendermint
* Add max clock drift to client state
* Test updates
* Update APIs from Tendermint
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
2020-04-22 19:21:48 +00:00