Robert Zaremba
3a9e696bbf
fix: Signature only flag bug on tx sign command 7632 ( #8106 )
...
* fix: Signature only flag bug on tx sign command 7632
* Update client/context.go
Co-authored-by: Cory <cjlevinson@gmail.com>
* Update client/context.go
Co-authored-by: Cory <cjlevinson@gmail.com>
* use named return value and closure (#8111 )
This is to correctly handle deferred Close()
calls on writable files.
* set the right 'append' logic for signing transactions
* cleanup
* update tx.Sign interface by adding overwrite option
* Update Changelog
* sign command cleanup
* implementation and changelog update
* fix SignTx and tx.Sign calls
* fix: sign didn't write to a file
* update flags description
* Add tx.Sign tests
* fix grpc/server_test.go
* Update client/tx/tx.go
Co-authored-by: Cory <cjlevinson@gmail.com>
* changelog update
* Add test to verify matching signatures
* cli_test: add integration tests for sign CMD
* add output-file flag test
* add flagAmino test
* Update x/auth/client/cli/tx_sign.go
Co-authored-by: Alessio Treglia <alessio@tendermint.com>
* Update x/auth/client/cli/tx_sign.go
* update amino serialization test
* TestSign: adding unit test for signing with different modes
* Add test with Multi Signers into Robert's TxSign PR (#8142 )
* Add test with Multi Signers
* remove true false
* Use SIGN_MODE_DIRECT
* Fix litn
* Use correct pubkeys
* Correct accNum and seq
* Use amino
* cleanups
* client.Sign: raise error when signing tx with multiple signers in Direct
+ added more unit tests
* add more tests
* Update client/tx/tx_test.go
Co-authored-by: Cory <cjlevinson@gmail.com>
* fix TestGetBroadcastCommand_WithoutOfflineFlag
* Any.UnsafeSetCachedValue
* fix note packed messages in tx builder
* reorder unit tests
* Changelog update
* cleaning / linting
* cli_tes: copy validator object instead of modifying it's shared codec
* x/auth cli_test: remove custom codec creation in tests
* Update CHANGELOG.md
* updates to CHANGELOG.md
* remove unused method
* add new instance of transaction builder for TestSign
Co-authored-by: Cory <cjlevinson@gmail.com>
Co-authored-by: SaReN <sahithnarahari@gmail.com>
Co-authored-by: Alessio Treglia <alessio@tendermint.com>
Co-authored-by: Amaury <amaury.martiny@protonmail.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
2020-12-14 21:44:15 +00:00
Amaury
7ad2aab2c4
Add panic handler on queries ( #8039 )
...
* Add test that panics
* Add panic in abci query
* Move proto gen files to correct place
* Add panic handler in grpc server
* Fix test
* Fix build
* Use %v
* Better panic message
* Fix tests
Co-authored-by: Aleksandr Bezobchuk <alexanderbez@users.noreply.github.com>
2020-11-30 16:59:35 +00:00
Alessio Treglia
1f211aad57
types: keep migrating tests to test suites ( #7478 )
...
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
2020-10-08 11:42:32 +00:00
Erik Grinaker
4faeefebd2
Add state sync support ( #7166 )
...
* Add state sync support
* fix incorrect test tempdir
* proto: move and update Protobuf schemas
* proto: lint fixes
* comment tweaks
* don't use type aliasing
* don't call .Error() when logging errors
* use create terminology instead of take for snapshots
* reuse chunk hasher
* simplify key encoding code
* track chunk index in Manager
* add restoreDone message for Manager
* add a ready channel to Snapshotter.Restore()
* add comment on streaming IO API
* use sdkerrors for error handling
* fix incorrect error
* tweak changelog
* syntax fix
* update test code after merge
2020-09-08 09:05:44 +00:00
Federico Kunze
0fffaf589b
ibc: modular client messages ( #7160 )
...
* ibc: modular client messages
* more updates
* remove client messages
* fixes
* fix tests
* lint
* Apply suggestions from code review
Co-authored-by: colin axnér <25233464+colin-axner@users.noreply.github.com>
* codec.go tests
* cleanup exported
* MsgCreateClient test
* msg tests
* Apply suggestions from code review
Co-authored-by: colin axnér <25233464+colin-axner@users.noreply.github.com>
* fix tests
* proto files update
* errors
* address comments
* spec changes
* add sanity check test cases
* add additional sanity check
* fix expPass
* fix build and remove unnecessary test since validatebasic is checked in the msg
Co-authored-by: colin axnér <25233464+colin-axner@users.noreply.github.com>
Co-authored-by: Aditya Sripal <adityasripal@gmail.com>
Co-authored-by: Colin Axner <colinaxner@berkeley.edu>
2020-09-01 10:40:31 +00:00
Amaury Martiny
50bab8f820
Put AccountSequence in SignerInfo ( #6997 )
...
* WIP test the grounds
* Update ADR020
* Fix compile errors
* Fix ADR
* Make ante tests pass
* Fix remaining ante handler tests
* Simplify code
* Fix x/bank app_test
* Fix tests
* Remove useless accSeq from signerdata
* Fix test
* Update simapp/helpers/test_helpers.go
Co-authored-by: Alexander Bezobchuk <alexanderbez@users.noreply.github.com>
* Update simapp/helpers/test_helpers.go
Co-authored-by: Alexander Bezobchuk <alexanderbez@users.noreply.github.com>
* Update x/auth/client/cli/tx_multisign.go
Co-authored-by: Alexander Bezobchuk <alexanderbez@users.noreply.github.com>
* Address rewview
* Update x/auth/ante/sigverify.go
Co-authored-by: Simon Warta <2603011+webmaster128@users.noreply.github.com>
* Update x/auth/ante/sigverify_test.go
Co-authored-by: Simon Warta <2603011+webmaster128@users.noreply.github.com>
* Update x/auth/tx/builder_test.go
Co-authored-by: Simon Warta <2603011+webmaster128@users.noreply.github.com>
* Update x/auth/tx/builder_test.go
Co-authored-by: Simon Warta <2603011+webmaster128@users.noreply.github.com>
* Update x/auth/tx/direct_test.go
Co-authored-by: Simon Warta <2603011+webmaster128@users.noreply.github.com>
* Update x/auth/tx/builder_test.go
Co-authored-by: Simon Warta <2603011+webmaster128@users.noreply.github.com>
* AccSeq -> Seq
* Address reviews
* Better variable naming
* Fix variable assign
* Remove old SetSignerInfo
* Fix test
* proto-gen
* Make proto-gen
* Reput gw comment
* Add Changelog
* Update x/bank/app_test.go
Co-authored-by: Alexander Bezobchuk <alexanderbez@users.noreply.github.com>
* Update x/bank/app_test.go
Co-authored-by: Alexander Bezobchuk <alexanderbez@users.noreply.github.com>
Co-authored-by: Alexander Bezobchuk <alexanderbez@users.noreply.github.com>
Co-authored-by: SaReN <sahithnarahari@gmail.com>
Co-authored-by: Simon Warta <2603011+webmaster128@users.noreply.github.com>
2020-08-21 14:20:47 +00:00
Aaron Craelius
94b3cc50b4
Add RejectExtensionOptionsDecorator ( #6988 )
...
* Add RejectExtensionOptionsDecorator
* Fix error code
* Fix lint
* Add ExtensionOptionsTxBuilder
* Add tests
* Add tests
* Update tests
* Docs
Co-authored-by: sahith-narahari <sahithnarahari@gmail.com>
Co-authored-by: Alexander Bezobchuk <alexanderbez@users.noreply.github.com>
2020-08-18 13:44:56 +00:00
Alexander Bezobchuk
9ae17669d6
Tx Height Timeout ( #6089 )
...
* Implement TxHeightTimeoutDecorator
* Update error message
* rename type
* set height timeout
* update tests
* update *SignDoc)
* rename
* remove dup
* fix build
* cli updates
* rest updates
* cl++
* Update x/auth/ante/basic.go
Co-authored-by: colin axnér <25233464+colin-axner@users.noreply.github.com>
* Update x/auth/ante/basic.go
Co-authored-by: colin axnér <25233464+colin-axner@users.noreply.github.com>
* Update x/auth/ante/basic.go
Co-authored-by: colin axnér <25233464+colin-axner@users.noreply.github.com>
* Update x/auth/ante/basic.go
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
* rename
* rename
* remove TimeoutHeight from SignDoc
* updates
* fix tests
* update IBC cmd flags
* use omitempty
* update godoc
* add test case to TestStdSignBytes
Co-authored-by: colin axnér <25233464+colin-axner@users.noreply.github.com>
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
2020-08-07 23:32:22 +00:00
Alexander Bezobchuk
9ebda4edb9
Server/simd: Viper Removal ( #6599 )
...
* init commit
* remove viper from tm cmds
* updates
* Undo x/bank/client/cli/tx.go
* Fix unit tests
* lint++
* rename var
* Fix genutil test
* fix test
* prefer cmd.Flags() over direct viper usage
* update
* fix ABCI error tests
* fix integration tests
* Add viper to context
* fix build
* fix unit test
* Implement and use AppOptions
* Revert Redact godoc
Co-authored-by: Alessio Treglia <alessio@tendermint.com>
2020-07-05 16:56:17 +00:00
colin axner
6973c56457
x/ibc: fix internal errors messages ( #6268 )
...
* update errors in ibc client and localhost
* update code 1 errors
* fix misisng import
* add import
* fix compile and lint issues
* fix lint
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
2020-05-22 17:17:52 -04:00
Federico Kunze
48aebed2ea
x/ibc: /types cleanup ( #6169 )
...
* x/ibc: move /types to /common
* x/ibc/types: remove errors
* remove mocked proofs
* remove invalidProof{}
* create new ibc/types dir
* format
* move keys to host
* move order to channel
* move channel state
* move connection state
* lint
2020-05-13 19:23:33 -04:00
Aaron Craelius
bb4642ad0d
Decouple client/tx from x/auth ( #5992 )
...
As part of #5864 part 2), this PR decouples the new client/tx
package from x/auth (as an incremental step to deprecating
all the tx logic in x/auth) and adds StdFee, StdSignature,
StdSignMsgBase and StdTxBase to codec/std, while
deprecating the corresponding types in x/auth.
2020-04-15 23:55:02 +02:00
Alessio Treglia
0ba4e3a630
types/errors: make Wrap() work like github.com/pkg/errors.Wrap
...
Wrap(ErrInsufficientFunds, "40 < 500") returns strings like
"insufficient funds: 40 < 50". Although he function syntax
fits perfectly SDK app developers use case and as such it
should not be changed, the interface is still counter-intuitive
as most Golang developers may reasonably expect a different
result similar to what other popular libraries' (see [1])
would produce (e.g. "40 < 500: insufficient funds").
Follow up PR of #5876 .
[1] https://godoc.org/github.com/pkg/errors#Wrapf
2020-03-28 00:19:44 +01:00
Federico Kunze
9cce836c08
crypto/keys: move keybase and keyring to crypto/keyring/ dir ( #5866 )
...
* crypto/keys: move keybase and keyring to crypto/keyring/ dir
* Update client/keys/root.go
* Update crypto/keyring/errors.go
* Update crypto/keyring/keybase.go
* Update crypto/keyring/options.go
* format
* changelog
* fix build
* format
* lint
2020-03-25 15:20:36 +00:00
Alessio Treglia
da5c6ced1d
types: add test cases ( #5747 )
...
Upgrade gomock dependency.
2020-03-04 17:49:59 +00:00
Alexander Bezobchuk
a63de303b8
Merge PR #5665 : Bump Module ABCI Error Codes
2020-02-18 14:43:00 +01:00
Ferenc Fabian
67c2acd75a
Merge PR #5484 : Add errors.Is support to the wrappedError
2020-01-08 13:41:10 -05:00
Alexander Bezobchuk
9a183ffbcc
Merge PR #5421 : Refactor Error Handling
2019-12-27 12:57:54 -05:00
Alexander Bezobchuk
95ddc242ad
Merge PR #5240 : x/evidence module implementation
2019-11-06 14:08:02 -07:00
Marko
b9490f2d93
Merge PR #5203 : Add more linters
2019-10-17 09:47:35 -04:00
Marko
936cffef40
Merge PR #5055 : Added Prealloc, Gosec, Golint linters
2019-09-17 12:13:26 -04:00
Marko
3a4f1fc4d4
Merge PR #4881 : Linting Galore
2019-08-19 12:06:27 -04:00
colin axner
3eac2707b2
Merge PR #4908 : Various goreport fixes
2019-08-15 09:54:10 -04:00
Ethan Frey
68dd969b4d
Merge PR #4821 : Port weave errors package
2019-07-31 12:37:11 -04:00