Commit Graph

27 Commits

Author SHA1 Message Date
Christopher Goes 3387261e6b Add comment outlining safety of commission-withdraw (#3175) 2018-12-19 14:36:25 -08:00
Hendrik Hofstadt 2be19b9d33 Merge PR #3163: Withdraw commission on self bond removal
* Withdraw commission on self bond removal
* Update PENDING.md
2018-12-19 17:05:33 +01:00
Jae Kwon bc51fa93b6
Fix updateValidatorDistInfoFromPool (#3046)
Fixes regression introduced by #2984.
Continuiation of #3033 , which didn't fix the simulation issues.
(candidate) Complete solution for #3019, 9002 halt bug.

From #2984, it isn't sufficient to take the fee pool rewards of a validator. Since we don't track delegator accums (as we do with validator accums), and because onValidatorModified >updateValidatorDistInfoFromPool is also being called upon delegation updates (or at least I believe this is the reason), it is necessary to also withdraw self delegation.

TODO: I don't think self-delegation should be required to be modified here... consider using a delegation hook to do the self-delegation withdraw part instead, e.g. splitting the updateValidatorDistInfoFromPool function into two. It might not result in cleaner code, however. Think hard.
2018-12-08 07:18:04 -08:00
Alexander Bezobchuk 6395e2a7ab Merge PR #2984: Removal of Mandatory Self-Delegation Reward
* Some minor cleanup and reformatting to make things easier to understand

* Update onDelegationSharesModified hook

* Add pending log

* Address PR comments

* Fix linting
2018-12-04 17:53:52 -05:00
frog power 4000 7cb1ba625e blockly minting (#2825)
* update mechanism to use average block time
* correctly sets accum height for zero-delegations
* update Decimal Format()
* clip withdrawal tokens
* PositiveDelegationInvariant
* DelegatorSharesInvariant
* DelAccumInvariants
2018-11-26 04:13:47 -08:00
Christopher Goes 94f45311a0 Fix state export/import, add to CI (#2690)
* Update slashing import/export
* More slashing.WriteGenesis
* Add test import/export to CI
* Store equality comparison.
* Fix validator bond intra-tx counter
* Set timeslices for unbonding validators
* WriteGenesis => ExportGenesis
* Delete validators from unbonding queue when re-bonded
* Hook for validator deletion, fix staking genesis tests
2018-11-08 16:28:28 -08:00
Jae Kwon 336415baea
Fix simulation bugs; Incorprates #2676 from Sunny (#2677)
* Fix simulation bugs; Incorprates #2676 from Sunny
* Address review feedback; Update PENDING
2018-11-04 22:11:03 -08:00
Rigel d71f38bdac Merge PR #2597: Add distribution accum invariants 2018-10-26 13:42:53 +02:00
Jae Kwon 0f1fb179c4 Merge PR #2599 from cosmos/jae/dist_refactor
* Rename Pool -> DelRewards; PoolCommission -> ValCommision
* FeePool.Pool -> FeePool.ValPool
* WithdrawalHeight->DelPoolWithdrawalHeight
* OnValidatorBeginUnbonding
* Caught the bug's tail
* Update vi.FeePoolWithdrawalHeight upon bonding
* Fix staking slashUnbondingDelegation bug; fixes simulator failure #9
2018-10-26 13:27:55 +02:00
Christopher Goes 2a279e954f Remove logs from prior debugging 2018-10-25 13:22:54 +02:00
Christopher Goes edd56be952 Cleanup, additional item in PENDING.md 2018-10-23 18:29:39 +02:00
Christopher Goes be66a4950e Remove debugging print statements 2018-10-23 15:50:35 +02:00
rigelrozanski 5a559f75c5 simulation stop early with no proposers 2018-10-22 23:55:49 -04:00
Jae Kwon fa3730a5d2 WIP looking for bug... 2018-10-22 19:48:28 -07:00
Jae Kwon ea565baa60 WIP intermediate... 2018-10-22 17:49:53 -07:00
rigelrozanski 278d23776b call hook on slashing 2018-10-22 14:59:00 -04:00
Christopher Goes c88fc481d4 Fix linter issues 2018-10-20 01:05:07 +02:00
Christopher Goes 255a6a5db8 Cleanup to one hook 2018-10-20 00:19:10 +02:00
Christopher Goes 7770aec306 Withdraw rewards on bonded to unbonding 2018-10-20 00:13:44 +02:00
Christopher Goes 25ce0dea00 Update stake module simulation and fix linter errors 2018-10-18 22:08:00 +02:00
rigelrozanski f4f39ae03f allocation tests 2018-10-10 23:16:49 -04:00
rigelrozanski 900a5f47f6 keeper_test 2018-10-10 22:53:25 -04:00
rigelrozanski 22de85651f fix distr initialization 2018-10-09 21:59:07 -04:00
rigelrozanski e304b9c600 debugging simulation 2018-10-05 20:32:06 -04:00
rigelrozanski 60a3541380 major debugs 2018-09-28 03:29:52 -04:00
rigelrozanski 251a81f589 yay it compiles 2018-09-20 00:53:48 -04:00
rigelrozanski 5dabd1bf6d the errors never want to seem to end... 2018-09-19 22:54:46 -04:00