a8ef4a380d
All Makefile proto commands use Docker ( #7931 )
...
* Update tooling around docker
* Run commands
* Remove swagger gen for now
* Update proto-gen-any
* Fix indentn
* Use CURDIR
Co-authored-by: Alessio Treglia <alessio@tendermint.com>
2020-11-13 16:36:58 +00:00
f3e4964f2f
Add TxsByEvent gRPC endpoint ( #7842 )
...
* add service definition for TxsByEvents
* add TxsByEvent gRPC endpoint
* fix lint
* fix test
* review changes
* review changes
* fix proto descriptions
* review changes
* fix lint
* review changes
* Update proto/cosmos/tx/v1beta1/service.proto
* review changes
Co-authored-by: Aleksandr Bezobchuk <alexanderbez@users.noreply.github.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
2020-11-12 14:22:54 +00:00
1961935fc7
Add GetTx gRPC endpoint ( #7688 )
...
* Add empty TxByHash
* Fix search & replace
* Renname to GetTx
* Make getTx grpc work
* Hash as string
* Add todo comment
* /tx
* Make tests pass
* Put into function
* Add changelog
* Fix lint
* RegisterTxService in server
* Remove comment
* Update proto/cosmos/tx/v1beta1/service.proto
Co-authored-by: Cory <cjlevinson@gmail.com>
* Create new protoCdc
* Move tx service to x/auth
* Small tweaks
* Link gh issue
* Fix lint
* Update x/auth/tx/service.go
Co-authored-by: Aleksandr Bezobchuk <alexanderbez@users.noreply.github.com>
Co-authored-by: Cory <cjlevinson@gmail.com>
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
Co-authored-by: Aleksandr Bezobchuk <alexanderbez@users.noreply.github.com>
Co-authored-by: SaReN <sahithnarahari@gmail.com>
2020-10-30 12:32:02 +00:00
bd9af94174
Use embedded lib key type in sdk pub keys instead of bytes. ( #7672 )
...
* Remove duplicate print message on keys add command (#7654 )
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
* ed25519: use stdlib/crypto types
* use standard package testing
* use crypto/ed25519 instead of golang.org/x/crypto/ed25519
In Go 1.13 the new crypto/ed25519 package implements the Ed25519 signature scheme.
This functionality was previously provided by the golang.org/x/crypto/ed25519 package,
which becomes a wrapper for crypto/ed25519 when used with Go 1.13+.
* use standard package testing for secp256k1 tests
* secp256k1: add cross packages signature checks
* ed25519: rollback the _test package name
* rename underlyingSecp256k1 to btcSecp256k1
* package update
Co-authored-by: Denis Fadeev <denis@fadeev.org>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
2020-10-28 10:24:41 +00:00
6bc8ff2dfe
Use any as validator pubkey ( #7597 )
...
* protobuf pubkey type update
* wip2
* wip3
* solving types.NewValidator issues
* remove bech32 from validator type assignment
* update Validator interface
* Changelog update
* wip4
* update genutil
* fix simapp & x/ibc/testing tests
* update staking
* changelog update
* fix import cycle in tests
* fix amino panic on TestValidatorMarshalUnmarshalJSON
* fix TestValidatorMarshalUnmarshalJSON consensus_pubkey check
* Add UnpackInterfaces to HistoricalInfo
* fix TestHistoricalInfo
* update todos
* fix: Expecting ed25519.PubKey to implement proto.Message
* fix linter issues
* Fix migrate test
* Update CHANGELOG.md
Co-authored-by: Marie Gauthier <marie.gauthier63@gmail.com>
* review comments
* cosmetic changes
* add UnpackInterfaces got GenesisRandomized test
* Validator.Equal reuses Validator.MinEqual
* fix test
* use Validator.Equal in tests
* Fix staking simulation TestRandomizedGenState
* Remove TODO
* use HistoricalInfo.Equal
* use proto.Equal
* rename Validator.GetConsPubKey to TmConsPubKey
* prefer require.Equal over reflect.DeepEqual
* SetHistoricalInfo using a pointer
* Fix TestQueryDelegation test
* Fix TestQueryValidators test
* Fix TestSimulateMsgUnjail test
* experiement with LegacyAmino instances
* Register codecs in all simapp tests
* Fix cli_test compilation problems
* fix typo sdk -> std
* fix typo
* fix TestPlanStringer
* Rename to MakeEncodingConfig
* Remove RegisterCodecsTests
* Use gRPC in GetCmdQueryValidators
* Empty status
* fix info log check
* linter fixes
* rename simapparams to simappparams
* Update simapp/test_helpers.go
Co-authored-by: Marie Gauthier <marie.gauthier63@gmail.com>
* comments updates
* use valAddr1 instead of sdk.ValAddress(pk1.Address().Bytes())
Co-authored-by: Cory Levinson <cjlevinson@gmail.com>
Co-authored-by: Amaury Martiny <amaury.martiny@protonmail.com>
Co-authored-by: Marie Gauthier <marie.gauthier63@gmail.com>
2020-10-23 12:07:52 +00:00
8eaf2ececc
Refactor x/staking Validation and Delegation tests based on MsgCreateValidator.Pubkey type change. ( #7526 )
...
* testing: refactore Validation and Delegation handling of x/staking
This Changeset introduces set of improvements for writing tests.
The idea is to create a testing subpackage which will provide functions
to make tests more dev-friendly and wrap higher level use-cases.
Here is a show-up of of creating a service for staking module
for tests.
This PR also changes the `x/staking/types.MsgCreateValidator.Pubkey` from string
to types.Any. This change motivated the other change to show the pattern I'm describing here.
* add validator checks
* type change fixes
* use deprecated
* adding test slashing
* new network comment update
* working on tests
* Fix TestMsgPkDecode test
* Add UnpackInterfaces to MsgCreateValidator
* Fix tests
* Convert bech32 pubkey to proto
* Fix test
* fix v039/migrate_test/TestMigrate
* fix tests
* testslashing: rename Service to Helper
* file rename
* update TestMsgDecode
Co-authored-by: blushi <marie.gauthier63@gmail.com>
Co-authored-by: Amaury Martiny <amaury.martiny@protonmail.com>
Co-authored-by: Cory Levinson <cjlevinson@gmail.com>
2020-10-19 13:04:55 +00:00
8138605aed
Refactor x/auth/vesting to use ADR-031 ( #7551 )
...
* update auth/vesting module to use proto msg services
* rm accidental tmp files
* Update x/auth/vesting/msg_server.go
Co-authored-by: Marie Gauthier <marie.gauthier63@gmail.com>
* golangci-lint fix
Co-authored-by: Marie Gauthier <marie.gauthier63@gmail.com>
Co-authored-by: Aaron Craelius <aaron@regen.network>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
2020-10-19 09:22:56 +00:00
58eabcb71f
Refactor x/evidence to ADR-031 ( #7538 )
...
* Refactor x/evidence to ADR-031
* Add hash in response
* Update changelog
* Update x/evidence/keeper/keeper.go
* Update proto/cosmos/evidence/v1beta1/tx.proto
Co-authored-by: Marie Gauthier <marie.gauthier63@gmail.com>
* Use msgServer struct
Co-authored-by: Marie Gauthier <marie.gauthier63@gmail.com>
2020-10-16 16:05:25 +00:00
18ef33caff
Refactor x/staking according to ADR 031 ( #7556 )
...
* Refactor x/staking according to ADR 031
* lint
* review changes
* review changes
* review changes
Co-authored-by: Aaron Craelius <aaron@regen.network>
2020-10-16 14:53:49 +00:00
6e569e1255
Refactor x/{gov, crisis} according to ADR 031 ( #7533 )
...
* Refactor x/gov according to ADR 31
* fix tests
* Refactor x/crisis according to ADR 031
* fix lint
* lint
* lint
* review changes
* lint
* review change
* fic doc
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
2020-10-16 13:04:02 +00:00
c59a04d70f
[x/slashing] Implement Protobuf Msg Services ( #7557 )
...
* Update x/slashing to use proto msg service
* Fix proto-gen
Co-authored-by: Aaron Craelius <aaron@regen.network>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
2020-10-15 14:38:15 +00:00
bf7165414d
Refactor x/distribution according to ADR 031 ( #7524 )
...
* Refactor x/distribution according to ADR 31
* lint
* removed unused
* Apply suggestions from code review
Co-authored-by: Marie Gauthier <marie.gauthier63@gmail.com>
Co-authored-by: Aaron Craelius <aaron@regen.network>
Co-authored-by: Marie Gauthier <marie.gauthier63@gmail.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
2020-10-15 13:54:16 +00:00
9be15a42b9
Refactor x/bank according to ADR 031 ( #7520 )
...
* Refactor x/bank according to ADR 031
* Add comment
* Update comment
* Add comment
* Add tests, address edge cases
* Imports
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
2020-10-13 09:05:46 +00:00
33e7297c79
Use enum instead of int32 for BondStatus ( #7499 )
...
* Migrate staking module
* Add gov legacy
* Add comments
* Add x/distrib
* x/crisis
* x/mint
* Fix test
* migrate x/genutil
* Fix lint
* Fix staking constants
* Fix test
* Update x/genutil/legacy/v040/migrate.go
Co-authored-by: Marie Gauthier <marie.gauthier63@gmail.com>
* Add migrate script instead of change BondStatus constants
* Change staking bondStatus to enum
* Fix test
* Fix another test
* Remove staking exported
* fix references
* Better constants
* Fix build
* Fix lint
* Remove buf version
* Fix tests
* Fix test
Co-authored-by: Marie Gauthier <marie.gauthier63@gmail.com>
Co-authored-by: Aleksandr Bezobchuk <alexanderbez@users.noreply.github.com>
2020-10-12 13:56:02 +00:00
4a1b2fba43
Add Fee granter field ( #7418 )
...
* WIP on adding Fee granter field
* WIP on adding Fee granter field
* WIP on adding Fee granter field
* Update comments, add tests
2020-10-05 21:56:09 +00:00
d9ede6551a
0.39->0.40 CLI `migrate` command ( #6839 )
...
* WIP on BaseAccount protobuf pub_key
* WIP on BaseAccount.PubKey
* Migrate supply
* Change validator_slash_event
* Add evidence
* Add evidence to genutil migrate
* Fix lint
* Add println
* No _ in package name
* Add slashing migrate
* Add tests for slashing
* Add capacity to array
* stray fmt.Prinlnt
* WIP on BaseAccount pub key
* Put current types in v0_40
* Add evidence old types
* Remove useless impl
* Add RegisterInterface
* Add clientCtx to argument
* Register evidence interfaces
* Update PubKey
* Update Account
* Docs
* WIP on protobuf keys
* Use Type() and Bytes() in sr25519 pub key Equals
* Add tests
* Add few more tests
* Update other pub/priv key types Equals
* Fix PrivKey's Sign method
* Rename variables in tests
* Fix infinite recursive calls
* Use tm ed25519 keys
* Add Sign and VerifySignature tests
* Remove ed25519 and sr25519 references
* proto linting
* Add proto crypto file
* Implement some of the new multisig proto type methods
* Add tests for MultisigThresholdPubKey
* Add tests for pubkey pb/amino conversion functions
* Move crypto types.go and register new proto pubkeys
* Add missing pointer ref
* Address review comments
* panic in MultisigThresholdPubKey VerifySignature
* Fix compile errors
* Remove pk conversion in ante handler
* Use internal crypto.PubKey in multisig
* Add tests for MultisigThresholdPubKey VerifyMultisignature
* Only keep LegacyAminoMultisigThresholdPubKey and move to proto keys to v1
* Remove conversion functions and introduce internal PubKey type
* Override Amino marshaling for proto pubkeys
* Merge master
* Make proto-gen
* Start removal of old PubKeyMultisigThreshold references
* Fix tests
* Fix solomachine
* Fix ante handler tests
* Pull latest go-amino
* Remove ed25519
* Remove old secp256k1 PubKey and PrivKey
* Uncomment test case
* Fix linting issues
* More linting
* Revert tests keys values
* Add Amino overrides to proto keys
* Add pubkey test
* Fix tests
* Use threshold isntead of K
* Standardize Type
* Revert standardize types commit
* Fix build
* Fix lint
* Fix lint
* Add comment
* Register crypto.PubKey
* Add empty key in BuildSimTx
* Simplify proto names
* Unpack interfaces for signing desc
* Fix IBC tests?
* Format proto
* Use secp256k1 in ibc
* Fixed merge issues
* Uncomment tests
* Update x/ibc/testing/solomachine.go
* UnpackInterfaces for solomachine types
* Remove old multisig
* Add amino marshal for multisig
* Fix lint
* Correctly register amino
* One test left!
* Remove old struct
* Fix test
* Fix test
* Unpack into tmcrypto
* Remove old threshold pubkey tests
* Fix register amino
* Fix lint
* Use sdk crypto PubKey in multisig UnpackInterfaces
* Potential fix?
* Register LegacyAminoPubKey
* Register our own PubKey
* Register tmcrypto PubKey
* Register both PubKeys
* Register interfaces in test
* Refactor fiels
* Add comments
* Remove old cosmos-sdk/crypto/keys reference
* Use anil's suggestion
* Add norace back
* Use our own ed25519
* Fix pubkey types
* Fix network tests
* Fix more tests
* Make ibc work?
* Use TM pubkey in NewValidator
* Fix lint
* Put interface in tpyes
* rerun CI
* Better name register
* Remove stray code
* Add ed25519 tests
* Check nil
* Correct interface impl assert
* rerun CI
* Add fix for Bech32
* Address comments
* FIx lint
* Add tests for solomachine unpack interfaces
* Fix query tx by hash
* Better name in amino register
* Fix lint
* Add back ed25519 test (fixes #7352 )
* go mod tidy
* Fix merge issues
* Sort import
* Add test for backwards-compatibility
* Fix tests
* Fix merge issue
* Fix merge issues
* Fix tests build
* Fix tests
* Marshal to proto
* Fix 040 marshalling
* Remove dontcover
* Fix equivocation
* Add vesting
* Fix vesting
* Fix slashing test
* Fix evidence test
* Remove pb.go files
* Fix legacy auth tests
* deterministic tests help
* Fix auth tests
* Remove useless code
* Small cleanups
* Add comment
* Fix migrate hub
* fmt.Println
* No need to marshal indent
* Update proto comment
* Fix merge issues
* Support nil pubkey
* Use protobuf empty
* Address comments
* Fix tests
* Unify legacy package names
Co-authored-by: Aaron Craelius <aaronc@users.noreply.github.com>
Co-authored-by: Aaron Craelius <aaron@regen.network>
Co-authored-by: blushi <marie.gauthier63@gmail.com>
Co-authored-by: Alexander Bezobchuk <alexanderbez@users.noreply.github.com>
Co-authored-by: colin axnér <25233464+colin-axner@users.noreply.github.com>
Co-authored-by: Zaki Manian <zaki@manian.org>
Co-authored-by: Alessio Treglia <alessio@tendermint.com>
2020-10-05 21:28:14 +00:00
01fd22d244
ibc: upgrade client ( #7367 )
...
* implement upgrade module changes
* implement client changes
* implement core tendermint logic
* remove assumption that new client state has same structure as old
* fix light client builds
* fix rest of build
* fix tendermint tests
* fix all tests except MarshalJSON
* fix, marshalUpgrade fails
* Apply suggestions from code review
* minor updates
* update proto and validate path
* fix MarshalJSON panic
* hack my way to first passing test case
* add rest of upgrade test cases
* fix plan tests
* add keeper tests
* fix upgrade tests
* add more tests
* add upgrade path validation to ValidateSelfClient
* validate upgradedClient
* fix upgrade handler tests
* appease linter
* Apply suggestions from code review
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
* change signer to string in proto
* lint
* start address @colin-axner review
* improve test coverage
* fix abci stringer test
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
Co-authored-by: Federico Kunze <federico.kunze94@gmail.com>
2020-10-01 03:21:57 -03:00
d917520092
Add fee payer to protobuf definition ( #7384 )
...
* Add fee payer to protobuf definition
* Compile new tx type
* Use FeePayer from Tx, add it to required signers
* Add unit tests on proper handling of FeePayer field
* Use string address for fee payer field
* Update logic for string feePayer
2020-09-30 09:03:44 +00:00
489599b70f
Remove the old message PublicKey proto oneof ( #7390 )
...
* Remove unused PublicKey type and update docs
* Update wording
* Update proto/cosmos/base/crypto/v1beta1/crypto.proto
Co-authored-by: Amaury Martiny <amaury.martiny@protonmail.com>
* Edit docs
* Move crypto.proto to multisig
* Proto linting
* Update docs/architecture/adr-020-protobuf-transaction-encoding.md
Co-authored-by: Amaury Martiny <amaury.martiny@protonmail.com>
* Update wording for Public Key Encoding
Co-authored-by: Amaury Martiny <amaury.martiny@protonmail.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Co-authored-by: Robert Zaremba <robert@zaremba.ch>
2020-09-29 10:01:54 +00:00
d55c1a2665
Change `address` from bytes to bech32 strings ( #7242 )
...
* init
* Fix bank proto messages
* missing conversions
* remove casttype for addresses
* Fix tests
* Fix consaddress
* more test fixes
* Fix tests
* fixed tests
* migrate missing proto declarations
* format
* Fix format
* Fix alignment
* Fix more tests
* Fix ibc merge issue
* Fix fmt
* Fix more tests
* Fix missing address declarations
* Fix staking tests
* Fix more tests
* Fix config
* fixed tests
* Fix more tests
* Update staking grpc tests
* Fix merge issue
* fixed failing tests in x/distr
* fixed sim tests
* fixed failing tests
* Fix bugs
* Add logs
* fixed slashing issue
* Fix staking grpc tests
* Fix all bank tests :)
* Fix tests in distribution
* Fix more tests in distr
* Fix slashing tests
* Fix statking tests
* Fix evidence tests
* Fix gov tests
* Fix bug in create vesting account
* Fix test
* remove fmt
* fixed gov tests
* fixed x/ibc tests
* fixed x/ibc-transfer tests
* fixed staking tests
* fixed staking tests
* fixed test
* fixed distribution issue
* fix pagination test
* fmt
* lint
* fix build
* fix format
* revert tally tests
* revert tally tests
* lint
* Fix sim test
* revert
* revert
* fixed tally issue
* fix tests
* revert
* fmt
* refactor
* remove `GetAddress()`
* remove fmt
* revert fmt.Striger usage
* Fix tests
* Fix rest test
* disable interfacer lint check
* make proto-format
* add nolint rule
* remove stray println
Co-authored-by: aleem1314 <aleem.md789@gmail.com>
Co-authored-by: atheesh <atheesh@vitwit.com>
2020-09-25 10:25:37 +00:00
91ca8ad3c1
Migrate BaseAccount PubKey to use Any ( #7268 )
...
* WIP on BaseAccount protobuf pub_key
* WIP on BaseAccount.PubKey
* WIP on BaseAccount pub key
* Update PubKey
* Update Account
* Docs
* WIP on protobuf keys
* Use Type() and Bytes() in sr25519 pub key Equals
* Add tests
* Add few more tests
* Update other pub/priv key types Equals
* Fix PrivKey's Sign method
* Rename variables in tests
* Fix infinite recursive calls
* Use tm ed25519 keys
* Add Sign and VerifySignature tests
* Remove ed25519 and sr25519 references
* proto linting
* Add proto crypto file
* Implement some of the new multisig proto type methods
* Add tests for MultisigThresholdPubKey
* Add tests for pubkey pb/amino conversion functions
* Move crypto types.go and register new proto pubkeys
* Add missing pointer ref
* Address review comments
* panic in MultisigThresholdPubKey VerifySignature
* Fix compile errors
* Remove pk conversion in ante handler
* Use internal crypto.PubKey in multisig
* Add tests for MultisigThresholdPubKey VerifyMultisignature
* Only keep LegacyAminoMultisigThresholdPubKey and move to proto keys to v1
* Remove conversion functions and introduce internal PubKey type
* Override Amino marshaling for proto pubkeys
* Merge master
* Make proto-gen
* Start removal of old PubKeyMultisigThreshold references
* Fix tests
* Fix solomachine
* Fix ante handler tests
* Pull latest go-amino
* Remove ed25519
* Remove old secp256k1 PubKey and PrivKey
* Uncomment test case
* Fix linting issues
* More linting
* Revert tests keys values
* Add Amino overrides to proto keys
* Add pubkey test
* Fix tests
* Use threshold isntead of K
* Standardize Type
* Revert standardize types commit
* Fix build
* Fix lint
* Fix lint
* Add comment
* Register crypto.PubKey
* Add empty key in BuildSimTx
* Simplify proto names
* Unpack interfaces for signing desc
* Fix IBC tests?
* Format proto
* Use secp256k1 in ibc
* Fixed merge issues
* Uncomment tests
* Update x/ibc/testing/solomachine.go
* UnpackInterfaces for solomachine types
* Remove old multisig
* Add amino marshal for multisig
* Fix lint
* Correctly register amino
* One test left!
* Remove old struct
* Fix test
* Fix test
* Unpack into tmcrypto
* Remove old threshold pubkey tests
* Fix register amino
* Fix lint
* Use sdk crypto PubKey in multisig UnpackInterfaces
* Potential fix?
* Register LegacyAminoPubKey
* Register our own PubKey
* Register tmcrypto PubKey
* Register both PubKeys
* Register interfaces in test
* Refactor fiels
* Add comments
* Remove old cosmos-sdk/crypto/keys reference
* Use anil's suggestion
* Add norace back
* Use our own ed25519
* Fix pubkey types
* Fix network tests
* Fix more tests
* Make ibc work?
* Use TM pubkey in NewValidator
* Fix lint
* Put interface in tpyes
* rerun CI
* Better name register
* Remove stray code
* Add ed25519 tests
* Check nil
* Correct interface impl assert
* rerun CI
* Add fix for Bech32
* Address comments
* FIx lint
* Add tests for solomachine unpack interfaces
* Fix query tx by hash
* Better name in amino register
* Fix lint
* Add back ed25519 test (fixes #7352 )
* go mod tidy
* Fix merge issues
* Sort import
* Add test for backwards-compatibility
* Fix tests
* Fix merge issue
* Update client/context.go
Co-authored-by: Cory <cjlevinson@gmail.com>
* Update types/address.go
Co-authored-by: Cory <cjlevinson@gmail.com>
* Address feedback
* Add comment
* Fix BaseAccount SetPubKey and address further comments
* Lint
* Remove unnecessary use of copy in getPubKeyFromString
* Update comment
Co-authored-by: Aaron Craelius <aaronc@users.noreply.github.com>
Co-authored-by: Aaron Craelius <aaron@regen.network>
Co-authored-by: Amaury Martiny <amaury.martiny@protonmail.com>
Co-authored-by: Alexander Bezobchuk <alexanderbez@users.noreply.github.com>
Co-authored-by: colin axnér <25233464+colin-axner@users.noreply.github.com>
Co-authored-by: Cory <cjlevinson@gmail.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
2020-09-25 08:41:16 +00:00
7cd25abb87
Proto Tx with Any ( #7276 )
...
* WIP on protobuf keys
* Use Type() and Bytes() in sr25519 pub key Equals
* Add tests
* Add few more tests
* Update other pub/priv key types Equals
* Fix PrivKey's Sign method
* Rename variables in tests
* Fix infinite recursive calls
* Use tm ed25519 keys
* Add Sign and VerifySignature tests
* Remove ed25519 and sr25519 references
* proto linting
* Add proto crypto file
* Implement some of the new multisig proto type methods
* Add tests for MultisigThresholdPubKey
* Add tests for pubkey pb/amino conversion functions
* Move crypto types.go and register new proto pubkeys
* Add missing pointer ref
* Address review comments
* panic in MultisigThresholdPubKey VerifySignature
* Use internal crypto.PubKey in multisig
* Add tests for MultisigThresholdPubKey VerifyMultisignature
* Only keep LegacyAminoMultisigThresholdPubKey and move to proto keys to v1
* Remove conversion functions and introduce internal PubKey type
* Override Amino marshaling for proto pubkeys
* Merge master
* Make proto-gen
* Start removal of old PubKeyMultisigThreshold references
* Fix tests
* Fix solomachine
* Fix ante handler tests
* Pull latest go-amino
* Remove ed25519
* Remove old secp256k1 PubKey and PrivKey
* Uncomment test case
* Fix linting issues
* More linting
* Revert tests keys values
* Add Amino overrides to proto keys
* Add pubkey test
* Fix tests
* Use threshold isntead of K
* Standardize Type
* Revert standardize types commit
* Fix build
* Fix lint
* Fix lint
* Add comment
* Register crypto.PubKey
* Add empty key in BuildSimTx
* Simplify proto names
* Unpack interfaces for signing desc
* Fix IBC tests?
* Format proto
* Use secp256k1 in ibc
* Fixed merge issues
* Uncomment tests
* Update x/ibc/testing/solomachine.go
* UnpackInterfaces for solomachine types
* Remove old multisig
* Add amino marshal for multisig
* Fix lint
* Correctly register amino
* One test left!
* Remove old struct
* Fix test
* Fix test
* Unpack into tmcrypto
* Remove old threshold pubkey tests
* Fix register amino
* Fix lint
* Use sdk crypto PubKey in multisig UnpackInterfaces
* Potential fix?
* Register LegacyAminoPubKey
* Register our own PubKey
* Register tmcrypto PubKey
* Register both PubKeys
* Register interfaces in test
* Refactor fiels
* Add comments
* Use anil's suggestion
* Add norace back
* Check nil
* Address comments
* FIx lint
* Add tests for solomachine unpack interfaces
* Fix query tx by hash
* Better name in amino register
* Display StdTx instead of proto Tx
* Remove useless check
Co-authored-by: Aaron Craelius <aaronc@users.noreply.github.com>
Co-authored-by: blushi <marie.gauthier63@gmail.com>
Co-authored-by: Alexander Bezobchuk <alexanderbez@users.noreply.github.com>
Co-authored-by: colin axnér <25233464+colin-axner@users.noreply.github.com>
2020-09-21 16:48:28 +00:00
320a852ee2
PubKey proto types ( #7147 )
...
* WIP on protobuf keys
* Use Type() and Bytes() in sr25519 pub key Equals
* Add tests
* Add few more tests
* Update other pub/priv key types Equals
* Fix PrivKey's Sign method
* Rename variables in tests
* Fix infinite recursive calls
* Use tm ed25519 keys
* Add Sign and VerifySignature tests
* Remove ed25519 and sr25519 references
* proto linting
* Add proto crypto file
* Implement some of the new multisig proto type methods
* Add tests for MultisigThresholdPubKey
* Add tests for pubkey pb/amino conversion functions
* Move crypto types.go and register new proto pubkeys
* Add missing pointer ref
* Address review comments
* panic in MultisigThresholdPubKey VerifySignature
* Use internal crypto.PubKey in multisig
* Add tests for MultisigThresholdPubKey VerifyMultisignature
* Only keep LegacyAminoMultisigThresholdPubKey and move to proto keys to v1
* Remove conversion functions and introduce internal PubKey type
* Remove old secp256k1 PubKey and PrivKey
* Uncomment test case
* Fix linting issues
* More linting
* Revert tests keys values
* Add Amino overrides to proto keys
* Add pubkey test
* Fix tests
* Use threshold isntead of K
* Standardize Type
* Revert standardize types commit
* Add comment
* Simplify proto names
* Add comment about multisig codec
Co-authored-by: Aaron Craelius <aaronc@users.noreply.github.com>
Co-authored-by: Amaury Martiny <amaury.martiny@protonmail.com>
Co-authored-by: Alexander Bezobchuk <alexanderbez@users.noreply.github.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
2020-09-16 11:08:55 +00:00
4d9c32f44f
Remove UNINITIALIZED usage from connection and channel ( #7297 )
...
* remove UNINITALIZED connection state
* remove uninit channel state
* add back uninitalized def in proto file
* fix typo
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
2020-09-14 21:41:23 +00:00
b2348180b8
Migrate {x/auth, x/gov, x/staking} missing CLI queries to proto ( #6994 )
...
* Fix error code
* Fix decoder
* Fix typo
* Fix decode
* refactor
* Migrate SearchTxsResult to proto
* fix MarkEventsToIndex
* lint++
* Fix output
* Add QueryTxCmd cli test
* Add fmt
* Put txBuilder in types/tx
* Add GetAnyTx in TxBuilder
* Add new IsAnyTx
* Rename to IntoAny
* Fix bug
* fmt
Co-authored-by: Marie <marie.gauthier63@gmail.com>
* Fix ibc CLI to use proto
* Fix any MarshalJSON
* Fix test
* Make tx.Tx implement sdk.Tx
* Register sdk.Tx
* Fix lint
* Allow DefaultJSONTxEncoder to take tx.Tx
* refactor
* Rename variable
* remove fmt
Co-authored-by: Anil Kumar Kammari <anil@vitwit.com>
Co-authored-by: Alexander Bezobchuk <alexanderbez@users.noreply.github.com>
Co-authored-by: Aleksandr Bezobchuk <aleks.bezobchuk@gmail.com>
Co-authored-by: Amaury Martiny <amaury.martiny@protonmail.com>
Co-authored-by: Marie <marie.gauthier63@gmail.com>
2020-09-10 18:26:47 +00:00
a9547b54ff
Add proto formatting tool ( #7266 )
...
* Add proto format option
* Add clang format options
* Fix proto format
* Fix fmt
* Fix SpacesInSquareBrackets to match with SpacesInSquareBrackets setting
2020-09-08 22:06:54 +00:00
325be6ff21
Merge PR #7209 : Create Vesting Account Message
2020-09-08 09:09:50 -07:00
4faeefebd2
Add state sync support ( #7166 )
...
* Add state sync support
* fix incorrect test tempdir
* proto: move and update Protobuf schemas
* proto: lint fixes
* comment tweaks
* don't use type aliasing
* don't call .Error() when logging errors
* use create terminology instead of take for snapshots
* reuse chunk hasher
* simplify key encoding code
* track chunk index in Manager
* add restoreDone message for Manager
* add a ready channel to Snapshotter.Restore()
* add comment on streaming IO API
* use sdkerrors for error handling
* fix incorrect error
* tweak changelog
* syntax fix
* update test code after merge
2020-09-08 09:05:44 +00:00
ebfb616d88
Migrate missing `x/distribution` CLI queries to proto ( #7244 )
...
* migrate CommunityPoolSpendProposalJSON to proto
* migrate NewWithdrawAllRewardsCmd to proto
* fix ineffectual issue
* refactor
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
2020-09-07 13:14:00 +00:00
3d969a1ffd
Implement gRPC Simulate endpoint ( #7035 )
...
* Implement simulate endpoint
* Add GetProtoTx()
* Add signing in test
* Add txBuilderFromProto
* Remove stray println
* Update to master
* Merge master
* Fix tests
* Make tests pass
* Integrate in router
* Make proto-gen
* Fix lint
* Really fix lint
* Refactor to fix import cycles
* Rename builder -> wrapper
* Update proto/cosmos/base/reflection/v1beta1/reflection.proto
* Fix after merge
* t->w
Co-authored-by: Alexander Bezobchuk <alexanderbez@users.noreply.github.com>
2020-08-24 14:41:08 +00:00
50bab8f820
Put AccountSequence in SignerInfo ( #6997 )
...
* WIP test the grounds
* Update ADR020
* Fix compile errors
* Fix ADR
* Make ante tests pass
* Fix remaining ante handler tests
* Simplify code
* Fix x/bank app_test
* Fix tests
* Remove useless accSeq from signerdata
* Fix test
* Update simapp/helpers/test_helpers.go
Co-authored-by: Alexander Bezobchuk <alexanderbez@users.noreply.github.com>
* Update simapp/helpers/test_helpers.go
Co-authored-by: Alexander Bezobchuk <alexanderbez@users.noreply.github.com>
* Update x/auth/client/cli/tx_multisign.go
Co-authored-by: Alexander Bezobchuk <alexanderbez@users.noreply.github.com>
* Address rewview
* Update x/auth/ante/sigverify.go
Co-authored-by: Simon Warta <2603011+webmaster128@users.noreply.github.com>
* Update x/auth/ante/sigverify_test.go
Co-authored-by: Simon Warta <2603011+webmaster128@users.noreply.github.com>
* Update x/auth/tx/builder_test.go
Co-authored-by: Simon Warta <2603011+webmaster128@users.noreply.github.com>
* Update x/auth/tx/builder_test.go
Co-authored-by: Simon Warta <2603011+webmaster128@users.noreply.github.com>
* Update x/auth/tx/direct_test.go
Co-authored-by: Simon Warta <2603011+webmaster128@users.noreply.github.com>
* Update x/auth/tx/builder_test.go
Co-authored-by: Simon Warta <2603011+webmaster128@users.noreply.github.com>
* AccSeq -> Seq
* Address reviews
* Better variable naming
* Fix variable assign
* Remove old SetSignerInfo
* Fix test
* proto-gen
* Make proto-gen
* Reput gw comment
* Add Changelog
* Update x/bank/app_test.go
Co-authored-by: Alexander Bezobchuk <alexanderbez@users.noreply.github.com>
* Update x/bank/app_test.go
Co-authored-by: Alexander Bezobchuk <alexanderbez@users.noreply.github.com>
Co-authored-by: Alexander Bezobchuk <alexanderbez@users.noreply.github.com>
Co-authored-by: SaReN <sahithnarahari@gmail.com>
Co-authored-by: Simon Warta <2603011+webmaster128@users.noreply.github.com>
2020-08-21 14:20:47 +00:00
f02b0b5745
Protobuf audit: base package, module packages, tx/Msg's ( #7059 )
...
* proto audits auth, bank, crisis, distribution
* audit module proto files
* audit base proto package
* make protogen
* golint
* fix gov genesis test
* Update proto/cosmos/bank/v1beta1/tx.proto
Co-authored-by: Aaron Craelius <aaron@regen.network>
* update coin metadata protos & documentation
Co-authored-by: Alexander Bezobchuk <alexanderbez@users.noreply.github.com>
Co-authored-by: Aaron Craelius <aaron@regen.network>
2020-08-19 07:36:41 +00:00
3f81c0a18d
gRPC interface reflection. ( #6722 )
...
* WIP on gRPC interface reflection.
* Update docs in proto
* Add tests
* Add test
* Add route inside router
* Address nits
* ListInterfaces -> ListAllInterfaces
* Fix proto lint
* Remove stray println
* Update proto/cosmos/base/reflection/v1beta1/reflection.proto
Co-authored-by: Alexander Bezobchuk <alexanderbez@users.noreply.github.com>
* Update codec/types/interface_registry.go
Co-authored-by: Alexander Bezobchuk <alexanderbez@users.noreply.github.com>
* Update codec/types/interface_registry.go
Co-authored-by: Alexander Bezobchuk <alexanderbez@users.noreply.github.com>
* Add godoc
Co-authored-by: Amaury Martiny <amaury.martiny@protonmail.com>
Co-authored-by: Alexander Bezobchuk <alexanderbez@users.noreply.github.com>
2020-08-17 17:02:13 +00:00
7d2062b674
x/bank: gRPC Params Route ( #7070 )
...
* update x/bank proto gRPC query service
* fix path
* update keeper
* add godoc
* add test
* lint++
2020-08-17 13:55:04 +00:00
0e3f87313e
ibc-transfer: enable transfer parameter ( #6607 )
...
* ibc-transfer: enable transfer parameter
* param_test.go
* update tests and types
* gRPC test
* relay logic and spec update
* fix tests
* unused param
2020-08-17 02:24:14 -04:00
8de96d16f9
tendermint: update to rc3 ( #6892 )
...
* modify light imports
* change abci.header to tmproto.header
* use rc
* rc
* fix import
* Merge PR #6893 : fix key imports
* fix rc2
* tendermint: update 3 (#6899 )
* tendermint: update 4 (#6919 )
Co-authored-by: Alexander Bezobchuk <alexanderbez@users.noreply.github.com>
* tendermint: update 5 (#6923 )
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
* bump to latest master
* tendermint: update (#6972 )
Co-authored-by: Aleksandr Bezobchuk <aleks.bezobchuk@gmail.com>
Co-authored-by: Cory Levinson <cjlevinson@gmail.com>
* Update x/ibc/07-tendermint/types/test_utils.go
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
* address comment
* go mod
* bring back things
* fix test
* update tm proto files
Co-authored-by: Alexander Bezobchuk <alexanderbez@users.noreply.github.com>
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
Co-authored-by: Aleksandr Bezobchuk <aleks.bezobchuk@gmail.com>
Co-authored-by: Cory Levinson <cjlevinson@gmail.com>
Co-authored-by: Federico Kunze <federico.kunze94@gmail.com>
2020-08-14 13:58:53 -04:00
f87624e9de
Add Grpc gateway annotations ( #6918 )
...
* grpc for bank module
* edit module.go
* added annotations for x/auth query proto
* generated gw file
* added grpc gateway for x/staking query proto
* added annotations for evidence
* added annotations for gov query proto
* added annotations
* added annotations for slashing module
* updated annotations
* added annotations for staking module
* added annotations for upgrade query
* annotations added for x/ibc/channel query proto
* added annotations for ibc/connection query proto
* updated annotations
* updated annotations
* annotation changes
* ommitted ibc module
* updated go.mod
* fixed lint issue
* review changes
* review changes
* review changes
* review changes
* go sum changes
* updated annotations
* annotation changes
* Fix proto lint issues
* review changes
* review changes
* review changes
* discussion changes
* review changes
* grpc for bank module
* edit module.go
* added annotations for x/auth query proto
* generated gw file
* added grpc gateway for x/staking query proto
* added annotations for evidence
* added annotations for gov query proto
* added annotations
* added annotations for slashing module
* updated annotations
* added annotations for staking module
* added annotations for upgrade query
* annotations added for x/ibc/channel query proto
* added annotations for ibc/connection query proto
* updated annotations
* updated annotations
* annotation changes
* ommitted ibc module
* updated go.mod
* fixed lint issue
* review changes
* review changes
* review changes
* review changes
* go sum changes
* updated annotations
* annotation changes
* Fix proto lint issues
* review changes
* review changes
* review changes
* discussion changes
* review changes
* fixed conflicts
* review changes
* updated gw files
* lint
* lint
* lint
* added missing annotations
* review changes
* review changes
* review changes
* review changes
Co-authored-by: SaReN <sahithnarahari@gmail.com>
Co-authored-by: Anil Kumar Kammari <anil@vitwit.com>
2020-08-14 10:05:35 +00:00
5559af8b97
Proto Auditing: Replace ID with Id ( #7032 )
...
* Proto Auditing: Replace ID with Id
* make proto-gen
* Update docs
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
2020-08-14 08:55:54 +00:00
816c5a37bd
Enable proto JSON generally and remove HybridCodec ( #6859 )
...
* Remove HybridCodec
* WIP on fixing proto JSON issues
* WIP on fixing proto JSON issues
* WIP on fixing proto JSON issues
* WIP on fixing proto JSON issues
* WIP on fixing proto JSON issues
* Test fixes
* Delete hybrid_codec.go
* Fixes
* Fixes
* Fixes
* Test fixes
* Test fixes
* Test fixes
* Lint
* Sim fixes
* Sim fixes
* Revert
* Remove vesting account JSON tests
* Update CHANGELOG.md
* Lint
* Sim fixes
* Sim fixes
* Docs
* Migrate more amino usages
* Remove custom VoteOption String() and json marshaling
* Fix tests
* Add comments, update CHANGELOG.md
Co-authored-by: Jonathan Gimeno <jgimeno@gmail.com>
Co-authored-by: Alexander Bezobchuk <alexanderbez@users.noreply.github.com>
2020-08-13 13:20:02 +00:00
134e1dcecd
Protobuf Audit: Genesis states ( #6978 )
...
* Remove some casttypes
* Add more comments
* Finish remaining modules
* Fix lint
* Revert customname
* Revert evidence
* Review nits
* Consistent doc for genesis state
* Make proto-gen
* Update docs for capability
* Remove useless customtype
* Update proto/cosmos/auth/v1beta1/genesis.proto
Co-authored-by: Anil Kumar Kammari <anil@vitwit.com>
* Add godoc
* Update proto/cosmos/evidence/v1beta1/genesis.proto
Co-authored-by: Marie <marie.gauthier63@gmail.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Co-authored-by: Anil Kumar Kammari <anil@vitwit.com>
Co-authored-by: Marie <marie.gauthier63@gmail.com>
2020-08-12 15:48:22 +00:00
20c5ee3624
Enable proto JSON for genesis ( #7000 )
...
* Enable proto JSON for genesis
* Test fixes
* Cleanup
* Cleanup
* Cleanup
* Update CHANGELOG.md
* Protogen
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
Co-authored-by: SaReN <sahithnarahari@gmail.com>
2020-08-11 14:22:30 +00:00
61a97ef347
Audit / Refactor proto packages layout ( #6905 )
...
* create base proto package, move ValAddresses to staking
* move tx, crypto, query proto packages into base; mark module level packages as beta
* new cosmos/base/abci.proto file, refactor some message names
* add comments to TxResponse
* refactor RegisterInterface calls to new proto package names
* fix bug in merge commit
* move missing module proto packages to beta, move cosmos.kv to cosmos.base.kv
* add tx.proto files, holding proto messages for module Msgs
* rm old generated pb.go files
* cosmos/base/base.proto -> cosmos/base/coin.proto
* mark genutil proto package as beta
* Fix conflicts
* Restructure proto files
* Re put signing
* Fix test
* Update slashing genesis
* Ignore confio proto files
* Fix interface register
* Make proto-gen
* Fix lint
* Put tx service into tx.v1beta1
* Use v1beta1 in interface registry
* Remove to cosmos.base.store
* Remove extra confio in buf
Co-authored-by: Amaury Martiny <amaury.martiny@protonmail.com>
Co-authored-by: Alexander Bezobchuk <alexanderbez@users.noreply.github.com>
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
2020-08-11 11:49:45 +00:00
0f44d1af23
store: Remove Amino ( #6984 )
...
* Update kv pair to proto
* updates
* fix LastCommitID
* lint++
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
2020-08-11 10:09:16 +00:00
0faf545221
Add simulation gRPC service definition ( #6872 )
...
* WIP on TxService
* WIP on TxService
* Update docs
* WIP on simulation service
* WIP on simulate service
* Simplify interface
* Simplify interface
* proto-gen
* Update docs
* Update docs
* Simplify
* proto-gen
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
2020-08-11 07:33:35 +00:00
6e3c268a72
Protobuf audit: Queries ( #6967 )
...
* Add required fields for queries, p1
* Add comments
* Remove required
* More modules
* 2 to go
* Finish all modules
* Fix typo
* Fix test
* Make proto-gen
Co-authored-by: Alexander Bezobchuk <alexanderbez@users.noreply.github.com>
2020-08-10 08:12:59 +00:00
9ae17669d6
Tx Height Timeout ( #6089 )
...
* Implement TxHeightTimeoutDecorator
* Update error message
* rename type
* set height timeout
* update tests
* update *SignDoc)
* rename
* remove dup
* fix build
* cli updates
* rest updates
* cl++
* Update x/auth/ante/basic.go
Co-authored-by: colin axnér <25233464+colin-axner@users.noreply.github.com>
* Update x/auth/ante/basic.go
Co-authored-by: colin axnér <25233464+colin-axner@users.noreply.github.com>
* Update x/auth/ante/basic.go
Co-authored-by: colin axnér <25233464+colin-axner@users.noreply.github.com>
* Update x/auth/ante/basic.go
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
* rename
* rename
* remove TimeoutHeight from SignDoc
* updates
* fix tests
* update IBC cmd flags
* use omitempty
* update godoc
* add test case to TestStdSignBytes
Co-authored-by: colin axnér <25233464+colin-axner@users.noreply.github.com>
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
2020-08-07 23:32:22 +00:00
662aa7fa01
Slashing genesis types proto migration ( #6881 )
...
* slashing genesis types migrated to proto
* review changes
* fixed lint
* review change
* review change
* review changes
* Update proto messgaes
* Add test for ExportGenesis
* Address naming suggestions
* Update genesis
* Fix genesis test
* Add GetMissedBlocks
* Update genesis test
* Address review suggestions
Co-authored-by: Anil Kumar Kammari <anil@vitwit.com>
Co-authored-by: SaReN <sahithnarahari@gmail.com>
2020-08-04 12:58:36 +00:00
617b822efa
types: add kv type ( #6897 )
...
* add kv type
* add changelog entry
* fix build
* replace sdkkv with kv
* revert change
* fix some tests
* proto-gen
* fix tests
Co-authored-by: Aleksandr Bezobchuk <aleks.bezobchuk@gmail.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
2020-07-30 14:53:02 +00:00
72ebafeeca
Update auth cli commands ( #6717 )
...
* add utils
* update sign cmd
* update multisign cmd
* update sign batch cmd
* update genutil cmd
* add wrap tx builder
* update gentx cli
* update validate sigs cmd
* fix lint
* add flag reader to cli
* update marshaler for batchscan
* add register query server
* update to master
* remove depricated methods
* fix keyring issue
* update wraptx
* Fix batch scan
* fix register interfaces issue
* update printOutput
* Update Validate Sigs test
* WIP on signature JSON
* Cleanup
* Cleanup
* Test fixes
* Test fixes
* Fixes
* WIP on tests
* Fix gov tests
* fix lint
* fix MultiSign tests
* fix tests
* refactor tests
* Cleanup
* Address review comments
* Update encode
* Test fix
* Rename SignData func
* Fix lint
* Fix lint
* Revert ReadTxCommandFlags
Co-authored-by: Aaron Craelius <aaron@regen.network>
Co-authored-by: Aaron Craelius <aaronc@users.noreply.github.com>
2020-07-29 22:33:42 +00:00
2da954ff61
x/evidence genesis protobuf migration ( #6864 )
...
* Migrate evidence genesis state to proto
* Fix lint error
* Remove commented code
* Clean up
* Add UnpackInterfaces to evidence GenesisState
* Add cosmos_proto.accepts_interface to evidence any and fix lint error
* Add test for x/evidence ExportGenesis and use table tests
* Update x/evidence/types/genesis.go
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
* Update proto/cosmos/evidence/evidence.proto
Co-authored-by: Alexander Bezobchuk <alexanderbez@users.noreply.github.com>
* Keep []Evidence as return type in GenEvidences
* Add GenesisState Validate tests
* Add test case for NewGenesisState
* Add tests for GenesisState UnpackInterfaces
Co-authored-by: SaReN <sahithnarahari@gmail.com>
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
Co-authored-by: Alexander Bezobchuk <alexanderbez@users.noreply.github.com>
2020-07-29 18:22:51 +00:00
Amaury
MD Aleem
Robert Zaremba
Cory
atheeshp
Marie Gauthier
Aaron Craelius
Aditya
Ethan Frey
Anil Kumar Kammari
colin axnér
SaReN
Alexander Bezobchuk
Erik Grinaker
Federico Kunze
Marko