Commit Graph

267 Commits

Author SHA1 Message Date
Dev Ojha 955a0c9af7 Switch asserts to require (#1483)
* meta: Switch the majority of asserts to require

Switch most assert statements to require, to ease debugging.
Closes #1418

* Fix imports
2018-06-30 03:10:15 +02:00
Dev Ojha 097dd8a164 tools: Add unparam linter (#1443)
* tools: Add unparam linter

unparam detects unused parameters in functions, and a parameter to
a function which only ever takes on one value. The latter is an
indication that more tests are required.

There are many nolints in this PR, as I believe that writing tests
to fix alot of these situations is out of scope for this PR / it
will be changed in future commits. There are some nolints for
when we have to comply to normal api's.

* crypto/keys no longer used by x/gov/client/rest/rest.go
2018-06-29 18:22:24 -04:00
Christopher Goes 59aadf42aa
Ledger integration (#931)
Merges the keybase and Ledger code from go-crypto (which is no more) into the SDK
Adds support for Ledger into gaiacli
Cherry-picks updated error handling from #1158
2018-06-29 02:54:47 +02:00
Dev Ojha ac3adff1e8 Merge PR #1438: Tools: Add errcheck linter
This linter ensures that all errors are checked.
This is disabled in the client directories, since its not needed on
those writes
2018-06-29 00:52:10 +02:00
Dev Ojha 2755c66545 Merge PR #1424: tools: add unconvert linter
unconvert checks for unnecessary type conversions
2018-06-28 18:08:29 +02:00
Rigel 6f140d7296 Merge PR #1119: Unbonding, Redelegation
* stake/fees spec updates
* staking overview.md revisions, moving files
* docs reorganization
* staking spec state revisions
* transaction stake updates
* complete staking spec update
* WIP adding unbonding/redelegation commands
* added msg types for unbonding, redelegation
* stake sub-package reorg
* working stake reorg
* modify lcd tests to not use hardcoded json strings
* add description update
* index keys
* key managment for unbonding redelegation complete
* update stake errors
* completed handleMsgCompleteUnbonding fn
* updated to use begin/complete unbonding/redelegation
* fix token shares bug
* develop docs into unbonding
* got non-tests compiling after merge develop
* working fixing tests
* PrivlegedKeeper -> PrivilegedKeeper
* tests compile
* fix some tests
* fixing tests
* remove PrivilegedKeeper
* get unbonding bug
* only rpc sig verification failed tests now
* move percent unbonding/redelegation to the CLI and out of handler logic
* remove min unbonding height
* add lcd txs
* add pool sanity checks, fix a buncha tests
* fix ante. set lcd log to debug (#1322)
* redelegation tests, adding query functionality for bonds
* add self-delegations at genesis ref #1165
* PR comments (mostly) addressed
* cleanup, added Query LCD functionality
* test cleanup/fixes
* fix governance test
* SlashValidatorSet -> ValidatorSet
* changelog
* stake lcd fix
* x/auth: fix chainID in ante
* fix lcd test
* fix lint, update lint make command for spelling
* lowercase error string
* don't expose coinkeeper in staking
* remove a few duplicate lines in changelog
* chain_id in stake lcd tests
* added transient redelegation
* 'transient' => 'transitive'
* Re-add nolint instruction
* Fix tiny linter error
2018-06-27 04:00:12 +02:00
Joon ec6acda6a4 Merge PR #1331: Remove TxBytes from NewContext 2018-06-22 03:03:05 +02:00
Aditya f049a56376 Merge PR #1266: Multiple messages
* Started work on multiple msgs, types and x/auth tests pass
* Fix issues in x, examples, and baseapp
* Added baseapp tests for multiple msgs
* Documentation fixes
* Fix baseapp tests with sdk.Int
* Modify test
* Transaction handling is now atomic
* Fix test comment
* Minor doc fixes and code cleanup
* Added baseapp result changes
* Use address in validator update accumulation
* Started work on multiple msgs, types and x/auth tests pass
* Fix issues in x, examples, and baseapp
* Added baseapp tests for multiple msgs
* Documentation fixes
* Fix baseapp tests with sdk.Int
* Modify test
* Transaction handling is now atomic
* Fix test comment
* Minor doc fixes and code cleanup
* Added baseapp result changes
* Use address in validator update accumulation
* Added ante tests for multisigner
* Remove validatorUpdates from tx result
* Better error logs
* Put Memo in StdSignBytes and formatting
* Updated changelog
2018-06-22 00:05:25 +02:00
Dev Ojha e2d23040a8 Merge PR #1325: Refactor Complete Setup to not take in a testing parameter
* Refactor Complete Setup to not take in a testing parameter
* Update changelog
2018-06-21 18:55:08 +02:00
Joon 314b5a854d Merge PR #1218: sdk.Int in sdk.Coin
implement Int, Int256, Uint256
pass ci
pass ci
add to changelog, add boundcheck to test
add comments, fix cli_test.go
fix errors
apply requested changes
panics on New*WithDecimal
fix Int.BigInt()
fix stake tests
* Panic on uint division-by-zero
* Set ok=false on NewIntFromString, NewUintFromString failure
* Nuke CircleCI caches
2018-06-15 23:16:45 +02:00
Fabian 42e72956f4 Merge PR #1252: Query node version
introduce non store queries
add version query
update lcd spec
changelog
moved version query into baseapp
2018-06-14 07:49:21 +02:00
David Kajpust ec2fedd36c Merge PR #1227: Set all Error strings 1st letters to lowercase. Fixes issue #1154 2018-06-13 21:13:22 +02:00
Christopher Goes 5bf58ee444
Merge PR #1210: Fix testcases (another fast-forward merge issue) 2018-06-12 09:47:59 +02:00
Christopher Goes ee17b7c9cc
Address PR comments: test descriptions & NewValidatorSigningInfo 2018-06-11 21:47:35 +02:00
Christopher Goes c9a977beae
Cleanup testcase 2018-06-11 03:15:48 +02:00
Christopher Goes a4865ef6aa
Add mock.SignCheck, update testcase to assert error code 2018-06-11 03:14:20 +02:00
Christopher Goes f6a30afbf4
Improve testcase, add comment 2018-06-11 03:03:52 +02:00
Christopher Goes 3bea85abb3
Register slashing keeper, set startHeight, testcases 2018-06-11 02:55:54 +02:00
Christopher Goes 496d4681c2
Add MsgUnrevoke.GetSignBytes() testcase, remove unused functions 2018-06-08 02:05:34 +02:00
Christopher Goes a583a70b7c
Fix address type for x/slashing/MsgUnrevoke 2018-06-08 01:59:10 +02:00
Christopher Goes 971e1489b2
Bech32ify msg.GetSignBytes() for x/slashing & x/stake 2018-06-08 01:24:08 +02:00
Rigel e0e50fce50
Merge pull request #1134 from cosmos/jlandrews/clidocfix
Fix docs for cli refactor
2018-06-04 23:30:28 -07:00
Jeremiah Andrews 5a831bd0f8 additional changes 2018-06-04 18:35:07 -07:00
Christopher Goes be7ec5bc07
Merge PR #1115: Update SDK to ABCI v11 2018-06-05 01:42:01 +02:00
Christopher Goes 024eaf6ac0
Swap x/slashing to sdk.ValidatorSet 2018-06-02 00:27:37 +02:00
rigelrozanski 0ef3259a39 revised use of EndBlock/BeginBlock, basecoin updated for staking/slashing 2018-06-01 14:24:48 -07:00
Christopher Goes 7ff6eebb32
Fix command documentation 2018-06-01 06:21:26 +02:00
Christopher Goes c7a9b53fae
Use valpk.Address() 2018-06-01 06:21:26 +02:00
Christopher Goes cde91bd229
gaiacli unrevoke 2018-06-01 06:21:22 +02:00
rigelrozanski 952aedc4f1 get rid of candidacy references 2018-05-31 14:57:09 -07:00
Christopher Goes 27ae1a1490
Match UnmarshalBinaryBare/MarshalBinaryBare 2018-05-31 22:19:46 +02:00
Christopher Goes f32093e9e3
Use evidence type constants from Tendermint 2018-05-31 05:43:54 +02:00
Christopher Goes 141bc5fb1c
amino.MarshalJSON instead of json.Marshal 2018-05-31 01:52:07 +02:00
Christopher Goes 3d37d51795
Switch to evidence type enum 2018-05-31 01:47:24 +02:00
Christopher Goes 5c4c486e7b
Add newlines to clarify testcase separation 2018-05-31 01:39:57 +02:00
Christopher Goes 604fd4c9a7
Address a few style comments 2018-05-31 01:37:38 +02:00
Christopher Goes 004e10ebcd
More comments on counter logic 2018-05-31 00:32:08 +02:00
Christopher Goes 99bed49c8d
Minor wording changes 2018-05-31 00:25:18 +02:00
Christopher Goes 5f03e370c3
Remove ValidatorByPubKey, don't marshal sdk.Address 2018-05-31 00:19:23 +02:00
Christopher Goes 3b4aa4d0ae
Minor test fix after merge 2018-05-29 21:46:38 +02:00
Christopher Goes 6712ea7f3a
Present, not absent 2018-05-29 08:32:39 +02:00
Christopher Goes 69af8b1a94
Clarify signing info stored by validator address 2018-05-29 02:58:43 +02:00
Christopher Goes 88e0025724
DowntimeUnbondDuration to 10 minutes 2018-05-29 02:56:40 +02:00
Christopher Goes 345b5b88a8
Add comment on MsgUnrevoke 2018-05-29 02:50:04 +02:00
Christopher Goes 65945c069c
Clarify counter logic 2018-05-29 02:48:29 +02:00
Christopher Goes 7fbecc6b72
Clarify default signing info 2018-05-29 02:36:31 +02:00
Christopher Goes b8b4fe24e3
Absent validators map[crypto.PubKey]struct{} 2018-05-29 02:33:01 +02:00
Christopher Goes aed5d94b1c
Remove absent validators from sdk.NewContext 2018-05-29 02:26:17 +02:00
Christopher Goes f4f8cc66d9
Add some explanatory comments 2018-05-29 00:10:52 +02:00
Christopher Goes 26f22dbe4d
Test start height update 2018-05-28 23:55:39 +02:00
Christopher Goes c0487996ab
Update slashing docs, slight index change 2018-05-28 23:46:08 +02:00
Christopher Goes 02ab73e266
Signing info slashing testcases 2018-05-28 23:39:57 +02:00
Christopher Goes 93f1cb45cc
Split slashing params & signing info into separate files 2018-05-28 23:24:58 +02:00
Christopher Goes bfa9d5f914
Linter fixes 2018-05-28 22:12:45 +02:00
Christopher Goes d03577a2fc
Fixes after rebase, jail in x/slashing 2018-05-28 22:08:13 +02:00
Christopher Goes e4b0d0a618
Reorganization in progress 2018-05-28 21:55:54 +02:00
Christopher Goes 6f3d81d5d6
Swap to individual offset 2018-05-28 21:55:53 +02:00
Christopher Goes 8aaff4b96e
Cleanup testcase a bit 2018-05-28 21:55:53 +02:00
Christopher Goes 97b084b842
Fix ForceUnbond() testcase 2018-05-28 21:55:53 +02:00
Christopher Goes e614799d0f
ForceUnbond() implementation WIP 2018-05-28 21:55:53 +02:00
Christopher Goes 796948b838
Downtime slashing testcases 2018-05-28 21:55:53 +02:00
Christopher Goes be4b140003
Add testcase past max evidence age 2018-05-28 21:55:53 +02:00
Christopher Goes 7da5833b81
Implement ValidatorSet.Slash 2018-05-28 21:55:52 +02:00
Christopher Goes 366d8f9323
Slash() and ForceUnbond() are functions of ValidatorSet, not Validator 2018-05-28 21:55:52 +02:00
Christopher Goes b005f9f18d
Validator by pubkey, tests work-in-progress 2018-05-28 21:55:52 +02:00
Christopher Goes 67f7f31ba9
Fix testcases by mounting store 2018-05-28 21:55:52 +02:00
Christopher Goes 95c5baf449
Rebase & squash slashing 2018-05-28 21:55:27 +02:00